- reasoning: this group contains set-up and teardown,
it does not include 'it' blocks
Change-Id: I1803420a5c7f59246f3af211e42ced808a994c3f
Reviewed-on: https://gerrit.instructure.com/60329
Tested-by: Jenkins
Reviewed-by: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-19867
test plan:
- submit an assignment as a student
- click the link to view submission details
- navigate to show rubric and hit enter
- rubric should display behavior similar to a modal, tabbing at last element
should return focus to top, shift tabbing at top should send focus to bottom
- using VO navigation, vo box should not be able to exit from top or bottom of
rubric
- when viewing this page as a teacher, save comment button should save changes
and close rubric
- rubric should be able to be closed by either hitting enter on the 'x' button
or hitting escape while anywhere
- upon closing, focus should return to 'show rubric'
- all keyboard nav on the page should return to normal after rubric closes
Change-Id: Ib9e4e720c8f9c267f8655c3f3fe7873a510763db
Reviewed-on: https://gerrit.instructure.com/52785
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-15499
test plan:
- go to a course assignment page
- add a rubric and check 'use for grading'
- hit save, but don't refresh the page
- hit edit on the rubric
- the 'use for grading' check should still be there
- now refresh the page and edit again
- the 'use for grading' check should still be there
Change-Id: Idb43afa1d1974f26cec7b86adc317a64f7010185
Reviewed-on: https://gerrit.instructure.com/52038
Tested-by: Jenkins
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-15284
test plan:
- create an assignment with a rubric
- as a teacher, edit the rubric on the assignment page and click on the
"view long description" link
- the dialog should have 'update description' and 'cancel' buttons
- now stop editing the rubric and click the link
- the buttons should be hidden
- try reloading the page and viewing non-editing first, then editing
- try viewing the page as a student, and click the linke
- the buttons should be hidden
Change-Id: I35a340da41f5e2210b0fa81881029f277fd2e0d2
Reviewed-on: https://gerrit.instructure.com/50966
Tested-by: Jenkins
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
tests were written to catch this in the future by cameron
Change-Id: I80e1c5d9c141232b5a976ade3def76d83bc96a15
Reviewed-on: https://gerrit.instructure.com/46426
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
Reviewed-by: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
in particular, change "it_should_behave_like" to
"include_examples" (in rails 3, "it_should_behave_like"
does not extend the defined methods to nested examples)
Change-Id: I24c3d0a214e763cd61bbe73e055f610e021fddd0
Reviewed-on: https://gerrit.instructure.com/28157
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-6624
test plan:
- general regression test on rubrics, including rubrics in assignment and
discussion pages, on the rubrics page, in the student submission page, and in
speedgrader
- go to an assignment page, add a rubric, and read it with the screenreader.
It should not read the title and/or "find a rubric" with each cell
- try using 'update' and 'cancel' buttons when editing a rubric. they should
manage focus properly
- there are a lot of things that aren't accessible yet (like editing). Those
are coming.
Change-Id: I8e4296243d32f089fc2216c5e25ca925d16acc50
Reviewed-on: https://gerrit.instructure.com/25104
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
There are a few old LearningOutcomeResults that have a nil artifact, and
many that have a Submission as an artifact. We want to get rid of these
because they come from bad data, and step 1 toward that goal is to stop
creating them and hide them in the UI.
The LORs with a nil artifact are very old and I believe came from a very
early incarnation of outcomes. The LORs with a Submission as an artifact
came from a combination of two code problems. The first was old code
that allowed an assignment that was aligned with an outcome but did not
have a rubric to create LORs directly based on it's submission. The
second was a bug that prevented the assignment <-> outcome link from
being destroyed when a rubric with an outcome was removed from an
assignment.
fixes CNVS-7495
fixes CNVS-7498
test plan:
- try different combinations of adding a rubric with an outcome to an
assignment.
- when you grade the assignment, the grade create a learning outcome result
(which can be seen on the outcome show page, or in the account outcome
report) if the rubric+outcome are currently attached to the assignment.
- so for example, add a rubric with an outcome, check, remove just the outcome
row, check, add a new outcome row, check, remove the whole rubric, check.
- be sure to check both the show page and the outcome report
TODO:
- datafix migration
Change-Id: I37700e3e5c08fc6cfb8fcf1cac42ea6693fcaba3
Reviewed-on: https://gerrit.instructure.com/23303
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
creates new permission :manage_rubrics, which was
previously a subset of the rights in :manage_grades
test plan:
* confirm that a new permission for
outcomes and rubrics is available in the ui
* confirm that this permission restricts the
creation and editing of rubrics
fixes #CNVS-266
Change-Id: I40d108b53e2771890d8fdbb108e1de24364aa055
Reviewed-on: https://gerrit.instructure.com/17763
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
change and clean up the assignment show and edit pages to use new code
standards and to follow the style guide. separates the logic for viewing and
editing an assignment and moves editing into a backbone model.o
closes CNVS-930
test plan:
- make sure you can still view and edit existing assignments.
- make sure all fields in the assignment form work (enable turnitin and
assignment freezing for a comprehensive test)
- make sure submitting an assignment as a student still works
- make sure downloading and uploading submissions as a teacher still works
- make sure adding a new assignment group, group category, grading standard,
and rubric still work
- make sure the show page renders correctly for both a student and a teacher.
Change-Id: I9ca6c5d56eb386d35a62f6b816a03ebebda662d4
Reviewed-on: https://gerrit.instructure.com/16823
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
refactored to use click_option
refactored to use have_class and have_attribute
refactored do end
Change-Id: I6b3a921152347a5057263d727ccdc00ba9fd21ea
Reviewed-on: https://gerrit.instructure.com/17495
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jake Sorce <jake@instructure.com>
QA-Review: Jake Sorce <jake@instructure.com>
the looked like they were being maintained, but the content tag links between
rubric and outcome and between assignment and outcome were not being generated
properly after a course copy.
fixes #CNVS-1274
test plan:
- create and account level outcome and a course level outcome
- in the course create two assignments, with rubrics
- in one, add the course level outcome
- in the other add the account level outcome
- grade a student with the rubrics
- ensure that alignments and mastery look correct
- copy the course
- in the new course grade a different student
- ensure that alignments and mastery look correct
Change-Id: I04c240256f007791613e4f29b8288f1bc7729849
Reviewed-on: https://gerrit.instructure.com/15908
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
test:
1. removed skip_if_ie usages
2. changed single line blocks to {} and
multi-line blocks to do end
3. replaces .displayed? and !displayed with
.should .should_not be_displayed
4. removed some extra selectors
5. refactored helpers\basics\specs
Change-Id: I35bdc50594ee97774da35703d97a6bbab05654a4
Reviewed-on: https://gerrit.instructure.com/13532
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jake Sorce <jake@instructure.com>
test:
1. refactored specs to user f aliases
2. refactored some :link usages to classes or ids
Change-Id: I8527c752b594fb58eaa2b54af2bdb2a922d10888
Reviewed-on: https://gerrit.instructure.com/13134
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jake Sorce <jake@instructure.com>
test plan:
- create an assignment and tie a grading rubric to it
- submit the assignment as a student
- grade the submission and add a comment to a couple of the fields in the rubric
- go back to the student and view "Submission Details"
- click on "Show Rubric"
- a comment bubble should show under the "Pts" column
- clicking on the bubble should show an un-editable popup with the comments
Change-Id: Iad9de6fd6087e7638bf26abe623bd30760e7f16a
Reviewed-on: https://gerrit.instructure.com/9740
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
tweak our javascript so that the rubrics controller update method knows that we
want to save the rubric association even if we can't modify the rubric. also
clean up some unused code in the rubric spec that was confusingly named
read_only, but not related to the rubric read_only property.
test-plan:
- create a rubric
- create two assignments that have the same points
- associate the rubric with the first assignment and select it be used for
grading. make sure it sticks across refresh (and the rubric is not
duplicated)
- same for the second assignment
Change-Id: I2c32d4da35eff508680f0a19c97cb1111fe4cef1
Reviewed-on: https://gerrit.instructure.com/8981
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Deepeeca Soundarrajan