recent puma bump exposed some flaky student group specs, skipping
per known fix work
flag = none
refs FOO-1869
Change-Id: Ia50dbd403ee865a11858745086b9f3931d65c1f9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262778
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Ryan Norton <rnorton@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Noticed this file was in the wrong place
refs VICE-1230
flag=react_discussions_post
Test Plan:
- N/A
Change-Id: Iec0651d887c83449d12cae32af366f0fe0b17160
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262774
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes VICE-1238
flag=react_discussions_post
Test Plan:
- Enable the react_discussions_post feature flag
- Navigate to a discussion topic
- You should see the threads of the discussion topic
- Expand a nested reply and it should load the replies
Change-Id: Ifc795ce1fe79117d822bf9e14003d4f360f2fb30
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262728
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
test plan
- existing specs should pass
fixes VICE-1318
flag=none
Change-Id: I450cfacec186e7ea50fa9d8e43ce4358fad9f01d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262760
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Matthew Lemon <mlemon@instructure.com>
Product-Review: Matthew Lemon <mlemon@instructure.com>
flag = none
Change-Id: I876e9918888242ccea1158898379a9e4054f588f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262761
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
When launching a 1.3 tool as an unauthenticated user (possible in
public courses), Canvas sends the `sub` claim as
`https://canvas.instructure.com/public_user`
However, the sub claim should really be omitted when launching a tool as
an unauthenticated user, according to the IMS spec.
http://www.imsglobal.org/spec/lti/v1p3/#user-identity-claims
The `lti11_legacy_user_id` claim should follow the same behavior of
user_id laim in an LTI 1.1 tool. As `user_id` is empty when launching
a LTI 1.1 tool in a public course with unauthenticated user we're
changing the `lti11_legacy_user_id` claim to return an empty string
instead of `https://canvas.instructure.com/public_user`.
closes INTEROP-6599
flag=none
test-plan:
* Have a public course published;
* Install an LTI 1.3 tool with course navigation placement enabled, you
can use the this change in the LTI 1.3 Test Tool
https://gerrit.instructure.com/c/canvas-lms/+/262530, which disable
sub claim validation;
* As an unathenticated user, access the tool in the course navigation,
and verify that the tool should launch and the `sub` claim should not
be present and the `lti11_legacy_user_id` claim should em empty;
* As an athenticated user, access the tool in the course navigation,
and verify that the tool should launch and the `sub` and
`lti11_legacy_user_id` claims should be present;
Change-Id: I78bb64e3d898f44fcc401a43d054909032ef5420
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262530
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Evan Battaglia <ebattaglia@instructure.com>
QA-Review: Evan Battaglia <ebattaglia@instructure.com>
Product-Review: Wagner Goncalves <wagner.goncalves@instructure.com>
refs DE-338
Eliminate the need for the withEnv() indentation by consistently naming all of these variables.
Test Plan:
1. Migrations caching works correctly
Change-Id: Iaef43c4e4278878e17b90e2190dc0d7a0a42cb26
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262743
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Add a log that gather all the output of the commands, hide
output to the user and show a spinner if the commands takes
longer to run.
refs DE-482
flag = none
test-plan:
- local docker dev job passes
- docker_dev_setup works and the output is not shown to
the screen
- interrupt the execution of docker_dev_setup and check if
the user is notified with the interruption
- force docker_dev_setup to fail and check if the error
notification is present on the screen and the log shows
the actual error
Change-Id: I84870fee23d9d1280addfffbb234335577bb3b93
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261371
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
fixes VICE-1316
flag=react_discussions_post
Test Plan:
- Navigate to /graphiql
- Run the following query:
```
query MyQuery {
legacyNode(_id: <id>, type: DiscussionEntry) {
... on DiscussionEntry {
id
subentriesCount
discussionSubentriesConnection {
nodes {
message
}
}
}
}
}
```
- The subentriesCount field should be correct
Change-Id: Ic2ba7a4d2ef72dbf0a01410e6bb3928c3bae527a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262742
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
refs DE-608
When we pull the experimental syntax docker image, buildkit can fail with the error “failed to solve with frontend gateway.v0: frontend grpc server closed unexpectedly”. We don’t actually need buildkit or the experimental syntax for this image, so stop using it.
Test Plan:
1. Linters passes in main build.
2. Linters fails when webpack file size is wrong.
3. Linters uploads image when upload directive specified.
Change-Id: I6b508cbf7fc42d0d93b066804ba07dc994b9625d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262734
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
refs FOO-1869
flag = none
test plan:
• test is skipped
• build passes
Change-Id: Ic793f7a7b87cf66fea06ed1be13735f78449805f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262735
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
refs DE-338
After we started moving stages out of the nospot block, we forgot to move the post-actions function out of that block as well. This results in postFn() being called too early.
Test Plan:
1. Build summary report actually captures all stages.
Change-Id: I743827c4f35682e8887918c9041ed833e51ad2f3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262712
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
closes EVAL-1572
flag=assignments_2_student
Test plan:
- Open the enhanced student view as a test student
- The footer should appear above the "you are viewing this as a test
student" alert at the bottom
- Without the test student alert, it should appear at the bottom of the
page as usual
- Make sure neither the footer nor the student alert occlude any of the
content of the page
Change-Id: Ia9bafa8b7181f266be308425889e0513a0f2ad0f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262536
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jody Sailor
QA-Review: Adrian Packel <apackel@instructure.com>
closes MAT-40
flag=auto_show_cc
Requested by the Columbus Public Schools (my homies), create a
setting so videos automatically show CCs when playing
videos.
test plan:
- create RCE content and include a video
- add a couple CC files in different languages, including the
user's language (the .srt files don't have to be in another language,
just tell canvas they are)
- save
> expect no CC without selecting them from the CC menu in the
media player
- click on the user's avatar to open the user's tray and choose Settings
- enable the "Automaticaly show media captions" feature
- refresh to the page with RCE content
> expect the CCs in the user's language to automatically show
- change the user's language to another one you have CCs for
- refresh the page with the video
> expect the new language's CCs
- change the user's language to something not in the CC list
and not English
- refresh the video page
> no CCs and nothing bad happens.
note: I wanted to test with with various combinations of en, en-US,
and en-GB but canvas won't let you add CCs in regional locales. I don't
know why, but that's a problem for another day.
Change-Id: I355fd12c5ea42fe5bc8e776a0c602c2857aaf4c6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262500
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes VICE-1311
flag=none
manual testing only
test plan:
- as an admin, visit /accounts/self/settings
- go to the Announcements tab
- create a global announcement
with a long paragraph
- verify than as you make the browser width narrower,
that it overflows without scrollbars, and that
it does not bleed into other parts of the page
- visit / (this is the dashboard)
- verify that it overflows properly here as well
Change-Id: I34a8a00271d1544ea04d06f4c15fbd9ee339f5f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262718
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
test plan
- create a discussion entry
- create sub_entries
- run the following graphql query:
```
query MyQuery {
legacyNode(_id: <root_entry_id>, type: DiscussionEntry) {
... on DiscussionEntry {
id
rootEntryParticipantCounts {
unreadCount
repliesCount
}
}
}
}
```
- The result should show number of entries, and unread for the user
fixes VICE-1309
flag=none
Change-Id: I4a5a640498d3e31002e7a62f0e4ac556374a6c56
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262628
Tested-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Matthew Lemon <mlemon@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Matthew Lemon <mlemon@instructure.com>
This loads the non-hidden, course nav apps for the k5 subject course
on the resources tab.
closes LS-2062
flag=canvas_for_elementary
Test plan:
- Open up a k5 subject course as a teacher or student
- Click the resources tab
- Expect to see whatever apps appear for that user on the classic
course nav
- Click an app, expect app to open in course context
- Reload page, expect to see loading spinner briefly
- Simulate network failure, expect to see error message when loading
apps
Change-Id: Ie483315d02feaeaeea835656dacf2739902ee2ef
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262572
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
QA-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
closes MAT-26
flag=new_math_equation_handling
*** the same change in a sibling commit has been merged
*** into stable/2021/04/14 and is being warmfixed.
we were pulling the equation LaTex from the image's
data-equation-content attribute but in the quiz from the ticket
its value was not the equation. I'm not sure how this happened
(could the quiz author really have edited the HTMl to change
all the quiz's equations?) but since the src UTL is the equation's
source of truth, let's just always use that.
There are other places in the code that rely on the date-equation-content
attribute to generate mathml, but it's only exercised if the
new math feature is off. I'd rather not remove it from everywhere on
a ticket that will be hotfixed.
test plan:
- with the new_math_equation_handling flag on
- in the rce use the equation editor to create an equation
- edit the HTML to put something else in the data-equation-content
and alt attributes, or remove all but the src attribute if you
want.
- save
> expect the correct MathJax typset equation in the result.
- have an equation with no LaTex in the src attribute and save
> expect the broken-image image and no catastrophic failures
Change-Id: If2a0528563804c05d8b0344cc7e4b0f1dc5a47a2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262593
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Jenkins