these views are causing serious performance problems. follow
the advice of our DBAs and instead of using/ joining on the
module_student_visibilities view we will now use the new services
refs LX-1728
flag=differentiated_modules
test plan:
- tests pass
- a thorough QA of assigning modules to different students
and sections and checking for correct visibility.
Change-Id: Icb02a49a47cf79e508a43dec652d901ddb245a7c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348917
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Sarah Gerard <sarah.gerard@instructure.com>
closes EVAL-4166
flag=none
test plan:
- Create a course with active student enrollments.
- Create a custom grading scheme using points,
with letter grades between 10-0.
- Create an assignment, set it to be worth
10 points and to use a Letter score following
the newly created grading scheme.
- Open student submission in Speedgrader.
- Add a long decimal score to the assignment,
such as 2.100000000009.
- notice the score rounded to 2 decimal places.
- Ensure that 2.10 is also shown in the student's
gradebook and individual gradebook
Change-Id: Ib95398ed69f8ac6776e652dee7dbb15d65b3095a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348771
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
QA-Review: Chris Soto <christopher.soto@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
refs VICE-4189
flag=instui_nav
Test plan:
- Enable instui_nav FF
- Go to Announcements (or Discussions) page
- Click to '+ Announcement' in the right corner os page
- Check the loaded page contains this header: Create Announcement
- It need to be works same in Discussion page
Change-Id: Ia8c3bc47b99d182c1f0522e342064b5fff9822d8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348427
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Roland Beres <roland.beres@instructure.com>
Reviewed-by: Daniel Matyas Vincze <daniel.vincze@instructure.com>
Product-Review: Donát Bali-Papp <donat.balipapp@instructure.com>
Add keyword highlighting to smart search. Also remove relevance as it
was causing more confusion than helping.
Test Plan:
* Load course with smart search enabled
* Navigate to search
* Search for specific words you know are included in the body of the
text
* Notice keyword highlighting
* Create a long wiki page and notice that keyword highlighting will
use a substring of text with highest occurence of keywords
highlighted
* Confirm that relevance is no longer displayed
flag=smart_search
closes ADV-118
closes ADV-119
Change-Id: I584068ce7e97b8458ac1f4ff6f4c36e53f1ab9c0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348772
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Dustin Cowles <dustin.cowles@instructure.com>
QA-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
refs VICE-4065
flag=none
Test plan:
the tests ran successfully
Change-Id: I61fcab63cecb1067939405557618905f3b879a22
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348933
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Jason Gillett <jason.gillett@instructure.com>
Pass in permissions and feature flags to AnalyticsHub as env vars
Fix invalid port configuration for Analytics Hub
https://instructure.atlassian.net/browse/EAX-697
flag=analytics_hub
refs EAX-697
test plan:
- Check in Analytics Hub if the variables are passed on
Change-Id: I524e6ed97549c21c47f2a3f897cf85bfd193b169
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348723
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: David Kalacska <david.kalacska@instructure.com>
Product-Review: David Kalacska <david.kalacska@instructure.com>
flag=none
closes RCX-1848
Test Plan:
- Check out PS
- Add/Remove uses of byRole
- Make and push new commit
- Or run script/tatl_tael locally
* Verify comments only in files in /__tests__/
* Verify comments only on new uses of byRole
* Verify no comments on existing uses of byRole
Change-Id: I931f70a6fa2df94fe85b0d210a4888ff062e5113
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348071
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
refs LF-1003
flag=none
test plan:
- 'does not show error with when
choosing another date time format' test passes
Change-Id: I0bcdac6adea4353a1eac571b71bca4e1c410dbb7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348951
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Reviewed-by: Mario Hegyi <mario.hegyi@instructure.com>
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes VICE-4232
flag=none
Test Plan:
- As descriebd in VICE-4232 steps to reproduce
- Try to hit Reply on a msg and then submit with "Send"
- Compose modal should NOT appears again
after spinner is closed
Extra notes to plan:
- As I removed setTimeout which was a fix for VICE-4106,
try the scenario above by just navigating with Tabs, the flow
should not be breaked.
The gist of the solution:
- The spinner itself should be rather added/removed from DOM
instead of trying to control it by its open prop.
Change-Id: I429f027c25f7599df28d8469ba0ccb8101df5802
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348724
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Roland Beres <roland.beres@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Jozsef Gubicza <jozsef.gubicza@instructure.com>
closes LX-1681
flag=differentiated_modules
test plan:
- goto a course page
- edit one of the modules and change the requirements
- the Requirements CHanged modal should open
- check that the x close button should be focused
Change-Id: Ic3ec59a305745f93b2f20df7b77f9e087929cf67
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348425
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: Alvaro Talavera <alvaro.talavera@instructure.com>
Sarah Gerard