and apply new cop 99% Style/SuperArguments
and a couple Layout/EmptyComment and Style/ArgumentsForwarding that
are found by fixes in those cops
Change-Id: Icc0af9c8065f035bca43868b564f73e8776052f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348626
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
This reverts commit 63a05bc983.
Reason for revert: bundler 2.5.10 is now available as a system gem on our servers
Change-Id: I53031bd6b11a30184cf6b584f72f72892c09dc35
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348271
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
This reverts commit 698049fdf0.
Reason for revert: Passenger isn't loading the correct version of bundler, and the new version causes a conflict with the old version
Change-Id: I030f29872e6052c0af59ae8d7810725189261170
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345745
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
test plan: Enable the feature flag translating the
inbox message for current user.
Go to inbox, click compose. Verify that checkbox is
at bottom of screen. Click checkbox,
select language, and select message position.
Also turn on Inbox Settings QW flag, set
signature for message, and verify that signature
persists after translation.
flag=translate_compose_message
refs ADV-105
Change-Id: I72d34b05771ff6a845fa2a76e8e66c6abb373abf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347122
Build-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jacob Windle <jacob.windle@instructure.com>
Product-Review: Jacob Windle <jacob.windle@instructure.com>
Add `cohere.embed-multilingual-v3` as new embedding strategy for smart
search.
Test plan:
* Add bedrock creds to rails credential store
* Make sure that background jobs processor is running
* Open search page on existing indexed course
* Confirm that course is re-indexed and run searches
* Confirm that newly enabled courses are also index properly
flag=smart_search
closes ADV-98
Change-Id: I664a954f34e5c474db0b210f2ae092f891d60f89
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346524
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Jacob Windle <jacob.windle@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
test plan: Put translation AWS credentials into Canvas vault.
Create a test discussion in new discussions UI. Enable feature flag.
Click the kebab menu icon on discussion post page, click show translation.
Select a language from translation dropdown menu. Ensure loading icons and translations
are happening.
flag=translation
refs ADV-100
Change-Id: Id86f53184b31e504fe3736bab9e5b15b47a87e5d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346282
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
QA-Review: Jacob Windle <jacob.windle@instructure.com>
Product-Review: Jacob Windle <jacob.windle@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes LF-1550
flag=none
Test plan
- In Canvas, create a link like <a id="media_comment_m-media_id"
class=" instructure_video_link instructure_file_link"
title="title.mp4" href="/courses/1/files/1/download?wrap=1">Text</a>
in rich content
- Copy the course and verify it copies the page and the link looks correct after copy
(the data media id doesn't update if you put one, but that seems
unrelated)
Change-Id: I1704be7e3c8d0c954366aa2367ca4f9526167151
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346585
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes LF-203
flag=none
Test plan
- In RCE in Canvas do the following:
- Set up a standard media iframe
- Set up a media link that looks like this:
<p><a id="media_comment_m-65LRekaWzXTLCp9PwqaibDkX3C5Jo6Vf"
class="instructure_inline_media_comment video_comment"
href="/media_objects/m-65LRekaWzXTLCp9PwqaibDkX3C5Jo6Vf"
data-media_comment_type="video" data-alt=""></a></p>
(use your own media id)
- Set up a media object that looks like this:
<p><iframe style="width: 200px; height: 150px;" title="Video"
data-media-type="video" src="/media_objects_iframe/m-65LRekaWzXTLCp9PwqaibDkX3C5Jo6Vf
?type=video&embedded=true" allowfullscreen="allowfullscreen" allow="fullscreen"
data-media-id="m-65LRekaWzXTLCp9PwqaibDkX3C5Jo6Vf"></iframe></p>
- Copy the course to a new course and ensure all of the links
now point to the new media file that was created in the course
- Do an export/import and ensure the same
Change-Id: I9a93980d63c9ad351b9f192d8c48dd2012178a66
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/343251
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Build-Review: Alex Slaughter <aslaughter@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
Change-Id: I98591f1119945e06e34906ce2bcbbdaab596633a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/344511
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: Ic9bb3deea7d89a48cd23e0ee8cd138cdd9e89321
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/344092
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Cody Cutrer