closes FOO-1464
flag=none
TEST PLAN:
1) scrub a launch by forcing a silly url
2) you get a flash error rather than an app-level
500
Change-Id: I38ac55d85f505e62fc7368da6026e19cf4573a06
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256673
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes FOO-1387
flag=none
TEST PLAN:
1) try to launch LTI content in a place it doesn't go
2) get a standard LTI error response, rather
than a 500
Change-Id: Id600715e1e4ebd05e1b5d3364f05da2a068ed711
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/255711
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Closes PLAT-2818
Test Plan:
- Using the Create endpoint API found at
https://canvas.instructure.com/doc/api/originality_reports.html
and specify an originality score.
- Verify the originality report is created with the specified
originality score and other data.
- Repeat the exact same post request, but change the originality
score value.
- Verify the originality report is updated and a new one is not
created.
- Verify you can still update the originality report via the
PUT endpoint found in the same docs.
Change-Id: I4a2b8ad6f5b68e49a6195862cf7826fe31152bca
Reviewed-on: https://gerrit.instructure.com/125944
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
fixes PLAT-1871
test plan:
this requires an indirect test,
before loading this code
hit the external_tool#retrieve endpoint passing in a secure_param
jwt that is invalid
/courses/:course_id/external_tools/retrieve
look at your error reports you should have and error for:
uninitialized constant Lti::UnauthorizedError
load this code and repeat the above step, you should now
have an error for a bad JWT token
Change-Id: I405befe60fdcc0d1178c1977442f6e372b73b852
Reviewed-on: https://gerrit.instructure.com/95384
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Nathan Mills <nathanm@instructure.com>
Ethan Vizitei