test plan:
- as a parent observer in an account with self-registration
for observers enabled, you should be able to add an
observee who is using a login id that formerly belonged
to a deleted user
fixes CNVS-22146
Change-Id: Ib2eea55bdc3e41e1badd4e65c221a514481c40c3
Reviewed-on: https://gerrit.instructure.com/59885
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Change-Id: Ie88b2239a3d95d0dfd36608f6744a89de5cbf7a9
Reviewed-on: https://gerrit.instructure.com/60082
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Adrian Foong <afoong@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
accessibility compliance
fixes CNVS-22042
fixes CNVS-22044
fixes CNVS-22045
fixes CNVS-22041
test plan:
- check the following pages for any visual or accessibility regressions:
Assignment show page (teacher view)
Discussion Topic edit page (for both discussions and announcements)
Quiz show page
Change-Id: I51a915994fb3a047e0b6a461870de9d24ba9fd33
Reviewed-on: https://gerrit.instructure.com/58973
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
- Allows multiple preferences to be updated by category
- Fetch the categories that exist in the notification preferences
fixes CNVS-21902
Change-Id: I96f005dc981079ee0797beec75cdecde4d05e96c
Reviewed-on: https://gerrit.instructure.com/57829
Tested-by: Jenkins
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
sshepherd,panda,1
Test Plan:
- Run Specs
Change-Id: I15ac9c39dc15930e872cd399238d5117dba69bda
Reviewed-on: https://gerrit.instructure.com/60039
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes CNVS-20332
test plan:
- make quiz with an access code
- as a student, POST an api request to /api/v1/courses/:id/quizzes/:id/verify_access_code
with the correct access code in the access_code parameter
> the request should return 'true'
- send a request with the wrong access code
> the request should return 'false'
Change-Id: I910da2a715d121412fee62b9707de3986b1c762c
Reviewed-on: https://gerrit.instructure.com/55662
Reviewed-by: Brian Finney <bfinney@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Brian Finney <bfinney@instructure.com>
sshepherd,panda,0
(I accidentally added an extra one last spec, so this makes things right)
Test Plan:
- Run specs
Change-Id: Iba404e25a9d44dd870632fa0ab1e51361f3b26b3
Reviewed-on: https://gerrit.instructure.com/60017
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Fires off delayed job that hits the turnitin callback url,
creates a submission, and maps originality data into the turnitin_data
field.
Fixes PLAT-1167
Fixes PLAT-1169
Test Plan:
You'll need to have the TurnItIn LTI tool installed, and delayed_jobs
running
Create an assignment with the submission set to the External Tool for
turnitin.
As a student, submit the assignment.
wait for the delayed job to run. check out /jobs to see whats going on
After the job has ran you should see turnitin data, as you would
normally with the plugin
Change-Id: I5d60d250e91b422b5e77255d715abf2e4712f130
Reviewed-on: https://gerrit.instructure.com/59942
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
QA-Review: Nathan Mills <nathanm@instructure.com>
rails4 modifies _core_en.js while running compile_assets (presumably due
to new formats), this will allow the rails4 build to be selinimized
also whitelist selinimum's own files, since changes to them don't affect
the actual selenium tests
test plan:
1. rails3 and rails4 builds of this commit should get selinimized
Change-Id: I0f012f8e900f44290f258a791c96d5ab6e4cc095
Reviewed-on: https://gerrit.instructure.com/60010
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
sshepherd,panda,2
Test Run:
- Run specs
Change-Id: I2f1acbc55dbde818e327d9355b46505fa6842bc1
Reviewed-on: https://gerrit.instructure.com/59989
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
test plan:
* enable page views
* as a user, visit the course profile page of another user
* the visitor's access report should show the visited user's
name, rather than a blank "Content" column
closes #CNVS-22233
Change-Id: Ifaa4bd9fcdee7a805e00dc23f313262e9925325a
Reviewed-on: https://gerrit.instructure.com/59836
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-22295
Test Plan:
1) Login as teacher, create module
2) You should expect that there is no requirement message that
says 'Complete All Items'
3) Publish module as a teacher then as a student ensure that
there is no requirement message and that there is no completed
check mark icon. There should be no icon.
4) As a teacher, add an assignment to the module and publish it
5) As a student, ensure that there still is no requirement message
or check mark
6) As a teacher, make the assignment a requirement for the module.
7) You should expect that the requirement message that says 'Complete
All Items' now appears on both student and teacher view.:
Change-Id: Ibb8a41a496d71d5f006ef3845f6ebca6af4b7fbf
Reviewed-on: https://gerrit.instructure.com/59878
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-21686
test plan
- regression test sending messages to groups in conversations
Change-Id: Ic8043fcf44ed1d190aff96084a1aa91fba4467b7
Reviewed-on: https://gerrit.instructure.com/59377
Reviewed-by: Alex Boyd <aboyd@instructure.com>
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
closes RC-70
I was continuing to error with this:
kinesis_1 | LevelUPError: Failed to require LevelDOWN (Cannot find module 'leveldown/package'). Try `npm install leveldown` if it's missing
Adding the npm install command to the Dockerfile for
kinesis seemed to solve the problem.
Change-Id: I963e97761c966492fca8b3d8eec607d628902af9
Reviewed-on: https://gerrit.instructure.com/59966
Reviewed-by: Zach Wily <zach@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Fixes PLAT-1160
Test Plan:
- Install a test tool at the account level and give it a variety placements.
- Navigate to a course within the account you just installed the tool in.
- go to settings -> apps and look at the app configurations.
- make sure the account level tool has a button that allows a user to view placements.
- make sure the list of placements given for the account level tool is correct.
Change-Id: I306290d593e59d80dcd34ff7550388508694c141
Reviewed-on: https://gerrit.instructure.com/59040
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes Plat-1168
Test-plan:
Submit a turnitin assignment using the lti tool
it should create a submission with the submitted file as an attachment
Change-Id: I37b24f8d2cb5c78f1247a0096f1afe2f3528abcb
Reviewed-on: https://gerrit.instructure.com/59701
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Tested-by: Jenkins
Product-Review: Nathan Mills <nathanm@instructure.com>
QA-Review: Nathan Mills <nathanm@instructure.com>
Fixes: CNVS-21513
Test Plan:
- In Firefox with NVDA enabled, turn on the new UI
- Move through the global nav with NVDA
- Previously, Account and Inbox options had an extra
link announced (http://screencast.com/t/mAp9jc5tMtjO)
- Now, the Account and Inbox options should be
consistent with the ones before them (no extra
'link' is announced)
Change-Id: Ie7267a4a93680c5ea8f066b505148c1b0e42fa31
Reviewed-on: https://gerrit.instructure.com/59669
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
refs CNVS-22054
Course had a large method `gradebook_to_csv` which was not a
clear responsibility of Course objects. This extraction creates
a GradebookExporter PORO which is responsible for exporting
gradebooks to CSV files.
Change-Id: I0a5c3099d21358ef0ee4c5cd03586760b971a9f5
Reviewed-on: https://gerrit.instructure.com/59708
Tested-by: Jenkins
Reviewed-by: Derek Bender <dbender@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
should be able to switch seamlessly between rails 3 and rails 4
now with the same session
refs #CNVS-21596
Change-Id: Icfa64ba861a5309dadcd962ffbfa53c4e59f4c76
Reviewed-on: https://gerrit.instructure.com/59869
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-21383
Test Plan:
1. In Firefox with NVDA enabled, navigate to
the Modules page of a course
2. Using the up and down arrow keys, move NVDA
focus to the name of a module item
3. Press Enter and you should expect the system
to navigate to the assignment
Change-Id: Ic2e34b1030ccbc4bffca8bceaab5215a31732150
Reviewed-on: https://gerrit.instructure.com/58530
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Brock Cooper <bcooper@instructure.com>
fixes CNVS-21389
The content export tool is being updated so that it consders the
provided user's rights, so that the CC export can be used for the new
epub generation tool.
This PS employs WikiPages::ScopedToUser to make sure that the user
only gets the wiki pages that they have the right to view.
test plan:
- Regression test for content export tool wiki pages
functionality.
Change-Id: Icd3cd11fb8008bbd7441854e51fd8f37bcfbb6b7
Reviewed-on: https://gerrit.instructure.com/59395
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
fixes CNVS-21390
The content export tool is being updated so that it consders the
provided user's rights, so that the CC export can be used for the new
epub generation tool.
This PS employs Assignments::ScopedToUser to make sure that the user
only gets the assignments that they have the right to view.
test plan:
- Regression test for content export tool assignment functionality.
Change-Id: Id0170806c10715130d34e8c7a190e4fcaeb22cd5
Reviewed-on: https://gerrit.instructure.com/59323
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
fixes a problem where sometimes quiz points were not correctly
specified because of migration_id collisions
closes #CNVS-22287
Change-Id: I311398570aa6186c9be9c3502329a46a0c30c555
Reviewed-on: https://gerrit.instructure.com/59780
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes CNVS-22283
test plan:
- go to theme editor
- if you click on a color's
label, it focuses on the input
- if you input an invalid color and
then inspect element on its input,
you see aria-invalid is true
- it is false when it is not invalid
Change-Id: Ic4ff57967f96784942d83d210eb0046d67114b81
Reviewed-on: https://gerrit.instructure.com/59775
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Fixed the way screen reader reads the collapsed
and expanding of the new conferences and concluded
conferences reading.
fixes CNVS-21775
test plan:
- Go to the conferences page
- with screen reader on navigate to the
new conferences header
- collapse and expand it notice the correct reading
- repeat above for concluded conferences
- repeat above for all screenreaders
Change-Id: I72dd37aef3410435b8326c1c99736889c8bad268
Reviewed-on: https://gerrit.instructure.com/59530
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
fixes CNVS-22236
Test Plan:
* Prerequisites: course with assignments, and several modules that have unlock dates.
* Modules with unlock dates in the original course.
* Perform a course copy, setting start and end dates in the future, and select 'Adjust Dates' (the destination dates should be prefilled with the future dates).
* Once the copy is complete, compare the module unlock dates with those of the source course
* The unlock dates should have been properly shifted
Change-Id: I4e880f44f9cf924d6a3dd2a7e34371d845906b1d
Reviewed-on: https://gerrit.instructure.com/59741
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
Jeremy Stanley