build query that search for overrides but delegates to assignment if none exist
fixes CNVS-20435
Change-Id: I0b88ccb78027e43a7d82c392a11b9980fff52174
Reviewed-on: https://gerrit.instructure.com/57176
Tested-by: Jenkins
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-22349
Test plan
0. In a course with sections navigate to the gradebook.
1. Confirm that there is a sections dropdown on the right.
2. Confirm there is NOT a sections dropdown on the left.
Change-Id: Ib0419fbf7cfd78be87277b487a9b1080ab22329f
Reviewed-on: https://gerrit.instructure.com/60656
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-22557
Test Plan:
- create a user and register them with google docs
- then try to register them with google drive
- notice you can change what email you want to register with
google drive
Change-Id: Id5894cd7fddf152491a27c2cadb17f5a93109b1b
Reviewed-on: https://gerrit.instructure.com/61293
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins
Product-Review: Peyton Craighill <pcraighill@instructure.com>
fixes CNVS-20609
Test Plan:
- Go to /accounts/XX/permissions
- Using the keyboard navigate to one of the permission buttons
- You should be able to open the menu with the Enter key
- You should be able to navigate up and down in the menu and
select a new permission
- Pressing Enter or Spacebar should select the new permission
Change-Id: I6ec2aa5a90e6f4a183816744e531fa0889cd5013
Reviewed-on: https://gerrit.instructure.com/60917
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
twilson, panda, 2
- added shared examples for Candroid and SpeedGrader for
login view and credentials
- minor simplification of iOS specs
- to test: comment/uncomment appium init and skip statements in
mobile_common, spin up Appium server, create and edit yml file,
and run specs
Change-Id: Ia984a79bac51104dba232cf348a77fdc6a656c8b
Reviewed-on: https://gerrit.instructure.com/61280
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Dev keys with an account id will no longer be able to auth with users
outside their account.
Fixes PLAT-1202
Test Plan:
Create a dev key for one account
try to auth it with a user on another account
Change-Id: I16edb6abc4af59c7e903eaf9287cc081b610967f
Reviewed-on: https://gerrit.instructure.com/60561
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
- this is in preparation for separating the appium tests
from the selenium tests
- Test Plan:
make sure it passes Jenkins
make sure all the Appium Tests still work
Change-Id: Ie2810c489ed8672f4c3a99392927444b317618d4
Reviewed-on: https://gerrit.instructure.com/61263
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
test plan:
* image files and thumbnail creation should work as before
closes #CNVS-22544
Change-Id: I5631b392a4f4371d6fba2065608b8ce65175dcd5
Reviewed-on: https://gerrit.instructure.com/61078
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
twilson, panda, 7
- added shared examples for iCanvas and SpeedGrader for
login view and credentials
- to test: comment/uncomment appium init and skip statements in
mobile_common, spin up Appium server, create and edit yml file,
and run specs
Change-Id: Ie32900026028ea36568343b85b275c4e00d33fa3
Reviewed-on: https://gerrit.instructure.com/61224
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure all test_ids match up to an existing test case in TestRails
mhargiss,panda,11
Change-Id: I347834d5be266aa8b422c1623f676fc374ebf7dc
Reviewed-on: https://gerrit.instructure.com/59274
Tested-by: Jenkins
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Reviewed-by: Taylor Wilson <twilson@instructure.com>
otherwise it will ovewrite logger.level with the default
(:info on production)
refs #CNVS-21596
Change-Id: I18352300b769d141de7a83959568e627f6a519b4
Reviewed-on: https://gerrit.instructure.com/61257
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
avoid even going to redis for two common cases that are likely
already cached in-process, or for repeated calls to the same
method
Change-Id: Ia90dbe25d83ab69ba62f26c966884a041ff61f3d
Reviewed-on: https://gerrit.instructure.com/61093
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
* query the sis assignments api for an account/course
* /api/sis/accounts/:account_id/assignments
* /api/sis/courses/:course_id/assignments
* the description field should not be returned for any assignment
fixes CNVS-22513
Change-Id: I2d679a3b7eedf4f4892ef5e7d1b93007e7500c7a
Reviewed-on: https://gerrit.instructure.com/60861
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Mark Severson <markse@instructure.com>
fixes CNVS-22506
test plan
- regression test google doc collaborations
Change-Id: I696562d74e317b465b1679513fa7f5ff913a1c99
Reviewed-on: https://gerrit.instructure.com/60923
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
We now pull the account from the developer key
Fixes PLAT-1200
Test Plan:
Run the tests?
not much really changed
none of is really exposed/used
Change-Id: I88b3b9b907ae7b15145ac8e2e6fc1a18527b40d5
Reviewed-on: https://gerrit.instructure.com/60544
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
don't stuff them in the fake js_env and join the data there
just return them with the rest of the speedgrader data
also don't do unnecessary permissions checks on every rubric
assessment
test plan:
* regression test speedgrader rubric assessments
closes #CNVS-22522
Change-Id: I31a025c8f23b054857823f411a229780c27cb94f
Reviewed-on: https://gerrit.instructure.com/60963
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
loading AccountServies.allowable_services shouldn't calculate
"expose_to_ui" when unnecessary
Change-Id: I86c6bebb88c372932283b063054a5f9e5fb947e1
Reviewed-on: https://gerrit.instructure.com/61186
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
sshepherd,panda,9
Test Plan:
- Run specs
Change-Id: I34630c52b3fcd8b3076b2c1ea6ed52bcfd24021a
Reviewed-on: https://gerrit.instructure.com/61231
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Slight structural change to post grades button to make style more
uniform. Test plan from original ticket where button was added is
pasted below for ease of testing. Verify that change works for old and
new canvas styles.
Test Plan:
* configure powerschool grade posting by enabling sis feature flag
* /accounts/:id/settings
* "post grades to sis" -> on
* /courses/:id/settings
* SIS ID -> random number
* add an assignment, make sure that "post grades to sis" is checked
* navigate to gradebook, verify that "post grades" button is visible
* verify that "post grades" button is not visible when no assignments
are present
* click on button and verify that current powerschool modal launches
* add sisapp lti launch
* get local sisapp running
* /accounts/1/settings/configurations
* add app, by url http://<local sisapp>/post_grades/config.xml
* navigate to gradebook, verify that both powerschool post and new
lti post are available in drop down menu
closes CNVS-22119
Change-Id: Id57bed25774e4bff2208eb8a7ec1f318a276f1c5
Reviewed-on: https://gerrit.instructure.com/60378
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
twilson, panda, 4
- added shared examples for iCanvas and SpeedGrader landing page
- minor changes to appium environment setup, school_domain now
defined in selenium.yml file
- to test: comment/uncomment appium init and skip statements in
mobile_common, spin up Appium server, create and edit yml file,
and run specs
Change-Id: Ica180895f167e007cab14cadfe79e554a44f25da
Reviewed-on: https://gerrit.instructure.com/61118
Reviewed-by: Heath Hales <hhales@instructure.com>
Reviewed-by: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins
Product-Review: Ben Bolton <bbolton@instructure.com>
QA-Review: Ben Bolton <bbolton@instructure.com>
When using SpeedGrader on an external URL page, the teacher is
presented with the URL as a link that opens in the frame and a second
instance of the link with the text "(View in a new tab.)" Because of
this, teachers have the option to choose to view inline or in a
seperate tab.
fixes CNVS-22370
test plan:
- In a published course with students...
- Add a URL submission assignment and publish it.
- As a student submit http://placekitten.com as the assignment
submission.
- As a teacher view the submission in speedgrader, and click the
submission links in the left frame.
- Confirm that the URL link opens in the iFrame and the "View in a new
tab" link opens in a new tab or window.
Change-Id: I4991db9cd12101f0cfdd719aed3e77acf0ce7a61
Reviewed-on: https://gerrit.instructure.com/60517
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
Entering any invalid character—e.g. &, }}, {{+, or space—as an initial
grade in either the Gradebook or SpeedGrader causes the grade to be
set to null and the workflow_state to remain in unsubmitted. Because
of this, results in SpeedGrader do not show the student as needing to
be graded.
fixes CNVS-20823
test plan:
- Create a course with multiple students and an assignment of any type.
- Enter any non-grade in either Gradebook or SpeedGrader (characters
like &, ?, +, etc…), and press 'Enter'
- Note that the character is removed as the field updates
- View the submission in SpeedGrader and note that the student shows
as unsubmitted by the lack of orange dot nor green checkmark next to
their name
Change-Id: Idae8c025739fdb051ca7c8089f3cc25fe1424690
Reviewed-on: https://gerrit.instructure.com/60851
Tested-by: Jenkins
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
The File Attachment and Media Comment buttons in the teacher comment
attachment area in the SpeedGrader Add a Comment area now navigates
and reads properly in screenreaders. As a result, navigation and
intention is now communicated clearer to users with accessibility
needs.
fixes CNVS-13135
test plan:
- Create a text entry assignment and have a student submit something
to be graded
- As a teacher, go into speedgrader for that assignment
- With a screenreader activated, select the Add a Comment text area
and navigate using tab over the following buttons: Submit Comment,
File Attachment, Media Comment
- Observe that after the Submit Comment button, the File Attachment and the
Media Comment buttons are read as "File Attachment Button" and "Media Comment
Button"
Change-Id: I05e45ada0f083e7bf1ae20433065909f55be133c
Reviewed-on: https://gerrit.instructure.com/60298
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
refs #CNVS-21317
Change-Id: Id9bbb04a92abd835af69ba5ec0c21ef758a8a324
Reviewed-on: https://gerrit.instructure.com/61146
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
hhales,panda,1
Change-Id: I5dae7af8288cba7a30f3f32e8b8f75bf9f66b41e
Reviewed-on: https://gerrit.instructure.com/61100
Tested-by: Jenkins
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes CNVS-22555
test plan
- db:migrate should work
Change-Id: I6259abacf508195cbaca04e06bfed7ec202f5c8b
Reviewed-on: https://gerrit.instructure.com/61133
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Had to split up the n mastery and decaying average int
validation into two functions. There was an issue with
two error boxes being present on the page.
Above range and below range now each have their own tests.
Change-Id: I99954c3c75c2131eb31f3e40ca7c0589dbda761e
Reviewed-on: https://gerrit.instructure.com/61117
Reviewed-by: Matt Fairbourn <mfairbourn@instructure.com>
Tested-by: Jenkins
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
refs CNVS-22335
Test Plan:
- Search for a file that doesn't exist in files
- A message should appear saying that no results were found
Change-Id: Iba07fc829e612205417921f4618f29a9141d01dd
Reviewed-on: https://gerrit.instructure.com/61022
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
sshepherd,panda,6
Test Plan:
- Run specs
Change-Id: I6c62dc36b912edfcaf14bfeec59edcb5b6896627
Reviewed-on: https://gerrit.instructure.com/61112
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Derek Bender