Change-Id: I72f8019fe96b1c854ac2f016d1a40fc25882fbcb
Reviewed-on: https://gerrit.instructure.com/123019
Tested-by: Jenkins
Reviewed-by: David Tan <dtan@instructure.com>
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
closes CNVS-37087
Test plan:
1. Create a OQAAT quiz with `lock questions` set so the
student cannot go back to a previous question.
2. Add 1 or more questions
3. Start the quiz
4. See the alert in English, but since it's wrapped in a
t block now, it will go through the translation service.
Change-Id: I269c83dfaee0292ef5e3df76c7deac2fe07a17f7
Reviewed-on: https://gerrit.instructure.com/122800
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: Davis Lynn McClellan <dmcclellan@instructure.com>
Product-Review: Dave Donahue <ddonahue@instructure.com>
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
fixes CNVS-38665
test plan
- import should work
Change-Id: I5e6cd86f37cf9c29c17702a59bbc54eec5c0edb5
Reviewed-on: https://gerrit.instructure.com/122722
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
fixes CNVS-38593
an updated net-ldap gem changed these defaults
test plan:
* do an LDAP test against an LDAP server that uses SSL
* it should work
Change-Id: I9519033ee45cdceb7dda356a18c497c1615a091b
Reviewed-on: https://gerrit.instructure.com/122785
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
if we sanitized away a link then don't make a confusing
migration issue
closes #CNVS-38688
Change-Id: I2129af0b459db52130f9204aa5f0b92fadaf23d7
Reviewed-on: https://gerrit.instructure.com/122782
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* create a module in a blueprint course
* sync to an associated course
* add a module item in the associated course
* change the module name in the blueprint
* sync to the associated course
* the moddule items in the associated course
should not have been deleted
closes #CNVS-38655
Change-Id: I98127f54f72042e8a69b4ecc06a472ea73239745
Reviewed-on: https://gerrit.instructure.com/122933
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-38494
Change-Id: I929a87349374be4f2d66dd05d6f18736b470d40c
Reviewed-on: https://gerrit.instructure.com/122617
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes PLAT-2770
test plan:
• Go to any account/course settings page
• Click on the Apps tab
• Click on any LTI that populates within the App Center (I use 3DGameLab)
• Click '+ Add App'
• Click the 'Add App' button in the window that appears
• Verify app is added successfully
Change-Id: I060ed314423c841ff5d8ef12c46f2377f31b58b1
Reviewed-on: https://gerrit.instructure.com/122918
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: August Thornton <august@instructure.com>
Fixes: CNVS-38647
Test plan:
- Code reviewer: confirm Canvas CSS and assets compile
ok.
- All reviewers:
- Go to Conversations and activate the Courses dropdown
menu. Confirm that the background color for the :hover
state is var(--ic-brand-primary):
https://cl.ly/080C3V2R1z2y
Change-Id: I9d55b1e89c7b67a2fbf432ecdff1687d99193cf7
Reviewed-on: https://gerrit.instructure.com/122510
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Fixes: CNVS-38648
test plan:
- as a user navigate to locoal canvas dashboard ... use the tab
key to activate the "skip to content" button
- the box shadow has been removed that was a carry over from
bootstrap styles
- now as an admin navigate to the theme editor - click any of the
themes to launch the editor
- navigate to the "watermarks & other images" section... the
"select image" link/buttons have the updated var vs the
"lighten" style
example: https://screencast.com/t/F0A2OMuaG
Change-Id: If27e4d61e7a053c207780728a97967f9de63619a
Reviewed-on: https://gerrit.instructure.com/122619
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Fixes: CNVS-38676
This was causing a storm of jobs and tons of duplicate advisory locks
during the import process, both of these things are unnecessary since
we're already in a background job.
Test Plan:
- Course Content Migrations still work
- There should be fewer jobs spawned during content migrations/imports
Change-Id: Ia29e2d4ba00a3f982404b834061822cae32e5364
Reviewed-on: https://gerrit.instructure.com/122763
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Tyler Pickett <tpickett@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Test plan: docker-compose run --rm karma yarn test
Change-Id: I316d80e7a1b712b0dda91a390c4dddeb09b3e6fb
Reviewed-on: https://gerrit.instructure.com/122776
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Fixes: CNVS-38667
When Assignment#update_submissions is being called it's triggering
Submission#update_assignment to be called without indicating that we
don't need to update the assignment again, this patch fixes that so the
assignment update won't be circular.
Test Plan:
- Stuff still works
Change-Id: I7deb87081725396fa3cfebda25605238b9614a57
Reviewed-on: https://gerrit.instructure.com/122624
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Tyler Pickett <tpickett@instructure.com>
fixes GRADE-197
test plan:
* create a teacher notes column for gradebook
* hide the teacher notes column
* open the web console and reload gradebook
* ensure the custom column data request completes successfuly
* it returns a 200 response, not a 404
Change-Id: I32ede1df6d95490963c9ac2c94652cb81c34e164
Reviewed-on: https://gerrit.instructure.com/122874
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
closes CNVS-38670
test plan:
- perform a search with the recipient search api
(/api/v1/search/recipients)
- result should include full_name for users
Change-Id: I1ac89ac35448bf3ca68b754ca5fefb794e97d4e3
Reviewed-on: https://gerrit.instructure.com/122709
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
closes GRADE-15
test plan:
* heavily smoke test Old Gradebook with grading periods
Change-Id: Idca8d0a448907b36216ded36d37a96d4bd6cccf6
Reviewed-on: https://gerrit.instructure.com/122661
Tested-by: Jenkins
Reviewed-by: Sheldon Leibole <sheldon@siimpl.io>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Change-Id: I46eaf15956910d0e4cde07258cceebb55b056eb2
Reviewed-on: https://gerrit.instructure.com/122816
Tested-by: Jenkins
Reviewed-by: David Tan <dtan@instructure.com>
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
Change-Id: I5958c1e7c8980824c7c2625b86200751f88bd36b
Reviewed-on: https://gerrit.instructure.com/122828
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes GRADE-132
test plan:
* heavy smoke test SRGB with grading periods, especially:
* filtering assignments by grading periods
* filtering assignment list by changing student
* grade locking (closed grading period grade protection)
Change-Id: Iffbb784a91786d1a9cc013933c3c8fe85b90c4b5
Reviewed-on: https://gerrit.instructure.com/121872
Tested-by: Jenkins
Reviewed-by: Sheldon Leibole <sheldon@siimpl.io>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes gh-1095
test plan
- api should have restrict_enrollments_to_section_dates
Change-Id: I4b3eb38bafefe09c1fbaccc95cd4450c425a821a
Reviewed-on: https://gerrit.instructure.com/122770
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
closes GRADE-166
Test Plan
- Use new gb history, all functionality should be the same as before
this.
- Ensure this didn't add any issues that weren't already present.
- Current known issues are that you can search by an invalid date
range. The Filter button is also not disabled when an invalid
date is entered.
Change-Id: I72ba51f0c2b3c1e59076357b17e81b6946e7b9db
Reviewed-on: https://gerrit.instructure.com/122135
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Tested-by: Jenkins
Product-Review: Matt Goodwin <mattg@instructure.com>
test plan:
- click "Forgot password" on the login screen and enter
a valid login for a user
- the reset password link sent to the user should work
as expected (you can use /users/X/messages as an admin
in a separate browser to get the link for testing purposes)
- after the password is reset, you should be returned to the
login screen with a flash message indicating your password
was reset.
- click "Forgot password" again, but wait > 2 hours
before trying to use the reset-password link
(or change the timeout by using the console to, e.g., 5 minutes:
Setting.set('password_reset_token_expiration_minutes', '5')
Note that this expiration applies only to password resets
requested after the setting is changed.)
- you should get a message indicating the code is no longer
valid
fixes CNVS-2757
Change-Id: I6c3beec9a5b59e089997c46d518645357eec3b08
Reviewed-on: https://gerrit.instructure.com/119868
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes: CNVS-38649
Test plan:
- Replaced the one place the $btnPrimaryBackgroundHighlight
Sass variable was being used with the new CSS variable,
--ic-link-color, then was able to delete the
$btnPrimaryBackgroundHighlight variable altogether.
- Code reviewer and QA, please make sure Canvas' CSS compiles
with no errors. The styles that are being touched here
aren't being used within the app right now, so there is
nothing to check in the browser.
Change-Id: Ia80da0d2b7f1e297abc603f363f0a1d31e68aee4
Reviewed-on: https://gerrit.instructure.com/122644
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
closes CNVS-38354
test plan:
- hit the CommMessages api
- it should return `from` and `from_name`
Change-Id: Ie06a09e778a3f0098a1ae80cd5bfc237014715bb
Reviewed-on: https://gerrit.instructure.com/120316
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
The column doesn't exist in vanilla canvas
Change-Id: I8566959a17fcfcadfa263f4e10ad333da3ddb964
Reviewed-on: https://gerrit.instructure.com/121053
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
closes CNVS-38163
test plan:
- run Setting.set('content_migrations_expire_after_days', '1')
- create some content imports if you don't already have any
- ContentMigration.where(id: ContentMigration.last.id).
update_all(created_at: 2.days.ago)
- visit the course content import page
- it should show as unavailable
Change-Id: I0491a1f1e292c0d9ded2ca202bd2cd997839a4bf
Reviewed-on: https://gerrit.instructure.com/118714
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
update the ims-lti gem with the new re-registration service name
remove the OAUTH2 algorithim for the security profile
support OAuth2 for re-registration
fixes PLAT-2721, PLAT-2722
test plan:
LTI2 launches should still work
re-registration should work with OAUTH2 now
the tool consumer profile shouldn't have an algoritim specified for
the OAUTH2 WS security profile
Change-Id: I00d3600da3296ab24d361c31b0599b93f96e715c
Reviewed-on: https://gerrit.instructure.com/118978
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
test plan:
* create a course
* change the setting to allow a "Join this course" link
and "include this course in the public course index"
* change the account settings to set "allow self-enrollment"
to "never"
* the "join this course" link should not be shown on
the course home page
close #CNVS-38524
Change-Id: I6f935efe63c39f56e51daccfbd045d058fe20862
Reviewed-on: https://gerrit.instructure.com/122291
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
there is a measurable cost associated to this step of api content
transformation, so only run it on types of url attributes that might
actually need to be rewritten (ignore mathml href's)
fixes CNVS-38442
test plan:
- create a submission with a lot of <p> tags
- request it from the API
- performance should be better
- now create a link/image to something root-relative in canvas
- request it from the api
- it should come back as absolute
Change-Id: I21fc42db25e84e70a0d19db7dc271cfd46801ecb
Reviewed-on: https://gerrit.instructure.com/122400
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan:
* in a blueprint course create an assignment, discussion and
a quiz all with a link to a file in their description
* lock content for all of them
* sync to a child course
* in the child course, should be able to edit dates without
getting an error
close #CNVS-38520
Change-Id: I0eb7331094871d8e2698ee1357fa2c0c16f3bd46
Reviewed-on: https://gerrit.instructure.com/122384
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-38643
test plan:
- as an admin navigate to an account and select "themes" from the
sub-nav (choose any of the default themes)
- within the themes preview pane on the right hand side there view
the "secondary" button example... when in normal contrast the
background and text color should be using brand variables...
now exit theme editor and as the same user turn on HC and
navigate back into the theme editor (you will get a warning
that you cannot preview... no worries) within the preview
pane inspect the same "secondary" button and it should now
be using hex colors for the background and text color
example: https://screencast.com/t/5NtBwIOgWr
Change-Id: I85cfd8e629e5be5d3759e506a93013c49f7678ed
Reviewed-on: https://gerrit.instructure.com/122522
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Fixes: CNVS-38646
test plan:
- as an admin navigate to the account theme editor
- select *any* of the default themes
- within the preview pane of theme editor - scroll down to
"switch-style checkbox"
- the focus state has been updated - example of new look:
https://screencast.com/t/IM2oRSLdEpO
Change-Id: Ifaa47fa3b5dae931b4587b654853a4f6e0347bfc
Reviewed-on: https://gerrit.instructure.com/122498
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Fixes: CNVS-38645
test plan:
- as an admin navigate to the account theme editor
- select *any* of the default themes
- select the "watermakr and other images" section
- the watermark opacity slider uses the "range-input"
styles... move the slide back and forth to see the
updated focus & active styles
example of new styles: https://screencast.com/t/tlnqb5eN
Change-Id: I58bcba9d1c62f79697a8b6c8323df681e7e893f6
Reviewed-on: https://gerrit.instructure.com/122493
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Fixes: CNVS-38371
Test plan:
- As a teacher/admin, create a course assignment or
discussion that has peer reviews
- As a student in that same course, complete the
assignment
- As a teacher/admin, go to the assignment, then click
`Peer Reviews` in the right sidebar
- Assign a second student to peer review the assignment
completed by the first student
- Reload the page, then hover over the incomplete peer
review under the second student's name
- Confirm there is a bell/alert button now showing to
remind the student he/she needs to complete the
peer review:
https://cl.ly/2P033s2w3L2O
Change-Id: I123be5c4bd9001e89a53c24a2924d5e2adbb0920
Reviewed-on: https://gerrit.instructure.com/122016
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Fixes: CNVS-38644
Test plan:
- Code reviewer: confirm Canvas CSS and assets compile
ok.
- All reviewers:
- Confirm that in normal contrast, the newer Canvas
CSS form inputs have the following :focus state
(see /styleguide):
https://cl.ly/3B3j1I3M1I1H
- Confirm that in HIGH contrast, the newer Canvas
CSS form inputs have the following :focus state
(see /styleguide):
https://cl.ly/0a473P412824
Change-Id: Iaa791c20f71fa4ce2f7b8ffdcd4eac3665f71768
Reviewed-on: https://gerrit.instructure.com/122495
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
test plan:
* create a question bank in a blueprint course
with a multiple choice question
* create a quiz with a quiz group linked to
the question bank
* lock the quiz
* sync to an associated course
* should be able to preview and take the quiz
and have answers scored
closes #CNVS-38629
Change-Id: Iab770823411ad68dcf293ba2dc53c08bdce729f0
Reviewed-on: https://gerrit.instructure.com/122571
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
David Mirabile