Reformat and delint speed_grader_select_menu.js to make later patchsets easier to
code review. Reformat speed_grader.
refs GRADE-176
test plan:
- Smoke test functionality around student menu of SpeedGrader and
SpeedGrader as a whole
Change-Id: Ia3f08d577a6525d9bf574e8ecdc34aa4d40284c4
Reviewed-on: https://gerrit.instructure.com/123717
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes CNVS-38030
test plan:
* set up an assignment to use turnitin (old way?)
* actually submit something to the assignment, and have jobs running
(to ensure the assignment's turnitin id gets generated)
* duplicate the assignment
* it should not error
Change-Id: I4737b09d743371e080e1429f28f3e8245d3f4c09
Reviewed-on: https://gerrit.instructure.com/123164
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
avoids a less-than-ideal query plan on large dbs
Change-Id: Ifef15fd1232323d42abb42b5f4f67114c52a8bd8
Reviewed-on: https://gerrit.instructure.com/123835
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
so we don't constantly refetch the same data when running
progressions
test plan:
* module progressions with assignment overrides
should work as before
closes #CNVS-38735
Change-Id: If85cb5f6d736eaebdcd84a5e16fcf1b243ec42aa
Reviewed-on: https://gerrit.instructure.com/123268
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes FALCOR-508
closes FALCOR-509
Test Plan
* Open up teacher account and make sure that
old dashboard widget shows
* Use a student account
* Have dashboard feature flag on
* Make sure the correct assignments show on dashboard
* Dismissing should work correctly on dashboard
* This shows assignments only 2 weeks prior
and 2 weeks after the current day
Change-Id: I473b764989192d8764b9324c24ad4f2933df4cd1
Reviewed-on: https://gerrit.instructure.com/122705
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Aaron Kc Hsu <ahsu@instructure.com>
add timezone locales that were lost when moving from vendoring the
library to pulling it from npm. custom locales were apparently added
to the vendored lib.
fixes CNVS-38138
test plan:
- change user locale to each of the following:
ar, da, fa, ht, hy, mi, nn, tr
- load a page
- ensure there is not a 404 when trying to load the timezone js file
Change-Id: Idff0059e3e445d1602f5d595d595af4780b34517
Reviewed-on: https://gerrit.instructure.com/123653
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
test plan:
* have a common cartridge package with an LTI tool
* set up an LTI tool on the account-level that
matches the url/settings of the course tool to be imported
* import the package into a course
* it should not create a new course-level tool but
use the account-level tool instead
closes #CNVS-38453
Change-Id: Ic54f462f120026460d07619fba3546fdc65fc516
Reviewed-on: https://gerrit.instructure.com/123525
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-38653
This will prevent compile_assets from continuing
if webpack had any warnings.
Test plan:
* Comment out `new webpack.IgnorePlugin(/\.flow$/),`
in frontend_build/baseWebpackConfig.js
* run webpack
* it should return a non-zero exit code
Change-Id: Iecfd47bc4e83e15a288397e102716535a5a4ef0d
Reviewed-on: https://gerrit.instructure.com/122994
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: brian kirkby <bkirkby@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
refs CNVS-35911
test plan:
* go to account, course, and user settings
* Icelandic (Islenska) should sort appropriately, even though it
has an accent over the I
Change-Id: Iec8304a4575ac8c36e186f184c3db62c78ef71de
Reviewed-on: https://gerrit.instructure.com/122186
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
test plan:
* have a blueprint course and an associated course
* add an item (assignment/page/etc) to a
blueprint course
* sync it over
* delete the copy in the associated course
* make a change to the original item and resync
* it should not restore the deleted copy
* lock the original item and resync
* it should restore the copy
closes #CNVS-38776
Change-Id: I5bc34d61a804deced31439f1be380a43c90c4096
Reviewed-on: https://gerrit.instructure.com/123652
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs #CNVS-38786
Change-Id: I15b829bf4a8baef53d89d2478423557bfdc5ae53
Reviewed-on: https://gerrit.instructure.com/123649
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes PLAT-2774
test plan:
do a jwt launch to a url with spaces in the query params
check that the spaces have been encoded
Change-Id: I42dce794149d6bfbcecdc997981faf4a91b11e33
Reviewed-on: https://gerrit.instructure.com/123430
Tested-by: Jenkins
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
fixes CNVS-38343
test plan:
* do a SIS import of a user with a non-ASCII character as part of
their username
* ensure you can login and generally use Canvas as this user
* do a SIS provisioning report; make sure it works
* do people with single and double quotes in their usernames
* ensure that things generally work correctly, and are properly
escaped in reports
Change-Id: Ib1ec679dcf373c3b09ba893c69b9695b7e1475a6
Reviewed-on: https://gerrit.instructure.com/123197
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
The order of merging on gerrit ended up undoing a change in a spec.
This changes it back to what it was.
Change-Id: I5d13130c05ac8ed525abe60a67e5fc02080eac4b
Reviewed-on: https://gerrit.instructure.com/123690
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
Product-Review: Derek Bender <djbender@instructure.com>
QA-Review: Derek Bender <djbender@instructure.com>
was trying to open a dialog to force a change on the home
page type but if they don't have the rights for that we
should just publish it
test plan:
* have an account admin in a custom role
with "Change course state" permission
but not "Manage courses"
* they should be able to publish a new course
that doesn't have a module
closes #CNVS-38759
Change-Id: I5817dcd36d5a559ac67aa63a0477c5de73b7c829
Reviewed-on: https://gerrit.instructure.com/123650
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes GRADE-209
Test Plan
1. Start with a smaller window and then load gradebook history.
2. Open gradebook history.
3. Resize window to be larger.
4. Pagination should still work as expected.
5. Try any combination of window resizing, but window resizing
should no longer stop pagination from working.
Change-Id: Idfeacae3569900bb6f314fde19ad247a732dde7d
Reviewed-on: https://gerrit.instructure.com/123232
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
Reviewed-by: Brian Park <bpark@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
closes GRADE-171
There are some edge cases where if the assignment went from points
based to non-points based and vice versa, grades will not show up
with points possible or they show up as the non-points based type
with a points possible. Examples are "100" alone and "A/100".
Test Plan
1. Grade some points based assignments.
2. Grade some non-points based assignments.
3. Check the history page; the points based assignments show a points
possible that the assignment was out of. The non-points based
assignments do not show points possible.
4. Change the points possible on a points based assignment.
5. Re-grade that assignment.
6. Check the history page; the new entries from Step 5 show up with
the new points possible. The old entries from before Step 4 show
with the old points possible.
Change-Id: Id7a4e20622daf021047e378815dea2f8ed6ace9c
Reviewed-on: https://gerrit.instructure.com/122817
Reviewed-by: Brian Park <bpark@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
closes: GRADE-131
Test Plan
1. Create a course with multiple students and assignments.
2. Make sure some of the assignments are late, missing, excused.
3. Visit Gradezilla.
4. From a variety of grading cells, open the submission tray.
5. Verify that the assignment name is displayed below the
student's name.
6. If there is a grading cell to the left of the currently selected
cell, verify an arrow appears to the left of the assignment name.
7. Click the left arrow.
8. Verify the cell to the left of the selected cell is now selected
and the left arrow has focus.
9. Verify the data for the selected cell is loaded in the tray.
10. If there is a grading cell to the right of the currently selected
cell, verify an arrow appears to the right of the assignment name.
11. Click the right arrow.
12. Verify the cell to the right of the selected cell is now selected
and the right arrow has focus.
13. Verify data for the selected cell is loaded in the tray.
14. If there is not an assignment cell to the left of the selected
cell, verify the left arrow is not present and that the right
arrow now has focus.
15. If there is not an assignment cell to the right of the selected
cell, verify the right arrow is not present and that the left
arrow now has focus.
Change-Id: I6acdff62048c6547fb3ff21724ed9766206a5e68
Reviewed-on: https://gerrit.instructure.com/120071
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
Fixes: SIS-2912 and SIS-2915
Test plan:
- Enable SIS feature options
- Navigate to a course
- Confirm you can create an assignment with post_to_sis checked
- Confirm you can create an assignment without post_to_sis
checked
- Edit the assignment
- Check post_to_sis and add a due date for Everyone Else
- Confirm the assignment saves
Change-Id: I921343525713747e3a1fb7a0242ae62826c163f8
Reviewed-on: https://gerrit.instructure.com/122693
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins
QA-Review: Mark McDermott <mmcdermott@instructure.com>
sometimes people try to import packages that are almost
like normal cartridges except the files are contained
within a single root directory at the top
rather than make people unzip and rezip let's just
handle it
note: won't be able to handle tars right now
Change-Id: Ideafac212e9606e6752cbb165460875a94c475fc
Reviewed-on: https://gerrit.instructure.com/123160
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-38794
test plan
- specs should pass
Change-Id: Iff6b6933d5d2fc7d2372a5032822ed32b04b5c51
Reviewed-on: https://gerrit.instructure.com/123636
Tested-by: Jenkins
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
* reject if InstFS is disabled
* requires JWT from InstFS to access
* creates attachment from metadata given by service
closes CNVS-38590
test plan: specs
Change-Id: I0726beb1d0c368414e5dffc899ea70190c9caa10
Reviewed-on: https://gerrit.instructure.com/123349
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
refs CNVS-37748
test plan
- run an admin import
- it should have admin import count
Change-Id: Ied789fd26d7e49b267005d3b305400060580a7cd
Reviewed-on: https://gerrit.instructure.com/123599
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Reviewed-by: brian kirkby <bkirkby@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes GRADE-191
Test Plan
1. In Firefox, Chrome on both Mac and Windows and IE on Windows
a. Create a published course with one teacher and students
enrolled in at least two sections.
b. Create an assignment.
c. As a teacher access SpeedGrader
d. Click the student's name in the top right corner
e. Hover your mouse over "Showing all Sections"
f. Verify that there is no gap between the menu that
slides out to the left and the main student menu.
Change-Id: Ibb1085285b16a1f81ac093295a4931883fb60dc0
Reviewed-on: https://gerrit.instructure.com/123098
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
closes CNVS-38267
test plan
- report should run
- it should be formatted correctly
Change-Id: I9d3bed54e9bd9f06ffce28c59cfe46518c95bdc2
Reviewed-on: https://gerrit.instructure.com/119413
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes CNVS-37748
test plan
- run migrations
- it should create and delete admins through sis import
- check docs with rake doc:api
- the documentation should be correct
Change-Id: I251fd5b0af06293dcb74699fdcfe8f950f779683
Reviewed-on: https://gerrit.instructure.com/119403
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes OUT-1401
test plan:
- in a course with multiple assignments, log in as a student
- go to the assignment index page
- there should be a toggle in the top left to toggle show by
- toggling show by date and type should work as expected
- reload the page, whatever option is currently selected should
persist upon reload
- requires full a11y testing
Change-Id: I10b7bcfa04206631a207b7d05372974fbbb159b6
Reviewed-on: https://gerrit.instructure.com/122983
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Tested-by: Jenkins
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
closes CNVS-38714
test plan:
- enable the crocodoc plugin with a bogus api key
- notice that the CrocodocDocument.update_process_states runs and fails
- check the box to disable polling in the plugin
- the job should stop failing
Change-Id: I365ceeba2d83e4d2ec66ed8e977ba7798a58a960
Reviewed-on: https://gerrit.instructure.com/123017
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
name did not match usage, and all remaining usage can be satisfied in
other ways.
closes CNVS-38407
test plan: regression test message sending (immediate, delayed, and
dashboard notifications w/ stream items)
Change-Id: Ibe110527b4644cbaa417c53b2b53c2fd7e18dc9e
Reviewed-on: https://gerrit.instructure.com/120520
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Reviewed-by: Matt Smith <msmith@instructure.com>
Reviewed-by: Benjamin Christian Nelson <bcnelson@instructure.com>
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-38331
test plan:
- make sure normal quiz submission backups still work
Change-Id: I5a3a3ac20c78dffab37a669d4c383037afe21878
Reviewed-on: https://gerrit.instructure.com/120081
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
QA-Review: Tyler Burraston <tburraston@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Closes PLAT-2771
Test Plan:
- Create an originality report
- Attempt to update the originality report via
the new endpoint and verify changes are persisted:
assignments/:assignment_id/files/:file_id/originality_report
- Attempt to get an originality report via the
new endpoint:
assignments/:assignment_id/files/:file_id/originality_report
Generate docs and verify they now include the new endpoints:
http://canvas.docker/doc/api/originality_reports.html
Change-Id: Iad5543201b3d4de24d4355f5d51730613e328a42
Reviewed-on: https://gerrit.instructure.com/123253
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes: CNVS-38740
Test plan:
- Make sure one of your courses has a Term set for it
(Course > Settings)
- Make sure some of your other courses do not have
Terms set
- Your dashcards should now all be the same height,
regardless of whether or not the course has a Term.
Before: https://www.screencast.com/t/hVQADinnRQVv
After: https://www.screencast.com/t/vE06qyrzM
Change-Id: I68b36cc140349854a09ea7defcf5b321423268ce
Reviewed-on: https://gerrit.instructure.com/123435
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
fixes CNVS-38707
test plan
- user merge should work
Change-Id: I4378b075ae806e8813a9f9d1224c2a96b33d3727
Reviewed-on: https://gerrit.instructure.com/123507
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
add the option to course search to search either by "Course"
(as it was before), or "Teacher"
closes CNVS-33426
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/courses
- make sure course searching works as before
- make sure courses are searchable by teacher when that
option is selected
- make sure keyboard navigation/a11y are good
Change-Id: I9b4cf51e0fa29d6fd0d5dd6e28ac7ed90e9582f6
Reviewed-on: https://gerrit.instructure.com/121070
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-37038
test plan:
* _before_ you check out this patchset
* enable help links (`Setting.set("show_feedback_link", "true")`)
* go to account settings, and add a custom help link
* checkout this change, and run migrations
* change your language
* the default help links in both your menu and on the settings page
should be translated now; the custom one won't magically translate
itself
* remove a default help link and save
* add it again and save
* it should still be translated
* change your language again for good measure
Change-Id: Ie8d2fb504814aa227383b68ee1d8b5387e166f77
Reviewed-on: https://gerrit.instructure.com/123316
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-38728
test plan:
- load equation editor
- look in console and make sure there are no errors for MathJax loading
Change-Id: Ide62e6db8ed08b30714f44e0d9942119cc42a862
Reviewed-on: https://gerrit.instructure.com/123081
Tested-by: Jenkins
Product-Review: brian kirkby <bkirkby@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
closes GRADE-214
Test Plan:
1. Verify both "original" and New Gradebook load.
2. Start a server with NEW_GRADEBOOK_DEVELOPMENT=true and verify New
Gradebook loads.
Change-Id: I7ee58cad92d5e28eda83ae160e6ecd76a0bf7994
Reviewed-on: https://gerrit.instructure.com/123314
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Neil Gupta <ngupta@instructure.com>
refs CNVS-37582, refs CNVS-37583
Test plan:
querying for a users summaryAnalytics should return null (the real
implementation is provided by the analytics plugin)
Change-Id: I6fb746ac0ed5b1ca6192e6b814eab0bf112bef9b
Reviewed-on: https://gerrit.instructure.com/123216
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Tested-by: Jenkins
QA-Review: Collin Parrish <cparrish@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
Keith Garner