Closes: CNVS-38885
Test Plan:
Verify the lti subscription index endpoint returns
an array of subscriptions with pagination headers.
Change-Id: Ifa81263ccb9e762c5021c3c5334fa3055d6afbc9
Reviewed-on: https://gerrit.instructure.com/124184
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
test plan:
* have an account with students restricted from viewing
future courses and restricted from seeing future courses
in the enrollments list
* have a student added to an unpublished course
* they should not be able to see the course
in their "/courses" list
closes #CNVS-38833
Change-Id: If02ad835861f3d6f4ebc05731bb8a0c8c38e93db
Reviewed-on: https://gerrit.instructure.com/123968
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes GRADE-124
test plan:
* Create a differentiated assignment
* Submit the assignment from two students
* Assign grades to all but one student
* Unassign the assignment from a graded student and the ungraded
student
* Go back to gradebook
* Verify that the cell for the graded student is grayed out and not
editable
* Verify that the cell for the ungraded student is grayed out and
not editable
Change-Id: I93c9a2f4dec0888d56ba39682bc2184196f25bba
Reviewed-on: https://gerrit.instructure.com/122731
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Matt Taylor <mtaylor@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
test plan:
* the drop-down for assignment groups when creating
a graded discussion should appear normally
closes #CNVS-38774
Change-Id: I68dda521ea2695b5e0f4f7526eade15ccebe82eb
Reviewed-on: https://gerrit.instructure.com/123884
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* have a quiz in a blueprint course
* sync the quiz to an associated course
* delete a quiz question on the blueprint side
* re-syncing should delete the associated question
as well (unless the associated quiz has been
changed)
closes #CNVS-38704
Change-Id: Ib4de42f0ceb0d6d434db58bfdbc3605f63976d86
Reviewed-on: https://gerrit.instructure.com/123520
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* save a discussion topic with availability dates set
* edit it to set it to a graded topic but leave the
assignment dates blank
* the original availability dates for the topic should
not persist on the discussions index
closes #CNVS-38362
Change-Id: I28c565cb23c7fa2da3b16449ae189f44040b88c1
Reviewed-on: https://gerrit.instructure.com/123990
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-38866
test plan:
- all css vars work in ms edge 15
Change-Id: Ife2aa8f5aba8eeaeb4407f346b05681327cfa550
Reviewed-on: https://gerrit.instructure.com/124111
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes CNVS-38863
test plan
- run sis import that would delete an admin that
is running the sis import
- it should not delete the admin
- attempt to delete the user
- it should not delete the user
Change-Id: Ie5fb341b21017fea7cbf24b09a14a93ac781a1ab
Reviewed-on: https://gerrit.instructure.com/124103
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
refs CNVS-38864
Change-Id: I753621048717b27d3ce8ac15a21ba887c394f906
Reviewed-on: https://gerrit.instructure.com/124109
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-38848
test plan:
* beta flag should no longer be on the blueprint courses feature flag
Change-Id: Ib7a362fdbce67e234fe31c0031ef3657d4649420
Reviewed-on: https://gerrit.instructure.com/124038
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
fixes: CNVS-38654
otherwise the health check might happily say canvas
is all good, when no front end page will actually work
test plan:
(Do all of this in RAILS_ENV=production)
* go to /health_check; it should work
* delete public/dist/webpack-*/webpack-manifest.json
* restart your server
* go to /health_check; it should give a 500
* compile_assets again
* go to /health_check; it should work
* delete public/dist/brandable_css
* restart your server
* go to /health_check; it should give a 500
* compile_assets again
* go to /health_check; it should work
* rm public/dist/rev-manifest.json
* restart your server
* go to /health_check; it should give a 500
Change-Id: I0d4c941e71185563ad382d5f91dfce92447fbba6
Reviewed-on: https://gerrit.instructure.com/122326
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes GRADE-215
Removes the GRADEBOOK_DEVELOPMENT key from the ENV after specs that add
the key to the ENV, instead of setting its value to "false".
Change-Id: I7bb0fcc1f311725901e7ed0fa67b8cca80e5ffea
Reviewed-on: https://gerrit.instructure.com/123944
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
test plan:
* create a course with the setting
"Let students create discussion topics" enabled
(under the "more options")
* should not be able to try to create a group
discussion as a student
closes #CNVS-38705
Change-Id: I46b7bd4d59dd7df457e709bbbc9ce1d764c08792
Reviewed-on: https://gerrit.instructure.com/123729
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
This reverts commit 639e3899d2.
The above commit removed the screenreader field that's being used by
the dashcards interface. See CNVS-37921.
fixes CNVS-38600
test plan:
* make sure the actions hover text and screenreader text show and read
the proper strings.
Change-Id: If97203a21274563e8894c3593a66ae4d3960a395
Reviewed-on: https://gerrit.instructure.com/123982
Tested-by: Jenkins
Reviewed-by: Aaron Kc Hsu <ahsu@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
test plan:
* have a course with a student
* create a group set with two groups
* randomly assign students, checking the
box to require members to be in same section
* it should work
closes #CNVS-38813
Change-Id: I56a64aff1355c6d61160cd14911c0c5c4dc965a2
Reviewed-on: https://gerrit.instructure.com/123810
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-38823
test plan:
- as an admin using default canvas theme ensure the "Forgot
Password" link on the login page is white vs link blue
- next navigate to theme editor to test that switching the
"Login Link Color" is respected and sticks :D
example: https://screencast.com/t/ibeH0Uvrp
Change-Id: Iff5c4a8318cdbaa8921e06365a93758c03887d60
Reviewed-on: https://gerrit.instructure.com/123828
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
closes #CNVS-38755
Change-Id: I4c2f12d247f9b569368f4fad21581080a1025f5b
Reviewed-on: https://gerrit.instructure.com/123970
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
occasionally we have strings that come through unescaped, and we need to
handle that case better
fixes CNVS-37254
test plan:
- regression test equation editor with mathman
- create single-escaped equation images in rich content manually
- they should also render properly
Change-Id: I2037a0e048f24e149e4d75ccb2c1042ad33b3b07
Reviewed-on: https://gerrit.instructure.com/123535
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
wdransfield