refs #CNVS-21596
Change-Id: If144ea4e42fd632ef80339b450cda9c20b3fb555
Reviewed-on: https://gerrit.instructure.com/60149
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-22366
Test Plan:
1) Add a module with the "must complete all" requirements option.
2) For one of the requirements, have an assignment with a "score at least"
3) As a student, submit the assignment
4) Ensure that the yellow warning sign is now showing in the module header
Change-Id: Idf7067ae7ee9f9361abb44a1d91bb554d164b462
Reviewed-on: https://gerrit.instructure.com/60043
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Brock Cooper <bcooper@instructure.com>
fixes CNVS-22168
Test Plan:
* Create a course and multiple grading schemes
* Attempt to change the course's grading scheme via API (course[grading_standard_id]) as an account user with "Edit Grades" permission disabled
* You should receive a HTTP 401 (Unauthorized) response
* If "Edit Grades" permissions is enabled, the grading scheme should change without issue.
Change-Id: I685166062636170b69906457c0c46a74ee6d9500
Reviewed-on: https://gerrit.instructure.com/59933
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes CNVS-21391
The content export tool is being updated so that it consders the
provided user's rights, so that the CC export can be used for the new
epub generation tool.
This PS updates CC::WebResources#add_course_files to pass a user
instance to the ContentZipper instance it uses to zip up a course's
files, so that the ContentZipper can determine if the user has the
correct permissions to see the files.
Also, we update ContentZipper so that a user can be provided via
attr_writter.
test plan:
- Regression test for content export tool files functionality.
Change-Id: Ic5edecef28d60d9517ce3a67bc8aef5c5dade9cc
Reviewed-on: https://gerrit.instructure.com/59440
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
fixes CNVS-21394
The content export tool is being updated so that it consders the
provided user's rights, so that the CC export can be used for the new
epub generation tool.
This PS employs DiscussionTopic::ScopedToUser to make sure that the user
only gets the discussion topics that they have the right to view.
test plan:
- Regression test for content export tool discussion topic functionality.
Change-Id: Id67bf1ed69c4b2066ff9d81678a5d61d52702978
Reviewed-on: https://gerrit.instructure.com/59365
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
jyetukuri,panda,1
Change-Id: I2c102404ec4c712bfee834f9cfb2c94681ced07d
Reviewed-on: https://gerrit.instructure.com/60163
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Pedro Fajardo <pfajardo@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
fixes CNVS-22165
test plan:
* go to /accounts/self/authentication_providers
* create at least two ldap configs
* ensure the radio buttons work independently
per ldap configuration
* ensure radio button selections save properly
* default ldap config should check
"No TLS" by default
Change-Id: Ibb1702b0d732a91856191b054d33c389a5c0dbab
Reviewed-on: https://gerrit.instructure.com/60089
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: August Thornton <august@instructure.com>
- removes the Conferences and Collaborations tests
about Public Courses
Change-Id: Ic70e6c0b072f53d24bebe9e13468c1a2b574446d
Reviewed-on: https://gerrit.instructure.com/60151
Tested-by: Jenkins
Reviewed-by: Heath Hales <hhales@instructure.com>
Reviewed-by: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes PLAT-957
Test Plan:
- Make sure a 'message_handler_id' column is added to the 'lti_resource_placements' table after migration
- Use the master branch of https://github.com/westonkd/lti_tool_provider_example and make sure
placements work as expected in Lti2Launch
- use the 'placements_to_message' branch of https://github.com/westonkd/lti_tool_provider_example and
make sure placements work as expected in Lti2Launch
Change-Id: I2d681eb8efb2a1c25e0250a89c09bb5d0c8ad797
Reviewed-on: https://gerrit.instructure.com/58654
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
- public_courses_spec was a shared example that was only
used within itself.
- since no team clearly owns public courses, each spec was sent
to the page it was being tested in
- creates a shared_context for public courses instead
- the tests for collaborations and conferences were not
given an id since these are testing broken behavior
(these might have to be completely removed in
the future)
Change-Id: Ibd6464e229402ba2aaa005a33c7f82badf007b1a
Reviewed-on: https://gerrit.instructure.com/60123
Tested-by: Jenkins
Reviewed-by: Ben Bolton <bbolton@instructure.com>
QA-Review: Ben Bolton <bbolton@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
test plan:
* as a test student, start a quiz
* reset the test student
* should not receive an error
closes #CNVS-22303
Change-Id: I8389a35349f3505614b8c08b4c57dc7d9ea89dd5
Reviewed-on: https://gerrit.instructure.com/59909
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* create a course with self-enrollment enabled
* in a new browser session visit the self-enrollment link
* errors during logging in (e.g. incorrect username/password)
should be shown
closes #CNVS-22332
Change-Id: Id4aba305fefe2a2929223bbf3e6899b49aac3b44
Reviewed-on: https://gerrit.instructure.com/59907
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-22122
- Suppress scrolling on the body and instead have
the Preview iframe and the Theme Editor sidebar
scroll independently
- Refactor flex layout so we don't need to use
fixed positioning and no longer have hidden
inputs as part of the flexed layout
- Some small, nitpicky CSS updates
Test plan:
- Make sure the Use New Styles feature flag is ON
- Go to the Theme Editor from your admin account
- Clear your browser cache
- The Theme editor preview and sidebar should now
each have their own scrollbars:
http://cl.ly/image/021P2X1v3t1T
- Theme editor should look and work exactly the
same as before
Change-Id: I8e56cae95c5a2898cc05fc61281be8a3c9724bd6
Reviewed-on: https://gerrit.instructure.com/59147
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-19924
When a teacher uploads a CSV with assignments in past
grading periods then they are not able to change grades.
Test plan
1. As an admin, create an account level grading period in
the past.
2. Create assignments due during the past grading period.
3. Login as a teacher.
4. Navigate to the gradebook
5. Click export to download a CSV
6. Change the grade for the assignment in the past grading
period.
7. Click the export button and use the wizard to upload
your modified CSV.
8. You should receive a message telling you you are not
allowed to edit the assignment in the past.
Change-Id: Ia8701c3504b03bd6ed35d0da1fe56cd8330ace79
Reviewed-on: https://gerrit.instructure.com/55297
Reviewed-by: Dylan Ross <dross@instructure.com>
Tested-by: Jenkins
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
Fixes PLAT-1184
Test Plan
- Install the test tool at the account level with the account navigation and course navigation placements
- Once installed edit the app and add the custom field 'role_test=$Canvas.membership.roles'
- launch the app from the account navigation and make sure the variable was expanded
- launch the app from the course navigation and make sure the variable was expanded
Change-Id: I840c537de5ec1fa8fc1f1f94d2b8beef1aed2abb
Reviewed-on: https://gerrit.instructure.com/59859
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes CNVS-22351
Test Plan:
1. Create a module
2. Edit the module and lock until a date
3. login as student and hover over the lock
4. Ensure screenreader reads out the Unlock at certain date message
Change-Id: I684700f7ffe29a684fbdccf05483f31c525c2f45
Reviewed-on: https://gerrit.instructure.com/60019
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes: CNVS-22258
test plan:
* open theme editor and open the "watermarks and
other images section. you should not see any
404's in the browser console and you should
see a default for each except for the 'watermark'
* in IE, make sure you don't see a "broken link"
image for the watermark
Change-Id: Iea743e8efc5115e2f4dfae6b8d12f26d4f3f346f
Reviewed-on: https://gerrit.instructure.com/59793
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
For the Canvas Data product, we have an LTI app that we use to give customers access
to a flat file download or manage credentials for accessing a Redshift
database.
Since this is basically a huge amount of access, we want to be double
extra sure that we are properly linking up accounts with the canvas data
portal and only giving authorized users access.
For the LTI app, we are currently using per account oauth keys/secrets
and user whitelisting to ensure that only authorized users can access
the data. However, we currently have a gap where if a shard_id (which we
need for driving the ETL process) is not entered correctly, we would
process data for the wrong customer. With the shard_id being passed
by the LTI app, we can at least ensure that this data can't be accessed
by not allowing authentication if we are passed a shard_id we don't
expect.
This commit adds an expansion for the globalized account_id (which we
may use later) and the shard_id.
Test Plan:
- Create an LTI app that expands $Canvas.root_account.global_id and $Canvas.shard
- Ensure that the globalized root_account_id and shard_id are passed
Change-Id: I5315320c4920e258032a08f424b9a83a6f7a8744
Reviewed-on: https://gerrit.instructure.com/59895
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Addison Higham <ahigham@instructure.com>
fixed skipped tests
moved repeated code into nested contexts
Added MGP specs
there is a lot of repeated code in the inheritance tests, since
we are testing 3 roles on 3 pages
the way this works will change soon (MGP version 3), so it makes
more sense to wait for these
changes before refactoring these tests
Change-Id: I4ef36370e8b8987136617d56aa5adafe601cc995
Reviewed-on: https://gerrit.instructure.com/59767
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
test plan:
- as a parent observer in an account with self-registration
for observers enabled, you should be able to add an
observee who is using a login id that formerly belonged
to a deleted user
fixes CNVS-22146
Change-Id: Ib2eea55bdc3e41e1badd4e65c221a514481c40c3
Reviewed-on: https://gerrit.instructure.com/59885
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Change-Id: Ie88b2239a3d95d0dfd36608f6744a89de5cbf7a9
Reviewed-on: https://gerrit.instructure.com/60082
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Adrian Foong <afoong@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
accessibility compliance
fixes CNVS-22042
fixes CNVS-22044
fixes CNVS-22045
fixes CNVS-22041
test plan:
- check the following pages for any visual or accessibility regressions:
Assignment show page (teacher view)
Discussion Topic edit page (for both discussions and announcements)
Quiz show page
Change-Id: I51a915994fb3a047e0b6a461870de9d24ba9fd33
Reviewed-on: https://gerrit.instructure.com/58973
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
- Allows multiple preferences to be updated by category
- Fetch the categories that exist in the notification preferences
fixes CNVS-21902
Change-Id: I96f005dc981079ee0797beec75cdecde4d05e96c
Reviewed-on: https://gerrit.instructure.com/57829
Tested-by: Jenkins
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
sshepherd,panda,1
Test Plan:
- Run Specs
Change-Id: I15ac9c39dc15930e872cd399238d5117dba69bda
Reviewed-on: https://gerrit.instructure.com/60039
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes CNVS-20332
test plan:
- make quiz with an access code
- as a student, POST an api request to /api/v1/courses/:id/quizzes/:id/verify_access_code
with the correct access code in the access_code parameter
> the request should return 'true'
- send a request with the wrong access code
> the request should return 'false'
Change-Id: I910da2a715d121412fee62b9707de3986b1c762c
Reviewed-on: https://gerrit.instructure.com/55662
Reviewed-by: Brian Finney <bfinney@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Brian Finney <bfinney@instructure.com>
sshepherd,panda,0
(I accidentally added an extra one last spec, so this makes things right)
Test Plan:
- Run specs
Change-Id: Iba404e25a9d44dd870632fa0ab1e51361f3b26b3
Reviewed-on: https://gerrit.instructure.com/60017
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Transifreq