fixes the calendar modal being cut off when the browser
window is really small.
fixes CNVS-21755
test plan:
- From within the calendar create a new calendar event via the "+" icon
- Under the edit event field select the "more options" button
- Give the event a title and under the content editor add 20 lines (can be single character, just hit 'enter' after each one)
- Select "Update Event"
- Click the newly created event.
- Note that the top of popover (and the 'X' to close it) is positioned onscreen
- Enlarge and shrink the window notice x and title stay on screen
Change-Id: I37700ac74742ecd3ad27692a6e5393c21f7bf83a
Reviewed-on: https://gerrit.instructure.com/60328
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
- reason: the tests have been skipped for a very long
time due to waiting for an undefined refactor
Change-Id: I192689fe56063cd87d1cd7e68fe94b1d74c578c2
Reviewed-on: https://gerrit.instructure.com/60936
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
fixes PLAT-1174
Test Plan
~ make sure resource_handler_id from the lti_resource_placements table
~ make sure installing a tool via lti tool registration URL works correctly as
well as any other task that uses the Lti::ResourcePlacement model.
Change-Id: I058ae01cb43366342754e3fa9cdabf1c408cce0e
Reviewed-on: https://gerrit.instructure.com/60494
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
fixes CNVS-22216
test plan:
- with k12 feature flag off
- go to theme editor
- it doesnt show k12 brand config
- turn flag on
- go back to theme editor
- it does show k12 brand conifg
- turn flag off and check that it goes away
(note: it may take a little bit for the
change to kick in)
Change-Id: Ic4ab4557d5330426128d26890d739ee6feb98a7b
Reviewed-on: https://gerrit.instructure.com/60783
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
fixes CNVS-21898
test plan
- canvas should load with armenian
- date pickers should work
Change-Id: I45ad840fdbe711cb82337bd91ba4009496b19ff1
Reviewed-on: https://gerrit.instructure.com/60960
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
twilson, panda, 5
- refactor to support mobile SpeedGrader and mobile
Canvas apps for both Android and iOS
- landing_page_common moved to shared context to be
used with SpeedGrader and mobile Canvas
- to test: comment/uncomment appium init and skip
statements in mobile_common, spin up Appium server,
and run specs
Change-Id: I4862f69874549e972488f44b65c5aeac6b47bf4a
Reviewed-on: https://gerrit.instructure.com/60538
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Jahnavi Yetukuri <jyetukuri@instructure.com>
Tested-by: Jenkins
Product-Review: Ben Bolton <bbolton@instructure.com>
QA-Review: Ben Bolton <bbolton@instructure.com>
test plan:
- enable new styles in the root account
- on a course files page, when the window is shrunk to where
the course nav doesn't fit, a hamburger menu should appear
to toggle it
- on a user files page, the hamburger menu should not be there
(because there is no course nav to toggle; currently it is
toggling an empty space)
fixes CNVS-21105
Change-Id: I229e308ead615f6790002aee3d17de436655f727
Reviewed-on: https://gerrit.instructure.com/60803
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes: CNVS-22217
Test Plan:
- In the NUI, open Theme Editor
- Make some change, and click preview in
the center of the screen
- The progress bar should now fit exactly
inside its container.
- instead of this
http://screencast.com/t/gqzsUkHGn
you should see this
http://www.screencast.com/t/DoalArPiaCjj
Change-Id: I8a1ca6011cffe66e9e870ef82ca3ae5d277f9fca
Reviewed-on: https://gerrit.instructure.com/60646
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
fixes CNVS-21535
For now this can just be a plain feature flag because feature
flags implement the "cascading state" functionality we want for
this setting. We can change the UI on this or convert it to a
new type of setting later if we think that's important enough.
test plan:
- Anonymous grading feature flag exists as a feature currently
under development (only visible to site admins until it is
turned on). Nothing else should be affected by this
flag's setting yet.
Change-Id: I5136265cd46af47ea48482b2ab5015112e079557
Reviewed-on: https://gerrit.instructure.com/60871
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes CNVS-21581, CNVS-21582
test-plan:
- regression around all datepicker elements
- for each, when it loads with prepopulated data, that data should be
localized
- the prepopulated localized data should be valid to the datepicker
Change-Id: I633034967c70066e337dc22d9b9ad0cd84793834
Reviewed-on: https://gerrit.instructure.com/60229
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Product-Review: Mike Nomitch <mnomitch@instructure.com>
- reason: this spec does not contain any example blocks.
its methods are not used anywhere
Change-Id: Ia285e2a00cc230b0abc2efce5387bf739ac67f3e
Reviewed-on: https://gerrit.instructure.com/60926
Reviewed-by: Adrian Foong <afoong@instructure.com>
Tested-by: Jenkins
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes CNVS-22516
test plan:
* explicitly link a login to a SAML provider
* view the users page for the user
* it should not error
Change-Id: I6a2b746f19963b2d9aa20808244a96353102b827
Reviewed-on: https://gerrit.instructure.com/60900
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
it can't preload until _after_ it knows what the notification_id is
Change-Id: Ice9aef3e1788549a8f0c2d488afe2a0429a6db96
Reviewed-on: https://gerrit.instructure.com/60792
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
should not be able to interfere with assessments that
belong to submissions or assignments
closes #CNVS-22007
Change-Id: I9aee919ba3c3b7568127927b1da5d898e94bbbb2
Reviewed-on: https://gerrit.instructure.com/60832
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Change-Id: Iae8b08b6b4b227cf7261b8d1d7a4f5fde0e0b8e9
Reviewed-on: https://gerrit.instructure.com/60894
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-22451
Test Plan:
1) Navigate to modules as a teacher
2) Add a modules and an assignment to modules
3) Make assignment a requirement for the module
4) ensure that the pill message does not show
Change-Id: Ic892c6e976b616475db65cb9d3dbf607ee76ce3e
Reviewed-on: https://gerrit.instructure.com/60683
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
test plan:
1. Create and publish an assignment that accepts a submission
and enables Moderated Grading
2. As a student, submit the assignment
3. As a teacher, edit the assignment and note that the
Moderated Grading setting should still be changeable
4. Use the console to create a provisional grade:
Assignment.find(assignment_id).submissions.last.find_or_create_provisional_grade! scorer: User.find(teacher_id), position: 1, score: 0
(where assignment_id is set to the id of the assignment created
in step 1, and teacher_id is the teacher's user id)
5. Refresh the edit-assignment page, and the "moderated grading"
checkbox should be disabled with a tooltip indicating the setting
can't be changed
fixes CNVS-22208
Change-Id: Iab5fa94508b199d40c2db486a13988665505ab2f
Reviewed-on: https://gerrit.instructure.com/60533
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
- specs should pass
- a quick regression test on comments on submissions in SpeedGrader
would probably be a good idea
fixes CNVS-22008
Change-Id: I26e9dc5bd2e3dd1a074b5625613a3b32744b6b50
Reviewed-on: https://gerrit.instructure.com/60196
Reviewed-by: Derek Bender <dbender@instructure.com>
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
* add an lti tool configured for course_settings_sub_navigation
* add a teacher to a course with a term that restricts teacher
edit access past a date in the past
* should still be able to see the lti tool
closes #CNVS-22488
Change-Id: I332da191ec08e859001e68f7813d52e00028487b
Reviewed-on: https://gerrit.instructure.com/60787
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Instructors were getting a cached copy of the modules page, but
a new copy of context_modules.js. The new version of context_modules
requires an id to be present as an element on the page. The cached
copies of this page does not include an id attribute.
The problem resolves itself anytime the cache is busted by modifying
other aspects of the module. This forces the cache to bust for
everyone so they get a new copy of the page.
fixes CNVS-22413
Test Plan:
- Load up an old course (you need to have an old cached copy of the page)
- You should be able to add an item to a module without problems.
Change-Id: I217e63b1587577db65120d51dfd777c705acddbc
Reviewed-on: https://gerrit.instructure.com/60779
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
adds a notification_category column in order to move all
the calculation of stream item counts to the db instead
of loading all the instances and items
test plan:
* regression test activity stream summary api endpoint
closes #CNVS-22424
Change-Id: Ia0abf9d89e02d53800bcd5d62fdf1a36131bd6f8
Reviewed-on: https://gerrit.instructure.com/60578
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs #CNVS-21317
Change-Id: I60016fd04109605d4324d5b184d5c0f7afa2515e
Reviewed-on: https://gerrit.instructure.com/60583
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
the course proxy caches values that would otherwise be
re-calculated over and over again
refs #CNVS-21317
Change-Id: Iae0edc43b896b1029e869cf8c759aea7d7bcfd62
Reviewed-on: https://gerrit.instructure.com/60580
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes: CNVS-22491
we used to have a bunch of things in js where look
for hidden elements in #identity to get user_ids
and context_ids. that is a bad idea and has been
deprecated in favor of using window.ENV.
I just did a check and these were the last 2
that I could find.
test plan:
* in the new UI...
* as a student, go to the modules page
* you should see a green checkmark next to the
modules you've completed
Change-Id: Ic10b903220b93e35b314e274a69872482c52cc64
Reviewed-on: https://gerrit.instructure.com/59863
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
sshepherd,panda,6
Also fixes some minor errors in comments in older specs
Change-Id: Ief0e30f1c9115d9c7afeb85e1d774ce6215f59f1
Reviewed-on: https://gerrit.instructure.com/60672
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
A tag makes it filterable, vs extra data which is just displayed on the samples
screen.
Change-Id: I9d01491c59a5ede9ffa12269d5a035a0e2d80793
Reviewed-on: https://gerrit.instructure.com/60488
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
closes: CNVS-22368
When a student only has enrollments in unpublished
courses, they do not see a courses global nav link.
The link is needed to get to "all courses" and see
their enrollments.
this changes things so the "courses" menu is always
shown. that way those users will be able to get
to that "all courses" link
Product / UX/UI review question:
This is just one possible way of fixing this problem.
the other thing we could do is to leave it how it was
but do a second, more expensive DB query to see if
there are any of those unpublished or archived courses that
I can see on the /courses page but not in the course
menu. in standup, we agreed to do it like this but
if any of you feel strongly that we should do it
the other way, that's fine too.
test plan:
Add a new user
Enroll them in an unpublished course
Masquerade as the new user,
click the courses global nav option
you should see the "all courses" link in the tray popup
Change-Id: I140dbc4f4d2852c386cc57cac3f2afec6ef62979
Reviewed-on: https://gerrit.instructure.com/60233
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Steven Burnett