twilson, panda, 7
- added shared examples for iCanvas and SpeedGrader for
login view and credentials
- to test: comment/uncomment appium init and skip statements in
mobile_common, spin up Appium server, create and edit yml file,
and run specs
Change-Id: Ie32900026028ea36568343b85b275c4e00d33fa3
Reviewed-on: https://gerrit.instructure.com/61224
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure all test_ids match up to an existing test case in TestRails
mhargiss,panda,11
Change-Id: I347834d5be266aa8b422c1623f676fc374ebf7dc
Reviewed-on: https://gerrit.instructure.com/59274
Tested-by: Jenkins
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Reviewed-by: Taylor Wilson <twilson@instructure.com>
otherwise it will ovewrite logger.level with the default
(:info on production)
refs #CNVS-21596
Change-Id: I18352300b769d141de7a83959568e627f6a519b4
Reviewed-on: https://gerrit.instructure.com/61257
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
avoid even going to redis for two common cases that are likely
already cached in-process, or for repeated calls to the same
method
Change-Id: Ia90dbe25d83ab69ba62f26c966884a041ff61f3d
Reviewed-on: https://gerrit.instructure.com/61093
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
* query the sis assignments api for an account/course
* /api/sis/accounts/:account_id/assignments
* /api/sis/courses/:course_id/assignments
* the description field should not be returned for any assignment
fixes CNVS-22513
Change-Id: I2d679a3b7eedf4f4892ef5e7d1b93007e7500c7a
Reviewed-on: https://gerrit.instructure.com/60861
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Mark Severson <markse@instructure.com>
fixes CNVS-22506
test plan
- regression test google doc collaborations
Change-Id: I696562d74e317b465b1679513fa7f5ff913a1c99
Reviewed-on: https://gerrit.instructure.com/60923
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
We now pull the account from the developer key
Fixes PLAT-1200
Test Plan:
Run the tests?
not much really changed
none of is really exposed/used
Change-Id: I88b3b9b907ae7b15145ac8e2e6fc1a18527b40d5
Reviewed-on: https://gerrit.instructure.com/60544
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
don't stuff them in the fake js_env and join the data there
just return them with the rest of the speedgrader data
also don't do unnecessary permissions checks on every rubric
assessment
test plan:
* regression test speedgrader rubric assessments
closes #CNVS-22522
Change-Id: I31a025c8f23b054857823f411a229780c27cb94f
Reviewed-on: https://gerrit.instructure.com/60963
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
loading AccountServies.allowable_services shouldn't calculate
"expose_to_ui" when unnecessary
Change-Id: I86c6bebb88c372932283b063054a5f9e5fb947e1
Reviewed-on: https://gerrit.instructure.com/61186
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
sshepherd,panda,9
Test Plan:
- Run specs
Change-Id: I34630c52b3fcd8b3076b2c1ea6ed52bcfd24021a
Reviewed-on: https://gerrit.instructure.com/61231
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Slight structural change to post grades button to make style more
uniform. Test plan from original ticket where button was added is
pasted below for ease of testing. Verify that change works for old and
new canvas styles.
Test Plan:
* configure powerschool grade posting by enabling sis feature flag
* /accounts/:id/settings
* "post grades to sis" -> on
* /courses/:id/settings
* SIS ID -> random number
* add an assignment, make sure that "post grades to sis" is checked
* navigate to gradebook, verify that "post grades" button is visible
* verify that "post grades" button is not visible when no assignments
are present
* click on button and verify that current powerschool modal launches
* add sisapp lti launch
* get local sisapp running
* /accounts/1/settings/configurations
* add app, by url http://<local sisapp>/post_grades/config.xml
* navigate to gradebook, verify that both powerschool post and new
lti post are available in drop down menu
closes CNVS-22119
Change-Id: Id57bed25774e4bff2208eb8a7ec1f318a276f1c5
Reviewed-on: https://gerrit.instructure.com/60378
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
twilson, panda, 4
- added shared examples for iCanvas and SpeedGrader landing page
- minor changes to appium environment setup, school_domain now
defined in selenium.yml file
- to test: comment/uncomment appium init and skip statements in
mobile_common, spin up Appium server, create and edit yml file,
and run specs
Change-Id: Ica180895f167e007cab14cadfe79e554a44f25da
Reviewed-on: https://gerrit.instructure.com/61118
Reviewed-by: Heath Hales <hhales@instructure.com>
Reviewed-by: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins
Product-Review: Ben Bolton <bbolton@instructure.com>
QA-Review: Ben Bolton <bbolton@instructure.com>
When using SpeedGrader on an external URL page, the teacher is
presented with the URL as a link that opens in the frame and a second
instance of the link with the text "(View in a new tab.)" Because of
this, teachers have the option to choose to view inline or in a
seperate tab.
fixes CNVS-22370
test plan:
- In a published course with students...
- Add a URL submission assignment and publish it.
- As a student submit http://placekitten.com as the assignment
submission.
- As a teacher view the submission in speedgrader, and click the
submission links in the left frame.
- Confirm that the URL link opens in the iFrame and the "View in a new
tab" link opens in a new tab or window.
Change-Id: I4991db9cd12101f0cfdd719aed3e77acf0ce7a61
Reviewed-on: https://gerrit.instructure.com/60517
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
Entering any invalid character—e.g. &, }}, {{+, or space—as an initial
grade in either the Gradebook or SpeedGrader causes the grade to be
set to null and the workflow_state to remain in unsubmitted. Because
of this, results in SpeedGrader do not show the student as needing to
be graded.
fixes CNVS-20823
test plan:
- Create a course with multiple students and an assignment of any type.
- Enter any non-grade in either Gradebook or SpeedGrader (characters
like &, ?, +, etc…), and press 'Enter'
- Note that the character is removed as the field updates
- View the submission in SpeedGrader and note that the student shows
as unsubmitted by the lack of orange dot nor green checkmark next to
their name
Change-Id: Idae8c025739fdb051ca7c8089f3cc25fe1424690
Reviewed-on: https://gerrit.instructure.com/60851
Tested-by: Jenkins
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
The File Attachment and Media Comment buttons in the teacher comment
attachment area in the SpeedGrader Add a Comment area now navigates
and reads properly in screenreaders. As a result, navigation and
intention is now communicated clearer to users with accessibility
needs.
fixes CNVS-13135
test plan:
- Create a text entry assignment and have a student submit something
to be graded
- As a teacher, go into speedgrader for that assignment
- With a screenreader activated, select the Add a Comment text area
and navigate using tab over the following buttons: Submit Comment,
File Attachment, Media Comment
- Observe that after the Submit Comment button, the File Attachment and the
Media Comment buttons are read as "File Attachment Button" and "Media Comment
Button"
Change-Id: I05e45ada0f083e7bf1ae20433065909f55be133c
Reviewed-on: https://gerrit.instructure.com/60298
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
refs #CNVS-21317
Change-Id: Id9bbb04a92abd835af69ba5ec0c21ef758a8a324
Reviewed-on: https://gerrit.instructure.com/61146
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
hhales,panda,1
Change-Id: I5dae7af8288cba7a30f3f32e8b8f75bf9f66b41e
Reviewed-on: https://gerrit.instructure.com/61100
Tested-by: Jenkins
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes CNVS-22555
test plan
- db:migrate should work
Change-Id: I6259abacf508195cbaca04e06bfed7ec202f5c8b
Reviewed-on: https://gerrit.instructure.com/61133
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Had to split up the n mastery and decaying average int
validation into two functions. There was an issue with
two error boxes being present on the page.
Above range and below range now each have their own tests.
Change-Id: I99954c3c75c2131eb31f3e40ca7c0589dbda761e
Reviewed-on: https://gerrit.instructure.com/61117
Reviewed-by: Matt Fairbourn <mfairbourn@instructure.com>
Tested-by: Jenkins
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
refs CNVS-22335
Test Plan:
- Search for a file that doesn't exist in files
- A message should appear saying that no results were found
Change-Id: Iba07fc829e612205417921f4618f29a9141d01dd
Reviewed-on: https://gerrit.instructure.com/61022
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
sshepherd,panda,6
Test Plan:
- Run specs
Change-Id: I6c62dc36b912edfcaf14bfeec59edcb5b6896627
Reviewed-on: https://gerrit.instructure.com/61112
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
added these files included by timezone_core recently; apparently they
need to be whitelisted
Change-Id: I529975dc7da25a9e2cb5c3a9d095796e30d0f6c7
test-plan: `grunt test` works for canvas_quizzes
Reviewed-on: https://gerrit.instructure.com/61094
Reviewed-by: Kacey Roberts <kroberts@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Tested-by: Jenkins
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
test plan: N/A
Change-Id: I6b21021bc61cebc9d80990ee14b5c69cdc75164b
Reviewed-on: https://gerrit.instructure.com/59792
Tested-by: Jenkins
Reviewed-by: Christina Wuest <cwuest@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
test plan: N/A
Change-Id: I6baddd64b542fc4fb8c8388a718b9456db01e0a6
Reviewed-on: https://gerrit.instructure.com/59785
Tested-by: Jenkins
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
this avoids repetive queries for site admin
Change-Id: I6c7ac3c49f47385167007b92b8e589257250c41f
Reviewed-on: https://gerrit.instructure.com/61016
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
also get rid of the :nil nonsense in caching - it's not needed in Rails 3
Change-Id: Ie2879f91e59898981ad2566a63a6b99350313165
Reviewed-on: https://gerrit.instructure.com/61017
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
that was only needed in rails 2
Change-Id: I1e2a00f65237d45ac82daa19eaecf5c589171718
Reviewed-on: https://gerrit.instructure.com/61025
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
apparently they are the exception to the asset_type
is class name rule
test plan:
* create an announcement
* it should count as a separate type of stream item in the
activity stream summary
refs #CNVS-22424
Change-Id: I4eefaab180e1dc8f441c9b23d0a2a237dac627c9
Reviewed-on: https://gerrit.instructure.com/61001
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-22536
Test Plan:
- New UI only
- When you open the "Admin" nav panel by clicking
the Admin link in the primary navigation, you
should now see an All Accounts link at the bottom
of the list of accounts
- Clicking on this link should take you to the Canvas
page where you can view all the accounts/subaccounts
you manage.
Change-Id: Ieeb38674f3c593c40105f79069bfef01673e3965
Reviewed-on: https://gerrit.instructure.com/61007
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Tested-by: Jenkins
fixes CNVS-21569
Test plan:
1. Log into a course
2. Navigate to course settings (in the left column)
3. Select the Course Details tab
4. Scroll down to the Grading Scheme section and select set
grading scheme.
5. Confirm the grading schemes and the done button are
fully visible.
Change-Id: I72aa23056a4875f7d5a1aa1123d6f7315352f01d
Reviewed-on: https://gerrit.instructure.com/60461
Tested-by: Jenkins
Reviewed-by: Derek Bender <dbender@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Christi Wruck
fixes CNVS-22312
Test plan
* Uploading images form fields should make sense and be navigable in screen readers
* Uploading JS/CSS files should make sense and be navigable in screen readers
* The 'Select Image' button should have a focus state when navigated to via keyboard
Changes
* Added an alt attribute to preview images
* Added a heading element for image names
* Added aria-hidden attribute to duplicate labels for image upload inputs
* Changed accessible label for image upload inputs to include the name of the image
* Removed duplicate label text (for screen readers) for JS/CSS upload inputs
* Added accessible button label for Reset button for JS/CSS uploads
* Added aria-hidden attributes to icons for JS/CSS uploads
* Added focus state for 'Select Image' "button"
Change-Id: I0763aaf26315660a9f2eb6f29d616abfec60f3a8
Reviewed-on: https://gerrit.instructure.com/60390
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Cody Cutrer