closes CNVS-37584
Test plan:
- student context cards should work as usual with graphql turned off
- when graphql is on, student context cards should behave
identically, but should hit the /api/graphql endpoint instead of
the REST api
Change-Id: I723ac48a7c7f58c4b6065b92ec37c9985498c9d3
Reviewed-on: https://gerrit.instructure.com/122427
Tested-by: Jenkins
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
QA-Review: Collin Parrish <cparrish@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
Closes: CNVS-39133
Test Plan:
- Pay special attention to instui Modals and Popovers
- Also DatePickers/DateInputs
- Test an InstUI component in Canvas high contrast mode
and ensure that it shows correctly
Change-Id: I24a1fa7502397a433e872a114afe64bab6f97f96
Reviewed-on: https://gerrit.instructure.com/125239
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Stephen Jensen <sejensen@instructure.com>
fixes GRADE-180
Test plan:
Smoke test all Canvas pages that use InstUI.
Change-Id: I9ca3dc199924ec3a26c21bcc47dacb51ed12df6a
Reviewed-on: https://gerrit.instructure.com/122611
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Neil Gupta <ngupta@instructure.com>
Fixes: CNVS-38904
test plan:
- local environment set-up... since this is updating our
icon dependecy you will need to remove /dist folder and
re-compile all the things prior to viewing
- once all things are up and running - navigate to a course
select an assignment... if it's pubished click to unpublish
so you can see the "updated unpublish icon"
- example of new view: https://screencast.com/t/n5TSgNXpCSr
Change-Id: I42fb39a3856ee331460623a8964818c0925f32f4
Reviewed-on: https://gerrit.instructure.com/124362
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
this will make it so all of our bundles share one copy of:
axios, browser, react-redux, redux-thunk. uuid, core-js etc.
it will make it so users have to download less bytes of javscript
in their webpack bundles
test plan:
make sure pages that use axios work.
automated specs should pass
Change-Id: If3698452e3d6f1095997bd97505efc11ae05c678
Reviewed-on: https://gerrit.instructure.com/124266
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Test plan
- Smoke test to ensure dependency pinning hasn't
caused any issues
Change-Id: I98f2feec9c56f98f530685fa9c94c106d9881c4c
Reviewed-on: https://gerrit.instructure.com/122023
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Refs: CNVS-38653
This upgrades us to webpack 3.5.4 and upgrades uglify
and Istanbul related stuff too:
Test plan:
* automated build should pass
* run yarn && COVERAGE=1 yarn test && open coverage-js/index.html
* it should run karma & open your browser to a bunch of istambul reports
* run `yarn run webpack-production`
* it should generate minified code that works in your browser when you
open canvas in prod mode
Change-Id: Id8b3c2457f47a30f299eafc6a8206102cfe98dc5
Reviewed-on: https://gerrit.instructure.com/122993
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Test plan: docker-compose run --rm karma yarn test
Change-Id: I316d80e7a1b712b0dda91a390c4dddeb09b3e6fb
Reviewed-on: https://gerrit.instructure.com/122776
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-34165
test plan:
- make sure you are running with RAILS_LOAD_ALL_LOCALES=1
for (web and webpack if you are running docker)
- change locale to each of es, de, fr, fr-ca, he and pl
- create/edit a quiz
- in the due date try setting the due date to a day in each month
- no need to save
- make sure after clicking the day it doesn't change to a different
month or year
Change-Id: I2da96f80678193e084786d867b27f2944a6e402c
Reviewed-on: https://gerrit.instructure.com/119926
Tested-by: Jenkins
Product-Review: brian kirkby <bkirkby@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Refs: QUIZ-2556
have canvas-rce share the same lodash, prop-types,
format-message, & redux that's already on the page,
so bundles are smaller.
test plan:
* check to make sure the service version of RCE works right
* the webpack bundle for it should be smaller
Change-Id: I9e9cb96524760987138d4a9ef24073a854889366
Reviewed-on: https://gerrit.instructure.com/121276
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
… so Jenkins logs are less noisy
Test plan:
* verify that the “full console” view
For the selenium build of this patchset doesn’t
Have a bunch of noisy progress output from webpack
Change-Id: Id69b04435be52bcc3213298e5ae55ac146d8e2ed
Reviewed-on: https://gerrit.instructure.com/120863
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-38384
This is just to keep our tooling up to date
Test plan:
* automated tests should pass
* build tooling should work (meaning webpack builds
In prod & dev)
Change-Id: I11fbda35827487e59712c762a71540a51258d1db
Reviewed-on: https://gerrit.instructure.com/120434
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes FALCOR-495
This release includes these things from canvas-planner:
- Bump planner to version 1.0.6
- Handle long strings in planner items and groups
- Bump version to 1.0.5
- Make past items load in descending order when fetching
- Make close button for opportunities modal show at bottom and be hidden
- Dismissing Opportunties breaks for certain planner items
- update readme for deploying
- fix instui defaultValue error
- Finally patches scrolling bug
- [i18n] update locales with new translations
- Canvas Planner Fix For Showing Due Dates at 12:00 A.M.
- Bump version to 1.0.4
- Change dismissing opportunity to different API field
- [i18n] update locales with new translations
- Add copyright notice linting
- Add LICENSE file to repository
- Make ungraded discussion topics show the new replies pill
- Upgrade a few libraries that we depend on
- Make todo items associate properly with courses
- Create non-existing days when needed
- fix a time dependent test
- [i18n] update locales with new translations
- Fix IE x wrong spot issue
- [i18n] update english locale with new strings
- fix translations in utilities file
- Bump version to 1.0.3
Test Plan:
- Things work, automated tests pass
Change-Id: I6ac18ed79c19d99a352681458507876adbf26412
Reviewed-on: https://gerrit.instructure.com/119306
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
Fixed: CNVS-38040
test plan:
- ensure package.json is referencing the correct version
- clean compile all assets (may require rm /public/dist)
- fire up local instance and ensure all icons are displaying
correctly
note:
- this commit also removed the unnessacry call-out to Icon-Line for
dashcard icon for accessing color as well as removed some
gradebook code that was rotating the old icon so it looks like
what the new one actually is now (vertical vs horizontal)
Change-Id: I7c74c64e16245d43bd9f717c7a44baab232fb002
Reviewed-on: https://gerrit.instructure.com/118182
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
closes FALCOR-447
Test Plan:
- Regression test planner
- New changes include:
[debcbf1629] (Clay Diffrient) Bump version to 1.0.3
[0087bf1781] (Jon Willesen) fix crash on status unread_count > 0
[f61625989c] (Ubuntu) [i18n] update locales with new translations
[3ff846d51e] (Aaron Kc Hsu) Fix scrolling to top when opening TODO update tray
Change-Id: I77d7e846021528649a97c5a0b5f5bd8f549571a4
Reviewed-on: https://gerrit.instructure.com/117467
Tested-by: Jenkins
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes FALCOR-427
Test Plan:
- Automated tests pass
- Regression on planner in Canvas
- The following commits from canvas-planner are added
in this release (in case that helps with testing new stuff)
[1a260a5b76] (Clay Diffrient) Bump version to 1.0.0
[0d743e31c6] (Clay Diffrient) Clear update todo item details when closing the tray
[b694a49c55] (Clay Diffrient) Handle focus management with the to do item tray better
[04322e9ed8] (Ubuntu) [i18n] update locales with new translations
[4df1ae93d5] (Clay Diffrient) [i18n] update english locale with new strings
[f582e8a4e4] (Clay Diffrient) Improve a11y of the update item tray
[018e1ec45f] (Clay Diffrient) Make opportunities popover aria-hide non-popover content
[9f2d288183] (Clay Diffrient) Make to do items show without needing refresh
[84f218acd5] (Jon Willesen) remove course link from to do groups
[cf1b9af0f1] (Aaron Kc Hsu) Fixes Moment Fail Test
[bc8f51a4ae] (Chris Hart) Better line-heights for Planner components
[c5839b7058] (Steven Burnett) allow updating of todos
[64df109598] (Clay Diffrient) Add alerts in places that need them
[f6170ad01a] (Aaron Kc Hsu) To Do items default to 11:59 PM on the front end
[fcf82f31b0] (Ubuntu) [i18n] update locales with new translations
[2c08e5bf92] (Jon Willesen) Revert "show days with nothing planned"
[98cc1bed74] (Aaron Kc Hsu) Change Todo link from black to correct color
[500aff0303] (Ubuntu) [i18n] update locales with new translations
Change-Id: I94aeefd20d3974844da05b0a6dd8e28327a4a790
Reviewed-on: https://gerrit.instructure.com/117081
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes CNVS-37721
Test Plan
- check to make sure package.json and yarn.lock makes sense
Change-Id: I90a7d47557a0d350d8b424d6e6e5023490d85f1e
Reviewed-on: https://gerrit.instructure.com/116406
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Tested-by: Jenkins
Product-Review: Keith T. Garner <kgarner@instructure.com>
Fixes: CNVS-37057, CNVS-37327
Refs: CNVS-37056
test plan:
- navigate around canvas to ensure the icons are aligned
and showing correctly :D
- overall note - icons are now the "line" version vs the
solid (with this implementation the assignments and
modules pages have removed the circle with background color
for better legibility for the icon)
- the overall base font size for canvas has been increased
to 1rem = 16px (there are still areas that have overriding
css to manipulate the font size smaller than the base and
can be addressed individually)
- this bumps inst-icons to a beta version for testing
Change-Id: I5ef389298257122f0c3016e97beff50ed8925df1
Reviewed-on: https://gerrit.instructure.com/114343
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
the new version of the rce and skin no longer incorrectly display the
font size of text in tables. many of the canvas style overrides have
also been moved to the skin and are no longer needed in canvas.
the initial push of this fix broke several rcs selenium tests due to a
circular destroy chain. https://gerrit.instructure.com/#/c/116660/ fixes
that and has been published to npm as v2.2.0-alpha.1. we should test this
patchset against that npm version
fixes CNVS-37517
test plan:
- run yarn install first to get new dependency versions. canvas-lms should
be version 2.2.0-alpha.1
- test rcs and legacy editors
- insert a table, type in a cell, text should be same size as outside
the table (shows as 11pt in toobar)
- test the toolbar nav with and without high contrast (alt+f10)
- toolbar styles should match colors and have a triangle under for
active state, and a border for focus state, and both when focusing
on an active button
- create a discussion thread
- add a reply to the discussion thread
- edit the reply to the discussion thread
- verify that this works and has no console errors
Change-Id: I7e8696cf54afda6de08fa729452f14fc1868510a
Reviewed-on: https://gerrit.instructure.com/116036
Tested-by: Jenkins
Product-Review: brian kirkby <bkirkby@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Test Plan:
- Full regresssion on the dashboard
Change-Id: I514f06497fb8d6c06208f3ccd4a959c7c84e8352
Reviewed-on: https://gerrit.instructure.com/116441
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Dan Minkevitch <dan@instructure.com>
test plan:
- run the following commands and assess that they run as expected:
- yarn run build
- yarn run build:css
- yarn run build:css:watch
- yarn run build:js
- yarn run build:jss:watch
Change-Id: I4c0a2a68ce62896364bc2da5e7956002c15f5847
Reviewed-on: https://gerrit.instructure.com/110497
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
closes: CNVS-31854
Test Plan:
- Given the New Gradebook
- When the Statuses Modal is open from the View Menu
- Then a popover kabob is present for each status
- When the kabob icon is clicked
- Then the color picker appears
- Then the displayed color for that status row is selected in the
color picker
- Then focus is on the first swatch
- When a swatch is selected
- Then swatch appears as selected with a bolder border
- Then the hex display is updated to that swatch's color
- Then the color preview updates to that swatch's color
- When Apply is clicked
- Then the color in the grid is updated
- Then the color picker popover is closed
- Then focus is returned to the kabob
- When the page is reloaded
- The updated color settings persists
- Given the color picker is open
- When clicking anywhere but the color popover content
- Then color picker closes
- Given the color picker is open
- Given another color is selected
- When cancel is clicked
- The color is not updated
- Focus is returned to the kabob
- This patchset should not change any behavior with the color picker on
the dashboard for course colors
Change-Id: I131eb6e564e78265db77a04fba63ba318e8ffaf6
Reviewed-on: https://gerrit.instructure.com/115212
Tested-by: Jenkins
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Christi Wruck
fixes CNVS-37610
test plan:
* on a machine with only production node modules installed (like a job
server), the offline export works.
Change-Id: I5013895c3b4a5faa51a13e569c4004a60f33b11e
Reviewed-on: https://gerrit.instructure.com/115793
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Robert Lamb <rlamb@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
closes FALCOR-344
Test Plan:
- Enable planner feature flag
- Create some items that have dates
- As a student log in and switch to "List View" in the dashboard
options menu
- Planner should display data appropriately
- NOTE: Checking items complete, will NOT work in this version.
- NOTE: Adding to do items will NOT work in this version.
Change-Id: Ifb3edc70c8d6f44e0b099c11b702a3d0fc4b7355
Reviewed-on: https://gerrit.instructure.com/115162
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
this addresses the brand theme issue
fixes CNVS-37386
Test plan:
- enable a different theme in canvas
- go to a course People paage
- click on +People
> expect the modal buttons and such to be themed correctly
Change-Id: I37bdf0c1528b94dc51e724f680ea1cbac96ed778
Reviewed-on: https://gerrit.instructure.com/115196
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes: CNVS-37355
Some people have reported getting errors while
`yarn install`ing or `npm install`ing when
it tries to build node-sass from brandable_css
(Especially in docker)
This commit updates brandable_css, which updates
the version of node-sass it uses. I want to see
if it fixes anything
test plan:
css should generate and node-sass should not fail when `yarn install`ing
Change-Id: I018560baf151479a402fa1dbd868eaca9d51bb02
Reviewed-on: https://gerrit.instructure.com/113228
Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-37316
fixes issue cause by a const not-transpiled to var
test plan:
- pages with tinymce don't have non-transpiled const
Change-Id: I2ff0bdae30921780b376fdb7ec7a5a128d495f7b
Reviewed-on: https://gerrit.instructure.com/114170
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
closes MC-183 CNVS-36933
test plan:
- create a master course with locked and unlocked content
- go to a learning object's index page
> expect the lock and unlock buttons to have the new icons, and for the
> mouse-over and tooltips to behave similarly to the publish icons
- go to an object's show page
> expect the locked/unlocked button to have the new icons, and for the
> mouse-over and tooltips to behave like the publish button
- create a child course and sync
> expect the child course's learning objects' pages to have the
> new lock and unlock icons
NOTE: this gerrit will never pass Jenkins tests because it depends on a
corresponding change in the demo_site gem/plugin.
https://gerrit.instructure.com/#/c/112656/ exists to test the 2
interdependent commits together. If it gets a Jenkins +1, then this is
OK too.
Change-Id: I5e4a8bb109d6b9574fdf8650787f530c4597b2ab
Reviewed-on: https://gerrit.instructure.com/112422
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Pert Eilers <peilers@instructure.com>
Change-Id: I74c3cb8521fb77415e679e65ccc5f8f00f016461
Reviewed-on: https://gerrit.instructure.com/114005
Product-Review: Neil Gupta <ngupta@instructure.com>
QA-Review: Neil Gupta <ngupta@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Tested-by: Jenkins
DO NOT USE THIS YET. It is beautiful, but unready.
Test plan:
1. enable graphql feature flag
1. go to /graphiql
2. shed tears of joy
closes CNVS-37001, CNVS-37004
Change-Id: I94ae9c452fe987efcc5e88659ca9c932c280097e
Reviewed-on: https://gerrit.instructure.com/112867
Tested-by: Jenkins
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
QA-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
closes: CNVS-37135
test plan:
try to drag drop things (like on the discussions
index page) on an iPad or other touch interface
make sure it still works
Change-Id: I290d5adc2a956edda367b95de1184224d5f1e66a
Reviewed-on: https://gerrit.instructure.com/113066
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
This moves the things in the prod dependencies
That are not actually needed for brandable_css
Previews to generate to the devDependencies
Test plan:
rm -rf node_modules yarn.lock
yarn install --production
yarn run brandable_css
All your css should generate without errors
Change-Id: I68bc3aeaf4b8ac934cdd3372476795a062cdcc69
Reviewed-on: https://gerrit.instructure.com/112514
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins
closes CNVS-35897
test plan
* Set your time zone to Cairo (+2) or Istanbul (+3)
* Set a recurring calendar event to extend into the next month
* the calendar event should not be one hour ahead when it
extends into the next month
Change-Id: I078697bc533bdb5a4f70d3f037ba9d2d25d3a058
Reviewed-on: https://gerrit.instructure.com/112420
Reviewed-by: brian kirkby <bkirkby@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
this upgrade includes support for hiding the "link to a new page"
link based on can_create_pages from the jwt workflow state.
fixes CNVS-35271
test plan:
- make sure you `yarn install` to git the latest npm module
- ensure you are running the latest RichContentService api server
- ensure rich content service flags are enabled in canvas
- go to a course discussion as a student
- you should not see the "link to a new page" link under the "pages"
section of the links tab for the rcs sidebar
- you should still see at as any user, regardless of role, who has
rights to create wiki pages in the context
Change-Id: Icfcc187e9c18d6c2d718830c09b8bd1ad2506f0d
Reviewed-on: https://gerrit.instructure.com/112503
Reviewed-by: brian kirkby <bkirkby@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
closes: CNVS-37028
Test plan:
* the textarea in the speedgrader should still
grow as you type in it as it did before
Change-Id: Iff6d03ff1e032073a211674b1c3d2ee3bacca89c
Reviewed-on: https://gerrit.instructure.com/112312
Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Closes CNVS-37032
test plan:
- navigate to user settings page and click the avatar.
- select the gravatar tab of the dialog.
- input field should be pre-populated with user's default
email address.
- image preview should show gravatar for default email.
- input new email address and click preview.
- new gravatar should be displayed in the preview.
- click select image button. dialog should close and new
avatar should be diplayed.
- refresh and make sure new avatar sticks.
- inspect element on the avatar image; it should point to
the gravatar domain.
Change-Id: I55891a567e54a1df4bb982133f2adc8f4872672e
Reviewed-on: https://gerrit.instructure.com/112433
Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-36805
I’m working towards turning on babel for public/javascripts
And so instead of having to worry about selectively adding excludes
For things in public/javascripts/vendor that we haven’t modified,
I’m just moving things out of there.
This commit just relies on gulp rev to put these files in
public/dist/* instead of having the intermediate artifacts
hanging around in public/javascripts/vendor/* that then
get copied/revved to public/dist by gulp rev.
This also minifies any gulp-revved js in production
Test plan:
* Nothing should change
* run compile_assets
* the javascript for your timezone data should load
just fine like it did before
* the lato fontface observer should still be working
* go to the site in IE, there should not be any
Js errors (like “Promise is not defined”)
Change-Id: I10b2e3f102276ab0ef5f58cbc0d981f5aa800522
Reviewed-on: https://gerrit.instructure.com/111251
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-37030
Test plan:
* the student dropdown menu in Speedgrader should still work
Change-Id: Icb7464188b4480e07356521609108caffc5c6f5e
Reviewed-on: https://gerrit.instructure.com/112310
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes FALCOR-265
Test Plan:
- Enable planner feature flag
- Switch to list view dashboard
- Have several assignments with due dates
- Notice that the assignments show up
Change-Id: I235795b86b704fd33d8f0ba82a874c89e9c3348d
Reviewed-on: https://gerrit.instructure.com/111723
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Mary Jane Anderson <manderson@instructure.com>
fixes CNVS-36648, closes INSTUI-421
Test plan:
The following areas of Canvas are affected by this upgrade:
- High contrast mode and theme editor branding
- blueprint courses
- conditional release stats
- student context cards
- new user tutorial
- course home dialog
Change-Id: I5d7128e4ebf88a34342ffcb99d4ccf7dd839b2f7
Reviewed-on: https://gerrit.instructure.com/111443
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Tested-by: Jenkins
closes CNVS-28612
test plan:
- test in legacy editor and with rcs enabled
- insert a table
- click table properties icon at bottom left of table context menu
- shift+tab to move focus back to tabs
- should indicate focus with a box outline in the tab
Change-Id: I547d2c204dab670ecfe3208c442a7250c40204ab
Reviewed-on: https://gerrit.instructure.com/111626
Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
Cameron Matheson