Commit Graph

4 Commits

Author SHA1 Message Date
Aaron Shafovaloff f8458c8699 fix formatting from useScope commits
test plan:
 - all tests pass

flag=none

Change-Id: I50e858039081b8bd0c5a497cdf9e697710a54dc5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287364
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
2022-03-17 21:07:06 +00:00
Ahmad Amireh bf46b5cc33 rewrite i18n! to useScope in javascripts
refs FOO-2696
flag = none

applied by the codemod found here: https://github.com/instructure/canvas-i18n-loader-rewrite

this won't pass in isolation, see the mega patch that cherry-picks them
all for the status

~ test plan ~

do a cursory glance over the changes and verify we didn't miss anything

Change-Id: I9bc7dad55c7aba9053ab69c9bb477cb4ee3e78bb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286661
Tested-by: James Butters <jbutters@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
2022-03-10 21:38:25 +00:00
Matthew Lemon ddf60591dc improve UX for reporting profile pictures
fixes VICE-2049
flag=none

Test Plan:
- Enable profiles on the account settings

- As a teacher navigate to the people page on a course
- Click on a user with a profile picture and then click on their name
  in the tray that opens
- The avatar image should no longer be clickable and there should now
  be a link next to the avatar saying "Remove avatar picture"
- Clicking the link should open a "Confirm Removal" modal with the
  message "Are you sure you want to remove this user's profile picture?"
- Hitting confirm in the modal should result in a success alert saying
  "The profile picture has been removed." and the avatar image should
  be removed from the page.
- If you refresh the page, the avatar image should show the default
  avatar image.

- As a student follow the same steps as above to get to a different
  user's profile page
- As a student you should see a link with the text "Report inappropriate
  picture"
- Clicking the link should open a "Report Profile Picture" modal with
  the message "Reported profile pictures will be sent to administartors
  for review. You will not be able to undo this action."
- Hitting confirm in the modal should result in a success alert saying
  "The profile picture has been reported" and the link should no longer
  be a link and the text should update to "This image has been reported."
- Refreshing the page should show the text "This image has been reported."
  instead of a link

Change-Id: If8fed6939d27c610fb66c3f4b0491a3fa350ef02
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276261
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
2021-10-25 17:57:04 +00:00
Ahmad Amireh 4243097b21 rename some things
fixes FOO-1265

[skip-eslint=true]
[pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5]
[pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5]
[pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf]
[pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22]
[pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805]

Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
2021-04-06 01:12:49 +00:00