closes VICE-2711
flag=react_inbox
Test Plan
1. Open the compose modal
2. Verify that inputs match the AC screenshot
Change-Id: I0400e9be7fcd93e73a950582344fa55edc185b25
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290274
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
Product-Review: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
fixes LS-3127
flag=course_paces
When disabling a MenuItem, the implementation slightly changes where we
are no longer providing the disabled tag, but rather setting that via
aria-disabled. In order to appropriately test this, our assertions were
updated as suggested in https://github.com/testing-library/jest-dom/issues/144
test plan:
- enable course_paces and course_paces_blackout_dates flags
- create a course and navigate to /courses/:id/course_pacing
- click on the settings cog
- clicking skip weekends should continue to mark the new checkbox
as appropriate and update the setting
- clicking manage blackout dates should close the menu and open the
modal still
qa risk: low
Change-Id: Ib37852849c8754853a81dcb956e3b283a3df5b05
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290156
Product-Review: David Lyons <lyons@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
so users know about unpublished changes etc.
closes: LS-3099
flag=course_paces
test plan:
- create a new course and turn on course pacing in settings
(alternatively, from a rails console, you can
Course.find(:id).course_paces.destroy_all)
- visit the course pacing page
> expect an info alert message at the top saying the pace is unpublished
> expect the cancel button to have a tooltip saying there are no
unpublished changes
> expect the publish button not to have a tooltip
- dismiss the info alert
- make changes
> expect the alert not to come back
> expect to see "X unpublished changes"
> expect no tooltips on the cancel or publish button
- cancel
> expect all the chnages to revert
- with changes or not, click publish
> expect a saved pace
Change-Id: I4f955a34df5c75a7694aacc585a7f1863c6acacf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290091
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
closes OUT-5068
flag=outcome_alignment_summary
Test plan:
- Enable Improved Outcomes Management FF
- Enable Outcome Alignment Summary FF
- As Admin, go to Account > Outcomes
- Verify that Alignments tab is not displayed
- Go to Course > Outcomes
- Verify that Alignments tab is displayed and
that clicking on it switches to an empty page
- Act as student and to go Course > Outcomes
- Verify that Alignments tab is not displayed
- Stop acting as student
- Disable Improved Outcomes Management FF
- Go to Course > Outcomes
- Verify that Alignments tab is not displayed
- Enable Improved Outcomes Management FF
- Disable Outcome Alignment Summary FF
- Go to Course > Outcomes
- Verify that the Alignments tab is not displayed
Change-Id: I18f970ae539b21b05564ec1b77db801d372c9f8e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289846
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Chrystal Langston <chrystal.langston@instructure.com>
Reviewed-by: Fernando Marques <fernando.marques@instructure.com>
QA-Review: Angela Gomba <angela.gomba@instructure.com>
Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
flag=react_discussions_post
fixes VICE-2595
TEST PLAN:
- turn off react_discussions_post
- visit discussions index as a teacher
- verify there is no anonymity
toggle in cog menu
- make sure that when you create
a new discussion, there are no anonymity settings
- now turn on react_discussions_post
- verify that in the discussions index,
there is now an anonymity setting, turn it on
- create a new discussion, verify that you can
either set it to full or partially anonymous
discussion
- verify that students discussion replies to
anonymous discussion still anonymizes them
Change-Id: Ib6203771bf4dac27ca442ab08ae1990337b39fde
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290269
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
flag=react_discussions_post
closes VICE-2683
Test Plan:
- Go to a discussion topic
- Focus over the elements of the DiscussionPostToolbar
- You should see the focus indicator appropriately.
Change-Id: I6cacb9dcd2df7b49866f076ef73a3e4302ba566c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290262
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
Product-Review: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
closes VICE-2685
flag=react_discussions_post
Test Plan:
- turn discussion redesign ff on
- turn voice over on (cmd + f5)
- go to a dicussion
- press tab to get to 'skip to content'
- press enter
- use cmd + ctrl + option + h to navigate forward
- use cmd + ctrl + option + shift + h to navigate
backward
> should see invisible h1 above the search
> should see h2 on discussion topic title
> should see invisible h2 on each reply
Change-Id: I380f1b0f1a4f527a24b18ec5b512cb9ea6bfdbab
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290197
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
On the k5 dashboard and in a k5 course, move the ObserverOptions
component to the right side for consistency with other views.
closes LS-3134
flag = none
Test plan:
K5 Dashboard:
- Open the k5 dashboard as an observer, teacher, and student
- Expect the observer picker (when present) to appear on the right
side, inline with the welcome heading and next to the options
dropdown (when present)
- Shrink the window and expect the observer picker (and other menu
options, if present) to move above the welcome heading
K5 Subject:
- Open a k5 subject as an observer and teacher
- Expect the picker (when present) to appear on the right next to
the student view button (if present)
- Shrink the window and expect the header to adjust appropriately
- As a student, expect the header to be gone comletely
Change-Id: I9dcb92ec37b08155086a8010d936195f8bc719e0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290164
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
closes LS-3108
flag=course_paces
test plan:
- in a course with pacing on
- have some assignments in modules
- publish the pace
As a teacher
- go to the syllabus page
> expect to see the course pacing notice instead of the
table of assignments + due dates
As a student
- go to the syllabus page
> expect to see your assignments with due dates
Change-Id: Ife9eddc2d860e9a345295f6bb464ce1c8473444b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290076
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
fixes VICE-2686
flag=react_discussions_post
Test Plan:
- turn on discussion redesign ff
- go to a discussion
- turn on voice over
- tab over reply, like, expansion, and thread action buttons
> voice over should read author name as part accessible content
Change-Id: I7f72bcb5d78bf37bccf6d13dae6475f550f12d1b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290063
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
closes VICE-2681
flag=none
Test Plan:
- turn inbox redesign ff on
- create a submission comment as a teacher
- as a student respond
As a teacher and as a student:
- go to the submission comment thread in inbox
- click title link
> should be directed to submission page
Change-Id: I80a9d359194312c259be5b38ca4acd9bcaac6238
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289995
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
closes VICE-2594
flag=none
Notes:
discussions_reporting is a sub flag of discussion_topics_post.
Thus, we want to remove the discussions_reporting flag
in all places possible.
This is mainly discussion_topics_post.
In places outside of discussion_topics_post, we cannot rely on
discussion_topics_post being enabled, thus the proposed solution
is to switch discussions_reporting check to discussion_topics_post.
Test Plan:
Verify that the switches are appropriate.
The specs and tests still pass.
Reporting options are available when discussion_topics_post is enabled.
Change-Id: If663ad3163b54d09ca77644194faf4b5c1b9ecfa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289819
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
closes VICE-2151
flag=react_inbox
Test Plan:
1. Verify that submission comments shows newest comments at the top
2. Verify that submission comments query doesn't require sort argument
3. Verify that the submission with the newest comment appears at the top
query MyQuery {
__typename
legacyNode(_id: "4", type: Submission) {
... on Submission {
id
commentsConnection {
nodes {
comment
createdAt
}
}
}
}
}
Note: backend submission sorting will be handled with VICE-2740
Change-Id: I30c06e7f758532ea5f6ab6488a783e291d58a10a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289704
QA-Review: Drake Harper <drake.harper@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes QUIZ-9453
flag=none
test plan:
- when adding a Quiz to the Quizzes index page,
verify that the “Remember by choice for this course”
label is programatically associated with its checkbox
Change-Id: If8e955502f8980d4d2c14aaa9634a5b43a9d8a43
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288966
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Marissa Pio Roda <marissa.pioroda@instructure.com>
Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
Reviewed-by: James Logan <james.logan@instructure.com>
QA-Review: Mark McDermott <mmcdermott@instructure.com>
refs LS-3109
flag=course_pacing
test plan:
- in a course with pacing on
- have an assignment in a module item
- go to the course pacing page and publish to give
the assignment a due date
As a teacher
- go to the modules page
> expect no due dates on the assignment(s)
As a student
- go to the modules page
> expect to see your due date
Change-Id: I0ab280747b22baef068d9ab47220796cc2370cc1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289993
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
refs LS-3109
flag=course_pacing
test plan:
- in a course with pacing on
- put a quiz in a module item
- visit the course pacing page and publish do the quiz
gets a due date
As a teacher
- go to the quizes page
> expect no Available dates or due dates with each quiz
As a student
- go to the quizzes page
> expect to see your due dates
Change-Id: I6b155b556bdf68d2f8b54511795537592debe23a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289988
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
remove availability and due dates
refs LS-3109
flag=course_pacing
test plan:
- in a course with course pacing
- add an assignment module item
- visit the course pacing page and publish to
give the assignment a due date
As a teacher
- go to the assignments page
> expect no Availabe dates or due dates with
each assignment
As a student
- go to the assignments page
> expect to see your due dates
Change-Id: Ib13edf04cf8dd648906e484150ab2d4d5129b068
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289967
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes VICE-2638
flag=none
Test Plan:
0) Try the below without the fix, doesnt work.
1) Turn off discussion redesign flag.
2) Go to a discussion with some entries (I used 4).
3) First set page limit (optional)
Go to: ui/features/discussion_topic/backbone/collections/EntryCollection.coffee
set perPage: 50 => 3; thus the 4th entry next page.
4) Use Entry search to search for entry on another page.
5) click 'View In Discussion'.
It should take you to the correct page and entry.
Notes/Resolution:
the bind function returned a function pointer that was no longer being called.
Also it needed a parameter the entry id.
Change-Id: I92cb4f5b85afea699e629f897bc0fb1d495cbb5e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289813
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
closes: VICE-2553
flag=react_inbox
Test Plan
1. Go to react inbox
2. Click compose message
3. Type a message without anyone in the "to" field
4. Verify that an error message appears and that the modal does not close.
Change-Id: I9a095d18b6c9b83f551e27279d6ac42db5bafe7f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289765
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
flag=react_inbox
refs VICE-2605
Test Plan:
- Go to compose modal.
- Select a course.
- Notice that an X appears allowing you to remove it.
Change-Id: Idc059cd46e7ed8731d73c56b084383d8be23cdab
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289830
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
closes VICE-2599
flag=none
Test Plan:
- turn inbox redesign flag on
- go to a filter that will show no messages
> should see panda throwing paper air plane
Change-Id: I4424ffad873b272f01a7c3cf92965b29c4a4890f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289851
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
fixes VICE-2562
flag=react_inbox
Test Plan:
- turn react_inbox ff on
- go to inbox
- create a conversation with 20+
- click the show more/less button
> ouline should not be cut off
Change-Id: Idaa8cb9744813bd38c7780363ea854cd26103c59
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289775
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
test plan:
- have a job with a "locked_by" in the format seen in prod,
e.g. job010001039065:12438
- the job details table should display the translated
IP address next to this, along with a button that will
copy it to the clipboard
flag=jobs_v2
closes DE-1143
Change-Id: I6aebf5439c38d1b365b89dfda3fd4aef76d9b773
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289780
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
also make the success/failure feedback disappear on a timer
instead of on blur, which is more consistent with what other
sites do (also the blur doesn't work quite right on Safari)
test plan:
- the copy-to-clipboard button in the jobs list should
behave as expected
refs DE-1142
Change-Id: I95bd757bc182c6b16ebcc9c8c5de576b2ad32313
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289774
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
closes VICE-2519
flag=react_inbox
Test Plan:
1. Open a conversation in react Inbox
2. Click the forward option in the thread header
3. Should be the option to the right of the thread subject
4. Should be able to forward the conversation thread
Change-Id: I56b4727be1ff1305edb290184e7ca79387fd3f77
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289748
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
closes LS-3121
flag=course_paces
test plan:
- go to the assignment index page in a non-paced course
- open the kabob menu
> expect to see "Edit Assignment Dates" and "Assignment Groups Weight"
- repeat in a course with pacing on
> expect to see "Assignment Groups Weight" only
Change-Id: I0e9eca4219c14f4011daaf11df3d030a1030c433
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289865
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Test plan:
- Go to Assignments
- Click on the 3 dots to the right of +Assignment
- Click on Edit Assignment Dates
- In the date field, select a date
- Open the date picker again, and select the same date
- Note that the time remains correct
fixes LS-3087
flag=none
Change-Id: Ifce67e43dbaac6628821e7891399a0160c4c3359
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289881
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
closes EVAL-2356
flag=enhanced_gradebook_filters
Test Plan:
With a gradebook with:
- a few assignments
- FF enabled
- "Allow final grade override" advanced view setting enabled
As a teacher:
1. Go to the gradebook and see that it shows the Total and Override
columns
2. Go to the settings, and check "Hide Total Column and Overide
Columns" and save. Make sure that the gradebook does not show the
Total and Override columns.
3. Go back to the panel and see that the setting is still checked
4. Refresh gradebook and see that the setting is still checked and
the 2 columns do not show in gradebook
5. With the FF disabled, you should not see the new setting and the
Total and Override columns show in gradebook
6. BONUS:
6.1. Create a set of Grading Periods on the account
6.2. Use the Grading Period filter condition to look at different
grading periods and make sure you can see the Total and Override
columns
6.3. Repeat step 6.2 with the view setting checked to hide total
and override columns. Make sure that the columns remain hidden for
all grading periods, selected grading period options
Change-Id: Ie5ca69d0a8eabcc73b7a2402e21c12fc2ad30a4a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288549
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
Reviewed-by: Paulo Chaves <paulo.chaves@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
https://gerrit.instructure.com/c/canvas-lms/+/289809
is a prereq, since it creates the course pacing
notice react component used here.
refs LS-3034
flag=course_paces
test plan:
- in a course with course pacing on
- create a quiz
> expect a notice about course pacing managing due dates
in lieu of the due date inputs
- click the go to course pacing link
> expect to go to the course pacing page
- go back and save the quiz
> expect the notice on the quiz "show" page.
Change-Id: Ifa00021eddb6ad11efa2d3691d02093ce3691193
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289823
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
It looks like I commented one line to mock some API responses,
it looks like it does not fail when running isolated, let's add that
line back and increase the jest time out.
closes: LS-3048
flag= none
Test plan:
- Passes Jenkins
Change-Id: I6949c5e2ec2656787fa639ac7744c501a991b1bb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288293
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
fixes FOO-2847
refs FOO-129
flag = granular_permissions_manage_course_content
Test plan:
• Smoke test Announcements -> /courses/<course_id>/announcements
• Ensure behavior hasn't changed with the following flag disabled:
• "Granular permissions for managing course content"
• Now enable the feature flag within root account feature options
• Within permissions only enable "Course Content - edit" for the
"Manage Course Content" granular group permission:
• You should have the ability to lock / unlock selected
annoucements in singular or bulk fashion
• The button *should not* be visible without this permission
• Within permissions only enable "Course Content - delete" for the
"Manage Course Content" granular group permission:
• You should have the ability to delete selected announcements
in singular or bulk fashion
• The button *should not* be visible without this permission
Change-Id: Idf5ab6d9a3eb537a994c3346153bc91d5baf5da3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289761
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
https://gerrit.instructure.com/c/canvas-lms/+/289809
is a prereq, since it creates the course pacing
notice react component used here.
refs LS-3034
flag=course_paces
test plan:
- in a course with course pacing on
- create an discussion and check "graded"
> expect a notice about course pacing managing due dates
in lieu of the due date inputs
- click the go to course pacing link
> expect a warning that you're leaving the page withoug
saving.
- say OK
> expect to go to the course pacing page
Change-Id: I8a8c31c249b9f13666c9eff24d7a887685854d69
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289818
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3034
flag=course_paces
test plan:
- in a course with course pacing on
- create an assignment
> expect a notice about course pacing managing due dates
in lieu of the due date input box
- click the link
> expect to go to the course pacing page
> expect the assignment show page to be as always
- save the assignment
> expect the notice to be in the assignment's show page also
- click the link
> expect to go to the course pacing page
Change-Id: I30b71b715c3317e57e7a2a25c7b91cdb0229e2c5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289809
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
As it is enabled 100% we do not need this FF any more
closes EVAL-2342
flag=none
Test Plan:
- As a teacher go to gradebook and make sure assignment and student
search works as expected
- Tests pass
Change-Id: I65885cab98d1c4853ec18ccd98ddb77d58bbee4b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288656
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eduardo Escobar <eduardo.escobar@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
fixes VICE-2586
flag=react_inbox
replaced invisible "Message sent successfully" with
visible "Message sent!" to match old inbox
test plan:
- in new inbox, send a message
- verify that on successful send,
you see a visible, green, "Message sent!"
flash message
Change-Id: I3968d658c68fa04e23a702096839ee72aff69a75
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289758
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
flag = react_inbox
refs VICE-2678
Test Plan:
1. Send a message to yourself
2. navigate to sent inbox
3. Verify that the participant string doesn't have a trailing comma
Change-Id: I53c0040aa631eaba438921c8e6ca66eea86a3237
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289767
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
temporarily replace the copy icon with a green check or red X
to indicate the success or failure of the operation
(similar to what gerrit does)
test plan: when you click one of the copy-to-clipboard buttons
that appears in the jobs table on hover, the icon should turn into
a green check to indicate the copy succeeded
and when you leave and come back to the row, it should be a normal
clipboard button again
flag=jobs_v2
closes DE-1142
Change-Id: I772b187beaae011bf7d5818abcaee9356f09be00
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289647
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
- click a tag, strand, or singleton in the jobs list
- it should refilter the jobs list to show only matching jobs,
changing the "tag" / "strand" / "singleton" selection at the
top of the screen if needed
flag=jobs_v2
closes DE-1131
Change-Id: I9197107bb8b164afd0f49fad0b7899aa5ec7f2a8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289615
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
While the form showed an error message when the end
date was before the start date, it did not disable
the Add button. It does now.
closes LS-3117
flag=course_paces
flag=course_paces_blackout_dates
test plan:
- in a course's course_pacing page
- open the manage blackout dates setting modal
- add a title
- add a start date
- add an end date before the start date
> expect an error message
> expect clicking the add button to do nothing
> expect a tooltip on the add button
- fix the error
> expect clicking the Add button to add the blackout dates
Change-Id: I44e38b060b2d80a39228f8d7a9c123f3990d1589
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289742
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs VICE-2151
flag=react_inbox
Test Plan:
1. Open react inbox
2. Navigate to a Submission comment
3. MAke a reply
4. Verify that new comment appears at the top of the thread
5. verify that the submission item on the left updates the submission count
Change-Id: I301b8c0d7618b53e6bdd1e860baebed281539fd2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289696
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
need to add specs to module.test.tsx to test
merging assignments and blackout dates
closes LS-3097
flag=course_paces
flag=course_paces_blackout_dates
test plan:
- go to a course pace
- shrink the screen to ~320px
- have a couple assignments
> expect it to look good
- add blackout dates that are between assignment
due dates.
> expect the blackout dates to show up in the table
in the right order by start date/due date
- shrink the screen so the display gets stacked layout
> expect it to still look good
> expect the blackout dates row not to have a
status entry
- create a blackout date with a long title and no
spaces
> expect the title in the row in the assignments table
to wrap when the browser gets narrow
Change-Id: I52694394d3227aa6b2efc2533ed3dc292e00d9e5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289317
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
refs VICE-2151
flag=react_inbox
Test Plan:
1. Open react inbox
2. Verify that the conversation compose modal looks the same
3. Verify that the conversation compose reply modal looks the same
4. Verify that the compose modal still sends correctly for conversations
5. Open Submission comment
6. Click on reply to thread
7. Verify that submission title appears in compose modal
8. verify that only body input is available.
9. verify that the cancel and send button appear
10. create a comment and click send
11. refresh the page.
12. verify that the new comment appears
Exclusion: Cache will not update in this commit.
Change-Id: I079b16ccbb078b213f51ff2020780f035702d63d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289524
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
closes LS-3113
flag=course_paces
flag=course_paces_blackout_dates
test plan:
- in a course with a pace plan and no blackout dates
- add a blackout date
> expect to see "1 unpublished change"
> expect the publish button to be active
- click it
- edit blackout dates, deleting one and adding one
> expect to see "X unpublished changs" where
X = number of deltees + number of adds
Change-Id: I136028f752869c4120995bcd655bda176cbc03f7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289633
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes LS-757
flag=none
test plan
- Verify Mastery Path is no longer in Feature Options
- Verify the setting is there on the account settings
- Verify that locking it disables changing it for subaccount and courses
- Verify that with the setting on all of mastery path still works
Change-Id: I9ee1b243439eb2eefa35885ecfce0db7589fbe13
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288418
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
Migration-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
test plan:
- shrink your window to a small vertical size
- click a tag in the top table
- the jobs list (focused on the selected tag) should
scroll into view
- click a job id in the jobs list
- the job details panel (focused on the selected job)
should scroll into view
flag=jobs_v2
closes DE-1121
Change-Id: I08c4469cfa033b08b7bd9819b4d75a1cc264337f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289448
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Didn't fail locally after numerous tries.
Jenkins seems fine with it.
Eventually we can get data if it does fail later.
Closes: LS-2243
flag=none
Test Plan: Consistently pass jenkins
Change-Id: Ibf151511935cee465333cca09e1cfd47205d0d34
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289540
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
Jason