ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
33,948 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

7 Commits

Author SHA1 Message Date
Cody Cutrer 7090d7675c rails 5.2: s/success/successful/g 
Change-Id: I5d5c67cd659dfad035dfb5415549a8924b66fabc
Reviewed-on: https://gerrit.instructure.com/159211
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
 2018-08-06 15:03:41 +00:00
James Williams 45147e0911 bypass the wiki model as much as possible for wiki_pages 
Change-Id: I60ec3b519219fcb5256a132c05f63538600df73f
Reviewed-on: https://gerrit.instructure.com/121760
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
 2017-08-09 16:09:06 +00:00
Landon Wilkins 0ce4a23f58 da licença part 46 
add consistent license headers to all source files

Change-Id: If9d3b01addc4fd9c2977bf2402dda57ec622e72f
Reviewed-on: https://gerrit.instructure.com/110151
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
 2017-04-28 17:56:22 +00:00
James Williams 031242d031 strong params part Q 
refs #CNVS-32574

Change-Id: Ifd139bf1e8296370d1d793ceed7c8e2e50440059
Reviewed-on: https://gerrit.instructure.com/94684
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
 2017-01-10 18:20:03 +00:00
Simon Williams 57497719a7 spec: rename the `course` helper to `course_factory` 
closes CNVS-34046

test plan: specs should pass

Change-Id: I8684d30e5af7be04566b2d3903db2b7f4b14b24b
Reviewed-on: https://gerrit.instructure.com/98439
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
 2016-12-27 20:25:29 +00:00
Simon Williams ece65b5a89 spec: rename the `user` helper to `user_factory` 
closes CNVS-34042

test plan: specs should pass

Change-Id: I20709a69f0cb28fb55eba18ca81f89f4d7673b56
Reviewed-on: https://gerrit.instructure.com/98426
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
 2016-12-27 20:25:25 +00:00
James Williams 09b2d1a7f5 touch content after changing course public visibility settings 
also fixes an issue with logging false setting changes

test plan:
* create a course with content (assignments, quizzes, etc)
* set the course as public
* in another browser/incognito window should be able to view the
 content
* in the course settings, turn off the public setting
* refresh the content pages in the other window
* should be unauthorized now (i.e. it didn't cache the setting)

(bonus test)
* enable "Disable comments on announcements" for the course
 (under the more options section)
* after refreshing, save another change to the course
* check the course activity logs in the account admin tools
* should not have logged a false change to the course settings

closes #CNVS-18580 #CNVS-18656

Change-Id: I65e4169ecb158207cd52126c31c52cf93a4a7cae
Reviewed-on: https://gerrit.instructure.com/49165
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
 2015-02-26 12:37:48 +00:00