because apparently they still see these items in the todo list,
and this only makes them reappear overnight after being X'd out
test plan:
- a teacher who sees todo items for a course in which her
enrollment was completed_at > 6 months ago should be able to
get rid of them by clicking X, and they should not reappear
after Ignore.cleanup is run
flag = none
fixes LS-2200
Change-Id: Ic1fe0c3325d6e32ee553b8a0251ea302de33d0c2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264296
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Change-Id: I70825be7ec7e24458afe0c63dc48c5a76158f520
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251150
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes ADMIN-844
Test plan
- WITHOUT to do list dashboard turned on
- Create an assignment, quiz and peer review
for a user
- As the user, go to the dashboard and ignore
the items in the to do list
- As the user, complete the items
- Verify the ignores have been deleted
- As a teacher who can grade one of the
above assignments, go to the dashboard
and ignore the grading remind
- Grade everything for the assignment
- Verify the ignore has been deleted
- Do the above again, but instead
of completing the items, mark the
enrollments as concluded 6 months ago
or deleted 1 month ago
- Run Ignore.cleanup
- Verify the ignores are deleted
- Verify other ignores are not deleted
Change-Id: I867102b62f45706b74156c0c8c2d5733dd12512f
Reviewed-on: https://gerrit.instructure.com/144045
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Mysti Sadler <mysti@instructure.com>
refs #CNVS-32574
Change-Id: I3ba018a7110a7530c9af4a59c97422f626a749b6
Reviewed-on: https://gerrit.instructure.com/99260
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
refs #CNVS-32574
Change-Id: Ied89f6194ea3f63c546b50d056fe7cbe3a038609
Reviewed-on: https://gerrit.instructure.com/94678
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
- ensure ungraded quizzes (survey or practice quizzes)
due in the near future appear alongside graded quizzes
and assignments in the To Do list on the dashboard
- ensure they appear in the correct chronological
position
- ensure they link to the quiz properly
- ensure the X button to remove the notification
works properly
- ensure ungraded quizzes are returned by the API
"TODO items" endpoints for users and courses
when `include[]=ungraded_quizzes` is supplied
and that they appear in the correct chronological
position
closes CNVS-32164
Change-Id: I216140ff9a3cada662c9fc8357de2e0ab0a8fa45
Reviewed-on: https://gerrit.instructure.com/91346
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-1455
test plan:
- create a graded discussion that requires peer review
- the discussion should have a peer review icon in listings
- assign peer reviews to students
- the students should have a peer review link in their
activity stream
Change-Id: I416c876c9e21b5ce2a72c46fceb7a33bdfd3f96e
Reviewed-on: https://gerrit.instructure.com/36459
Reviewed-by: Joel Hough <joel@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: David Josse <david@instructure.com>
fixes CNVS-2200
normalize ignores out of the users.preferences column into
its own table. makes it more performant, and shard safe
test plan:
* add a user as a teacher in courses on two different shards
* set up an assignment needing grading (i.e. have a student
submit an assignment that requires grading) in both courses
* the assignment should show up on the teacher's dashboard
regardless of which shard he's on
* ignore the assignment on your dashboard on one shard
* reload - it should stay gone
* it should also be gone on the other shard
* have another student submit to that assignment
* it should come back on both shards for the teacher
* ignore it, permanently this time
* have another student submit to that assignment
* it should still be gone on both shards
Change-Id: I6646410273c6be05d4b21b29b6ab76feb8e65d0f
Reviewed-on: https://gerrit.instructure.com/17295
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
Cody Cutrer