closes FALCOR-427
Test Plan:
- Automated tests pass
- Regression on planner in Canvas
- The following commits from canvas-planner are added
in this release (in case that helps with testing new stuff)
[1a260a5b76] (Clay Diffrient) Bump version to 1.0.0
[0d743e31c6] (Clay Diffrient) Clear update todo item details when closing the tray
[b694a49c55] (Clay Diffrient) Handle focus management with the to do item tray better
[04322e9ed8] (Ubuntu) [i18n] update locales with new translations
[4df1ae93d5] (Clay Diffrient) [i18n] update english locale with new strings
[f582e8a4e4] (Clay Diffrient) Improve a11y of the update item tray
[018e1ec45f] (Clay Diffrient) Make opportunities popover aria-hide non-popover content
[9f2d288183] (Clay Diffrient) Make to do items show without needing refresh
[84f218acd5] (Jon Willesen) remove course link from to do groups
[cf1b9af0f1] (Aaron Kc Hsu) Fixes Moment Fail Test
[bc8f51a4ae] (Chris Hart) Better line-heights for Planner components
[c5839b7058] (Steven Burnett) allow updating of todos
[64df109598] (Clay Diffrient) Add alerts in places that need them
[f6170ad01a] (Aaron Kc Hsu) To Do items default to 11:59 PM on the front end
[fcf82f31b0] (Ubuntu) [i18n] update locales with new translations
[2c08e5bf92] (Jon Willesen) Revert "show days with nothing planned"
[98cc1bed74] (Aaron Kc Hsu) Change Todo link from black to correct color
[500aff0303] (Ubuntu) [i18n] update locales with new translations
Change-Id: I94aeefd20d3974844da05b0a6dd8e28327a4a790
Reviewed-on: https://gerrit.instructure.com/117081
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Fixes: CNVS-37861
Test Plan:
- Given New Gradebook
- When hovering over all the grid column headers
- Then all ellipses are no longer tipped over
- Rejoice!
Change-Id: Id72559cebd2aa8801597da7684233eb6718b4731
Reviewed-on: https://gerrit.instructure.com/117133
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
the first two rcs flags have been enabled for all hosted accounts
for a long time. we are changing the lable of the 3rd flag and removing the
first two to provide better clarity as we enable the 3rd flag for
accounts.
closes CNVS-37261
test plan:
- go to the feature flags page for an account
- there should only be one rcs flag with an updated message
- ensure that flag is disabled
- editing wiki pages should still have the new sidebar
- high risk area (i.e. quizzes, assignments) should not have the new
sidebar
- enable the flag
- all editors should be using rcs with the new sidebar
Change-Id: I689eb9ebaf4d3a5fc111c231d13861cc28ae5d87
Reviewed-on: https://gerrit.instructure.com/116542
Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
This fixes a small logic error in LatePolicyApplicato that would cause
an undefined method error for NilClass when an assignment was assigned
to some students in a closed grading period and some students in an
open grading period.
fixes CNVS-37774
test plan:
- Have a course in a term with a closed grading period and an open
grading period and three students.
- Attempt to create an assignment. Set the due dates for one student
in the closed grading period and two students in the open grading
period.
- Observe that the assignment was created successfully.
Change-Id: If8e593302c96b7399214cbdf606ea929ff57ad15
Reviewed-on: https://gerrit.instructure.com/116816
Tested-by: Jenkins
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Fixes FALCOR-422
Fixes FALCOR-426
Test Plan:
* As a student
* In a course with Student Planner enabled
* And existing Planner Notes
* GET, PUT, POST, and DELETE from the `api/v1/planner_notes`
endpoint
* The responses should all be JSON formatted correctly and
return string IDs when the `Accept:
application/json+canvas-string-ids` header is passed
* The `GET` index/list endpoint should not return deleted notes
Change-Id: I2435d62e8794aacbd4bb2d9484f9e89170187f4e
Reviewed-on: https://gerrit.instructure.com/116980
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
[ci selinimum capture]
this fixes the post-merge selenium build, which
explodes on every spec w/ "uninitialized constant Cache"
Change-Id: I611925a226c9c83cd1623c31372d6861b8d8f9b8
Reviewed-on: https://gerrit.instructure.com/116951
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Fixes: CNVS-37786
Test plan:
- Go to [COURSE] > Settings > Sections in a course that
has sections
- Verify that the icon links are no longer defauling to
30% opacity
- Verify that there is no longer a gray background when you
hover over the list item containing the title and the
links
Before: https://cl.ly/1F412k15340F
After (rebased on big icon commit for full wow factor):
https://www.screencast.com/t/dcrn9FYiL
Change-Id: I8f72937c722f453d43e646a5dd372bfe4d5801fb
Reviewed-on: https://gerrit.instructure.com/116966
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
closes CNVS-37721
Test Plan
- check to make sure package.json and yarn.lock makes sense
Change-Id: I90a7d47557a0d350d8b424d6e6e5023490d85f1e
Reviewed-on: https://gerrit.instructure.com/116406
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Tested-by: Jenkins
Product-Review: Keith T. Garner <kgarner@instructure.com>
both the course settings page and blueprint were setting up a router to
route to code based on the url, and when you opened the settings page on
a blueprint course, bad things happened. Fixed this by only
initializing the blueprint router if we see "#!/blueprint" in the URL.
fixes: MC-262
Test plan:
setup:
- create master and child courses
- add an app to the master course
then:
- /course/:masterid/settings and click on Apps
> expect ot see your app(s)
- open the blueprint sidebar and open the associations modal, then
click on its close button
> expect it to close
Also, run the test cases from
https://gerrit.instructure.com/#/c/111233/20//COMMIT_MSGhttps://gerrit.instructure.com/#/c/114008/8//COMMIT_MSG
to be sure the URLs that automatically open the modals still work
Change-Id: I0bb24c12a455dff2c6fe544b54a56aa69096484b
Reviewed-on: https://gerrit.instructure.com/116555
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Tested-by: Jenkins
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Fixes: CNVS-37057, CNVS-37327
Refs: CNVS-37056
test plan:
- navigate around canvas to ensure the icons are aligned
and showing correctly :D
- overall note - icons are now the "line" version vs the
solid (with this implementation the assignments and
modules pages have removed the circle with background color
for better legibility for the icon)
- the overall base font size for canvas has been increased
to 1rem = 16px (there are still areas that have overriding
css to manipulate the font size smaller than the base and
can be addressed individually)
- this bumps inst-icons to a beta version for testing
Change-Id: I5ef389298257122f0c3016e97beff50ed8925df1
Reviewed-on: https://gerrit.instructure.com/114343
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
The old flashError is not screenreader accessible so this patchset
replaces flashError with FlashAlert.
fixes: CNVS-37550
test plan:
- Given the Grading Period Set Page
- Given an open New Grading Period Set Form
- When the Create Button is clicked
- Then a flash alert is displayed
- Then the flash alert is read by screenreaders
Change-Id: Ia475c3abc9b8a21775500a3d37e5b516508c0bc2
Reviewed-on: https://gerrit.instructure.com/116453
Tested-by: Jenkins
Reviewed-by: Matt Taylor <mtaylor@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
we only want to still include the current region, not every single
database
Change-Id: I8a03124b3996ed20bcef55709d31891d9d37c8ec
Reviewed-on: https://gerrit.instructure.com/116941
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fixes: CNVS-37549
test plan:
- Given grading period sets page
- Given a screenreader is on
- When filtering periods with the search box
- Then the flash notification for number of results
no longer interrupts other messages
Change-Id: Ife9589a09834d6bad2ca6371de79ad7aa66559bc
Reviewed-on: https://gerrit.instructure.com/116652
Tested-by: Jenkins
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Reviewed-by: Brian Park <brian@siimpl.io>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
Fixes: CNVS-35833
There is a lot more than just moving to Consul going on here. The whole
PrefixProxy business wouldn't be required for this change, but it will
be really useful as we move to adding cluster awareness.
Test Plan:
- Have MathMan running
- Update config/consul.yml to enable use_for_svg and
use_for_mml under the math-man init values key
- Start Canvas
- Build an equation with the rich content editor
- The equation should be rendered as usual.
Change-Id: I650527ebaecb6224c6ee6ba26346d27dee33b9d7
Reviewed-on: https://gerrit.instructure.com/111543
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Tyler Pickett <tpickett@instructure.com>
fixes CNVS-37803
test plan
- call destroy with replace on user attachment
- it should work if caller has permission to
masquerade as the attachments owner
Change-Id: Id74c37bfa5c2d775ba0d4d091b0fced3a05cd062
Reviewed-on: https://gerrit.instructure.com/116904
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
if the slave is behind, it would cause the report to fail immediately
Change-Id: I7b92c05d8bafcbd6f554b8095dd70fcbb2911a6e
Reviewed-on: https://gerrit.instructure.com/116902
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
refs FALCOR-210
Test plan
- Ensure the new user tutorial feature is on for all new users
Change-Id: Iba1ae69526ab4e6c8776cfb175940cc1614a99f7
Reviewed-on: https://gerrit.instructure.com/116894
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Mary Jane Anderson <manderson@instructure.com>
Closes FALCOR-391
Test Plan:
* As a student
* In a course with Student Planner enabled
* GET /api/v1/planner/items
* The response should be returned in order by the objects'
due dates, todo dates, or posted dates
* GET the next page (bookmark) of results
* The response should continue in the same order
Change-Id: Ic0b6ed8f51551ff8839cc11913e94b26709bc0c7
Reviewed-on: https://gerrit.instructure.com/116478
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
closes CNVS-37800
test plan:
* Ensure specs pass
Change-Id: I3b070b131f60c8437c4e7e79aba6d5f0e6a6ccea
Reviewed-on: https://gerrit.instructure.com/116879
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
QA-Review: Keith T. Garner <kgarner@instructure.com>
closes CNVS-37800
test plan:
* Create a course with multiple grading periods and at least one
student enrolled in it and at least two assignments, one in
each GP
* Ensure the grading periods have "show total for all grading
periods" unchecked
* Go to Gradezilla
* Show the Grading Period filter and choose "All Grading Periods"
* Reload Gradezilla
* Verify you don't see any total column and the filter continues
to say "All Grading Periods"
* Switch to another grading period
* Verify you do see the total column now and the filter says the
name of the grading period
* Verify the assignments are filtered to just the ones that
belong in that grading period
Change-Id: I09c1a7f336cbd141442179aad1c2d3cae0ae5af0
Reviewed-on: https://gerrit.instructure.com/116871
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
This was causing some warnings to show up because this triggered
ApplyTheme to be called which should not be the case when canvas-planner
is used within Canvas.
closes FALCOR-396
Test Plan:
- Enable planner
- It should load fine
- Enable High Contrast Mode
- It should load properly
Change-Id: Ief193f2bf72c0badc503579a61f2c61909398320
Reviewed-on: https://gerrit.instructure.com/116662
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Pert Eilers <peilers@instructure.com>
fixes CNVS-37775
test plan:
* visit gradebook for a course with multiple sections
* enable visibility of the section filter
* ensure all students are visible when "All Section" is selected
* ensure selecting sections filters out unrelated students
Change-Id: I5bc0afd2dd8402bb31a806089bf43389d3b3de96
Reviewed-on: https://gerrit.instructure.com/116862
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Neil Gupta <ngupta@instructure.com>
the new version of the rce and skin no longer incorrectly display the
font size of text in tables. many of the canvas style overrides have
also been moved to the skin and are no longer needed in canvas.
the initial push of this fix broke several rcs selenium tests due to a
circular destroy chain. https://gerrit.instructure.com/#/c/116660/ fixes
that and has been published to npm as v2.2.0-alpha.1. we should test this
patchset against that npm version
fixes CNVS-37517
test plan:
- run yarn install first to get new dependency versions. canvas-lms should
be version 2.2.0-alpha.1
- test rcs and legacy editors
- insert a table, type in a cell, text should be same size as outside
the table (shows as 11pt in toobar)
- test the toolbar nav with and without high contrast (alt+f10)
- toolbar styles should match colors and have a triangle under for
active state, and a border for focus state, and both when focusing
on an active button
- create a discussion thread
- add a reply to the discussion thread
- edit the reply to the discussion thread
- verify that this works and has no console errors
Change-Id: I7e8696cf54afda6de08fa729452f14fc1868510a
Reviewed-on: https://gerrit.instructure.com/116036
Tested-by: Jenkins
Product-Review: brian kirkby <bkirkby@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Closes FALCOR-233
Test Plan:
* Go to Account->Settings->Feature Options. There should now not
be any setting for "Duplicate Objects"
* It should still be possible to duplicate assignments and wiki
pages (except for discussion topics and quizzes)
Change-Id: Ib75ebdbc7852e1e11e455e4c72633b6bc9d64385
Reviewed-on: https://gerrit.instructure.com/116813
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
refs PLAT-2647
test plan:
• using an lti2 JWT
• create several hundred subscriptions
• do a GET request to /api/lti/subscriptions
• expect to see a list of subscriptions up to the default limit of
100 per result set
• look for an 'EndKey' header and put that value in your next request
as a header field called `StartKey`
• repeat this process until you have fetched all pages
Change-Id: I74c4029a245716a1f4bc6648348f52426d447e9b
Reviewed-on: https://gerrit.instructure.com/116795
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Product-Review: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
this is working and has a spec, but it is using it wrong
this makes it user it better
Change-Id: I966167664e24b5bbff32d5afc367245ed8ad634c
Reviewed-on: https://gerrit.instructure.com/116708
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
closes CNVS-36725
Test Plan:
1. Create a new course
2. Add a "Homework" assignment group to the course
3. Create two assignments in each assignment group
4. Enable "New Gradebook" for the course
5. Make sure grading period and module filters are set
to their default settings (no filtering)
6. Navigate to the gradebook; no filter dropdowns
should be visible, all assignment columns visible
7. Check "Filter > Assignment Groups" under "View";
dropdown should appear with "All Assignment Groups"
8. Select "Assignments" from the dropdown, only
assignments in the selected group should be shown
9. Select "Homework" from the dropdown, only
assignments in the selected group should be shown
10. Uncheck "Filter > Assignment Groups" under "View";
The assignment group dropdown should disappear, but
only the "Homework" the assignment columns should
be shown.
Change-Id: I834571a9423d4c885c894cd2855cb9aa79059b9f
Reviewed-on: https://gerrit.instructure.com/115250
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes CNVS-37703
test plan
- it should not say expired.
Change-Id: Ib42bec23749ab0e0d825ab9c6f934cd3f1b93bc0
Reviewed-on: https://gerrit.instructure.com/116702
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
* Closes FALCOR-139
* Closes FALCOR-140
* Closes FALCOR-141
Test Plan:
* Create a course, and make a wiki page.
* If "Duplicate Enabled" feature option is set, then a duplicate
option should occur on the cog next to the page you created.
* When this is clicked, a new page should pop up below unpublished,
with focus on the cog of the new page.
* (If you make a page that is an assignment, the new page will also
show up on the assignments list)
* A student should not be able to see this option, and if the
feature flag is off, this option also should not appear.
* A wiki page assignment can now also be duplicated from the
"Assignments" list as well.
* Discussion and Quizzes still cannot be duplicated from the
"Assignments" list
* Title convention: If title does not end in "Copy" or "Copy #"
will append "Copy" to the end of the title.
* After doing the above, finds the lowest number that doesn't
duplicate an existing assignment or wiki page name (if a number
is needed to effect this)
* In the above search, if a "#" is present on the title, *always*
starts from the # given. So "Copy 7" will go to "Copy 8" even
if 1-6 are not used.
Change-Id: Ib595a859b9186f934626b56e94a00eea231baa5a
Reviewed-on: https://gerrit.instructure.com/115934
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Mary Jane Anderson <manderson@instructure.com>
fixes CNVS-37717
test plan
- run sis import that would generate errors
- the json for the import api should have an
errors_attachment object
- the ui should have a download file option
Change-Id: I2c6f94b601be5777b8a57f4b5b56f9f2215869ec
Reviewed-on: https://gerrit.instructure.com/116523
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
refs CNVS-37717
test plan
- run sis import that would generate errors
- in console it should have an errors_attachment
- the attachment should contain all the errors
Change-Id: I8e76d29395047b1ee743e42394432baea27d7c3a
Reviewed-on: https://gerrit.instructure.com/116522
Tested-by: Jenkins
Reviewed-by: Tyler Pickett <tpickett@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes: CNVS-37602
Test Plan:
1. Navigate to GradeZilla
2. Open an assignment column header menu
3. Press keys while the menu is open
- When you press TAB:
Observe that the menu closes and the next item
in the normal grid navigation flow is focused
- When you press SHIFT+TAB:
Observe that the menu closes and the previous item
in the normal grid navigation flow is focused
- When you press ESC:
Observe that the menu closes and the menu trigger
is focused
- Other keys should behave as before
a. up/down arrow keys focus menu items
b. left/right arrow keys expand/collapse flyouts
- Nested flyouts should also trigger navigation upon
these key presses
4. Select a menu item
- If a modal appears:
a. Observe that the focus is placed within the modal
b. Observe the header menu trigger is refocused
when the modal is closed
- If a modal doesn't appear:
a. Observe the header menu trigger is refocused
5. Repeat 2-4 with all column header types
- Assignment Group column headers
- Student column headers
- Total Grade column header
Change-Id: I7cd50a5bc2c598b5bf899f7a5d17998fc4f4ec04
Reviewed-on: https://gerrit.instructure.com/115864
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
Reviewed-by: Sheldon Leibole <sheldon@siimpl.io>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Edit some spec numbers in other specs,
clean some code.
add dropdown specs.
Patch set 22: ALL HAIL GERGICH
Change-Id: Iaaddae9a2d75e28284f940d93fbee12c240bd77c
Reviewed-on: https://gerrit.instructure.com/116272
Tested-by: Jenkins
Reviewed-by: David Tan <dtan@instructure.com>
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
The "Unposted" menu item is now only shown in New Gradebook if the
New Gradebook Development feature flag is enabled.
closes CNVS-37763
Test Plan:
1. In a course that has the "New Gradebook" feature enabled and the
"New Gradebook Development" feature disabled at the account-level,
go to the gradebook.
2. Click on the menu toggle in an assignment header cell. Click on
"Sort by". Verify there is no option for "Unposted" in the
flyout menu for "Sort by" options.
3. Enable "New Gradebook Development" at the account-level. Go to the
gradebook.
4. Click on the menu toggle in an assignment header cell. Click on
"Sort by". Verify there is an option for "Unposted" in the
flyout menu for "Sort by" options.
Change-Id: I091971741ad0b585218827153744a716e899fb5b
Reviewed-on: https://gerrit.instructure.com/116750
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
refs CNVS-37743
Test plan:
* Create a course with an assignment and a student
* Mark the student as inactive
* Mute the assignment
* Grade the student
* Unmute the assignment
* The score in the backend should match the student's grade in the GB
Enrollment.find_by(course_id: <course_id>, user_id: <user_id>).computed_current_score
Change-Id: Ifa7f3c7c1b6880eb5e9114878fee5a3579343384
Reviewed-on: https://gerrit.instructure.com/116651
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Clay Diffrient