Commit Graph

17 Commits

Author SHA1 Message Date
Sterling Cobb 3d0f54bfc4 Fix h tag ordering on a few pages
fixes #CNVS-3553

When you view a page in canvas, the h tags (ie: h1, h2, h3) can be out
of order. This is bad for accessibility reasons as well as html
symantics. This commit fixes most of these problems by remove h tags in
places we don't need them as well as helping to fix the order on some h
tags. Extra styling was also needed to get his to work.

Test Plan
1. Visit the follow pages and make sure there are no styling items
broken.
  * http://localhost:3000/about
  * http://localhost:3000/courses/123/collaborations
  * http://localhost:3000/courses/123/discussion_topics
  * http://localhost:3000/courses/123/discussion_topics/456
  * http://localhost:3000/courses/123/announcements

2. Headers should also be in order for these pages not skipping any
numbers. For instance, you can't have h1, h2, h4 it must be h1, h2, h3,
h4. You can test this by opening the console in the browser and running
this jquery command $('h1, h2, h3, h4, h5, h6')

Change-Id: I8017e335d52850a44ecef974b8e0722a3f768c37
Reviewed-on: https://gerrit.instructure.com/17489
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams  <jamesw@instructure.com>
QA-Review: Bracken Mosbacker <bracken@instructure.com>
2013-02-08 15:52:05 -07:00
Ryan Shaw 713d0b8c91 replace all .button(s) with .btn
in order to not have to support buttons with .ui-button AND
.button AND .btn classes this simplifies and and makes our
codebase more consistent by deprecating the .button class
with .btn

Change-Id: I4802d785a47b36aa477f302e6ac8c87715db8a62
Reviewed-on: https://gerrit.instructure.com/15194
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
2012-11-14 13:29:30 -07:00
Ryan Florence 15bdef7fec new profile page closes #9369
users have a new profile page that displays a
custom bio, links, and contact methods as well as
how the viewing user knows them.

this profile can be a part of any page and is
displayed on the user in a course pages as well.

profiles are found at /about/:user_id

Change-Id: I3339144135d67415af9068d18776b691320c1938
Reviewed-on: https://gerrit.instructure.com/12298
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
2012-07-27 10:56:10 -06:00
Ryan Shaw 05dd27b7d2 fix user and group profile styles that got ruined
Change-Id: Ieaee3f77c197e6875ba23c8cb0c31d7098fcbc00
2012-06-22 12:06:57 -06:00
Cameron Matheson 55297d05d3 profile page: use old-style canvas layout
Change-Id: Ie0a2f074c3a8b498195f7c9508e9e33a2db90d72
2012-06-07 15:20:30 -06:00
Cameron Matheson 6fd1e62fb2 use button class on buttons
Change-Id: I5206c3a37c8e32882f23d72c84dbecb3a4a0c8ff
2012-06-07 02:07:28 -06:00
Cameron Matheson 1e92f50ce2 show followers count on user profile page
also fixed a problem with the display logic on the follow button

Change-Id: Ia74de0fd58fd960eaa69349c5ce872fdc37e753f
2012-06-06 10:30:31 -06:00
Cameron Matheson fe6bbe053b make follow user button work
Change-Id: I320125172c6b28be910feadeda31f1bb61fdc4c5
2012-06-06 10:07:09 -06:00
Cameron Matheson 09294efe56 profile page: only show social section when there are links to show
Change-Id: Ife724bff5ac5fb39d27a338a087e4f441a33004a
2012-06-04 18:08:04 -06:00
Cameron Matheson 3a42384d2b profile page: don't break if bio is nil
Change-Id: Ib5330e9744e1f7107f522cfe328ddb91686b52a2
2012-06-04 18:06:07 -06:00
Cameron Matheson 98734b8bbc social links on profile page
Change-Id: I4eb5a817394dd4a7a0aee1d7663c6cead8309aea
2012-06-04 17:36:44 -06:00
Cameron Matheson fa47409374 user profile tweaks
- fix active tab issue in sidebar on group settings page
- stats table is now composed of followers, collections, collection
  items

Change-Id: I88df0001b1cdffcb7f92e7b365b3ae00880f72e8
2012-06-04 17:24:27 -06:00
Cameron Matheson 1f75a5ba26 profile: use text helper for better bio formatting
Change-Id: Ifa9a8983e0089a434d5d3c995dbe65372eaa373d
2012-06-04 17:24:27 -06:00
Cameron Matheson 4876273811 add sidebar to user's own profile page
this includes a new application layout (new_application) for pages that
need a sidebar

Change-Id: I621c66d30be3f2213dff20929c6d96b0573251c6
2012-05-24 15:22:42 -06:00
Cameron Matheson 7ba9aa52fc limited levels of profile viewing
Change-Id: I527eaf6de5d0e7e22e37d67c5773d2f6e8925b61
2012-05-24 15:20:16 -06:00
Cameron Matheson 4258654adf responsive profile bio
Change-Id: I490b7bd9feff86239917d3158442f66a56f32930
2012-05-18 11:01:01 -06:00
Cody Cutrer f41047c61a account setting to disable name editing fixes #5851
also rearrange account settings slightly so that stuff that doesn't apply
to non-root accounts doesn't show for them

Change-Id: I568887a30cbf923c976e7c5bbac1036bb8e88659
Reviewed-on: https://gerrit.instructure.com/6012
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
2011-10-10 10:59:08 -06:00