Commit Graph

13 Commits

Author SHA1 Message Date
Spencer Olson 75e5d4da31 add filters to submissionsConnection for enrollment state
closes EVAL-3897
flag=none

Adds the include_concluded, include_deactivated, and
apply_gradebook_enrollment_filters filters to the submissionsConnection.
These filters allow for submissions belonging to concluded/deactivated
students to be returned.

Test Plan:
- specs pass

Change-Id: Ie6b6fa213a2d31d3c60fef5ce75c28bb6107b295
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337515
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
2024-01-19 17:02:29 +00:00
Jason Gillett 1519970bd4 Update the submission_search so that it can take a user_id
the user_search required 3 characters, however the grade summary
needs to be able to query ids that have less than 3 characters

flag=restrict_quantitative_data
refs VICE-3566

Test Plan
1. Create a course with a student
2. Verify that as a teacher you can look up the student's submissions
3. User graphiql and the user_id filter

Change-Id: I5676c72e4e3351404251d1c815d4f5e11ed4f607
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321045
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
2023-06-22 16:17:02 +00:00
Jason Gillett 530c94b9d5 Allow observers to search their associated user submissions
refs VICE-3566
flag=restrict_quantitative_data

Test Plan
1. Create a course with an observer and student
2. Link the observer to the student
3. Verify that as the observer you can see the student's submissions
3a use graphiql to test this

Change-Id: Iecd133f3e492e9f566792cae221f187ccf6e36d5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321019
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
2023-06-21 18:34:23 +00:00
Cody Cutrer b2b0bff902 rubocop: Style/TernaryParentheses, Style/RedundantParentheses
[skip-stages=Flakey]

Change-Id: I8d860eedd8b199ed3adf0e2bf9162b43096c5347
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315130
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-04-12 14:56:48 +00:00
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2021-11-25 14:03:06 +00:00
Cody Cutrer 8d4fee2d25 RuboCop: Style/RedundantAssignment
[skip-stages=Flakey]

auto-corrected

Change-Id: I73517db1000afa49b81fdd4f40d610faa760e6ff
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277967
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-11 17:39:20 +00:00
Cody Cutrer c65d57737a RuboCop: Layout lib
Change-Id: I0655d9a9d750f2debd6378b03d8ddc1403ebc31b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274158
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-22 20:01:52 +00:00
Cody Cutrer 06763dd519 add # frozen_string_literal: true for lib
Change-Id: I59b751cac52367a89e03f572477f0cf1d607b405
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251155
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2020-10-27 20:49:50 +00:00
James Williams cb4950c704 fix submissions search scope for unpermissioned users
test plan:
* should not throw a 500 error viewing an assignment
 as an invited user

closes #WOKE-42

Change-Id: I5da5cc1203680ad580dc93490b399cb46d9da396
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/217052
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
2019-11-13 21:31:32 +00:00
Cameron Matheson e30dc49859 graphql: use Course#users_visible_to in submissionsConnection
Test plan:
  * create a course with multiple sections and section-limited teachers
  * make submissions for students on an assignment
  * conclude a student's enrollment
  * when querying the assignment's submissionConnection:
    * only students belonging to the same section as the teacher should
      be returned
    * submissions belonging to concluded enrollments should not be
      returned

closes GQL-86
flag = none

Change-Id: Ie5244e368644b9ad6e3357d9e0f3e2bec8898a54
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/216038
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Cameron Matheson <cameron@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins
2019-11-05 23:20:33 +00:00
Matt Sessions eec763a245 Add grading status filter to submissions connection
refs: MBL-12809

Test Plan:
 - Create an assignment with a submission that needs grading, and
   a submission that is already graded
 - request submissions for the assignment through gql using the
   gradingStatus filter for needs_grading
 - It should return the submission requiring grading and
   not the other one

Change-Id: I2ac6b7e95819122d085898255a352a002aefa9f7
Reviewed-on: https://gerrit.instructure.com/202156
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Matt Sessions <msessions@instructure.com>
Product-Review: Matt Sessions <msessions@instructure.com>
2019-08-06 16:27:32 +00:00
Matt Sessions cf51fa972b Add fields and filter for mobile submission list to graphql
Test Plan:
 - late, missing and gradeMatchesCurrentSubmission should all be
   available on a submission in graphql
 - Filtering the submission connection by late should work in graphql

Change-Id: I603b81964ad57833009e741f47cca1023eac370e
refs: MBL-12809
Reviewed-on: https://gerrit.instructure.com/201349
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Matt Sessions <msessions@instructure.com>
Product-Review: Matt Sessions <msessions@instructure.com>
2019-07-19 19:56:06 +00:00
Jon Willesen 388bc15684 A2: add user search to submissions in graphql
This adds a bunch of search options to the assignment
submissionsConnection in graphql. Not all of the potentially needed
orders and filters are implemented, but this gets the basic concept and
the simple stuff implemented.

closes ADMIN-2324

test plan:
- go to the graphiql interface and query an assignment and its
  submissionsConnection. You should see a bunch of options in the filter
  input of the submissionsConnection.
- try out all the filters and orders and see that you get the results
  that you'd expect
car
Change-Id: I541e333dc544f2258c9c2359124bac0d24277abc
Reviewed-on: https://gerrit.instructure.com/184727
Tested-by: Jenkins
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
2019-04-05 19:56:42 +00:00