ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
61,098 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

9 Commits

Author SHA1 Message Date
Drake Harper b6debfc9fb Data fix up for Conversation/ConversationParticipant 
closes VICE-3336
closes VICE-3337
flag=none

Test Plan:
 - specs pass
 - migration runs locally to fix applicable data

Change-Id: Ie29956836e3a9e8f4dd0a354b8c42175d9ee83c6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/311446
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Jason Gillett <jason.gillett@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2023-02-17 19:17:24 +00:00
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
 2021-11-25 14:03:06 +00:00
Cody Cutrer c776b6ef3a RuboCop: Style/CommentAnnotation 
[skip-stages=Flakey]

auto-corrected

Change-Id: Ic82dbc22b8e63cc5f2ccb9b561cb3b9ed6628966
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279100
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
 2021-11-21 00:50:46 +00:00
Cody Cutrer 2b1dc0b9ea avoid usage of Shard#activate! 
and prevent it in test env (it's still useful in console and scripts for
dev and prod)

Change-Id: Iaf77dc91c5fff226eebaf23a3b3cb9c2c4af8b94
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275236
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2021-10-06 15:19:03 +00:00
Matthew Lemon 5c39a6938c handle MRA in graphql audit log 
fixes VICE-1022
flag=none

TEST PLAN:
- specs pass

Change-Id: Ifb8b19003ce83ca10e05a082270d4e1dd657dea3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/254661
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-03-31 18:41:04 +00:00
Cody Cutrer 06763dd519 add # frozen_string_literal: true for lib 
Change-Id: I59b751cac52367a89e03f572477f0cf1d607b405
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251155
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2020-10-27 20:49:50 +00:00
Matthew Lemon f567028eed add conversation improvements 
add a comment about root account ids being relative to the birth shard
and update some of the references to root_account_ids to use the
attribute rather than the helper function

fixes VICE-662
flag=none

/ ---- ---- \
| Test Plan |
\ ---- ---- /

- specs pass

Change-Id: If0397da0350ba74d336ee28de14abfddf69b35bb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/243998
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2020-08-03 15:51:14 +00:00
Matthew Lemon c7247d3efd ensure that root_account_ids are sorted 
fixes VICE-575
flag=none

/ ---- ---- \
| Test Plan |
\ ---- ---- /

- specs pass
- create a conversation
- add some additional root account ids to it
- verify that the root_account_ids are sorted

Change-Id: I3b603ae6a9b390cb22b8acb6517db8fefa69c812
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240965
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2020-06-23 20:49:41 +00:00
Matthew Lemon ec8040c720 update root_account_ids on conversations tables 
fixes VICE-341
flag=none

/ ---- ---- \
| Test Plan |
\ ---- ---- /

- Create a conversation
- Grab that conversation and add another root account id to it
  - c = Conversation.last
  - c.root_account_ids = [1,2] # assumes normal account and site admin
  - c.save!
- Check that the conversation participants root_account_ids now includes
  the added root_account_id
  - c.conversation_participants.first.root_account_ids
- Check that the conversation messages root_account_ids now includes the
  added root_account_id
  - c.conversation_messages.first.root_account_ids
- Check that the conversation message participants root_account_ids now
  includes the added root_account_id
  - c.conversation_message_participants.first.root_account_ids

Change-Id: I949bd25001d18303d6e79bd07dc7d3494166b84c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240730
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2020-06-19 23:39:34 +00:00