fixes CNVS-5495
test plan:
- go the the student grade page
- the assignment group and total columns background color should extend all the
way to the right
Change-Id: I7def811e98d7061967a366510d0d0892459d04ca
Reviewed-on: https://gerrit.instructure.com/20016
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
closes CNVS-4663
Test plan:
* load the student grades page
* the tooltip in the final grades column and assignment group columns
should read "N / M" instead of "Percent"
Change-Id: I7417512f385937ee753900f95fee3e404a634f1b
Reviewed-on: https://gerrit.instructure.com/19945
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
all the quiz api actions were checking tab_enabled? but it is possible in
canvas to be able to take a quiz even if the quiz tab is disabled (for example,
if it is linked to from a module), so to better mirror that behavior, only the
index action should care if the tab is enabled or not.
fixes CNVS-5473
test plan:
- create a course with some quizzes, and disable the quiz tab
- as a student, /api/v1/courses/X/quizzes should be a 404
- but /api/v1/courses/X/quizzes/Y should return the quiz object
Change-Id: Icbfb1850e1294784b2a3cf2783b5b2f5dedd491f
Reviewed-on: https://gerrit.instructure.com/19976
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-4932
test plan
- on the calendar, start adding an event
- ensure that screen readers pick up the labels for each editable
field on both the event and assignment tabs
Change-Id: I104fda9a49fe777e3e9a80f5825e245f37469cb7
Reviewed-on: https://gerrit.instructure.com/19541
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Ericksen <marke@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
fixes CNVS-5486
test plan:
- generate api docs and navigate to them
- go to assignments in the left nav
- the index at the top of the page should be split into two sections
Change-Id: I1680d19508cf84f735e6e257fdfbcaf2affcae21
Reviewed-on: https://gerrit.instructure.com/19998
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-5466
rather than special casing 0 questions and saying "No Questions", just say
"Questions: 0" since this should be an extremely rare case for students.
test plan:
- publish a quiz with zero questions
- view it as a student
- it should say "Questions 0", with "Questions" bold
- it should be spaced properly
Change-Id: Ieefd666aa0eda58972aa600a3b78616de8caab12
Reviewed-on: https://gerrit.instructure.com/19953
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan:
* create a media comment, either uploading a file
or recording a video
* the video thumbnail should show the "play" symbol
overlayed on top right away, and not just when
hovering over it
fixes #CNVS-5246
Change-Id: Iab5e4fd7cc048596d6d443341e9164ab0e588097
Reviewed-on: https://gerrit.instructure.com/19947
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
prevent malicious or accidental html content from getting through (e.g.
via translations or interpolated user content).
slight refactor in message.rb to make it more easily testable
test plan:
1. spot check html emails, make sure they look ok
2. ensure you can't get arbitrary html into an email, e.g.
1. change your name in canvas to "<b>ZOMG</b>"
2. send someone a message in canvasations
3. check the html email that got sent to them. your name should appear
as "<b>ZOMG</b>", and not "ZOMG" in bold text
Change-Id: Ie638a0d3d28427f25c0fa1ce89c10533802b0c6b
Reviewed-on: https://gerrit.instructure.com/19827
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
make i18n:check reject anything that looks html-y, since we should be
using wrappers (or markdown) instead
test plan:
1. generate the following emails and confirm that the html version is ok:
* content_export_failed
* content_export_finished
* merge_email_communication_channel
* migration_export_ready
* migration_import_failed
* new_context_group_membership
2. go to the quiz detail page as a student and confirm it loads/looks
correct (specifically where it says the number of questions below the
title)
Change-Id: I0b8bfb0628a081859915c33764bfc3ce49690e8d
Reviewed-on: https://gerrit.instructure.com/19823
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
fixes CNVS-5462
test plan:
- enable 'no enrollments can create courses' at the root acount level
- create a new user with no enrollments
- they should have a 'create course' button on the dashboard
Change-Id: Ic1c272c7e949b25365141c04c65b3cff5b47a6ed
Reviewed-on: https://gerrit.instructure.com/19944
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
QA-Review: Bryan Madsen <bryan@instructure.com>
FIXES CNVS-4942
The problem statement for this ticket was that
answered questions could only be seen as
answered in the right column because of the
color change, which is insufficient for
accessibility.
This patch uses icons to differentiate between
answered and unanswered questions.
TEST PLAN:
1) login as a student to a course where you
have a quiz to take
2) while taking the quiz, look at the right
column
3) the icon for questions you've already answered
should be a checkmark
Change-Id: I5ec289acda00aa9e14ef49e387c8756883424c0a
Reviewed-on: https://gerrit.instructure.com/19456
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Dana Morley <dana@instructure.com>
Also refactors some parts of the rescue action
Test Plan:
- as a visitor who is not logged in, go to a page such as
/users/2/files/thisoneisfake and it should not show user 2's
name in the breadcrumb
Fixes CNVS-5393
Change-Id: I3e8e6ba13b53645b4a6e624a0cb691db9d840f69
Reviewed-on: https://gerrit.instructure.com/19835
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Duane Johnson <duane@instructure.com>
specifically links the visibility of the permission
:manage_frozen_assignments to whether or not
the plugin :assignment_freezer is enabled
test plan:
* enable the assignment_freezer plugin
* confirm that ""Manage (edit / delete) frozen assignments"
is shown in the list of account permissions
* disable the plugin
* confirm that the permission no longer is shown
closes #CNVS-5207
Change-Id: I4cd308531a057356bd335e134348c63b92868775
Reviewed-on: https://gerrit.instructure.com/19788
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
fixes CNVS-5248
test plan:
- start taking a one-question-at-a-time quiz
- log out in another tab
- hit the next or previous button
- re-login
- you should land back in the quiz
Change-Id: I578d6803bd6deb90ec3c82153d999b478e42a199
Reviewed-on: https://gerrit.instructure.com/19539
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
closes CNVS-5189
test plan:
1. go to /courses/:course_id/users
- observe the beautiful avatars
Change-Id: I1b0b6f32efe0e174e7554f48f1eca7631091e1c6
Reviewed-on: https://gerrit.instructure.com/19766
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
fixes CNVS-3187
test plan:
- make sure student show page 'submission types' heading still works
- make sure masquerading still works
Change-Id: Id177d3266b42caa7bd7b83354ec3ad400ce3ce8d
Reviewed-on: https://gerrit.instructure.com/19774
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-5427
test plan:
- in a quiz with a 'multiple fill in the blank' question
- take it with a couple users, and as one, answer incorrectly
- run quiz stats on the quiz
- it should work
Change-Id: Icaad597e6d401651bc3625bf0a5f2f75f31185fa
Reviewed-on: https://gerrit.instructure.com/19848
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Bryan Madsen <bryan@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
also supporting forcing the quiz show page to require a user even in a public
course.
closes CNVS-5250
test plan (api):
- make sure the quiz api returns a mobile_url that sets these parameters
test plan (headless):
- go to a one question at a time quiz
- add ?headless=1 to the url
- notice that the quiz loads without top/side bars
- start the quiz
- the top/side bars are back
- now go back to the show page and add ?persist_headless=1
- start the quiz
- the top/side bars should still be gone
test plan (force user):
- as a logged-out user, go to a quiz show page in a public course
- it should work
- now add ?force_user=1 to the url of the show page
- it should redirect to the login page
- after logging in, you should end up back at the show page
note: please also check that getting notified when logged out of a quiz still
work, as that code was refactored slightly.
Change-Id: Id17ce336f8d12a6f4dd0f4d1324e7b4dd5cca1d0
Reviewed-on: https://gerrit.instructure.com/19597
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
this will be based on an account setting the defaults to false until this
functionality is fully implemented
closes CNVS-1152
test plan:
- first ensure that you cannot add a file upload quiz question by default
- then, in a test account, run the following:
# where ACCOUNT_ID is the id of your root testing account
acct = Account.find(ACCOUNT_ID)
settings = { :file_upload_quiz_questions => true }
acct.save
- then go to add a quiz question again.
- file upload should be a question type.
- make sure creating the quiz works with that question type, comments work,
switching between this question type and others works, etc.
Change-Id: I9b154028290551583cd44a059a5d1c23e247bbf6
Reviewed-on: https://gerrit.instructure.com/19616
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
back-populate submission_versions from existing versions for
submissions, and insert new index rows when new versions for submissions
are created.
refs CNVS-2802
test-plan:
migration:
- have at least two submission with at least one submission with
multiple versions in your database before introduction of this
code
- run the migration
- for every existing submission version record, there should now be
a submission_versions record
- the submission_versions records should have the correct metadata
for the submission version
trigger:
- create a new submission
- should create a new submission_versions record
- modify the submission in a way that triggers a new version
- should create a new submission_versions record
Change-Id: I9c4c39fa60926b037142abf3f01572c9deaa0643
Reviewed-on: https://gerrit.instructure.com/19605
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Duane Johnson <duane@instructure.com>
Product-Review: Duane Johnson <duane@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
SimplyVersioned plugin needs callbacks for the addition of the
submission_versions index table. Whenever a submission version is
saved, we will want to add an entry to the submission_versions table
in addition to the versions table. This patch provides hooks for
those callbacks.
Test Plan:
- Versioned anything should still work
Refs CNVS-2802
Change-Id: I02a862c5894a98ece8a586330f264680751ab52f
Reviewed-on: https://gerrit.instructure.com/19520
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Duane Johnson <duane@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
test plan:
- courses api should return 'unpublished' workflow_state for
courses in 'created' or 'claimed' state
Change-Id: I927cd6d4b66556c1d0762ad16433f69764d6a050
Reviewed-on: https://gerrit.instructure.com/19574
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
note: this currently just adds all the necessary hooks for a new question type,
and is currently disabled while the specific file upload functionality is
implemented.
closes CNVS-1150
test plan:
- should see no change with adding quiz questions, taking a quiz, or viewing
statistics
Change-Id: I3360f00055d1d0c4f9c9703d70590e888cd636d7
Reviewed-on: https://gerrit.instructure.com/19560
QA-Review: Myller de Araujo <myller@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes CNVS-5288
added a couple of fields to appointment group json so that we
don't need all the child events up front
stopped loading all the child events up front
test plan
- ensure scheduler works as before, especially the participant
count under appointment groups on a teachers view and the
signed up for times on a student view
Change-Id: I59d05484b3fdf43fdd38442e37d4a8fa98616f51
Reviewed-on: https://gerrit.instructure.com/19573
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
The Test Student should not appear in the search results list for
courses. In some cases, it may be useful to call the API and include
the Test Student. In these cases, include=test_student will do so.
Test Plan:
- As a teacher, go in to the "student view" for a course
- As a teacher or student of the same course, list students in
the course. There should not be a Test Student in the list.
Fixes CNVS-5335
Change-Id: I7ce5805a795ef2a5d20e002e1e8dcafaabc49390
Reviewed-on: https://gerrit.instructure.com/19745
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Duane Johnson <duane@instructure.com>
fixes CNVS-3124
fixes CNVS-3137
fixes CNVS-3141
fixes CNVS-3155
fixes CNVS-3157
test plan:
* rubrics
- check title of rubrics index page for course/user/account
- check create/update rubric button on individual rubric page
* quizzes
- check that the right sidebar still works while taking a quiz
- check that the 'pick x question, y pts per question' works in view and edit
mode when adding a question group to a quiz.
- check that creating fill in multiple blank questions still works
* grades
- make sure the print grades button still works
- make sure the "Showing: <section" dropdown in gradebook still works
Change-Id: I14379e1b8a4a21327d3db720da0a4e128fda9524
Reviewed-on: https://gerrit.instructure.com/19695
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
fixes CNVS-5403
previous accessibility changes broke styles on the
grade summary page. this commit repairs them.
test plan:
* as a student, navigate to /courses/:course_id/grades
and verify that the grade table displays as expected.
Change-Id: I4c6c89399f9c71d657389df9ccba03fd46b0c2d2
Reviewed-on: https://gerrit.instructure.com/19793
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
QA-Review: Zach Pendleton <zachp@instructure.com>
test plan:
* create an assignment, link an attachment
in the description, and save
* open the assignment editor up again and save it
* delete the attachment and re-upload another
file with the same name
* preview the assignment
* the link should take you to the updated
attachment instead of failing
fixes #CNVS-5216
Change-Id: I7258d4ca35f6d34594bd32bd77e86c2e61262ea4
Reviewed-on: https://gerrit.instructure.com/19594
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
test plan:
- using tinymce, make sure the flickr creative commons image search
still works
- the search input should have "enter search terms" as the default
text.
- as a teacher, update an assignment from the quick edit tool on the
course assignments page. make sure it still works as usual.
closes CNVS-5396
Change-Id: I02a7fc6f2dd13719ac5e63d5549ede3e8fe6f1eb
Reviewed-on: https://gerrit.instructure.com/19760
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
fixes CNVS-5308
test plan
- create a group discussion with more than one group having replies
unread by a teacher
- as a teacher, view the course level discussion
- ensure that the list of groups have badges indicating the number
of unread messages for each group and that the badges line up
Change-Id: I23a221a7812ad60f710ade601a34b8d24b554485
Reviewed-on: https://gerrit.instructure.com/19596
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Eric Berry <ericb@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
fixes CNVS-4562
test plan:
- in a public course, create a practice quiz
- log out
- take the quiz
- it should work
Change-Id: I0e98d6d165622ee58ddc63896d71bad57075a3cd
Reviewed-on: https://gerrit.instructure.com/19602
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
This actually did do the stats generation in the background, but that
has been disabled temporarily since we don't have a front-end UI yet.
Test plan:
make sure you can still download quiz stats csv
closes CNVS-4887
Change-Id: Ia84af0c8392396a054ceba2f6edbcaf7c8c40c90
Reviewed-on: https://gerrit.instructure.com/19397
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
refs CNVS-4887
Test plan:
This isn't exposed anywhere in the UI yet, but if you really wanted to
test this, you could download quiz stats csv for a large course and
watch the progress attached to the quiz_statistics model increase
while the csv was being generated
Change-Id: I0f1d703df38c2525a412414ce767505a6caf157d
Reviewed-on: https://gerrit.instructure.com/19323
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
fixes CNVS-1641, CNVS-3143, CNVS-5356
now it actually works :-/
* fix key getting stomped by iteration of options
* fix double-scoping (explicit and in options)
* fix absolute key bug (they were getting scoped)
* fix camelCased filenames having the wrong scope
* support single-quoted keys
test plan:
1. change your language
2. go to pages where translations didn't show up (e.g. outcomes, calendar2)
3. use optimized js, or tack on ?use_js_translations=1
4. the content should be translated
Change-Id: I9742d60e5dcbccf971ce30b1302e85d4f4033b77
Reviewed-on: https://gerrit.instructure.com/19717
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Escapes the presentation and capturing of grades in gradebook2 to guard
against xss attacks
test plan:
- as a teacher, edit a grade in the gradebook with
"><img src=/ onerror=alert(document.cookie);>
- you should not see an alert
fixes CNVS-5369
Change-Id: I67a9892ca71db62a2462789b6cf7f28dce47335e
Reviewed-on: https://gerrit.instructure.com/19706
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
test plan:
1. go to /courses/:id/users
2. click 'add users'
3. should work much like the add users UI in
the course settings -> users tab, but look
a little different
Change-Id: Icec24a41385e595d8b79dc5a7232545f0aff926e
Reviewed-on: https://gerrit.instructure.com/18888
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
dismisses the banner for the browser session
test plan:
- use canvas in an unsupported browser (e.g. ie8, old firefox,
or set your user agent to an unsupported one)
- click the minimum browser warning at the top of the page
- the warning should be dismissed
- when visiting other canvas pages the warning should still be dismissed
- restart the browser
- the warning should be visible again
Change-Id: I0d8bc966e8512e07dab0448f68a538a256228c4e
Reviewed-on: https://gerrit.instructure.com/19623
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Joe Tanner <joe@instructure.com>
QA-Review: Joe Tanner <joe@instructure.com>
fixes CNVS-3887
filter and user select inputs are now keyboard navigable.
arrow keys move throughout the list, and enter adds the
selected user/context to the list of recipients or filter.
test plan:
* attempt to use the recipient finder using only the
arrow/enter keys;
* using a screenreader, verify that each entry in the
results is read as expected.
Change-Id: I5b75d13b7baf7a090bfa341d21d8fb3d7f91c140
Reviewed-on: https://gerrit.instructure.com/19503
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Ericksen <marke@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
?include_js_translations=1 will cause js translation files to be required
and used... this way you don't need to use optimized js
note that you need to run `rake i18n:generate_js`, otherwise you will get
amd loading errors or out-of-date translations
test plan:
1. rake i18n:generate_js
2. switch to another language in the ui
3. go to the conferences page for a course and tack on
?include_js_translations=1 to the url
4. click to create a new conference
5. note that the submit button (i.e. "Create Conference") is now
translated
Change-Id: Id676fce6dbf3f2fbe739b00427e09541fdc8c639
Reviewed-on: https://gerrit.instructure.com/19716
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
the backend only allows linking a question bank while creating a question
group, so have the frontend match that
fixes CNVS-4647
test plan:
- create a quiz
- add a new question group
- notice that 'link question bank' is there and functions
- hit create group
- without reloading, edit the group
- the link should be gone
- reload the page
- the link should still be gone
Change-Id: I1ecb924e8104fa306b391f80bd931b192747de04
Reviewed-on: https://gerrit.instructure.com/19604
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-5102, CNVS-5255
when a quiz due date has changed, always send notifications
to affected users; don't require the editor to check the
"notify users this quiz has changed" checkbox.
test plan:
* as a teacher, change the due date of an existing quiz
and save the change without checking the "notify users
that this quiz has changed" checkbox;
* verify that affected students with ASAP notifications
receive a message.
* verify that these notifications also work as expected
for quizzes with multiple due dates.
Change-Id: Iba4bc32c2eb7629fd475201938ba7adb345c0e6a
Reviewed-on: https://gerrit.instructure.com/19609
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
QA-Review: Zach Pendleton <zachp@instructure.com>
Simon Williams