just do it the right way, since the shim doesn't seem to work in rails 5
this is just a massive find/replace (repeated, due to chained assignment)
refs CNVS-34867
Change-Id: I267a16bed05a116e463cf9301645270e79a2d80e
Reviewed-on: https://gerrit.instructure.com/104193
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
it's not performant enough right now, needs to be
removed until we can replace with something better
closes #CNVS-28683
Change-Id: Id71d16e611b2c75dccff47195ea5e17a6408f5d5
Reviewed-on: https://gerrit.instructure.com/78342
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
This will make the page a little faster, but unfortunately the bulk of
the time comes from counting active users in each term, and whether we
do that as N queries or 1, the overall time is about the same. To
really get this page to perform well, we need to look into storing these
counts somewhere that don't have to be calculated every time.
fixes CNVS-21524
test plan:
- set up several enrollment terms with different numbers of courses and
users in each.
- to go the root account enrollment terms page, and make sure the counts
of active courses and users is accurate.
- try deleting some of the courses and users and make sure counts update
appropriately.
- basic regression test of functionality around saving/editing
enrollment term start/end date overrides
Change-Id: I35fb637ddd91db64c4a5890d58a622f5affa3923
Reviewed-on: https://gerrit.instructure.com/56439
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Landon Wilkins