Commit Graph

17032 Commits

Author SHA1 Message Date
Ryan Shaw 3df20d6c5d Upgrade instUI from 6.10.0 to 6.12.0
Closes: COREFE-301

Test plan:
* all the instUI things should still work
* specifically check to make sure that bowser is no longer in prod build
  And that objectSpread thing is fixed so it uses babel helpers

Change-Id: Ie30edddba6ff7c9f37852ea13a65dddc42f93d65
Reviewed-on: https://gerrit.instructure.com/209745
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
2019-09-24 18:44:22 +00:00
Adrian Packel 3b4b71d88a Return test student in New Gradebook
Update the studentsThatCanSeeAssignment function in New Gradebook's
Gradebook.coffee to also return test students. This allows the routines
for posting/hiding grades in New Gradebook to be aware of test students
and update their submissions accordingly. At the same time, make sure
test students are still excluded from the "Message Students Who" dialog
since test students aren't eligible to receive messages.

fixes GRADE-2357

Test plan:
- Have a course with New Gradebook and Post Policies
- Add a test student to the course
- Test that posting and hiding grades also posts/hides for the test
  student in both New Gradebook and SpeedGrader
- Test that "Message Students Who" for an assignment never includes the
  test student in the list of students even if they otherwise fit the
  criteria for receiving the message
- Smoke test other instances where we call studentsThatCanSeeAssignment
  (e.g., setting a default grade for an assignment, curving grades) to
  make sure nothing has broken

Change-Id: I5a3efe75c77832d5b2df2d6d2b527d8fe483636f
Reviewed-on: https://gerrit.instructure.com/206137
Tested-by: Jenkins
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
2019-09-24 17:31:07 +00:00
James Williams 8e57c8d9a1 restrict submission notifications on grade permissions
don't send to tas/teachers that can't see follow
the link to view the submission

test plan:
* create a custom ta role with view all grades
 and edit grades disabled
* they should not receive an "Assignment Submitted" notification

closes #COMMS-2327

Change-Id: I5adde21709859183639e3ac6a8f6e19c23a20322
Reviewed-on: https://gerrit.instructure.com/210028
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
2019-09-24 15:15:04 +00:00
Jeremy Putnam ad1e933232 spec: add tests for locked and hidden subfolders and files
Change-Id: I847edbe456b3065951a05a64ce8c0dd9069c3cc2
refs: COREFE-288
Reviewed-on: https://gerrit.instructure.com/210471
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jeremy Putnam <jeremyp@instructure.com>
2019-09-24 15:09:35 +00:00
Jeremy Putnam d10a695454 spec: add specs checking hidden and locked root course folders
Change-Id: I59dc53a78940642bcad8eb417194683f74e4c19c
refs: COREFE-288
Reviewed-on: https://gerrit.instructure.com/210418
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jeremy Putnam <jeremyp@instructure.com>
2019-09-24 15:09:20 +00:00
Jeremy Putnam 4da57fcf63 spec: add test for adding file to show up in page and file tree
Change-Id: If346f22dff093ffa0880236193f17abf6016b0fc
refs: COREFE-288
Reviewed-on: https://gerrit.instructure.com/210243
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jeremy Putnam <jeremyp@instructure.com>
2019-09-23 17:56:13 +00:00
James Williams 4e9c60be26 don't increment root discussion participants for group users
test plan:
* create a course with a group with a student
* create a course discussion assigned to the
 group category (so students only see the copy of the root
 that's assigned to their group)
* as the student, view the discussion from the course index
 (to ensure the participant record is created)
* as the teacher, post to the root discussion topic
 (disregarding the message that students can't see it)
* it should not create a unclearable unread counter
 for the student

closes #COMMS-2425

Change-Id: I78fd8f147798ffb82c424bbdac76670e18e1178c
Reviewed-on: https://gerrit.instructure.com/210254
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
2019-09-23 16:12:00 +00:00
Jon Willesen 9d7bf53c29 add a setting for the common cartridge viewer url
closes ADMIN-2910
flag=direct_share

test plan:
- add a common_cartridge_viewer section to your
  config/dynamic_settings.yml file and set the base_url. See the example
  file for how to do this.
- As a teacher, go to the shared content page. In the console, check the
  value of ENV.COMMON_CARTRIDGE_VIEWER_URL. It should be the base_url
  value that you configured in dynamic_settings.yml

Change-Id: I61122519b18f33f3757cc0e1a401b630cf5aacb9
Reviewed-on: https://gerrit.instructure.com/210230
Tested-by: Jenkins
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-09-23 15:28:13 +00:00
Jon Willesen 5f8124750a initiate content share
closes ADMIN-2906
flag=direct_share

test plan:
- as a teacher on the discussions index page, click "Send to" from a
  discussion's kabob menu.
- in the dialog, search for and select users to share the discussion
  with.
- click "send" and see status reports about the api post
- check the database for newly created ContentShare records for the
  sender and the receivers

Change-Id: I17ec21062e942ea198f0ce6d18e57d401107ab8b
Reviewed-on: https://gerrit.instructure.com/210024
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-09-23 15:09:20 +00:00
James Williams 71c4296401 don't infer sortable name in sis csv if explicitly provided
closes #CORE-3296

Change-Id: I3845e5f2fcd9680cda33b000e603c01a21b2d252
Reviewed-on: https://gerrit.instructure.com/209824
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2019-09-23 13:06:56 +00:00
KC Naegle 8b67cd9901 spec: add a2 media student spec
test plan:
 build passes

Change-Id: I6d51030212727d803d9b499731002d3078aed607
Reviewed-on: https://gerrit.instructure.com/209744
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
2019-09-21 17:01:52 +00:00
Jon Willesen 01877f8cdd add content_export to content_shares api
closes ADMIN-2931
flag=direct_share

test plan:
- Perform CRUD operations on content shares. Results should include the
  content_export field with data about the associated content export.
- Generate API docs and see new field in the ContentShare type
  definition

Change-Id: I153f580b247af124bd00b0283b28bf01c6748928
Reviewed-on: https://gerrit.instructure.com/210255
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-09-20 22:18:52 +00:00
Jon Willesen e25f4cdac7 initiate direct share course copy
closes ADMIN-2813

test plan:
- as a teacher on the discussions index page, open the "copy to" dialog
for a discussion
- select a course and click the copy button
- an alert is shown stating the copy has started
- allow the background job to run
- copy of the discussion should appear in the selected course when the
copy is complete

Change-Id: I808ce6d5b94dbf59950fc476a4e64519d374df9b
Reviewed-on: https://gerrit.instructure.com/209328
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
2019-09-20 21:44:52 +00:00
Jeremy Stanley c2be7ad7ec student tray: hide analytics button if A2 is present
test plan:
 - if the Analytics 2 LTI tool is installed and feature is
   enabled, and analytics 1 is also enabled in account settings,
   the student context tray should include only a button that
   links to Analytics 2, not also one that links to the original
   analytics

fixes ADMIN-2902

flag=analytics_2

Change-Id: I06cd412ba6a355fa25cf4dbbb042650b1b80b4ac
Reviewed-on: https://gerrit.instructure.com/209906
Tested-by: Jenkins
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
2019-09-20 21:04:10 +00:00
Jeremy Stanley 977ea70adc point user and course analytics links to analytics 2
test plan:
 - install analytics 2 LTI tool
 - enable new analytics feature
 - verify links to new analytics exist in the following places:
   1. course right side nav
   2. course people page student kebab menu
   3. course user page (with and without user profiles)
 - for 2 and 3 above, links should only appear for students
 - the /api/v1/courses/X/users?include[]=custom_links API
   should not include analytics links for students
   (assuming the tool configuration sets required_permissions)

fixes ADMIN-2900

flag=analytics_2

Change-Id: Iddefdb6c119f0d50240144b6e507a4428fcf8af6
Reviewed-on: https://gerrit.instructure.com/209758
Tested-by: Jenkins
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Mysti Lilla <mysti@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
2019-09-20 21:03:57 +00:00
Derek Bender 8cf3d457d6 Fix moderated assignments with graded rubrics
Closes: GRADE-2414

Test plan:
- Given a course with a Teacher, on TA and a student
- Given a moderated assignment with one Grader
- Given the teacher is the final grader
- Given a rubric attached to the assignment with the option "use for
  grading" enabled
- Given the TA has graded the student with the rubric
- Given the TA has also given a *different* score in the normal grade
  box than what the rubric score was
- Given on the moderation page the Teacher selects the TA's score.
- When clicking the "Release Grades" button
- Then submitting grades works and does not error

Change-Id: Ia2d06047ec492bd79a17a1fd086861e016ccdf9d
Reviewed-on: https://gerrit.instructure.com/208051
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
2019-09-20 20:38:16 +00:00
James Williams f285948546 spec: fix flaky files datepicker selenium specs
sometimes tries to click the new datepicker before the
previous one has finished closing

Change-Id: Ide34f18a027af8d1d1c190b1a1bd98b30a9a8d79
Reviewed-on: https://gerrit.instructure.com/210446
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2019-09-20 20:03:25 +00:00
James Williams d291632df3 mark blueprint associated assignment rubric edited when cloned
test plan:
* create a blueprint course with a rubric
 associated to multiple assignments
* sync to an associated course
* edit the rubric on one of the associated course
 assignment pages (it should bring up a dialog saying
 that it will make a copy of the rubric)
* make an unrelated change to the assignment
 in the blueprint course and re-sync
* it should not sync the associated assignmment
 back to the previous rubric

closes #ADMIN-2928

Change-Id: Iaeb02e84adbe820537f59878fc78d06e075f8e84
Reviewed-on: https://gerrit.instructure.com/210204
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Mysti Lilla <mysti@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
2019-09-20 19:48:28 +00:00
James Williams dde4e9df1a spec: fix flaky accounts api search spec
sometimes ids are less than 3 characters

Change-Id: I87ad86366930cb77f52687b85226355e7ed45f86
Reviewed-on: https://gerrit.instructure.com/209989
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2019-09-20 19:08:33 +00:00
Keith T. Garner a60d671abf add only_current_enrollments to user api graded_submissions
Adds a parameter to the User API graded_submissions endpoint to only
return only submissions for current enrollments.

closes APG-99

test plan:
 - Create two courses and enroll a student in each.
 - Grade an assignment for the student in each course
 - Conclude the student in one of the courses
 - Visit /api/v1/users/<student id>/graded_submissions?only_current_enrollments=true
 - Note that only the submission for the still active enrollment is
   returned

Change-Id: I52b99af8f7e19b43729b831c52b20bcce7ea963e
Reviewed-on: https://gerrit.instructure.com/209087
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
2019-09-20 19:04:52 +00:00
wdransfield 54a7a0d6e4 Lookup assignments by lti_context_id
This commit fixes a regression introduced in
g/1990025

Fixes PLAT-4953

Test Plan
- Make a request to the plagiarism assignments API get action
  using the canvas assignment id
- Verify the assignment JSON is returned
- Make a request to the plagiarism assignments API get action
  using the assignment "lti_context_id"
- Verify the same assignment JSON is returned

Change-Id: Ic33859c4e4f6e9a81f94196bbeb50adad995f1ea
Reviewed-on: https://gerrit.instructure.com/210429
Reviewed-by: Clint Furse <cfurse@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Tested-by: Jenkins
Product-Review: Weston Dransfield <wdransfield@instructure.com>
2019-09-20 18:39:48 +00:00
Tyler Burraston c93425989b Adjust new/edit assignment cancel action for quiz_lti assignments
closes QUIZ-6983

Test Plan
---------
- With the newquizzes_on_quiz_page flag disabled:
-- The Quiz/Test easy button is on the Assignments page
-- Clicking the Quiz/Test button navigates you to the new assignments
   page
-- Clicking cancel on the new assignments page navigates you to the
   assignments index page

- With the newquizzes_on_quiz_page flag enabled:
-- The +Quiz button is on the quizzes page
-- Clicking the +Quiz button takes you to the new assignments page
-- Clicking cancel on the new assignments page navigates you back to the
   quizzes index page
-- On the assignments page, clicking +Assignment takes you to the new
   assignments page
-- Clicking on cancel takes you back to the assignments index page

Change-Id: Iab9ce3a75e76da56eeccc05fa595a358206e1162
Reviewed-on: https://gerrit.instructure.com/209746
Tested-by: Jenkins
Reviewed-by: Jared Crystal <jcrystal@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Kevin Dougherty III <jdougherty@instructure.com>
2019-09-20 17:44:09 +00:00
Jeremy Putnam 7274332736 spec: add test to upload text in images tab
Change-Id: I7241f0fbd3458f2a650ed2c54155e218fae60ec5
refs: COREFE-288
Reviewed-on: https://gerrit.instructure.com/210104
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jeremy Putnam <jeremyp@instructure.com>
2019-09-20 16:18:47 +00:00
Adrian Packel 23be390123 Update post policy assignment header statuses
Have the assignment column header show the status text "Manual" when an
assignment is manually posted in place of the old line eye icon.

closes APG-45

Test plan:
- Have a course with New Gradebook and Post Policies enabled
- Create three assignments:
  - An auto-posted assignment (A1)
  - A manually-posted assignment (A2)
  - An anonymously graded assignment (A3)
- Check that the following behavior holds:
  - A1:
    - The assignment header status text displays the number of points
      possible ("Out of X")
    - When submissions are graded but unposted, the orange eye icon
      appears as before
  - A2:
    - The assignment header status text includes the number of points
      possible and the text "Manual" ("Out of X MANUAL")
    - When submissions are graded but unposted, the orange eye icon
      appears as before
    - However, the previous line eye icon (signifying merely that the
      assignment was manually-posted) no longer appears at all, ever
  - A3:
    - The header has the status text "Anonymous" and does not show the
      number of points possible (this behavior has not changed)
- Do a quick check of Old Gradebook to make sure that the header text
  still shows "Out of X MUTED" when an assignment's muted value is true

Change-Id: I290c69a585a318ee95d43e1fc25417a2843d43e8
Reviewed-on: https://gerrit.instructure.com/210278
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
2019-09-20 15:39:54 +00:00
Steven Burnett 650da4816e fix relative path
Test Plan:
- closed captions work in a2 student view

Change-Id: I6957c08ae0d47b0074b80b54c2bdd88ef45d9698
Reviewed-on: https://gerrit.instructure.com/210227
Reviewed-by: Ben Nelson <bnelson@instructure.com>
QA-Review: Ben Nelson <bnelson@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
2019-09-19 21:15:58 +00:00
Mysti Lilla b56b1dfce8 Remove New Analytics LTI placements w/o FF enabled
closes ADMIN-2905
flag=analytics_2

Test plan
- When the Feature Flag is on, new Analytics course nav and
  student context card buttons should be available
- When the Feature Flag is off, new Analytics course nav and
  student context card buttons should not be available

Change-Id: Icd1cde22b2e5ff4ec40a81ecdefa4887698647c2
Reviewed-on: https://gerrit.instructure.com/209908
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
2019-09-19 18:27:50 +00:00
Tyler Burraston 4dea49f03b Move +QUIZ/TEST button from assignments page to quizzes page
closes QUIZ-6785

Test Plan
---------
- With the 'newquizzes_on_quiz_page' and 'quizzes_next' flags enabled:
-- The +Quiz/Test button does not show on the assignments page
-- The +Quiz and +Old Quiz buttons show on the quizzes page
-- The +Quiz button navigates to the create new assignment page, with
   the external tool set to new quizzes

- With the 'newquizzes_on_quiz_page' disabled:
-- The +Quiz/Test button remains functional on the assignments page
-- The +Quiz button on quizzes creates an old quiz
-- There is no +Old Quiz button on quizzes page
-- There is no +Quiz button that creates a new quizzes quiz on the
   quizzes page

Change-Id: I08ff0a63eb47333a21524742be7ea75c2075f2c8
Reviewed-on: https://gerrit.instructure.com/209233
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Aaron Griffin <agriffin@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Kevin Dougherty III <jdougherty@instructure.com>
2019-09-19 16:22:28 +00:00
Clay Diffrient efe559d030 Add authentication for immersive reader
Test Plan:
  - Given the proper credentials in dynamic_settings.yml, calling
    /api/v1/immersive_reader/authenticate works

closes COREFE-263

flag = none

Change-Id: I2f42772691d7d64fb79229585ee9d008fa2ce2b6
Reviewed-on: https://gerrit.instructure.com/209911
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-09-19 16:04:03 +00:00
Jeremy Stanley 34f254b1d5 fix permissions around "Login ID" column in course roster
test plan:
 - a custom role with "Users - View login IDs" permission granted
   and without "add/remove students" or "add/remove teachers"
   should still see the login ID column in the course roster
   and it should be populated
 - a custom role without "Users - View login IDs" permission granted
   should not see the login ID column in the course roster
   even if they do have "add/remove students" or "add/remove teachers"

fixes ADMIN-2628

Change-Id: I876fbcd7cae705cf78c2b422fb365adc629235fc
Reviewed-on: https://gerrit.instructure.com/208837
QA-Review: Rex Fleischer <rfleischer@instructure.com>
Tested-by: Jenkins
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
2019-09-19 15:31:34 +00:00
Adrian Packel 8751a4c415 Have learning outcomes check posted not muted
fixes GRADE-2397

Test plan:
- Have a course with New Gradebook and Post Policies enabled
- Enable the Student Learning Mastery Gradebook feature for the course
- Set up outcome stuff:
  - Create a couple outcomes
    - Create some rubrics and add said outcomes to them
  - Create an assignment and have it use one of the rubrics above
  - Create a quiz and have it use one of the rubrics above

- As a student, open your Grades page for the course
  - Click the "Learning Mastery" tab
  - All outcomes there should appear as "not yet evaluated"

- As a teacher, fill out the rubrics for the assignment/quiz
  - Assign some grades, and post grades if needed

- As a student, open the Grades page again
  - Under "Learning Mastery", the scores you received on the outcomes
    should now be displayed

Change-Id: I512f0fa2222d43e1360546b348424a8e0cdc4bf8
Reviewed-on: https://gerrit.instructure.com/209893
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Derek Bender <djbender@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
2019-09-19 14:39:53 +00:00
Jeremy Putnam 14b78e6437 spec: unskip sidebar upload new file test
Change-Id: I656f7ec491bfdd3f876a45f7df2b7c28f28d30c0
refs: COREFE-288
Reviewed-on: https://gerrit.instructure.com/209558
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Robert Lamb <rlamb@instructure.com>
2019-09-18 21:13:54 +00:00
James Butters d7b0dc2625 spec: reruns for rspec
closes: CORE-3299

Change-Id: I0febb9d4f6fdcf3f48d4e0079e7a230ac505218d
Reviewed-on: https://gerrit.instructure.com/208862
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
2019-09-18 20:01:14 +00:00
Steven Burnett b853db1383 allow creation of media comments in a2
fixes COMMS-2291

Test Plan:
- FULL PATH A2 STUDENT VIEW SUBMISSION COMMENTS
- as a student in a2
- navigate to any comment pane on any attempt
- click the media icon
- upload a recording
- click send comment with text or with attachement or just the media
- notice the media now shows up
- watch it and rejoice

Change-Id: I49a2f3003cbb92f3cc6b15065dd1f50c8ecc7576
Reviewed-on: https://gerrit.instructure.com/209082
Tested-by: Jenkins
QA-Review: Ben Nelson <bnelson@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
2019-09-18 19:02:35 +00:00
Landon Gilbert-Bland f09f271b5a Do not expose assignment description for locked assignment
Fixes COMMS-2455

Test Plan:
  - Make an assignment that is due in the future and unlocks in the
    future, and has a description
  - As a student, navigate to your calendar page
  - Open your network tab in your browser, and find the API request
    that pulls that assignment into your calendar. It should look
    something like /api/v1/calendar_events?type=assignments
  - Notice that the description for the assignment is not in the
    response for that API request
  - Modify the assignment so it now unlocks in the past
  - Make the API call again, and this time notice that the description
    for the assignment shows up in the API

Change-Id: I7500316f1835cf4a575077da80858136d5cd8112
Reviewed-on: https://gerrit.instructure.com/210004
QA-Review: Ben Nelson <bnelson@instructure.com>
Tested-by: Jenkins
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2019-09-18 16:50:52 +00:00
Xander Moffatt 8bcc4735db allow dev key saving with only public_jwk_url
closes PLAT-4858

test plan:
- create an LTI dev key with a public_jwk_url instead of a public_jwk
- the url doesn't need to be anything special but
`https://canvas.instructure.com/api/lti/security/jwks`
is always a safe bet
- edit the LTI dev key and click save
- the save should return 200 and not show any errors

Change-Id: I85a732fb6b7e9a1f32a3156621ab9899f2bf68b9
Reviewed-on: https://gerrit.instructure.com/209913
Tested-by: Jenkins
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
2019-09-18 16:44:34 +00:00
Matthew Lemon 726ee1a6f5 add url to the submission draft model/graphql type
Test Plan
- run the db migration to add url to the SubmissionDraft table
  - bundle exec rake db:migrate:up VERSION=20190916193616

- Create a course and add a student to it
- Create an assignment with a submission type of online url
- Masquerade as the student and navigate to the /graphiql endpoint
- Run the following mutation updated with the appropriate submissionID:
```
mutation MyMutation {
  __typename
  createSubmissionDraft(input: {submissionId: <your_submission_id>, url: "http://www.google.com", attempt: 1}) {
    errors {
      attribute
      message
    }
    submissionDraft {
      _id
      url
      submissionAttempt
    }
  }
}
```

- The mutation should return 0 errors and the submission draft should
  reflect the given url
- Run the following query updated with the appropriate submissionID:
```
query MyQuery {
  __typename
  legacyNode(_id: <your_submission_id>, type: Submission) {
    ... on Submission {
      id
      submissionDraft {
        url
        submissionAttempt
        _id
      }
    }
  }
}
```

- The query result should show the url you entered in the previous
  mutation

refs COMMS-2331
flag=assignments_2

Change-Id: I60d756a9f0a29ea5aece960416edbb43c0949ddc
Reviewed-on: https://gerrit.instructure.com/209727
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Ben Nelson <bnelson@instructure.com>
Product-Review: Matthew Lemon <mlemon@instructure.com>
2019-09-18 16:35:30 +00:00
Jeremy Putnam 66181c70ea spec: add second test for file tree focus
Change-Id: I975c57e49c633f406c05dc53d20754d8cf231a97
refs: COREFE-288
Reviewed-on: https://gerrit.instructure.com/209327
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jeremy Putnam <jeremyp@instructure.com>
2019-09-18 16:28:31 +00:00
Jeremy Putnam 45f4f35afc spec: add test for file tree focus
Change-Id: I1ef3b693f2efbc53b50955c4bd0aef255d6f3525
refs: COREFE-288
Reviewed-on: https://gerrit.instructure.com/209147
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jeremy Putnam <jeremyp@instructure.com>
2019-09-18 16:28:14 +00:00
Jeremy Putnam 05e76193d3 spec: unskip sidebar files folder expand test
Change-Id: I4c0f8a7f690bfd8bd1b0968a96443e0dc5f3bf64
refs: COREFE-288
Reviewed-on: https://gerrit.instructure.com/208922
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jeremy Putnam <jeremyp@instructure.com>
2019-09-18 16:27:55 +00:00
Clint Furse eeb161d156 hide legacy plagarism tool button in speedgrader
closes PLAT-4811

Test Plan:
- setup an assignment to use the plagarism tool
- have a student create a submission
- force an error on the submission by inserting data into
  submission.turnitin_data (see JIRA comment)
- open the submission in speedgrader and click the "!" icon
- the resubmit button should no longer appear

Change-Id: I54420f3c8bea45715bb8c862cd1f0ca4cda83b0e
Reviewed-on: https://gerrit.instructure.com/209286
Tested-by: Jenkins
Reviewed-by: Marc Phillips <mphillips@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
2019-09-18 16:09:38 +00:00
James Williams bed7d40a70 spec: fix timing issue in master_migration_spec
Change-Id: I9f2d182620c91e33e286b78e229a20daa3cc07fd
Reviewed-on: https://gerrit.instructure.com/209808
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
2019-09-18 12:31:31 +00:00
Rex Fleischer 5563aa50d3 move usage_rights_required and course_catalog to account settings
fixes: ADMIN-2525
fixes: ADMIN-2531

Test-Plan:
ensure that the settings work the same as the flags did

Change-Id: If5dd8e1d1700357321592fa433bbdfe49c75c886
Reviewed-on: https://gerrit.instructure.com/205261
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
2019-09-17 20:07:46 +00:00
Rex Fleischer be175af562 add the wiki_index_menu lti placement type
fixes: ADMIN-2876

Test-Plan:
configure an lti tool with the new placement type and ensure
it works as expected

Change-Id: I71c13d206164867704f1cc8bb2580fb3e78cdef0
Reviewed-on: https://gerrit.instructure.com/209108
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
2019-09-17 18:29:51 +00:00
wdransfield 1206fcf57a Add spec for content dialog deep linking
Refs PLAT-4914

Test Plan:
New specs pass

Change-Id: Icd8055b80546801cf02f60bd9b045a2b82862ecd
Reviewed-on: https://gerrit.instructure.com/209845
Tested-by: Jenkins
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
2019-09-17 18:14:17 +00:00
Xander Moffatt e73f1b60d9 add data attribute to all lti launches
closes PLAT-4835

test plan:
* specs

Change-Id: I4132f4209dd3d93520e8cea884adbd30a2a904d8
Reviewed-on: https://gerrit.instructure.com/209643
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
Tested-by: Jenkins
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
2019-09-17 17:33:10 +00:00
James Williams 62b33da585 require present value for knapsack enabled env
Change-Id: I0f4b3e1da3cd78a93e052f81ec8cd96b51804d33
Reviewed-on: https://gerrit.instructure.com/209673
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2019-09-17 17:11:44 +00:00
Ed Schiebel b5984c7034 Add course and user menu items under the rce media toolbar button
and comments out the upload media menu item until we work a ticket
to make that work.

closes COREFE-39

test plan:
  - load the RCE in a course as a teacher
  - click on the Media toolbar button
  > expect the expect User Media and Course Media
    in the menu
  - click on a menu item
  > expect the tray to open to My|Course Files and Media

  - repeat as a student
  > expect User Media only, no Course option

Change-Id: I3c92ea1265ab74fb2da793912734f7134250d0ff
Reviewed-on: https://gerrit.instructure.com/207011
Tested-by: Jenkins
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-09-17 16:51:23 +00:00
Jeremy Stanley 6c65d26e0e add list planner items endpoint for parents
test plan:
 - render API docs and confirm the "List planner items" entry
   shows both the /api/v1/planner_items and /api/v1/users/X/planner_items
   paths
 - ensure an observer can view a linked student's planner
   (the observer must be linked to the student via UserObservationLink)
 - ensure pagination works properly for both paths
 - ensure a user who is not an observer of the student
   (or the student herself) cannot view a student's planner items

flag=none
closes ADMIN-2883

Change-Id: I04554dbbc97eb42f4a78479d9f7c31646997e6ec
Reviewed-on: https://gerrit.instructure.com/208536
Tested-by: Jenkins
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Rex Fleischer <rfleischer@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
2019-09-16 17:30:54 +00:00
Landon Gilbert-Bland a849e49a1c Add support for rubric assessments versions in graphql
Test Plan:
  - Create an assignment with a rubric
  - Submit the assignment as a student
  - Grade the submission via the rubric as the teacher
  - Resubmit the assignment as a studnet
  - Re-grade the submission via the rubric as the teacher
  - Go to the A2 page as the student. Notice that when you click the
    previous and next buttons to cycle between submissions, it will
    update the rubric tabs with the graded results for the specific
    attempt you are on

fixes COMMS-2423
flag=assignments_2

Change-Id: I7b2fe876af670c7ff0973884a776917ba1705f6d
Reviewed-on: https://gerrit.instructure.com/209056
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins
QA-Review: Ryan Norton <rnorton@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2019-09-16 15:41:15 +00:00
Ryan Shaw c0a9a6c6bb spec: fix path to an icon in a spec
Change-Id: I872b476bf763757437c0730ad76240e03e863ade
Reviewed-on: https://gerrit.instructure.com/209555
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
2019-09-16 14:33:33 +00:00