Commit Graph

4 Commits

Author SHA1 Message Date
Aaron Shafovaloff a78f3fca8c Update spec/javascripts/ to latest prettier config
Test plan:
  - All existing tests pass

flag=none

[skip-eslint]

Change-Id: Ib125529990a476c49d4737ff7ba277f4f6c31b98
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/302260
Reviewed-by: Charley Kline <ckline@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2022-09-29 22:27:11 +00:00
Ahmad Amireh 8c41cb0ff3 webpack: remove support for virtual i18n! modules
refs FOO-2696
flag = none

with the recent changes to how we generate the locale bundles, modules
no longer have to have a dependency on their (scope) locale bundle since
they do not exist

with this change, all support for the virtual "i18n!xxx" modules is
removed, as it's been a convenience carried over from the days of
require.js but is proving to be more costly as the tooling landscape
evolves

. test plan .
 ..... .....

assuming you checked out the change that rewrites all imports to "i18n!"
to use the "useScope" specifier from @canvas/i18n, webpack should still
run

Change-Id: I6e0db400b46133458592976cc4772365efcde317
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286653
Tested-by: James Butters <jbutters@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
2022-03-10 21:38:10 +00:00
Ahmad Amireh 05dce63b6b babel independence(2): karma
refs FOO-2697
flag = none

webpack config for karma is also independent now and no longer tied to
the main build config, you can find it under ui-build/webpack-for-karma

there are no notable changes outside of breaking that config into a few
files

~ TEST PLAN ~
+-=---------!

- karma/QUnit suite actually runs and passes

Change-Id: Iff474a3d0068441dc8a7c4de605765d936e8ab6d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283377
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
Reviewed-by: Sean Scally <sean.scally@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
2022-02-07 18:48:18 +00:00
Ahmad Amireh 5f976f9989 rename frontend_build -> ui-build
minor QOL mainly for me; put webpack-specific configuration in its own
folder, make it portable, and make room for esbuild

the __webpack_public_path__ initializer no longer sources the value from
the build module, instead it uses a pre-defined global that webpack
injects

~ test plan ~

build is OK

Change-Id: I4ba4a3c0cb9175f96096f2b78022e152c04fc75d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276183
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
2021-10-21 19:13:02 +00:00