ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
61,768 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

83 Commits

Author SHA1 Message Date
Cody Cutrer 63a05bc983 Revert "bundle update --bundler" 
This reverts commit 698049fdf0.

Reason for revert: Passenger isn't loading the correct version of bundler, and the new version causes a conflict with the old version

Change-Id: I030f29872e6052c0af59ae8d7810725189261170
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345745
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-05-20 19:16:47 +00:00
Cody Cutrer 698049fdf0 bundle update --bundler 
Change-Id: I332279b9d679a3e7742eccfe96b2575b72703c12
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347802
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-05-20 15:51:24 +00:00
Cody Cutrer b773e95c97 bundle update minitest 
Change-Id: Ib391391bc56bce80d910d876ad22e3c9101c9af9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347573
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-05-16 21:05:06 +00:00
Cody Cutrer a32a26ac25 bundle update rspec-mocks 
Change-Id: Ie4254cb9d7ae7e5b988ee66adaf1bac0f36bbeaf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347110
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-05-10 16:17:49 +00:00
Cody Cutrer ee3fa745a2 bundle update i18n 
Change-Id: I60ad2353df26abead07b1784bcdcd481e12956b7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347104
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-05-09 16:54:08 +00:00
Cody Cutrer a87e21995e bundle update bigdecimal 
Change-Id: I5d37565f745d6d8ae17a5d2d815c31f0be0cd063
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347102
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-05-09 16:52:26 +00:00
Cody Cutrer 2ce06d4e7b bundle update --bundler 
Change-Id: I58fb6336e936d627669f9d946789942bce377b04
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345056
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-04-16 15:11:59 +00:00
Cody Cutrer 605137bf58 bundle update rake 
Change-Id: If3ae6b964b8ac1518f50181297ee4317cd526642
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/344514
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-04-09 22:26:38 +00:00
Cody Cutrer 82c87a7b56 bundle update bundler-multilock 
Change-Id: I47f6023ee0f5c50ba0a4cab9a3aa8848e8c540de
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/344095
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-04-01 21:54:21 +00:00
Cody Cutrer 49808b340c bundle update bigdecimal 
Change-Id: Id07fac5c51ada657fcad6bd46b26aa702434c1b5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/344068
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-04-01 14:45:44 +00:00
Cody Cutrer add7f4f71e bundle update --bundler 
Change-Id: Ic9bb3deea7d89a48cd23e0ee8cd138cdd9e89321
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/344092
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-04-01 14:22:00 +00:00
Cody Cutrer 3ee1791d00 bundle update minitest 
Change-Id: I3d0c56f811a0d4bdb48e4afe28740b3d88f7187f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/342894
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-03-14 17:03:55 +00:00
Cody Cutrer 5f0da7efa1 bundle update i18n 
Change-Id: I826730959e537ca60eb43842bb9e273315a0d388
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/342891
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-03-14 16:29:34 +00:00
Cody Cutrer bc3a49a39b bundle update rspec-support 
Change-Id: I6027df59b78db2aaba06c30aef8d7fb25dcc5f24
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341539
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-03-01 22:27:40 +00:00
Cody Cutrer 9c8f15d936 bundle update drb 
Change-Id: I8c7d03fdb2cba7d4ff3a67b043d4cad2e568649f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341888
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-03-01 21:44:10 +00:00
Cody Cutrer 369501d8dc bundle update --bundler 
Change-Id: Ic337ff6da406403f4d999cfef60d40227860f523
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340413
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-02-14 22:30:21 +00:00
Cody Cutrer 1e9f9ff387 add Rails 7.1 lockfiles for embedded gems 
closes AE-777

test plan: specs pass

Change-Id: I0d9f9dc10fd0421d83f8f4604598871ae25f70d5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340308
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-02-14 22:30:10 +00:00
Cody Cutrer e3cbecc5f3 bundle update minitest 
Change-Id: Ic990ac4ec74828c527720be6b5da241da9439ce4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339941
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-02-13 16:12:54 +00:00
Cody Cutrer b568cef3aa bundle update minitest 
Change-Id: Id424fb8f8c83d389dba63a4be6af27a3b818ea70
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339750
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-02-06 23:04:22 +00:00
Cody Cutrer 9916eca155 bundle update rspec 
Change-Id: I3de31d5130326fd1657d1aa6198247353aa77a76
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339732
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-02-05 21:07:05 +00:00
Cody Cutrer f170bf3c00 bundle update diff-lcs 
Change-Id: I9f2bb0232df447f8e53b9b94eed41d1f5008e515
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339731
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-02-05 21:05:33 +00:00
Cody Cutrer 1c78c5e75a bundle update minitest 
Change-Id: I638cb735b0c2ebc5b48185c4078a8eeb27eadac7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338579
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-01-30 20:06:43 +00:00
Cody Cutrer eacec0a606 bundle update factory_bot 
Change-Id: I3ab74c597004c220cc2d0515546f0f584579d433
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337908
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-01-24 16:18:47 +00:00
Cody Cutrer 8eeebf32b3 bundle update rubocop 
lots of autocorrect of RSpec/RedundantPredicateMatcher, and some
manual corrections of RSpec/RemoveConst (mostly ignoring it)

[skip-stages=Flakey]
[skip-crystalball]

Change-Id: I57a01c06a5f2dafd985912c5ea9dc18e199eddaa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337931
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2024-01-24 16:17:43 +00:00
Cody Cutrer 655bb62690 bundle update concurrent-ruby 
Change-Id: I83f239615f13ce8166b5aaa26295f993a88a4586
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337904
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-01-17 19:15:12 +00:00
Cody Cutrer 1797b412c6 bundle update --bundler 
Change-Id: Iffc641090e25eb1aefa9e3351bb804c361d69244
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335507
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2024-01-17 19:14:06 +00:00
Cody Cutrer 00f1eeeca9 bundle update rake 
Change-Id: I4cdde145effb3ce7060d3c1eb280fcc75a873050
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332704
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2023-11-13 21:37:43 +00:00
Cody Cutrer bd0097b762 bundle update --bundler 
Change-Id: I20dc6723943fc442865dad2fb68d512d7b98459a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328959
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2023-09-29 15:42:35 +00:00
Cody Cutrer f4d059689f bundle update rails 
Change-Id: Ie89256cf0eff7ac0adbdb590248cfbe548f8353c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327335
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-09-13 13:30:05 +00:00
Cody Cutrer 6dff8b8bfe bundle update factory_bot 
Change-Id: I8a72032faaa8aa359a7b34b041633c947f3801b9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326814
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2023-09-11 16:04:11 +00:00
Cody Cutrer f4c34f6393 bundle update --bundler 
also, don't set BUNDLER_VERSION env var in Docker, so that
bundler's auto-install-and-restart-with-the-correct-version
feature can work

Change-Id: I8e3722197fb3598b5c40679d997f19b3b3957ea8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326580
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-08-30 23:31:39 +00:00
Cody Cutrer 1397092957 bundle update rails 
Change-Id: I8c3e93b99f9656e64520400e1ee10123b836a075
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325864
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-08-22 22:23:08 +00:00
Cody Cutrer dd453ba37c bundle update rails 
Change-Id: I39eb3799ab011b16fb2cb448f032ffafd21087d3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325834
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-08-22 21:18:44 +00:00
Cody Cutrer 6347778e4e bundle update tzinfo 
Change-Id: Iea47a60ee8056b761d38ef854aa44ccb435bc585
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325486
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-08-17 19:37:28 +00:00
Cody Cutrer f450de57b6 bump rails 
Change-Id: Idf23d6f1926efb208d8d8b3e6f9629676b4bdb76
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/324918
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-08-11 17:42:20 +00:00
Cody Cutrer 5de85fb2d3 bump rails 
Change-Id: Ia59f4a8831c6bfc6f44d6490f7f2f5dbf43c0006
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323855
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-08-08 17:30:30 +00:00
Cody Cutrer ccba9e75b1 bump rspec-related gems 
Change-Id: Id53c1d31be838972bcfb5c45dd9d9861aa240752
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323856
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-08-07 20:13:45 +00:00
Cody Cutrer 399181bb27 bump rails 
Change-Id: Ia540a9ccc668e7dab62cda642b6eb9da2b661604
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321691
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
 2023-06-30 19:07:11 +00:00
Cody Cutrer 003e65f3aa bump rails 
Change-Id: Ib9a7f75fde9d85ac8d650ae2cad1b00cd5f98a4f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/320432
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-06-27 19:06:17 +00:00
Cody Cutrer c51fc4be30 add `ruby` platform to lockfiles 
Change-Id: I865d51f54945dad9ec7ccc6f22e0cf4ee587c641
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321480
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-06-27 17:56:13 +00:00
Jacob Burroughs 7dcc507d0a Rubocop for ruby 3.1 
[skip-stages=Flakey]

Change-Id: I6abefdfa9fed6dd4525c8786e93efa548b3710f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319603
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
 2023-06-06 16:44:26 +00:00
Cody Cutrer 2ad4ea5d18 fix lockfile syncing from canvas lockfile to sub-gems 
Actually use Bundler to write them out. this ensure that all
constraints are checked with the gem's Gemfile. Had to resolve
several issues with gems along the way.

also removed RedCloth from canvas_stringex, because it's never
used

Change-Id: I614be19e147bdfd3e351e7f032fd6f9b0c1926be
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317781
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2023-05-09 22:57:42 +00:00
Cody Cutrer 92f0d11892 bump i18n 
this includes a fix for https://github.com/ruby-i18n/i18n/issues/639,
and thus we need to adjust a spec

Change-Id: I5b1425245f942dcdfdcfa34863ec43c1afe6ff0f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317518
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-05-04 16:16:29 +00:00
Cody Cutrer 64c4308714 commit lockfiles for sub-gems 
still need to ensure gem dependencies are consistent, but this should
prevent unexpected breakage during tests

Change-Id: I39420479fd3fe4f7e49a12a418eca033fcdc7564
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/314979
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
 2023-04-14 14:07:43 +00:00
Cody Cutrer 1d3d9ed499 rubocop: fix miscelleneuos violations in prep of bumping rubocop 
Change-Id: I9d37303737f00d6e022cb8fc08726e293a7336ab
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315166
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2023-04-12 19:26:13 +00:00
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
 2021-11-25 14:03:06 +00:00
Cody Cutrer 60be8542df RuboCop: Security 
[skip-stages=Flakey]

manual

this isn't a complete fix, but addresses many offenses

note in particular for feature flags the enable_at key
has changed from doing eval to a Date.parse.

Change-Id: I1381a107c238dc7102a815cc0b38df390299e59f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279085
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2021-11-20 21:09:11 +00:00
Cody Cutrer ff99d18138 RuboCop: Style/RedundantSelf 
[skip-stages=Flakey]

auto-corrected

Change-Id: I5f26ad1f8210a74c2198b514235d5134dcd0dae1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279070
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-20 16:41:21 +00:00
Cody Cutrer ecd0798aeb RuboCop: Style grab bag 
[skip-stages=Flakey]

see .rubocop.common.yml changes for enabled cops

auto-corrected

Change-Id: Ia63a1c597c58646394b251ce81b707f32828bd4c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279010
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
 2021-11-20 03:04:04 +00:00
Cody Cutrer 4d43809cae RuboCop: Style/PercentLiteralDelimiters 
[skip-stages=Flakey]

auto-corrected, with a post-review looking for multiline strings
to convert to heredocs

Change-Id: I7f7afb11edd63415cde10866822dd2ac5ba0d8be
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278669
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
 2021-11-18 23:05:50 +00:00