closes FOO-1120
refs FOO-1125
flag=none
introduce canvas-errors logging callback
move error logging from application_controller
to Canvas::Errors callback
let all canvas::errors callbacks handle the new options hash
don't send errors less than ":error" level to sentry or
error reports.
change error stats to be grouped by "level", and use
error name as a tag.
TEST PLAN:
1) regular errors should still hit all the callbacks
2) errors declared as ":warn" or ":info" levels should
not make it to sentry (like SAML MissingMessage errors)
3) local errors during development should still get logged out
to development.log file
Change-Id: Ibe1401c0f5ad8f6d697c64f6a34153aaea048281
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251125
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
test plan
- existing errors should work
- have a raven.yml
- populate Settings.set('ignorable_errors', 'some error')
-
Change-Id: I1bbfc003506ef5f15aa7fdb887e0249c84f09c56
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232977
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
refs CNVS-20836
Once this is merged, plugins or extensions can
register their own exceptions if they don't
want them broadcast to sentry for whatever reason
(there are some job failures that are a good candidate
for this)
Change-Id: Ic3bceb8185a92479166ec55c8c6c66dacf259f5a
Reviewed-on: https://gerrit.instructure.com/55678
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes CNVS-20552
This doesn't fix the underlying media object problem, but it's being
reported as an issue with the sentry interface because Raven doesn't
like symbols as messages and trys to call ".message" on them
TEST PLAN:
1) error capturing should still work with sentry
2) call Canvas::Errors.capture with a symbol (instead of a string),
it should get sent to sentry correctly
Change-Id: I84cfe7894892692a8e2d8ea699cba86caf6c2b23
Reviewed-on: https://gerrit.instructure.com/54463
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Cody Cutrer