The code now differentiates between three similar but different error
conditions that prevent an upload: 1) no response from the service, 2)
timing out when talking to the service, 3) skipping over the call due to
timeout protection.
This also changes the timeout protection names around all the crocodoc
calls to be unique.
fixes CNVS-33152
test plan:
- Confirm crocodoc upload and viewing still works
Change-Id: Ie0b1eca38bbcfd1b3f1c3765d772ea7fd28d8bbe
Reviewed-on: https://gerrit.instructure.com/94589
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
closes CNVS-15940
Test plan:
* make a file upload assignment
* submit a crocodocable submission
* turn off delayed jobs
* submit another crocodocable submission
* in speedgrader, the second submission should not display in
crocodoc. you will be notified that the submission is still being
processed
Change-Id: Ifcdda634dd97a81f17d0d753cade0b80f3e0ebce
Reviewed-on: https://gerrit.instructure.com/42387
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
Adds support for optionally viewing documents with Crocodoc.
closes#9865
Test plan:
* configure the crocodoc plugin
* add an assignment that allows file uploads
* make a submission for that assignment with a pdf or doc or ppt
- on the 'submission details' page, opening a preview of the
assignment should display it in crocodoc
- speedgrader should display the submission in crocodoc too
* make a submission with odt or rtf
- the submission should be displayed with scribd or google docs
* if you disable the crocodoc plugin, submissions could continue being
previewed in google docs or scribd
Change-Id: I7dd2547f8e2d907c98ebe894a7f1ee9d58f1e030
Reviewed-on: https://gerrit.instructure.com/13668
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>