Commit Graph

47856 Commits

Author SHA1 Message Date
Luis Oliveira 3aec488ad7 Update text for "Join this course" button
closes: LS-2735
flag=none

test plan:
- Enable K5 mode
- Create a public self-enrollment enabled course
- Visit that course
- Check that the buttons for joining (in the confirmation and auth screens too)
  all refer to the subject as such, and not as course.
  E.g: Join this Subject instead of Join this Course

Change-Id: I3f81e86cf9b7720006d9e9a74b5281c246295ad2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276568
QA-Review: Robin Kuss <rkuss@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-10-26 20:11:12 +00:00
Matthew Lemon 741ae8d333 display media attachments on conversation messages
fixes VICE-2172
flag=react_inbox

Test Plan:
- Enable the react inbox FF
- Setup Kaltura (confluence docs are updated to help you know
  how to do this)
- Create a conversation message and add a media comment to it
- The message should appear with the media comment
- Clicking the title of the media comment should expand the
  media player
- Note that if the media was still being processed by kaltura
  the media player will just render a spinner. Refreshing the
  page after a moment should give you a media player with your
  video in it.

Change-Id: Ifa81cc5981bb37f6ac4cb3eab3a802cf04f1c6ea
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276510
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
2021-10-26 19:54:21 +00:00
Matthew Lemon 6b9cdb0daa implement reply all for react inbox
fixes VICE-2142
flag=react_inbox

Test Plan:
- Enable the react inbox FF
- Navigate to inbox
- Select a conversation and attempt to reply all to a conversation
  message
- It should work =)

Change-Id: Ie930e2557118047129790717e1cd0c33d4f8badf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276784
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
2021-10-26 19:54:03 +00:00
Cody Cutrer fb6e83d719 RuboCop: Lint/UnusedBlockArgument app
all manual

Change-Id: Ia093d2fcc95f9f32c44e73c382a0701e012dae18
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276606
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-10-26 18:56:51 +00:00
Martin Yosifov a7892e6c79 Add Individual Outcome Calculation & Rating Options FF to js_env
closes OUT-4830
flag=individual_outcome_rating_and_calculation

Test plan:
- Go to Account > Settings > Feature Previews and enable
Individual Outcome Rating and Calculation Method Options FF
- Go to Account > Outcomes
- Open dev > console and verify that command below returns true
ENV.INDIVIDUAL_OUTCOME_RATING_AND_CALCULATION
- Go to Account > Settings > Feature Previews and disable
Individual Outcome Rating and Calculation Method Options FF
- Restart local canvas to clear cache
- Open dev > console and verify that command below returns false
ENV.INDIVIDUAL_OUTCOME_RATING_AND_CALCULATION
- Go to Course > Outcomes, repeat the above tests and
verify that results are the same

Change-Id: I865340213ee60a28eec28fac04f3e49b2aeac121
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276643
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Manoel Quirino <manoel.quirino@instructure.com>
Reviewed-by: Chrystal Langston <chrystal.langston@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Ben Friedman <ben.friedman@instructure.com>
2021-10-26 18:56:35 +00:00
Cody Cutrer 2ed15f8d05 spec: automatically require spec_helper
[skip-stages=Flakey]

so we don't have to manually do it, especially with increasingly
complicated relative paths.

and stop manually requiring it in plugins, and also convert any other
require File.expand_path to require_relative

Change-Id: Ifc07149372fe09bcc146ac1b980feb3a9fd62865
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276816
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-10-26 17:39:19 +00:00
James Butters 22cebefa58 rspecq on or off, no percentage
Change-Id: Idaecd8bcb1542d2e3624b4d8c7e8420bf6cdad79
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276818
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-10-26 17:19:15 +00:00
Cody Cutrer 08b6fdeb64 add terminate_sessions API for users
closes FOO-2416

test plan:
 * login as a user
 * create an access token
 * as an admin, use DELETE /api/v1/users/:id/sessions of the first user
   (from a different session, or the command line with the admin's
   access token)
 * refresh as the first user
 * you should have to login again
 * look at your profile, and your access token should be expired now

Change-Id: I264de8591324c1ceb0e19c7b2ad62b16a8667bbb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276759
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
2021-10-26 17:10:03 +00:00
Ethan Vizitei 9c5244ca5b Revert "Add a jenkins stage to enforce zeitwerk compliance"
This reverts commit fc538f4336.

Reason for revert: unblock existing builds

Change-Id: I68e254fee49d0305b43e6f489e3ed88f52b3167e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276731
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
Tested-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
2021-10-26 17:05:33 +00:00
Jeremy Stanley 4a6509edf9 switch to primary to mark submission annotations unread
test plan:
POST to /api/v1/courses/X/assignments/Y/submissions/Z/annotation_notification?author_id=W
should not fail when a read-only secondary DB is configured

flag = submission_feedback_indicators

fixes LS-2795

Change-Id: I181adfc485412ad16add00f0c097d77f5b5e99fd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276825
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
2021-10-26 17:00:30 +00:00
Gonzalo Penaranda bfcdf55451 Include underlining for links on RCE editing
Fixes MAT-481
flag=none

Test Plan:

- Make sure High Contrast UI toggle is disabled
on the Account sidebar option
- Open a RCE instance
- Add a link to any URL with any text
- After adding, the underlining for links shows

Change-Id: I82913aad3687d16d3ce90ad394ce35c9c2a17117
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276652
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
2021-10-26 16:51:45 +00:00
Cody Cutrer 814149ddb8 rubocop: add some cops to the low-SnR group
there are too many existing offenses for these cops (thousands), that
means they are just an annoyance until we can address them in bulk

Change-Id: Ia1388d41659cdb10aa9a78bf827ee5fc7384704b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276824
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-10-26 16:33:04 +00:00
Ethan Vizitei 8aafc7d464 unconfuse OAuth::Helper references
refs FOO-2529
flag=none

TEST PLAN:
  1) sentry error goes away

Change-Id: I32305a316832fa21bd1edb8550cba309a3222c35
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276823
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
2021-10-26 16:18:22 +00:00
Caleb Guanzon eec5d783e4 spec: add selenium test for reporting a reply
flag = react_discussions_post
fixes VICE-2159

test plan:
code review

Change-Id: I1bc9f19e72357b7ffaa75d0fc494be949b826b91
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276767
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
2021-10-26 15:56:27 +00:00
Weston Dransfield 04bdbb9fdb Update canvas-rce translations
flag=none

Test Plan:
new strings are available in canvas-rce

Change-Id: I637892ba3c46c990ca1d9220758a38248def7013
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276817
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
2021-10-26 15:56:24 +00:00
Cody Cutrer 3b38d39572 support suspending users via SIS import
closes FOO-2414

test plan:
 * create a user via SIS
 * run another SIS import with the user's status set to "suspended"
 * that use should no longer be able to login

Change-Id: I31b177ee797b3dd8962112960bda11c5c4fa575a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276557
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-10-26 15:26:11 +00:00
Cody Cutrer 099f2f63f9 spec: ensure sis export report includes suspended users
closes FOO-2415

Change-Id: Ibc277a371d0acde1b10de9d4601294d700be5505
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276562
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-10-26 15:25:53 +00:00
Ethan Vizitei fc538f4336 Add a jenkins stage to enforce zeitwerk compliance
refs FOO-2439
flag=none

TEST PLAN:
  1) build passes
  2) introduce a non-zeitwerk-compatible constant
  3) next build fails

Change-Id: Ib4594b056ffb222f5217f7df8c50abd289872c93
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276279
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
2021-10-26 15:03:08 +00:00
Ethan Vizitei c656c0d60e make globalLookups a module to extend, not a stub
refs FOO-2498
flag=none
[pin-commit-multiple_root_accounts=5bd07698db01843f784622d0a99277bbd7be0dc1]

the stub pattern won't work with zeitwerk

TEST PLAN:
  1) specs pass with plugins migrated to autoextension of GL

Change-Id: I29c7249e38d06e54d4fc111f8a845d4e94ea70f3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276301
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
2021-10-26 14:58:27 +00:00
Jon Scheiding fdc3b44241 Add Content-Security-Policy for vanity domain iframing
flag=none
fixes MAT-439

Test plan
- Set up MRA / vanity domains
- Create a vanity domain for your Canvas (e.g. vanity.canvas.docker)
- Using your primary domain (e.g. canvas.docker), create a wiki page and
  embed a media file in it
- Using your vanity domain, browse to the wiki page you created and
  ensure the media file renders correctly

Change-Id: I2ccb6731d872ca6a6d79fb7d005655ae6b7ce852
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274794
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jon Scheiding <jon.scheiding@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
2021-10-26 14:09:57 +00:00
Michael Ziwisky 7bf1fbf53e don't publicly expose subgraph introspection query in prod
refs INTEROP-6995

we'll use Apollo Studio or some similar schema registry in production
environments.  public exposure is just a convenience for local dev -- it
allows you to run the API Gateway without needing an Apollo Studio graph
set up for it.

Change-Id: I3c996c76b985e81671d49b25d24db6ed2bfaf674
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/271283
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sean Scally <sean.scally@instructure.com>
2021-10-26 01:32:54 +00:00
Xander Moffatt 83946e2d4e fix: only listen for deep linking after tool open
why:
* as part of an ongoing project behind a feature flag, I added
deep linking to the module_index_menu placement, launched
from this file
* the correct response for a deep link at this placement is to
reload the page, since the module items were created on the
backend
* the listener was added at the top level (so on page load), which
conflicts with an existing listener added when a single module
item is added, meaning that before a user gets a chance to save
that single module item, the page reloads
* this means that no single module items returned from 1.3 tools
can be added right now

closes INTEROP-7114
flag=none

test plan
* with a 1.3 tool installed, that has the link_selection placment configured
* with an existing module
* without this code checked out, run webpack
* add an item to this module of type External Tool and select the
1.3 tool
* try to return a content item by clicking Send Deep Link to Platform,
and notice the page will reload before you can click save
* you may also be prompted to Leave Page with unsaved work
* with this code checked out, run webpack again
* add an item of External Tool type to this module, and select
the 1.3 test tool
* you should be able to edit and save the link returned, and
create a module item

Change-Id: I94b48cabc385a9b44e2d34c967080ace57fff278
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276194
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alexandre Trindade <alexandre.trindade@instructure.com>
Reviewed-by: Tucker Mcknight <tmcknight@instructure.com>
QA-Review: Alexandre Trindade <alexandre.trindade@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
2021-10-26 01:11:41 +00:00
Ethan Vizitei 7954f51512 bump canvas_webex
refs FOO-2434
flag=none

TEST PLAN:
  1) specs pass

Change-Id: Ice36e2bea7a0188356def1c40c21369b1ef74b40
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276771
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
2021-10-25 22:46:26 +00:00
Matthew Lemon 82291bd7b5 fix busted inbox gql query
flag=none

Test Plan:
- Navigate to inbox
- Select a conversation and hit the reply button
- It should load the compose modal
- Hit reply on a conversation message inside a conversation
- It should load the compose modal

Change-Id: I9dfe2a1df44b857bd2198f538159763d0238c352
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276778
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
2021-10-25 22:01:17 +00:00
Jackson Howe f0e10a5236 Support parents with cross-shard enrollments
closes LS-2750
flag = k5_parent_support

Test plan:
 - Check out the setup steps in ticket LS-2750
 - Visit the dashboard as the observer and expect to see the
   cross-shard user in the dropdown

Change-Id: I9dff318e177e7891a063f4cf4afa860fb38b1280
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276370
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
2021-10-25 21:32:35 +00:00
Matthew Lemon 137fd38f3b spec: skip spec until we fix inbox FE
Change-Id: Ia04b4eba9e65f0fa6b73cc02f1d07b83932cc3d3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276772
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
2021-10-25 21:10:52 +00:00
Adrian Packel f23e6259a4 Add updated "message students who" dialog
Add a basic component for an updated "Message Students Who" dialog,
viewable in Storybook but not yet accessible from Gradebook. This is
meant to give us a base to begin adding functionality and does not
presume to be the correct or final version of the UI.

closes EVAL-2056
flag=message_observers_of_students_who

Test plan:
- Test that the component appears as expected in Storybook

Change-Id: Ice349c68d4c717809d4fcbae4c8cae0a5fe7a5f1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276525
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
2021-10-25 20:38:53 +00:00
James Butters 0e69a91cf3 do not run node if queue is empty
[use-rspecq]

Test Plan:
-Jenkins passes both with and without rspecq
-add sleep to one node, wait for queue to empty
  -node will not run any stages since queue is empty
-add sleep to one node, wait but still have tests in queue
  -node will still run stages and tests

Change-Id: Iace45f456c19284c6a338f5537a367917fd4f9c0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275325
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
2021-10-25 20:17:59 +00:00
Matthew Lemon 56ddf1597d implement reply for conversation messages
fixes VICE-2141
flag=react_inbox

Test Plan:
- Enable the react inbox FF
- Navigate to the inbox
- Open a conversation and reply to a conversation message
  within the conversation
- Huzzah

Change-Id: If9d4baf4d538c4ea07f8df355651407276180279
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276561
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
2021-10-25 19:52:48 +00:00
Spencer Olson 5cf0922f94 stop passing custom prop to time tag
flag=none

Test Plan:
- specs pass

Change-Id: If629f81ac9bca86cc4b07d31c9cf6d7cfda5ce30
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275961
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Syed Hussain <shussain@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
2021-10-25 19:09:18 +00:00
Robin Kuss b57934335e spec:pace plan modules selenium
Closes LS-2767

Test Plan: passes Jenkins and tests the pace plan modules

Change-Id: Id8cdb359ca396e3ad550d2e9d46e3da420e5be02
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276584
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
2021-10-25 19:02:34 +00:00
Cody Cutrer bec3c7d33b RuboCop: Lint/UnusedMethodArgument gems
all manual. a few cascaded to cleaning up leaky consts in specs

Change-Id: Ia77478b92f23e06d1023f4e3cfa02a751593a368
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276484
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-10-25 18:57:24 +00:00
Cody Cutrer ea8cc92081 unguard the database server before running partitioners
fixes FOO-2519

since they could be set to prefer_secondary, which will ignore the GuardRails.activate(:deploy)

Change-Id: I6e7234e6b6b68121406d5fbbacbb19c7bbe984c7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276727
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-10-25 18:20:33 +00:00
Caleb Guanzon 5392acd247 spec: add new conversations media test
fixes VICE-984
flag=react_inbox

unfortunately, in selenium, trying to attach a media file
to upload leads to packages/canvas-media/src/ComputerPanel.js
erroring out. so this tests stops that the ui for uploading media
exists when replying

test plan: code review

Change-Id: I179d5adf369f7e38c3c9e44874941f21f526eee4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276750
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
2021-10-25 18:17:37 +00:00
Omar Gerardo Soto-Fortuño 8cea9a7a6f Fix Discussions Reporting notifications
closes VICE-2185

flag=discussions_reporting

test plan:
  - Specs pass

qa risk: low

Change-Id: I3ceadca171cbe6bc52a9bbca6929942016ff66a5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276753
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
2021-10-25 18:14:49 +00:00
Drake Harper 23588d60a0 Fix unique key prop console error in ThreadActions
refs VICE-2075
flag=discussions_reporting

Test Plan:
 - load a discussion with redesign ff turned on
 > should not see a unique kep prop console error

Change-Id: Ia1e3242c6f46330c34fc1c5a17905cfabaf81b21
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276751
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-10-25 18:11:27 +00:00
Aaron Ogata 5ec29f69d0 only spawn threads for files that will actually upload
refs DE-859

Change-Id: I625a36b823a3ed7d879e0e1da266c235c74a1f0a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276752
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
2021-10-25 18:03:14 +00:00
Chawn Neal 2dec8ef1ec Convert Delete message from flex to view
fixes VICE-1833
flag=react_discussion_post

This will fix the focus from being cut off.

Test Plan:
 1) Go to a discussion.
 2) create a root reply.
 3) create a child for that reply.
 4) delete that reply.
 5) Compare delete message with existing design.
  a) you can compare to cd.
  b) or a deleted post before my change.
 6) click on the screen above the message.
 7) use the tab to novigate to the deleted_message's replies.
 8) focus state should encapsulate the replies button

Change-Id: Ia788f878f6f0406be98f1af7ba768bdf10551de5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276291
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
2021-10-25 17:57:07 +00:00
Matthew Lemon ddf60591dc improve UX for reporting profile pictures
fixes VICE-2049
flag=none

Test Plan:
- Enable profiles on the account settings

- As a teacher navigate to the people page on a course
- Click on a user with a profile picture and then click on their name
  in the tray that opens
- The avatar image should no longer be clickable and there should now
  be a link next to the avatar saying "Remove avatar picture"
- Clicking the link should open a "Confirm Removal" modal with the
  message "Are you sure you want to remove this user's profile picture?"
- Hitting confirm in the modal should result in a success alert saying
  "The profile picture has been removed." and the avatar image should
  be removed from the page.
- If you refresh the page, the avatar image should show the default
  avatar image.

- As a student follow the same steps as above to get to a different
  user's profile page
- As a student you should see a link with the text "Report inappropriate
  picture"
- Clicking the link should open a "Report Profile Picture" modal with
  the message "Reported profile pictures will be sent to administartors
  for review. You will not be able to undo this action."
- Hitting confirm in the modal should result in a success alert saying
  "The profile picture has been reported" and the link should no longer
  be a link and the text should update to "This image has been reported."
- Refreshing the page should show the text "This image has been reported."
  instead of a link

Change-Id: If8fed6939d27c610fb66c3f4b0491a3fa350ef02
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276261
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
2021-10-25 17:57:04 +00:00
Matthew Lemon 0b5401fe42 allow querying conversation messages before a given date
When replying to an older message in a conversation we only
want to include older messages. This will allow us to exclude
newer messages when replying to a conversation message.

refs VICE-2141
flag=react_inbox

Test Plan:
- Have a conversation with a bunch of messages of varying ages
- Navigate to /graphiql
- Run the following query:

```
query MyQuery {
  legacyNode(_id: <conversation_id>, type: Conversation) {
    ... on Conversation {
      id
      conversationMessagesConnection(createdBefore: <iso8601_timestamp>) {
        nodes {
          createdAt
          body
          _id
        }
      }
    }
  }
}
```

- You should only get back messages created before the given
  timestamp

Change-Id: Ib32cb3224d6fbf469c78b4f35d1bc4726b0fa365
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276560
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
2021-10-25 17:56:41 +00:00
Lindsey Reno f3fab56668 Add url to new analytics feature flag description
test plan:
 - Visit ff page
 - Should have a link to the community

fixes OREO-1113
flag=analytics_2

Change-Id: I6d058d0738612ef80d9a5c81a1138a45729c4447
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275521
Product-Review: Carly Curran <carly.curran@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kwok Lam <klam@instructure.com>
Reviewed-by: Bryant Larsen <blarsen@instructure.com>
2021-10-25 17:52:19 +00:00
Kyle Rosenbaum 722512eaca adjust random number generation to spread over 100 for rspecq
Change-Id: I4b53f28ad9426a1453b4f7d8413868cdad59748b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276625
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
2021-10-25 17:00:46 +00:00
Service Cloud Jenkins 3afbee9a19 Update parallel_runtime_rspec.log from build 264
Change-Id: Ib6f5e9da5cb58cdd11f5a66e441e41e9d8453e7c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276662
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
2021-10-25 16:59:25 +00:00
Evan Battaglia 07b7fef075 DRY up a couple constants by using JS ENV
Test plan:
- go to course settings integrations page
- make sure copy mentioning max number of users in a team still shows
  correct numbers (25,000 and 100)

refs INTEROP-6805
flag=microsoft_group_enrollments_syncing

Change-Id: I01c6839bd63d8f221159050a68c04b28da09fda8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276585
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Evan Battaglia <ebattaglia@instructure.com>
2021-10-25 16:39:21 +00:00
Evan Battaglia 5bfb1572bd Don't restrict canvas_icon_class
We apparently we're restricting the values before
dbd8c466 fixed `"canvas_icon_class": { ... }` to
`"canvas_icon_class" => { ... }`

(Since that commit was ostensibly just a linting commit but changed
semantics, it might be worth revisiting other things in that commit.)

fixes INTEROP-7109

Test plan:
- Edit an LTI 1.3 dev key JSON in the Developer Keys UI
- Add "canvas_icon_class": "icon-pdf" to a placement in an LTI 1.3 dev key
- Make sure the dev key saves
- Observe that the dev key cannot be saved before this commit

Change-Id: Ibb22a8d5d9ebdb9b7afb99adf9ab2893be863165
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276645
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Karl Lloyd <karl@instructure.com>
2021-10-25 16:31:19 +00:00
Jacob Burroughs c4c8aed683 Fix services jwk rotation
Change-Id: Ia304051a03a0a311292b3730c0462d115b20d88a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276712
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-10-25 15:14:12 +00:00
Jeff Largent a6f45b2482 Improve C4E sticky header overlapping element spec?
An attempt to make the spec for fixing keyboard navigation on pages
with the sticky C4E better before we just remove it.

refs LS-2729
flag = none

Test plan:
  - Passes Jenkins and is not flakey

Change-Id: I0a2ae5f97405969f7a6b9ca7120ffe058b1102de
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276705
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jeff Largent <jeff.largent@instructure.com>
2021-10-25 14:03:41 +00:00
Luis Oliveira 186bdbac2e Update course favoriting course
closes: LS-2734
flag=none

test plan:
- Enable K5 mode
- Create 2 courses, A and B
- Enroll into course A as a student
- Check that you can't favorite/unfavorite course A
- Enroll into course B as a teacher
- Check that you now can indeed favorite course A
- Favorite course B, leave A unfavorited
- Check that your home show only course B

Change-Id: I20f4c63b00169f5ce2089be4b9a60e5d0766d939
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276536
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
2021-10-25 03:02:49 +00:00
Jenkins 9933a4c3fe [i18n] Update package translations
Change-Id: Ia26d0d213494033b25cceb5b5c5aa550dbf89bf8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276653
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-10-23 04:50:40 +00:00
Martin Yosifov 8a52bbb94b Add 'Individual Outcome Rating and Calculation Method Options' FF
closes OUT-4820
flag=individual_outcome_rating_and_calculation

Test plan:
-qa-cr-

Change-Id: I43aee6f1d00f806514cb1ccff4423faf4d93da4b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276541
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Brian Watson <bwatson@instructure.com>
Reviewed-by: Manoel Quirino <manoel.quirino@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
2021-10-22 21:43:21 +00:00