test plan:
* the dashboard should still work
closes #CORE-1746
Change-Id: Id522cf740eed9e60a7410f0222bb1a76add2fcb0
Reviewed-on: https://gerrit.instructure.com/161484
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* regression test dashboard
closes #CORE-1733
Change-Id: I301e8670c9fccd1a2340adce01379f0c6d3b7c01
Reviewed-on: https://gerrit.instructure.com/161174
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes ADMIN-1199
closes ADMIN-1031
Test plan
- This is a pretty hefty re-write for appointment
group permissions. May need regression testing
- Set up at least one or two courses with
appointment groups
- Set up at least one "manage_calendar by default"
user and one non-default user
- Ensure they can see the appointment groups in
the calendar as appropriate
- Fiddle with their permissions (by the enrollment
role or by admin roles) and ensure the user can
see the appointment groups as appropriate
- While a student is able to manage the appointment
groups, ensure they can see them on the planner
- In the server logs, ensure the appointment groups
don't create N+(6/7/8) queries
Change-Id: I5d5e1b4e8a83544374db063c76377b85b095d61e
Reviewed-on: https://gerrit.instructure.com/154975
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Mysti Sadler <mysti@instructure.com>
James Williams