otherwise we might still display "tomorrow" when midnight rolls over and
things are now due "today", for example.
Change-Id: Iebba1f2b9d7bee3831e61ef062bd4caffb162a21
Reviewed-on: https://gerrit.instructure.com/3175
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
External tools require Basic LTI, which needs to be stated
a little more explicitly in the UI or people are going to
be confused.
Change-Id: I9086a2e48c68300ae7aca2277aa209093b812f3f
Reviewed-on: https://gerrit.instructure.com/3144
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
this commit fixes a bunch of problems with importing
a whole export package and updates the UI
refs #3396
Change-Id: Ia344b385e06df2f08bb75878234a7712a036e4b3
Reviewed-on: https://gerrit.instructure.com/3085
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
started the framework for importing the canvas flavored
common cartridge packages. There is also some minor
refactoring of the export step to allow for easy testing
of both exporting and importing
course settings, assignment groups, and external tools
are imported and tested with this commit
refs #3396
Change-Id: I4e8a2ebfc9df7e31f8859b189fea23f9584d7ef4
Reviewed-on: https://gerrit.instructure.com/3042
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
* Include rubric_assessments inline, rather than linking to submission page
* Add link to "Show All Details", expands all rubric_assessments and comments sections
Change-Id: I93065908fa181a337a6497d5e3142324cfed6479
Reviewed-on: https://gerrit.instructure.com/3036
Reviewed-by: Brian Whitmer <brian@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Well, not quite so obviously, anyway (Rails is generating some
JavaScript and a form behind the scenes). Anyhow, doing it this way,
the controller renders html and a proper redirect, and the browser
respects it. Fixes#4070.
Change-Id: I5477a12f746f4335202f7dd628f65da531038e23
Reviewed-on: https://gerrit.instructure.com/3022
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
* Add modules to wiki sidebar
* Fix redirect from courses/:id/modules/:module_id to courses/:id/modules#module_:module_id, rather than just courses/:id/modules
* Auto-expand the specified module when you access modules/#module_:module_id
Change-Id: Iaa2ab30dc462fec753fe67928fb101212cff440a
Reviewed-on: https://gerrit.instructure.com/3021
Reviewed-by: Brian Whitmer <brian@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
It turns out that teachers like to use the SpeedGrader even for assignments
that aren't turned in online, instead of the Gradebook. That might change with
the improved Gradebook though.
Change-Id: I8b8b0620873a4adcc1f91db260d3cbfc02410071
Reviewed-on: https://gerrit.instructure.com/2980
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
- td where it should be a th
- missing a js file to report inappropriate pictures
Change-Id: Ifff7fd3b5ba307349bd06666b4c04d9a07c6e20e
Reviewed-on: https://gerrit.instructure.com/2970
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
This solves a few problems.
- will make it easier to support HTML5 video playback
for systems that don't handle flash
- first step toward making it possible for canvas
installs to migrate from one kaltura instance to
another by making a place for us to put some
additional logic if necessary
- third parties getting data from us are no longer
forced to find and handle media comments in order
for them to work, since this adds a fallback url
refs #4083
Change-Id: I729aaf88378a30bda2126bfca2b2a48ec14bb386
Reviewed-on: https://gerrit.instructure.com/2901
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Quiz statistics weren't supported for all question
types. Also added a csv export of the raw quiz
results data, with an attempt to make the data
meaningful even for complex question types.
fixes#4134
Change-Id: I55d1a21eed1cd6813fe0500190a1c0cc5fc038ab
Reviewed-on: https://gerrit.instructure.com/2850
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
proactively found and fixed varchar(255)'s where we relied on mysql's
silent truncation. added validations for places where we want to
enforce these limits
made it so you can reuse titles/urls of deleted wiki pages, and added
validations to ensure sane urls and prevent orphaned pages
Change-Id: I15bcc0c7a751efba1a0f7548e9989ad2ea1792bf
Reviewed-on: https://gerrit.instructure.com/2935
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
If a user's logins are all part of one account and you enroll them in
a course in another account, then go to their page in that account and
you'll see a link to delete them from the root account. Deleting them
from that root account will delete them from everywhere, which is not
the intended behavior. The logic was only checking logins, not
enrollments, and also was just checking the number of root accounts, not
if there were any *different* root accounts.
fixes#4108
Change-Id: Id7584c8766420b3ae8bb557444785513dca201b9
Reviewed-on: https://gerrit.instructure.com/2819
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
Teachers can specify that before students see any
messages in a topic they need to post at least once
in the topic themselves. This is used for
assignment topics or to help encourage students
to think for themselves instead of just posting
"what he said".
fixes#3871
Change-Id: I946b71ec47bfe135f06faff68598c6f19c088a27
Reviewed-on: https://gerrit.instructure.com/2370
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
The link in the gradebook to see information should link to the
speed grader instead of to the submission grades page, which has
less information.
fixes#4115
Change-Id: I6e9beae2d0e4ead7f0da0e025dcc5137d98893d3
Reviewed-on: https://gerrit.instructure.com/2837
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
the problem was that it was using a global js variable
'id_maps' to know which student was on which row.
when I removed rows not in this section, the rows
would be off.
Change-Id: Ifb4813cae5074c351a16767e1bda4dbaf2092b61
Reviewed-on: https://gerrit.instructure.com/2856
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
Also did a couple other tweaks:
* Fixed the "Time" display when reloading via ajax (wasn't checking for the
right workflow_state
* Hide the "Attempts" column on quizzes that have an unlimited # of
since it doesn't contain any useful data (always "--").
Change-Id: I21182193005d7415594b9c0531c03d619a31c262
Reviewed-on: https://gerrit.instructure.com/2857
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Each topic can now have its own podcast stream. Teachers
have to manually turn on the podcast for the topic, and
can specify whether student comments show up in the stream
or not.
fixes#3538
Change-Id: I19b1b44fc2eec864cfeb298163ef34a0b0181067
Reviewed-on: https://gerrit.instructure.com/2369
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
If a page hasn't finished loading and a user clicks on a
"#" link (javascript-enabled), then it'll jump them to
the top of the page unexpectedly because the listener
isn't ready yet. This commit will catch all those early
clicks and replay them after dom ready.
fixes#4109
Change-Id: I19a0b8a56e39eead693764d660ed6197ff6b0528
Reviewed-on: https://gerrit.instructure.com/2793
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Question banks can be aligned to outcomes that
are part of the same context. Whenever students
take a quiz with questions from the bank they'll
get evaluated for the linked outcomes based on
the points they got for each bank question.
Also fixed a bug which may or may not have existed
before this commit that unexpectedly deleted quiz
submissions when a user tried to re-take a quiz.
refs #3317
Change-Id: I744af3915672a5e260b078503e0bc648c238eca9
Reviewed-on: https://gerrit.instructure.com/2641
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
We were doing the query 3 times with different limits, so they weren't
getting cached. So it's actually more efficient to use the default limit of
15 and then just truncate the result array.
Change-Id: I2e4699574a64146585e2e8c533296e32a0c2be33
Reviewed-on: https://gerrit.instructure.com/2826
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
These are no longer used and can have a significant db cost.
Change-Id: I8fcf7cfe3a20e056310d760d97ca3a04ca387bb7
Reviewed-on: https://gerrit.instructure.com/2825
Reviewed-by: Zach Wily <zach@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Jon Jensen