test plan:
* configure a tool with a file_index_menu placement
(similar to the wiki_index_menu type)
* enable the "Import Commons Favorites" feature
* should launch the tool though a cog dropdown
in the header of the files page into a tray
* closing the tray after a message has been posted
should cause the page to refresh
flag=commons_favorites
closes #LA-290
Change-Id: I9e825401fd66734da6269c62054578ccd443a4f6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/218501
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
test plan:
* launching a tool with the
module_index_menu and assignment_index_menu placements
should return an array of hashes for the
com_instructure_course_available_canvas_resources
variable, as described in the documentation
refs #LA-75
Change-Id: I2c81ca611a60dfdc67d62823b35319353c4d846d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/218693
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* configure a tool with a
assignment_group_menu placement
(similar to the assignment_index_menu type)
* enable the "Import Commons Favorites" feature
* should launch the tool though a cog dropdown
for a specific assignment group into a tray
* the selected resources posted to the tool
should only list the one assignment group you selected
* closing the tray after a message has been posted
should cause the page to refresh
flag=commons_favorites
closes #LA-287
Change-Id: I65c38b87a863c25a45c55eae55c87994b5471632
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/218306
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* testing with the new index placement tools
on the assignments/modules page should send
the available canvas resources encoded
as a JSON string so the oauth signature works
Change-Id: I329c819a17ca70b84a5d165964246af6e635dacb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/218523
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* configure a tool with a
module_group_menu placement
(similar to the module_index_menu type)
* enable the "Import Commons Favorites" feature
* should launch the tool though a cog dropdown
for a specific module into a tray
* the selected resources posted to the tool
should only list the one module you selected
* closing the tray after a message has been posted
should cause the page to refresh
flag=commons_favorites
closes #LA-286
Change-Id: Idbaa746fc98d4ac4097da8488b7120a6acedc23f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/218212
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* configure a tool with a
discussion_topic_index_menu placement
(similar to the wiki_index_menu type)
* enable the "Import Commons Favorites" feature
* should launch the tool though a cog dropdown
in the header of the discussions page into a tray
* closing the tray after a message has been posted
should cause the page to refresh
flag=commons_favorites
closes #LA-78 #LA-79
Change-Id: I06e5915fe899f9bfd0f66b1a52b4a4faf28b814b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/218155
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* configure a tool with a quiz_index_menu placement
(similar to the wiki_index_menu type)
* enable the "Import Commons Favorites" feature
* should launch the tool though a cog dropdown
in the header of the quizzes page into a tray
* closing the tray after a message has been posted
should cause the quizzes page to refresh
flag=commons_favorites
closes #LA-76 #LA-77
Change-Id: I2205d3a73bb0c6bd2d60992968fa28b129e0e177
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/218039
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* configure a tool with an assignment_index_menu placement
(similar to the wiki_index_menu type)
* enable the "Import Commons Favorites" feature
* should launch the tool though a cog dropdown
in the header of the assignments page into a tray
* closing the tray after a message has been posted
should cause the assignments page to refresh
flag=commons_favorites
closes #LA-74 #LA-75
Change-Id: If2e7ec2055dd1be0706fe684b1bc617db039e70a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/217973
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs PLAT-4599
Test plan:
- add an LTI 1.3 tool without the default placements (assignment selection
and link selection) and check that they do not show up there (when
creating an assignment, and ... wherever the link selection shows up).
The Live Events LTI tool which you may already have installed fits the
bill for such an LTI 1.3 tool.
- add a LTI 1 tool (such as the LTI test tool) without the default
placements and check that they still do show up in those places.
- can anyone think of anything else to check?
Change-Id: I68cd37e2b8ed4015037354ab2609f47a2e0f8bcc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/217323
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
test plan:
* configure a tool with an module_index_menu placement
(similar to the wiki_index_menu type)
* enable the "Import Commons Favorites" feature
* should launch the tool though a cog dropdown
in the header of the modules page into a tray
* closing the tray after a message has been posted
should cause the modules page to refresh
flag=commons_favorites
closes #LA-71 #LA-72
Change-Id: I4ab15bf71da574482b107cbbba295cb4557f4fa8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/217828
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Closes PLAT-5143
Test Plan:
- Install an LTI tool that uses the new
$com.instructure.Person.pronouns variable
expansion
- Do an LTI launch and verify the post parameter
contains the current user's pronouns
Change-Id: I03ae80e0c6a3fe6a7ada5ce87da8cf8a97299964
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/217430
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Evan Battaglia <ebattaglia@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Evan Battaglia <ebattaglia@instructure.com>
refs LA-70
flag=commons_favorites
test plan:
- Set LTI to have message_type of 'ContentItemSelectionRequest' and
set up for wiki_index_menu
- LTI launches successfully
Change-Id: I8da26b8dafcf80950bcb41091ad508ddd20e8839
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/215861
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Mate Magyar <mmagyar@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
closes ADMIN-2891
flag=none
test plan:
- Set up new LTI Tool to accept the 4 custom parameters
- On Pages index, trigger LTI from kabob menu
- See the 4 new parameters are correctly sent to LTI
Change-Id: Ib3a17d2d9a5d6c5117671061a00365ca86a57d4f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/213879
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
https://github.com/lsegal/yard/blob/master/CHANGELOG.md
yard 0.9.6 added functionality which parses code blocks and tries to
auto link constants to their respective yard documentation. this means
that code blocks with invalid constants cause issues, which is why we
need to properly quote strings in our code blocks.
Change-Id: I0814ebb2658935f8bd3d528515acfdb5041d1e0f
Reviewed-on: https://gerrit.instructure.com/212925
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
closes PLAT-4891, Plat-4892
Test Plan:
- with a membership service call see that the sis id is added
to the payload if it exists
- see that it also is not added if one does not exist
Change-Id: Ib9723411648b7499a8c60435a522e437646e94de
Reviewed-on: https://gerrit.instructure.com/210816
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Karl Lloyd <karl@instructure.com>
fixes CORE-3215
test plan
- have a course with grade_passback_setting
- use gradePassbackSetting variable in lti tool
- it should return the setting
Change-Id: I0f598c8563d9f9d40e1d1f49c483a93bbde364a0
Reviewed-on: https://gerrit.instructure.com/205841
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes PLAT-4698
Test Plan:
-verify lti 1.3 and lti advantage flag is gone
-verify that all lti 1.3 features are still available/functional
Change-Id: I8be9e02fb2d32a92098bde43099ba0198e8d3329
Reviewed-on: https://gerrit.instructure.com/204381
Reviewed-by: Tucker Mcknight <tmcknight@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Tested-by: Jenkins
Closes PLAT-4660
Test Plan:
- Install an LTI 1 tool that uses
com.instructure.Editor.contents and
com.instructure.Editor.selection
- Launch the tool from an RCE that has content and
a selection
- Verify the custom fields are sent
- Verify the custom fields are not duplicated
in the launch without the "custom_" prefix
Change-Id: Ie77e2479f29c89ec8331f2cbf68bbdeb2de96168
Reviewed-on: https://gerrit.instructure.com/201204
Tested-by: Jenkins
Reviewed-by: Clint Furse <cfurse@instructure.com>
QA-Review: Clint Furse <cfurse@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Closes PLAT-4594
Test Plan:
Add the following custom parameters to an LTI 1 tool at the
editor button placement:
com.instructure.Editor.selection
com.instructure.Editor.contents
Launch the tool from the editor button placement and verify
the first param is set to the user's current selection
in the RCE.
Verify the second param is set to the current contents
of the RCE.
Change-Id: Ib0014397ce2d7cc0cad4331a8d00d60ec8d7c0be
Reviewed-on: https://gerrit.instructure.com/197842
Tested-by: Jenkins
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Clint Furse <cfurse@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
fixes PLAT-4585
Test Plan:
click on an installed lti 1.3 tool and see the deployment id
button, click on it, and see the deployment id
Change-Id: I78a2e977246b4a6524427995f10cf3600b59e090
Reviewed-on: https://gerrit.instructure.com/197321
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Tested-by: Jenkins
also keeps it undocumented for now
test plan:
* test an lti launch in a course using a variable
in the format:
$Canvas.membership.permissions<permission1,permission2,..>
with a comma-separated list in between the brackets
corresponding to course-level permissions
(see doc/api/roles.html#method.role_overrides.show), e.g.
$Canvas.membership.permissions<read_forum,moderate_forum>
these are the list of permissions to check
when the variable is expanded it should substitute it with a
comma-separated list of permissions filtered to those
that the user has been granted within the course
closes #PLYT-1796
Change-Id: I1c039e04318fcfe8ca5ee450e608bd3fb2affe6b
Reviewed-on: https://gerrit.instructure.com/194797
Tested-by: Jenkins
QA-Review: Nathan Mills <nathanm@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
test plan:
* set up a tool with the "$Canvas.course.sectionRestricted"
LTI variable substitution
* it should correspond to whether the user was enrolled
with "Can interact with users in their section only" checked
closes #PLYT-2349
Change-Id: I567a57927f0e5ec1b2dd34529262257f7dc9b527
Reviewed-on: https://gerrit.instructure.com/196878
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Nathan Mills <nathanm@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Closes PLAT-4531
Test Plan:
- install an LTI 1.3 tool that uses deep linking
from assignment_selection
- use the tool to select a link as an external_tool
submission type
- verify that the tool returned a url that is
different from the base launch url on the dev key
- launch the assignment and verify the target_link_uri
is correct in the final id_token
Change-Id: Ia773d7fdc67a510194ad9c998adb82681fbff826
Reviewed-on: https://gerrit.instructure.com/195782
Tested-by: Jenkins
Product-Review: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
Variable Expansion for sis_ids was causing an n+1 because
the lookup for the pseudonym didn't take into account if
the pseudonyms were preloaded.
Because of this, several other expansions would have produced
n+1s, so all known n+1 scenarios have been fixed.
fixes PLAT-4241
Test Plan:
tests pass
Change-Id: Ib39068e8e5f1e17a0963443148438b1d16287526
Reviewed-on: https://gerrit.instructure.com/195731
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
Closes PLAT-4487
Test Plan
- Install a tool in a course or account
- create an external tool assignment
associated with the tool
- create a module item associated with
the tool
- uninstall the tool
- verify the launches fail for both
the module item and assignment
- reinstall the tool (at course or
account level) and verify the launches
work again
Change-Id: Ifa41bda3bbaffc8413bc6944f48484b482f8d8f7
Reviewed-on: https://gerrit.instructure.com/195045
Tested-by: Jenkins
Reviewed-by: Drake Harper <dharper@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
closes PLAT-4438
Test Plan:
- Create a 1.3 tool in a context
- The 1.3 tool should only show placements
and the delete option from the cog dropdown
Change-Id: I8df1a6474226167fe402158a7837cc5fc33a458e
Reviewed-on: https://gerrit.instructure.com/192828
Tested-by: Jenkins
Reviewed-by: Drake Harper <dharper@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Closes PLAT-4436
Test Plan:
Verify LTI 1.3 tools are displayed the same
as 1.1 tools in course and account tool
index pages
Change-Id: I33237ad701ef4c6645f59521080519c483bc4900
Reviewed-on: https://gerrit.instructure.com/191996
Tested-by: Jenkins
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
refs CORE-2850
test plan
- have a user with a sis enrolled course
- have a second sis_id for the user
- it should return the sis for enrollment on
lti_launch
Change-Id: I3de963944465e7e49b768e898762362e1c463c7f
Reviewed-on: https://gerrit.instructure.com/191080
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Nathan Mills <nathanm@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Closes PLAT-3780
Test Plan:
- Install an LTI 1.3 tool that does deep linking at
migration_selection
- Launch the tool from the migration_selection
placement and verify a deep linking launch
occurs
Change-Id: Ib49192e5a3af97f946debbbbe636d2bcda496557
Reviewed-on: https://gerrit.instructure.com/190379
Tested-by: Jenkins
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Closes PLAT-3784
Test Plan:
- Install a 1.3 test tool that does deep linking at the
link_selection placement
- Create a new module item. Select the 1.3 tool in the content
selection modal.
- Verify a deep linking request is made to the tool
Change-Id: I90178a6f08b551c45a4b19627e2398e21eeeb641
Reviewed-on: https://gerrit.instructure.com/190263
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Nathan Mills <nathanm@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Closes PLAT-3781
Test Plan:
- Install an LTI 1.3 tool that expects a deep linking
request at the homework_submission placement
- Create a Canvas assignment with submission type "online upload"
- As a student go to the assignment submission page
- Verify the LTI 1.3 tool shows up in a tab and launches when
the tab is activated
Change-Id: I415fd17503dcf93f799910961d574d8960ec59c2
Reviewed-on: https://gerrit.instructure.com/189851
Tested-by: Jenkins
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Nathan Mills <nathanm@instructure.com>
Closes PLAT-4394
Test Plan:
- Install an LTI 1.3 tool that uses the assignment_selection
placement and expects an LtiDeepLinkingRequest
- Verify Canvas can do a deep linking request to the tool
- Verify the accept types setting only contains "ltiResourceLink"
- Verify the document target setting only contains "window" and
"iframe"
- Verify the media types setting only contains
"application/vnd.ims.lti.v1.ltilink"
- Verify the auto create setting is set to false
Change-Id: I5614f546eaa6f2f9d1a4b2944b35f50dc0f25c9d
Reviewed-on: https://gerrit.instructure.com/189481
QA-Review: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
fixes: PLAT-4361
test-plan:
* install a 1.1 tool with user navigation
* it should launch to the user_navigation_url
Change-Id: Ib064859f446007c05a0551a507104faf78f5a8fe
Reviewed-on: https://gerrit.instructure.com/188416
Tested-by: Jenkins
Product-Review: Marc Phillips <mphillips@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Change-Id: If7801aa4af6e39af0f885eba78e354ec7096db29
Reviewed-on: https://gerrit.instructure.com/189636
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs CORE-2598
test plan
- specs should pass
Change-Id: I0e67a641c71daa667a19e99a72f801cf85222c4a
Reviewed-on: https://gerrit.instructure.com/188007
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
when a user_a is merged into user_b, user_a is
deleted, but the enrollments lti_tools still point
to the old lti_id, so this allows us to store them
and serve them as the lti_id when a user is merged
fixes CORE-2565
test plan
- merge a user that uses an lti tool in a course
- the lti_id should not change for that course
Change-Id: Iac70957ed1fcb08111745a91d0c2e402dfad3002
Reviewed-on: https://gerrit.instructure.com/181905
Tested-by: Jenkins
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
LTI Tools now show up in the apps page.
refs PLAT-4288
Test Plan:
- Go to the appcenter page, note that the lti 1.3 tab is no
longer there
Change-Id: I0b1450322b741cb3bd733bc76919271b877a5855
Reviewed-on: https://gerrit.instructure.com/186189
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
Previously under the app center, now under the tool
management view.
closes PLAT-4288
Test Plan:
- Go to the app management area, see that you can install and
uninstall a tool in a context
Change-Id: Ia454c8671365b64629a0c60b725b15a96a1985dd
Reviewed-on: https://gerrit.instructure.com/185246
Tested-by: Jenkins
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Call the message validations on the lti messages
before we send the launch.
closes PLAT-4117
Test Plan:
- do a launch, it should still work
Change-Id: I34d20c328173158c76b11aacf7028f7eb152f87b
Reviewed-on: https://gerrit.instructure.com/185216
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
LTI 1.3 configurations had confusing names for the
target_link_uri. Make them consistent.
refs PLAT-4258
Test Plan:
n/a
Change-Id: Ia3ac7f896bdf5959cdf30fc6264ef85cd6774a76
Reviewed-on: https://gerrit.instructure.com/184158
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
On contextless launches, we failed to map
system roles to lti launch roles.
fixes PLAT-4277
Test Plan:
- do a contextless launch, see that an admin role is sent
Change-Id: I815f6eb4f31ccd0d1eed24ab1c62636af80f9607
Reviewed-on: https://gerrit.instructure.com/184363
Reviewed-by: Mark Valentine <mvalentine@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Tested-by: Jenkins
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
closes PLAT-4115
Test Plan:
- Install a tool with a global_navigation or user_navigation
placement
- launch the tool from these locations and note that they
don't pass the context roles of the use
Change-Id: I9810fc9745d26e5623a67f66988dbb97b25c606b
Reviewed-on: https://gerrit.instructure.com/182351
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
Tested-by: Jenkins
Closes PLAT-4141
Test Plan:
1. Create an LTI developer key and set the oidc_login_uri.
The tool should have the following placements:
- user_navigation
- course_navigation
- editor_button
Each placement should have a different 'url' property
(you can just add query params if you want)
2. Launch the tool from each of the placements and verify
the following:
- The OIDC login message is sent to the oidc_login_uri
- the target_link_uri sent in the OIDC login message
is equal to the 'url' property of the placement setting
3. Create ane LTI assignment with the tool and do a launch
4. Verify that:
- The OIDC login message is sent to the oidc_login_uri
- The target_link_uri is the 'url' of the ContextExternalTool
5. Install an LTI 1 tool in the same placements
6. Launch the LTI 1 tool at each placement and verify the launch
works as before
Change-Id: Ib7508daad9a954e7eabcb0374dbd54520280a172
Reviewed-on: https://gerrit.instructure.com/177627
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
James Williams