I broke fullscreen sizing with LA-729,
commit c603d6e9f2
This fixes that.
This change is built on top of the LS-1191, g/242726 changes
closes LS-1308
flag=none
test plan:
- in the rce, create a link to a video (select text then pick a video
from the tray and save
You should do this for a landscape video and a portrait video.
- click the link
> expect a new browser tab to open with the video
- click the fullscreen button
> expect the video to fill the screen, letterboxed if necessary
- click the fullscreen button on the embedded video
> expect the video to fill the screen, letterboxed if necessary
Change-Id: Ifb791c91c3d76b2285e2797aceb6c37c5d943605
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244745
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
test plan:
- enable Direct Share feature
- ensure Canvas jobs are running
- on the modules page, select the kebab menu next to a module
and choose "Copy To...", and ensure the module can be
copied to another course
- on the modules page, select the module kebab menu and
choose "Send To...", and ensure the module can be sent
to another teacher in the account
- As that teacher, ensure the module can be imported
into a course
- on the modules page, select the kebab menu next to module
items of all shareable types (assignments, discussions,
pages, quizzes) and ensure "Copy To" and "Send To" work'
(and module items other than these types do not have the
options available)
- repeat the previous step using newly added objects
(that were added to the module after the page load,
without reloading the page) and ensure "Copy To" and
"Send To" appear and work for the four types given,
and do not appear for all other types
- with the direct_share feature turned off, "Copy To"
and "Send To" do not appear in the menu for existing
or newly created items
flag = direct_share
closes LS-1254
Change-Id: If44f9e3a7b364828caa71bb49b9e9ec37433f70f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244185
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
if they have no reason to be at the account the signed in at. but only
if they weren't going to a deep link
test plan:
* have two accounts that trust each other, and use Canvas auth
* create a user in account 2, completely unassociated with account 1
* go to account 1, and sign in with that user's credentials
* you should end up at the dashboard for account 2
Change-Id: Ida64b77a58bd3494916e8d31d066c031ea640735
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/243508
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
* have two accounts that trust each other, using Canvas auth
* create a user in account 2
* go to account 1's login page, and try to reset the password
for that user
* you should get an email, and it should point to account 2
Change-Id: I9eaed4c2d6204987af82392222506c29df82fc64
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/243511
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
flag=none
closes QUIZ-7768
test plan:
- create question bank and a question in the bank
- go to a course and create a Classic Quiz
- click on Find Questions and add a question to the new quiz
- export course content
- choose to export Quiz only
- go to a new course settings and chose to import quiz content
- in rails console, verify the newly imported AssessmentQuestion
and Quizzes::QuizQuestion have correct root_account_id
Change-Id: I4298cb5f79caada562afb556f4097c432f6ecd9d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244750
Reviewed-by: Evan Battaglia <ebattaglia@instructure.com>
Reviewed-by: Bryan Petty <bpetty@instructure.com>
QA-Review: Evan Battaglia <ebattaglia@instructure.com>
Product-Review: Han Yan <hyan@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs OUT-3766
flag=account_level_mastery_scales
Test plan:
- create an outcome proficiency with ratings in the ui
- using canvas.docker/graphiql, select
account(id: "1")
outcomeProficiency
_id
locked
proficiencyRatingsConnection
nodes
_id
color
description
mastery
- verify that correct result is returned
Change-Id: Ib3da07798c36dc1f5f2d11343f1a2ded3641a1fb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/243561
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Pat Renner <prenner@instructure.com>
QA-Review: Augusto Callejas <acallejas@instructure.com>
Product-Review: Augusto Callejas <acallejas@instructure.com>
refs FOO-834
test plan:
* click around account settings, especially course and user search
* nothing should be broken
Change-Id: I532794f85bac099c126aec2bc5fa570a7723b37a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244658
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
test plan
- specs should pass
Change-Id: I2ffbe4282f1a4b6064780ff7c42683a389f1e102
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244302
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Moves LTI buttons into own group on toolbar and slides plugins and
LTI groups to the left of alignment group.
Also renames last group to 'Miscellaneous' since it no longer
contains apps.
flag=rce_enhancements
fixes LS-1302
Test plan:
- Open an RCE
- Expect to see groups in toolbar in this order: styles,
formatting, plugins, apps, alignment, misc
- Expect buttons to work as expected
Change-Id: Icd432c8bd480cdcc632878e54f2211c25be829f7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244702
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Published discussions in locked modules would cause course card
notifications despite being unavailable to the student
fixes VICE-644
flag=none
/ ---- ---- \
| Test Plan |
\ ---- ---- /
- Have a published course with at least one student enrolled
- Create an unpublished discussion
- Create a published module with an unlock date in the future
- Add the discussion to the locked module
- Publish the discussion
- Act as a student on the Dashboard, note there is no course card
notification for the discussion
Change-Id: I57ec318c350b28109e91ced2e1e5b4b6eafbea74
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244278
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
refs DE-184
[pin-commit-analytics=bccf577760596c0a047104315dae16a9650991e8]
The selenium framework preloads this by default now, so this method is no longer required.
Change-Id: Ia39713710a4acc5b0ab18efe4773d6e4ae488e71
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244725
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Inserting images or media in the RCE from the tray typically embeds it, but
if the user has selected text, the text is getting replaced with the embed,
which is unexpected. This PS changes it so if there is something
selected, we create a link to it.
Except when uploading/recording/embedding. In that case the uploaded image
or uploaded, recorded, embedded media is embedded just after the selected
text.
We also update the CanvasMediaPlayer so that it correctly handles
being not in an iframe, but window.top, as is the case when
the user clicks on the created link
closes LS-1191
flag=rce_enhancements
test plan:
- enter some text in the RCE
- select some text
- go to Media toolbar button and upload or record media
> expect the media to be embedded in the content just after
the selected text
- repeat by uploading an image
- select some text
- go to Media toolbar button > User Media
- select a media file
> expect the selected text to be a link to the video
- repeat using Image > Course or User Image
- save
- click on the media link
> expect a new tab to open and show the media or image.
> expect the player to look reasonable
> expect resizing the window to work reasonably well. Tthere
are some edge cases not accounted for. (portrait videos, if
shrunk vertically don't grow when the window gets larger.
landscape videos don't shrink in height when the browser is
made short)
- repeat for audio
- click on the image link
> expect the image to be downloaded (we have another ticket
to make file links behave more uniformly)
Change-Id: I70ab14aaa593d48688d99b0ba006f60a300ed8a6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/242726
Reviewed-by: Alex Anderson <raanderson@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
A user with no enrollments would not be able to render the new account
notification preferences page. This change makes it so that the user is
returned in the graphql query if the user is the same as the current
user.
fixes VICE-682
flag=notification_update_account_ui
/ ---- ---- \
| Test Plan |
\ ---- ---- /
- Turn on the notificaiton_update_account_ui ff
- login as a user with no enrollments
- navigate the the account notification preferences page
- Note that the page should load correctly
Change-Id: I81b9c9daaef58c4b8a50880c1c13f6ceec2c9d3f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244695
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
refs DE-186
[fsc-propagate=false]
Bypassing FSC because this spec sets a cookie that tells the flash alert to only appear once. The spec was manually run 30 times locally without failure.
for n in {1..30}; do docker-compose run --rm web bundle exec rspec spec/selenium/flash_notifications_spec.rb; done
Change-Id: Ic52c4482b862ec0312b206d3d08b5a75b54bebc9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244688
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Ryan Norton <rnorton@instructure.com>
refs DE-173
Test Plan:
1. Ensure that normal pre-merge build works
2. Ensure that normal post-merge build works
3. Ensure that pre-merge build requires a custom build-registry-path for the change-merged flag
4. Ensure that the post-merge build ignores the build-registry-path for the merge images.
Change-Id: I02bb3cfe9bff88c612cc77427ac301b9f1544abc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244276
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
QA-Review: Alex Slaughter <aslaughter@instructure.com>
Product-Review: Alex Slaughter <aslaughter@instructure.com>
validate <a href> against protocols accepted by canvas_sanitize
and show an error if bad.
closes LS-1232
flag=rce_enhancements
test plan:
- in the rce, Link > External Link
- enter a URL with an invalid protocol
e.g. xxx://example.com/path
> expect an error message
> expect the Done button to be disabled
- edit to http://example.com/path
> expect no error message and Done to be enabled
- edit to ://example.com/path
> expect an error message and done to be disabled
- edit to //example.com/path
> expect no error and Done to be enabled
- edit to /path
> expect no error and Done to be enabled
- edit to http:host
> expect and error and Done to be disabled
- edit to http://
> expect no error, but Done to be disabled
- edit to tel:999
> expect no error and Done to be enabled
- try ftp, http, https, skype, tel protocols
> expect them to be OK
> expect anything else before the : to be rejected
- try other stuff like that
- mailto, skype, and tel work with or without the //, but
if you include a /, you need 2 and the URL is not OK
until there's a char after it (e.g. mailto:x is ok,
mailto:// is incomplete and Done is disabled,
mailto://x is OK)
- ftp, http, https all require the //
once you have a link in the rce content
- click Link Options
- repeat the above steps in the Link Options tray
Change-Id: I11d96ecefa3214a26f399aba2b5c261923730a0d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/243214
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
- should ignore rules on the modules page if all the
associated assignments are deleted (so the rule is empty)
- should not block module progression if an unlocked
assignment is unpublished (and thus not visible)
test plan:
* set up a mastery paths trigger assignment
(easiest would be a quiz) with a score range
releasing two items
* unpublish one of the items to be released
* add all items to a module
* as a student, take the trigger assignment
and get the required grade to unlock the items
* should be able to continue through the
module progression "Next" button
on the bottom of the trigger assignment page
* now delete the unlocked items
(so the trigger assignment doesn't unlock anything)
* it shouldn't show a message to new students
that their progress is blocked until the empty trigger
assignment is graded
refs #LS-1270
closes #LS-1282
Change-Id: Id88c55c1561c3c813556177a76015a8a0d42dde6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244508
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Closes: LS-1208
Test Plan:
- Validate new tests verify mastery breakdown availability and adding an
assignment
- Passes Jenkins
Change-Id: I24610d2436562a62a7a30fc9f418c93fbe976a54
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244239
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
If a migration is present in the commit, this triggers
a build that checks if the migration will break things
for CDC/Canvas Data 2.
test plan:
- Verify that, if a migration adds a new column, the
CDC Schema Check step fails in the build (like in
build 4636, a previous version of this commit which
had a migration added)
- If a migration renames a column that CDC doesn't
care about, the CDC Schema Check step runs but
does not fail.
- If a commit has no migration in it, the CDC Schema
Check step doesn't run.
Change-Id: Ibe33955d11ef62bf68b8dd4cdb838cf2dad126e8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240916
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Tucker Mcknight <tmcknight@instructure.com>
The previous code suppressed the favorite tool toggle on the
site_admin's settings page, but missed course settings. This
change sees that it only shows up when it should
closes LS-1291
flag=rce_lti_favorites
test plan:
- with some LTI tools installed:
- go to /accounts/site_admin/settings, the Apps tab
- click View App Configurations
> expect no "Add to RCE toolbar" column with toggles
- repeat at /accounts/:account_id/settings
> expect to see "Add to RCE toolbar" and toggles
- repeat at /courses/:course_id/settings
> expect no "Add to RCE to toolbar"
Change-Id: I2b64652fa7095c5a4357fdadcb756b5450ca1917
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244521
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Anderson <raanderson@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
refs DE-183
Test Plan:
1. Run the command at the top of the newly generated Dockerfile and ensure there are no changes.
Change-Id: Ice28ad169be94c39efb07d014a6bbc37e2f6c7f8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244651
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
To maximize the benefit of caching, we need to allow the Dockerfile to be generated dynamically to minimize the number of file dependencies per step. Prepare to do this
by allowing dockerfile_writer.rb to accept arguments.
refs DE-183
Test Plan:
1. Ensure that ubuntu.development.Dockerfile doesn’t have any changes when run locally
2. Ensure that ubuntu.production.Dockerfile doesn’t have any changes when run locally
Change-Id: I8b4ba10b5929c2ee60c5c3537b70f606c8ea1d52
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244604
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
this change removes the automatic swizzling of youtube video links,
but as a side-effect you lose the inline-preview feature.
closes LS-1273
flag=rce_enhancements
test plan:
- in the old RCE, create a link to a youtube video
- you get a "preview will go here" box around the link
- create another youtube link, but check the "disable inline preview"
checkbox
- you just get a link
- save
- you'll get a thumbnail preview below the first link. the 2nd link
is just a link
- edit in the new RCE
> expect both youtube video links to just be links
- create another external link to a youtube video
> expect it to be just a link
- save
> expect the youtube previewable link created in the old RCE to
still get the preview thumbnail
> expect the preview disabled and the link created in the new RCE
to simply be links
extra credit
- enter a URL as text in the RCE and hit return
> expect it to automatically be converted into a link.
Change-Id: I49450e21c6c2aa17ec3d890947a181d9e3d298d3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244419
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Anderson <raanderson@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
to reduce heat on redis nodes for high traffic accounts
hold onto the permission data for 5 minutes
closes #LS-1299
Change-Id: I5c13b7c5df00e2f14a1b8c10d480b5f5f4233db7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244621
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Prepare for splitting pre-/post- merge webpack builds by splitting yarn into its own stage so it can continue to cache correctly
refs DE-161
Test Plan:
1. Pre-Merge Build Passes
2. Post-Merge Build Passes
3. Pre-merge build uses cache from post-merge build
Change-Id: Ib07c8934d8691b0cf7866afd56043aee503f666b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244606
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
test plan
- send enrollment file that tries to update an enrollment that is tied
to a deleted login and the enrollment is also already deleted
- it should not update the enrollment
fixes VICE-685
Change-Id: Id42b03c3f9596fdfe9d7717f78f07fc7bfd16128
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244306
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
test plan
- run sis import with users
- run sis import marking users as deleted
- run sis import again
- fewer queries should happen on the last import
fixes VICE-684
Change-Id: I01369227c6b15a0eef04f26102015bd6720031c5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244320
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
test plan
- import a course with an invalid account
- it should have an error for that line
- the rest of the import should work
fixes VICE-704
Change-Id: I307488aaad26459e508c2d0a3ac63707ee2b3ea3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244305
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
this doesn't really change anything with how report runners are run, but
how they might fail.
we don't want to abort the runner that may have failed, so we can get
data on which report had an error with state of error or running.
Also we don't want to write rows on a failed or aborted report runner
because then we can manually run that runner and any aborted to finish
the report in a console for troubleshooting.
test plan
- specs should pass
Change-Id: I5cfc3d975899f85aff64a6e20c7673b1f2cd1b88
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244625
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
refs LS-1297
Change-Id: Idbe87fa1c0b0a616984d2062ff8a3701cc008d97
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244553
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Chose to wrap instead of truncate because long assignment titles
wrap and syllabus home page title also wraps.
Fixes LS-1271
flag = none
Test plan:
- Create course with really long name
- Make a wiki page and set it as the front page
- Set the course home page to be the wiki front page
- Go to course home, expect course title to wrap and not run off
screen
Change-Id: I56610f0cff1635155d4748cfd6c3235e3743c071
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244406
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Anderson <raanderson@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
and the after_saves that are clearing unused cache keys
closes #LS-1296
Change-Id: Ida24905e39a1e8a61c875ca10116e799e0718c85
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244540
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes FOO-599
test plan:
- Enable a feature flag in siteadmin
- It should not appear in regular accounts
- Enable a course and account flag in a regular account
- On refresh they should still appear
- The course flag should not appear in courses in the account
Change-Id: I6af96794b0f0f9a5534374dd32b3b539a4b7f486
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244506
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
fixes INTEROP-5887
flag=none
Test plan
- Ensure you have a role without a root
account id
- Run DataFixup::PopulateRootAccountIdOnModels.run
- Ensure your roles have their root account ids
populated
Change-Id: I9fd7fa4ac40b92716b746f0e7424b85212f118ff
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244525
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Evan Battaglia <ebattaglia@instructure.com>
Reviewed-by: Evan Battaglia <ebattaglia@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
Previously, the div created for mastery path creation
error messages had some wonky CSS behavior that created
an overlap of shapes in the error message. Fixing the CSS
for this instance wouldn't work since that would have
adverse effects on other components that use the same CSS,
and inline styling didn't seem to fix the issue, so
replacing the div with the InstUI Tooltip component
seemed to be the next best solution.
test plan:
* Enable Mastery Paths in admin settings
* Start an assignment creation and navigate to the
Mastery Paths tab
* Attempt to put in NaN or some other invalid value
* The new tooltip component should appear.
fixes LS-1234
flag = none
Change-Id: I4e736e551c892e25d697a4eab861117854ba40d9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244296
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
what is it even accomplishing
closes #LS-1295
Change-Id: I293e205c6b6e408145d82ef3db3670ba0957f6f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244531
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* create a mastery paths trigger assignment
* add an unlockable assignment to two ranges
in the mastery path editor
* as a student get a grade in one range to unlock the assignment
* get a new grade in the other range (that should still leave
the same assignment unlocked)
* the same assignment should remain unlocked
closes #LS-1293
Change-Id: I9b7b8a0e82c31f960b6e0b91de65ae76c976e029
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244517
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
closes LS-1184
flag=rce_enhancements
test plan:
- add at least 6 lti tools to your course
(you can add less if you set ENV.MAX_MRU_LTI_TOOLS=something<5)
- edit something that opens the RCE
> expect to see the plain plug external tools toolbar button
- click it and open a tool from the popup dialog
- dismiss the tool
> expect the external tools toolbar button to be a menu button
(it has a down-caret next to the plug)
- click it
> expect to see your recently opened tool listed, followed by
"View All"
- click the tool from the menu
> expect it to open
> expect the menu to still show the tool only once
- open tools from "View All" until you have MAX_MRU_LTI_TOOLS in the menu
> expect the tools to be listed alphabetically
- open 1 more tool
> expect the lti tools menu to have removed the first opened tool
and added the most recently used tool (so those listed
are the MAX most recently opened)
Change-Id: Ia1cebe6b4ff24fff0953975740cee94942b4bb2b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244260
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Anderson <raanderson@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
moving the rest of the deletions prior to the import
broke the check that tries to not delete assignment groups
that aren't empty (if the assignments are moved out in the
same import)
test plan:
* create an assignment group with an assignment
in a blueprint course and sync
* create a new assignment group and move the assignment
to the other group, then delete the old group
* sync
* it should delete the old group in the associated course
(unless a new assignment was created in the group in
the associated course)
closes #LS-1278
Change-Id: I66f9f261f31572eaea8379def600c328ecfeeac1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244372
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
the jquery generated flash messages did not have any text on the
close button. this adds an aria-label which screenreaders
(at least VO + safari, which is all I can test atm) will read
closes LS-1231
flag=none
test plan:
- do something to cause a flash message to appear
(I went to /courses/1/users, selected Edit Role
from a user's kabob menu, killed my canvas server,
then clicked Update)
> expect the screenreader to read the message and "Close"
Change-Id: I7e56fc0d29ce88843ab417516730e48d2e4d9365
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244351
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Aaron Ogata