test plan:
- in a course with no pages (new course is best)
* manually update the course object:
* set default_view to 'wiki'
* manually update the course's wiki object:
* set front_page_url to nil
* set has_no_front_page to true
* navigate to the course home page
- there should not be an error on the page
fixes CNVS-7744
Change-Id: I047db32d2fa7a376be994a1314c0e55a0cadffde
Reviewed-on: https://gerrit.instructure.com/23751
QA-Review: Hannah Bottalla <hannah@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
test plan:
- account-level draft state => disabled
* create a course
* set a custom wiki page as the home page
* copy the course
* the new course's home page should be the copied front page
* copy the original course again
* selectively omit copying the front page
* the new course's home page should be an empty front page
- account-level draft state => enabled
* create a course
* set a custom wiki page as the home page
* copy the course
* the new course's home page should be the copied front page
* copy the original course again
* selectively omit copying the front page
* the new course's home page should be the dashboard
fixes #CNVS-7774
Change-Id: If9987cad55f069a2803002de611ecb0d81b2ebc5
Reviewed-on: https://gerrit.instructure.com/23788
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
test plan (in the course and group wikis):
* enable draft state for the account (enable_draft)
- general
* Pages course tab navigates to new pages
- front page
- index page (if no front page is set)
* Pages breadcrumb (in pages) navigates to new pages index
- index page
* New Page button is hidden unless user has create rights
* Publish icon & settings cog hidden unless user is a teacher or admin
- show page
* Published button is hidden unless user is a teacher or admin
* Published button functions properly (publishes and unpublishes)
* Edit button is hidden unless user has edit rights to the page
* Settings cog/Delete button is hidden unless the user has delete rights to the page
* Page content is restricted if the page is locked by a module
- edit page
* Published indicator is hidden unless user is a teacher or admin
* Settings cog/Delete button is hidden unless the user has delete rights to the page
* Title field is hidden unless user has full edit rights (course setting)
* Hide this page from students is hidden unless user is a teacher or admin
* ... can edit this page is hidden unless user has full edit rights (course setting)
* Unauthorized error if page is locked by a module
- pages api
* Unauthorized error when updating page if page is locked by a module
fixes #CNVS-6859
Change-Id: I12239e58a5f267c43fd2bcb912c7b485693de2c1
Reviewed-on: https://gerrit.instructure.com/22677
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Sterling Cobb <sterling@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
test plan (on a course wiki and group wiki):
- the following roles should interact with the wiki as they did before:
- admin (non-enrolled)
- teacher
- student
- member (group wiki)
- public (non-enrolled)
- course setting set to "Teachers and Students" (or "Anyone")
- students (or anyone) can create pages
- students (or anyone) can edit an existing page (unless the page is set to "Teachers only")
- students (or anyone) cannot edit pages set as "Teachers only"
- non-enrolled admins behave as an enrolled teacher
fixes #CNVS-7046
Change-Id: I677d52a53e83580a56aa9b5b834a50610719e42f
Reviewed-on: https://gerrit.instructure.com/22606
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
test plan:
* confirm that wiki pages can be created and updated
with the parameter wiki_page[front_page]
* if true, this will set the wiki page as the
front page for the context (assuming the page is
not hidden to students)
* if false, this will unset the page as the front page
(assuming it was the front page to begin with)
* confirm that /courses/:course_id/front_page acts
as a proper endpoint for show/update/destroy and
acts just as /courses/:course_id/pages/:url
for whichever page is set as the front page
* confirm that none of the above page breaks
normal wiki functionality
closes #CNVS-5528
Change-Id: I3f51d740e90ff0a5a39f2aafc988a1a33947ca18
Reviewed-on: https://gerrit.instructure.com/20938
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
test plan:
* make a course with a name as long as you can
(255 characters)
* confirm that you can export it successfully
fixes #CNVS-3549
Change-Id: I34dc93ba4578bf67b7155138beee231adeb5d4ef
Reviewed-on: https://gerrit.instructure.com/17376
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
no user visible behavior change
test plan:
* make sure existing wiki contents haven't disappeared
* make sure a new course gets a wiki that functions correctly
* make sure wiki rss feeds are still functional
* try to access the wiki from a new course from multiple requests
simultaneously; it should get a single wiki that's not conflated
Change-Id: I339b56c39d7868dbdec3df4007291a429272b1cf
Reviewed-on: https://gerrit.instructure.com/12432
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Mark Severson