fixes CNVS-7957
test plan:
* open conversations beta
* open course dropdown
* verify that optgroups have separator lines
* verify that abbreviated course names are not underlined,
including in the dropdown button when selected
* verify that checkmarks are not weird vertically
(easier to eyeball when focusing selected option)
Change-Id: Ifb7dd2c359c643864f906a2dd091101c5e6162d5
Reviewed-on: https://gerrit.instructure.com/24134
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Braden Anderson <banderson@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
test plan:
- go to course users page
- examine the element for the gear menu,
and look for a screenreader-only element inside the link tag
that says "Manage username"
fixes CNVS-6521
Change-Id: Ib6598d2afd274c0e48deafe05f155e308dca0403
Reviewed-on: https://gerrit.instructure.com/24238
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Hannah Bottalla <hannah@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
refs CNVS-5051
test plan:
- draft mode must be disabled
- go to assignments page
- click "+" to add new assignment
- fill out nec. fields
- type date in mm/dd/yy format
- click 'more options'
- verify that date is in correct format
- may be good to try a few diff dates
Change-Id: I04d0bc0565957e08c9048303e7a24d250e5219d3
Reviewed-on: https://gerrit.instructure.com/24056
Product-Review: Simon Williams <simon@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
test plan:
- with draft state enabled
* start editing the front page of the course
- the delete menu item should be disabled
* attempt to delete the front page using the api
- the attempt should be rejected
refs CNVS-7027
Change-Id: Ic873d7c7102bcc09db2b777e36da3be295964f94
Reviewed-on: https://gerrit.instructure.com/24178
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
test plan:
- with draft state enabled
- 'Use as Front Page' should be disabled for unpublished pages
* set a published page as the front page
- the publish icon should be disabled
- the delete menu item should be disabled
* navigate to the front page
- there should be a visual indicator to indicate the front page
- the publish button should be disabled
- the delete menu item should be disabled
* all other pages should operate normally (edit, etc)
fixes CNVS-7027
Change-Id: I9ebff478c48ccadfbe8bc95f4479dd17552c82a0
Reviewed-on: https://gerrit.instructure.com/24146
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Prereq pill now added to each module. If there are 0 prereqs, the pill
does not show up, if there is 1 prereq, the name of the prereq module
is displayed and if there are more than 1 prereq then the number of the
prereqs are displayed with their names being displayed in a tooltip
when hovering over with a mouse
Test Plan
1. Go to the modules page. Ensure there are modules with 0, 1 and 2
prereqs created.
2. Ensure draft state is enabled.
3. The module with 0 prereqs should not display any prereqs "pill". The
module with 1 prereq should display the name of the prereq module in a
pill and the module with 2 prereqs should show the number "2" with a
tool tip displaying the names of the 2 modules when you hover over the
"pill"
fixes CNVS-7995
Change-Id: I07d0d2282a0fcbc6265e2d082e0747ef1a8938a5
Reviewed-on: https://gerrit.instructure.com/24141
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes CNVS-7889
adds a plugin which will render a partial whenever the chat widget
should be inserted. useful partial to come later
test plan
- install our chat LTI tool at an account level
- the plugin sends a message to the javascript console when the
chat widget would appear
- with the plugin disabled, ensure that the message does not
appear (check the course index, where it normally would)
- with the plugin enabled, ensure that the message does not
appear when:
- you are on gradebook 1 or 2
- you are in speedgrader
- you are taking a quiz
- you are on a page without headers. these pages include:
- unauthorized action page
- the embedded submission on speedgrader
- the 'Join This Course' modal dialog
- you aren't logged in
- with the plugin enabled, ensure that the message appears when
you are on any other course page
- ensure that enabling the plugin on an account does not affect
a different account
Change-Id: I7c3fd9dd882b966160878ded0ca9194e53b11d21
Reviewed-on: https://gerrit.instructure.com/24127
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
Replaces the @object User example description. Add :model to tags that
are shown to describe objects in the API docs. Uses model info to
reproduce the expected @object style API documentation.
Change-Id: I12ffca98aeef72851cd331794fa8268d14812315
Reviewed-on: https://gerrit.instructure.com/23967
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Duane Johnson <duane@instructure.com>
Tested-by: Duane Johnson <duane@instructure.com>
Reviewed-by: Duane Johnson <duane@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
fixes CNVS-7946
test plan:
* open new conversations
* open compose message dialog
* shrink dialog to minimum height
* open courses dropdown
* verify that dropdown can overflow the dialog
Change-Id: I25d8432ffb00013c325af547a6275b45cb29ae35
Reviewed-on: https://gerrit.instructure.com/24131
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
fixes CNVS-7790
test plan:
* open a threaded discussion
* verify that styling looks good, including when collapsing
entries
* select "Go to topic" on a reply to the topic
* verify that the topic's author receives keyboard focus
* select "Go to parent" on a deep reply
* verify that the parent's author receives keyboard focus
* verify that screenreaders announce the date and
the cog menu after the author in document order
Change-Id: I1a91baac18784c2b2fe3406f04ba836740142376
Reviewed-on: https://gerrit.instructure.com/24058
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
fixes CNVS-2603
test plan:
- create new assignment
- set grading type to percentage, pts possible to 0
- save and verify error rendering
- clear pts possible field
- save and verify error rendering
- set pts possible to any string
- save and verify error rendering
Change-Id: I11b15fc9ad38376454635d7c08633d6f326813c0
Reviewed-on: https://gerrit.instructure.com/24029
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-7190, CNVS-7652
test plan
1. editing
- click edit from cog menu
- edit in dialog
- edits should display after dialog closes
2. variable due dates
- add a section to the course in the settings
- edit an assignment, and add multiple due dates
- "multiple due dates" with a tooltip should show up in the index page
- on the edit modal, the due date is disabled and shows dates in a hover tooltip
Change-Id: I0ada6bc94964f34e8f6327edd6c52c2201637791
Reviewed-on: https://gerrit.instructure.com/23550
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
fixes CNVS-7996
test plan:
* create a private conversation in the old conversations
ui;
* in the new ui, attempt to respond to that conversation;
* verify that your response successfully sends;
* verify that the "To:" field in the popup is disabled
and displays a tooltip, "You cannot add participants to
a private conversation."
Change-Id: I9b396953cc0dd3ef6b70abb78c675f239acc4a20
Reviewed-on: https://gerrit.instructure.com/24119
QA-Review: Cam Theriault <cam@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
fixes CNVS-7956
test plan:
* in the new conversations ui, reply to an existing
conversation that isn't the top-most conversation in
the left-pane;
* verify that after your message sends, the left-pane
updates and that the conversation you just replied to
is at the top;
* verify that the conversation's time has updated along
with its position.
Change-Id: Ie2131fdedaf705a9ee9ccb58cc4e7b33b8b366d3
Reviewed-on: https://gerrit.instructure.com/24066
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
QA-Review: Zach Pendleton <zachp@instructure.com>
adds retina-ready alternative images for the following:
* header background;
* header identity bar background;
* page background;
* "by instructure" link in footer;
* grading and grading_gray checkmarks.
also pngcrushes the already retina-ready logo for less
bits and great justice. ✨
Change-Id: I87b269cdfc5f2e650195dec604e279f0adfb3c38
Reviewed-on: https://gerrit.instructure.com/23960
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Zach Pendleton <zachp@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
Initiazing the wiki index page to be small, the sticky header bar
(when you have enought content to scroll) will no longer over flow out
of the main content.
Test
1. Go to the new wiki index page. Make sure you have enough items on
the index page that you can scroll.
2. Scroll down. The top bar should follow you as you scroll (fixed to
the page). The topbar should stay within the main content area as you
resize the window (width wise)
fixes CNVS-7920
Change-Id: Idc4f9ccc22c3f5e1ef9abae6df33504ba5383cfc
Reviewed-on: https://gerrit.instructure.com/23993
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Hannah Bottalla <hannah@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
test plan:
- with draft state enabled for the course
- index page
* ensure the toolbar sticks when scrolling
* ensure deleting a page works properly
* ensure editing a page works properly
- show page
* ensure the toolbar sticks when scrolling
- edit page (window #1)
* open another window to the corresponding show page (window #2)
* open another window to the same edit page (window #3)
* make a change to the page body in window #1
* save the change
- window #2 & #3 should show reload inicators within 30 seconds
- window #3 should indicate that someone else's changes will be
overwritten by the save
* click reload (window #2)
- the content should be updated to reflect the changes
* click reload (window #3)
- the content should be updated to reflect the changes
* making changes to the body and saving should still work
fixes CNVS-7510
Change-Id: Icf441771589950a0398bf4cbffb4449d1e19eb5b
Reviewed-on: https://gerrit.instructure.com/23951
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Hannah Bottalla <hannah@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
- Explicitly describe path parameters (e.g. "id", "account_id") so
that swagger will autogenerate the correct code.
- Use :resources which is already grouped, rather than :object, which
is not.
- Guess type information from current sample @object models
- Accept @model in API docs as a better alternative to @object.
@model descriptions use the JSON-schema draft 4 specification,
which is what Swagger uses.
See https://github.com/wordnik/swagger-core/wiki/Datatypes
- Add some swagger json generator specs
- Fix SubmissionsController's "Submission" object
Change-Id: I71befe1d2cea039fd996124e7de9cab2e639e191
Reviewed-on: https://gerrit.instructure.com/23831
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Duane Johnson <duane@instructure.com>
QA-Review: Duane Johnson <duane@instructure.com>
fixes CNVS-3110
test plan:
- create a new learning outcome
- title must be greater than 255 chars
- save learning outcome
- verify presence of error dialog
Change-Id: I9f91b03f5bce60dc6e7c8ddf9fdcbf1719f8adb7
Reviewed-on: https://gerrit.instructure.com/24004
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
fixes CNVS-3277
testing steps:
- either create a new ePortfolio or edit
the settings for one (i.e. left side nav
when in a portfolio "ePortfolio Settings")
- in popup, enter text longer than 255 characters
and try to submit
- should display that "Name is too long"
- when creating a new ePortfolio and when editing,
verify that it requires a "Name" and gives
a descriptive error message
Change-Id: Id7b6b495a3e47290ea5c37054865812ddc7f1dec
Reviewed-on: https://gerrit.instructure.com/23829
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
test plan:
- specs pass
Change-Id: Ie45ebc1ce4493485f00068145393ecc50c7cb540
Reviewed-on: https://gerrit.instructure.com/23945
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Matthew Irish <mirish@instructure.com>
Tested-by: Matthew Irish <mirish@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
QA-Review: Stanley Stuart <stanley@instructure.com>
- added new ember application generator
- also Ember -> ember in AMD requires
Change-Id: I7914a2578161e4f8370fc05ed6596ed07347c897
Reviewed-on: https://gerrit.instructure.com/24038
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
test plan:
* upload a relatively large file for import into a course
* try to navigate away or reload the page while the
file is uploading (as indicated by the spinner)
* a confirmation box should pop up
closes #CNVS-7692
Change-Id: Iaf24ef1c2d9c10472b711e7e9f06d14f31255255
Reviewed-on: https://gerrit.instructure.com/24022
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: August Thornton <august@instructure.com>
before, the conversation list would only paginate when you
reached the bottom and started scrolling the window. now it
should paginate as you scroll down.
fixes CNVS-7970
test plan:
- go to the new conversations page as a user that has many
conversations (> 20).
- scroll the left pane down slowly. you should see it paginate
before you reach the bottom of the list. you can tell when
it paginates because the scroll bar will jump.
- note that the exact position of when it paginates is
probably not optimal; it's caused by existing bugs in the
generic pagination code. fixing that is outside the scope of
this change and the current behavior is the best we can do
right now.
Change-Id: Ifabcc897b11a730c55f8be61ab6bc1c847346e32
Reviewed-on: https://gerrit.instructure.com/24059
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
fixes CNVS-6930
test plan
- go to the draft state assignment index page
- sort assignment groups
- refresh the page and the sorting should have stuck
- sort assignments within a group
- refresh and the sorting should have stuck
- drag assignments between groups
- refresh and the new groups should have stuck
Change-Id: Iaf77b7665603e8aa7b9759de4fbcee7e45f52576
Reviewed-on: https://gerrit.instructure.com/22730
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
fixes CNVS-7937
test plan:
- create a course with a long name (>25 chars).
- go to the new conversations compose dialog and open the
courses dropdown. check the mouse pointer when it hovers over
the truncated course name.
Change-Id: Ie7cfbeb4d71b03cc3d47849337cb108031ae33cb
Reviewed-on: https://gerrit.instructure.com/24023
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
test plan:
- start with draft state disabled
- for each step, exercise the api (as a teacher) to confirm the
expected values
1) create pages with different hide_from_students values
a) as a teacher
hidden pages should be visible; the hidden flag should persist
b) as a student
hidden pages should not be visible
2) using the api, update published and hide_from_students
(together and separately)
a) the published value should not be affected
b) the hide_from_students value should be updated when set
3) enable draft state
a) as a teacher
previously hidden pages should be visible, but unpublished
b) as a student
previously hidden pages should not be visible
4) edit a page
a) ensure the "Hide from students" option is gone
5) publishing pages should behave as expected
a) published pages should be visible to students
b) unpublished pages should not be visible to students
6) using the api, update published and hide_from_students
(together and separately)
a) the hide_from_students value should not be affected
b) the published value should be updated when set
7) create new pages with different published states
a) as a teacher
unpublished pages should be visible, but unpublished
b) as a student
unpublished pages should not be visible
8) disable draft state
a) as a teacher
previously unpublished pages should be marked hidden
b) as a student
previously unpublished pages should not be visible
fixes CNVS-7617
Change-Id: I395e0b2639543a64d9e2bc8d9377c78cf36f42d6
Reviewed-on: https://gerrit.instructure.com/23618
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
fixes CNVS-7195
test plan:
- create an unpublished assignment
- make an API call to comment on a submission as a student and teacher
- verify that you are unauthorized to comment (both as student and teacher)
- make another API call to add a group comment on the submission
- verify that you are unauthorized to comment
- make another API call to grade a submission
- verify that you are unauthorized to grade the submission
Change-Id: If627df5db03e3b488c25f50a0dd2c2f715da7b98
Reviewed-on: https://gerrit.instructure.com/23936
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
ContextModule#prerequisites= included a very expensive check
for cycles among module prerequisites (it took several minutes
to operate on a course with ~1000 modules). This check is
redundant anyhow, since we already (in validate_prerequisites,
a ContextModule after_save) forbid a module from having any
prerequisites whose position is not less than the module's
position.
test plan:
- in both the web and APIs,
- verify you can still create prerequisites
- verify you cannot create a prerequisite cycle
- context_module_spec.rb "prerequisites=" tests still pass
- deleting or reordering modules in a course with many modules
should not be unreasonably slow
fixes CNVS-7769
Change-Id: I5ed4c31211cb3bdf50e8c7afe4a970a86da8d472
Reviewed-on: https://gerrit.instructure.com/23826
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
fixes CNVS-6558
testing steps:
- ensure you have in your Recent Activity list
a section for annoucements, assignments, discussions,
and conversations. If not create some to cause the
activity to show up.
- tabbing through, verify that the "show more"/"show less" link is not
read by the screen reader but instead it reads text like
"Expand 3 announcements"/"Collapse 3 announcements"
- the date for the item in the table should now be a tabstop
so tabbing through will cause it to be read by the screenreader
- dismissing an activity item should cause the screenreader
text to have an updated count
Change-Id: I2f1f419c3af08800b0d3e69ecfbb1bac79c0c435
Reviewed-on: https://gerrit.instructure.com/23922
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
fixes CNVS-7823, CNVS-7847
Test plan:
* enroll a student in multiple sections
* make a group assignment
* comment on the group assignment submission for the student with
multiple sections
* the student should receive one copy of the comment (not multiple)
Change-Id: I26f44ef054fdb136f180c949d0676fc0168827a8
Reviewed-on: https://gerrit.instructure.com/23886
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
test plan:
* as a user who is not a site admin, navigate to
conversations;
* verify that you can click the help icon in the
top-right corner to switch to new conversations;
Change-Id: Ifbfa93b864fe250940c7abd77336efe6ce4938d8
Reviewed-on: https://gerrit.instructure.com/23971
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
fixes CNVS-7915
test plan:
* navigate to new conversations;
* verify that the right pane now displays an alert box
with the message "Beta Version You are using a beta
version of the Canvas inbox"
Change-Id: I5dd767b89a87254d950bd37db7c41a1dd23799f0
Reviewed-on: https://gerrit.instructure.com/23986
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
test plan:
- in a course with no pages (new course is best)
* manually update the course object:
* set default_view to 'wiki'
* manually update the course's wiki object:
* set front_page_url to nil
* set has_no_front_page to true
* navigate to the course home page
- there should not be an error on the page
fixes CNVS-7744
Change-Id: I047db32d2fa7a376be994a1314c0e55a0cadffde
Reviewed-on: https://gerrit.instructure.com/23751
QA-Review: Hannah Bottalla <hannah@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Added an aria-label to the points input.
Changed translation stuff in the ERB to be a bit less crazy and
more inline with the I18N wiki (with usage of `:wrapper`) while still
maintaining the output as a single traslation block.
fixes CNVS-6456
test plan:
- go to assignment creation page
- add a rubric
- verify that "Points" is read via VoiceOver when the criterion points field is
focused
- verify that there is no text following the points input field
- go to SpeedGrader™ with an assignment that has a rubric
- verify that "Points" is read via VoiceOver for the criterion points
field
- verify that there is a label like "/5pts" following the input field
Change-Id: If3e36bbc18db14f26906c85347a15497513a7c6a
Reviewed-on: https://gerrit.instructure.com/23903
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
test:
* create a new course
* confirm that the "Add TA's" link in the wizard points
to the new people page
fixes #CNVS-7500
Change-Id: I85f7b7975c086a6c5473204f218547c06b0a4b57
Reviewed-on: https://gerrit.instructure.com/23232
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
test plan:
- enable draft state
- go to a wiki page
- if you have permission to view page history, then
a "View Page History" item should appear in the gear menu
- clicking it should take you to the (existing) history page
- clicking "Back to Current Version" should take you back
to the page you came from (under /pages)
- disable draft state
- the "Page History" feature should still work
- "Back to Current Version" should take you back
to the page you came from (under /wiki)
fixes CNVS-7518
Change-Id: I084dbe9d83c848b33b374bed59282ab46a68466b
Reviewed-on: https://gerrit.instructure.com/23736
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
closes CNVS-7318
Test plan:
* Open a quiz in speedgrader
* Click the settings link and enable beta quiz navigation
* You should see a quiz navigation bar at the top
* the beta nav setting should only display for quizzes
Change-Id: I546c6032680bdef4fd56c9fed9e8fd79454e3f42
Reviewed-on: https://gerrit.instructure.com/23834
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
QA-Review: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
This reverts commit 49c9950d49.
Test plan:
see test plan for b70cc5438f
Change-Id: I1d913a25af48b17ac10f2b0c09cf62f43884f8db
Reviewed-on: https://gerrit.instructure.com/23748
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
fixes CNVS-7873
this commit also replaces the star png with unicode
stars to better support retina displays and save an
http request.
test plan:
* navigate to new conversations interface;
* verify that the unread indicator in the left pane
is a flat blue;
* verify that the star icons display as expected above
the read/unread indicator.
Change-Id: I0fb93903fe998171f0218de072973540758b962d
Reviewed-on: https://gerrit.instructure.com/23959
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Braden Anderson <banderson@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
fixes CNVS-6438
test plan:
* navigate to /profile/settings
* verify that there are no empty <th>'s in the Email Addresses
table in the right sidebar
* verify that this table has been refactored such that there is
now a <caption>Email Addresses</caption> instead of a table
header
Change-Id: Id6bff807e313ed06fb28de9ca541a02465495559
Reviewed-on: https://gerrit.instructure.com/23601
Reviewed-by: Mark Ericksen <marke@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
fixes CNVS-7872
test plan:
* in the new conversations UI, create a message with
a long subject (255 characters is max);
* verify that the subject, when displayed in the left
pane, is properly truncated;
* verify that the subject is also truncated properly at
the top of the right pane.
Change-Id: I963fe52082a4231696ccb4f3dbf198f4c4b163c0
Reviewed-on: https://gerrit.instructure.com/23958
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Braden Anderson <banderson@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
fixes CNVS-7343
test plan:
* create a discussion topic with a delayed posting date
* edit the topic, uncheck delay, and save
* verify that the topic is no longer delayed
Change-Id: Iaaba7c2bdfbd1e8ce196c937d4917fc2470cbb6c
Reviewed-on: https://gerrit.instructure.com/23957
QA-Review: Cam Theriault <cam@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
test plan:
* open conversations beta
* select a conversation with multiple messages
* hover over a message from the middle of the conversation
* click the reply or reply all icon
* verify that the included messages list contains messages
prior to the message you're replying to
Change-Id: Ie7dc9137541262b5dbf94dc0809529dc81f937d5
Reviewed-on: https://gerrit.instructure.com/23948
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
QA-Review: Zach Pendleton <zachp@instructure.com>
changes in this commit:
* can no longer highlight a single message in the
right pane;
* standardize vertical padding on messages in the
right pane;
* remove superfluous course code in left-pane message
list's header;
* standardize height of messages in left pane;
* in left pane, right-align message count to last
message time;
* move delete icon in right pane messages to the gear
menu;
* center the author and context information on author
avatar in right pane messages;
* reply-all on an individual message is now an icon in
the hover actions in the right pane.
Change-Id: I0109ab50f0e985290e24abf5bd5afccf78812f0e
Reviewed-on: https://gerrit.instructure.com/23688
Reviewed-by: Braden Anderson <banderson@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
Braden Anderson