Changes the display of letter grades (e.g. "A-") to use the unicode
minus character (U+2212) instead of en-dash, so that screenreaders properly
read the grade (e.g. "A minus" instead of "A (pause)").
flag=none
closes EVAL-3344
Test Plan:
- On the following pages, verify displayed minus letter grades use the
unicode minus character and are announced by screenreaders as
"<the grade> minus":
- global student grades page (/grades when a student is enrolled in more
than one course)
- student grades page
- new student grades page (student_grade_summary_upgrade FF enabled)
- A2 assignment page
- SpeedGrader
- Default Gradebook
- Enhanced Individual Gradebook (individual_gradebook_enhancements
enabled)
- On pages where letter grades can be input to grade a student (e.g.
Gradebook + SpeedGrader), verify both types of input are accepted:
- "<the grade><en-dash>" e.g. "B-"
- "<the grade><minus>" e.g. "B−"
Change-Id: I3b8c4b48f198966d492900edbe6265cd98f311f3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327945
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
[skip-stages=Flakey]
Change-Id: I6abefdfa9fed6dd4525c8786e93efa548b3710f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319603
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
closes CNVS-34622
test plan:
1. Enroll a user as 'Teacher' in at least two courses.
2. In one of those courses, add a student to multiple sections.
3. Log in as the teacher and go to the global grades page at /grades.
4. Verify the page loads.
Change-Id: Ifa2b95d2d67fce649de410cc91f52514c71ab4df
Reviewed-on: https://gerrit.instructure.com/100796
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
refs #CNVS-21596
Change-Id: I430704d1f40aa8bcd54072a13ef55aa6a5332dd1
Reviewed-on: https://gerrit.instructure.com/58955
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
when teaching 2 sections within the same course, we shouldn't display 2 links for one course.
Added a test to cover unique courses
fixes CNVS-6682
test plan:
1. Enroll a teacher to more than one section in a course
2. Click on Grades in the top nav
3. Make sure only one link is displayed for the course with multipled section enrollments
-
Change-Id: I22ef5f437b405a8a33c48c182d51adf231ab75c4
Reviewed-on: https://gerrit.instructure.com/37318
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
Apparently the fact that a shared example group added its before/after
filters to the outer context was a bug, and it's been fixed in rspec 2.
So we can't use a shared example group to setup or mark pending sharding
specs anymore.
test plan: specs
Change-Id: I92b022e2e7125214e6bad38bf0a23da547fca984
Reviewed-on: https://gerrit.instructure.com/19182
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Duane Johnson <duane@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
Simple "with_each_shard" fix for the
actual enrollment loading code.
I also pushed the data transformations down into
a presenter since there were so many
instance variables, and added some focused
specs around the presenter. (and updated
the view to reference all collections
from the presenter, memoizing to ensure
nothing gets transformed more than once)
Finally, to make the grade book summary work,
had to branch off of Jacob's fix for foreign
keys across shards and make use of
'relative_id_for' in the gradebooks_controller
fixes CNVS-2201
TEST PLAN:
1) login as a user who has enrollments
in 2 courses on different shards.
2) navigate to "/grades"
3) you should see all your courses, not just
the ones on your current shard.
Change-Id: I385bd94cce71bf2aee03b1ae7679157c08910924
Reviewed-on: https://gerrit.instructure.com/17667
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
Spencer Olson