Commit Graph

5 Commits

Author SHA1 Message Date
Cody Cutrer 103dce1f4a add frozen_string_literal comment to binaries
Change-Id: I4d0b95c1f22891772cfdc8a20adf0ff1e1bc8a8b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261819
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2021-03-30 18:14:03 +00:00
Cody Cutrer 8093d2fcbc force brakeman to rails 6
since Gemfile.lock doesn't currently exist with default settings,
it's assuming rails 3

Change-Id: I5a2afd9fba8b4ca1bd8d825a73d6f1b090a7e133
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258387
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2021-02-09 02:07:35 +00:00
Landon Wilkins 65744119ca dry up linters
test plan:
* see test commit verifying linters still work

Change-Id: I406c218309e824618869c9b5f3841af8387bf836
Reviewed-on: https://gerrit.instructure.com/98329
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Reviewed-by: Shawn Meredith <shawn@instructure.com>
Product-Review: Shawn Meredith <shawn@instructure.com>
QA-Review: Shawn Meredith <shawn@instructure.com>
2017-01-10 19:44:48 +00:00
Landon Wilkins 75af98699c use gergich in ruby instead of bash
fixes SD-1938

test plan:
* see that gergich still successfully comments on
  linter output on patchset 1

Change-Id: I3beecfab405e57ba0e8705821d6d297fe7423c3e
Reviewed-on: https://gerrit.instructure.com/98317
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2016-12-22 01:31:29 +00:00
Bryan Petty c76a9b6a79 add brakeman scanning for ci
refs: ENGSEC-1

Runs Brakeman security scanning on CI, reporting only on relevant
source changes, and only with Medium confidence for now.

Test Plan:
1. Brakeman runs on Jenkins aux builds.
2. Security warnings are only issued for changed files.

Change-Id: I5ce0d4ff47203a5df31ca30cdcb7e9b0cba32b0a
Reviewed-on: https://gerrit.instructure.com/96775
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
2016-12-07 21:22:08 +00:00