This will allow the external tools to fully show given the
module sequence footer is floating at the bottom now.
closes CNVS-26677
Test Plan:
- Load up a course with TurnitIn enabled
- Add an external tool to a module
- As a student take a look at the module
- The footer should not cover the "accept/reject" buttons
for TurnitIn.
* Note: This must be done at a lower resolution as it doesn't
affect larger screens since they have plenty of screen
real estate.
Change-Id: I3ae25cf3cc1e31dfd69cab3246afeaf8eb41aff8
Reviewed-on: https://gerrit.instructure.com/71042
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes CNVS-26856
test plan
- hit api/v1/accounts/self/courses with an admin
that does not have "View the list of courses”
- it should 401
- give permission and it should work
Change-Id: Ib70361fc4c9f894fa5562d9e447e632858f31b6a
Reviewed-on: https://gerrit.instructure.com/71069
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
refs CNVS-25916
this spec is checking the DB to check it's efficacy, which is something
hard to time right, and not correct for an acceptance test anyway.
To stabilize it, we check it's efficacy by examining what the user
can see instead (same way QA would check it), and we use the normal
selenium tools for awaiting page loads.
TEST PLAN:
1) profile_spec failure rate should drop
Change-Id: Iec1e0b95353a13d4f12b5cc005f2722d2d9f73c4
Reviewed-on: https://gerrit.instructure.com/71086
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
allow sorting by assignment group, due date, module,
and title on the course grades page. also, store
the user's sort preferences and remember that
preference on subsequent page loads.
closes CNVS-21660
test plan:
- as a student, go to the /courses/:course_id/grades
page.
- verify there is a dropdown to sort assignments by
due date and title. the first time you visit this
page, the dropdown option should default to
ordering by due date. verify each option correctly
sorts the assignments.
- if the course has any Modules, there should be an
option to sort by Module. if the course does not
have any Modules, there should not be a Module sort
option.
- if the course has assignments that belong to different
Assignment Groups, there should be an option to sort
by Assignment Group. if the course does not have any
assignments, or if all of the course's assignments
belong to the same Assignment Group, there should not
be an Assignment Group sort option.
- select any option besides 'Due Date'. next, leave the
page and return back to the page. verify the selected
dropdown option matches the option you selected before
leaving the page.
- repeat the steps above while logged in as a teacher, TA,
student view student, and admin. when logged in as a teacher,
TA, or admin, the url will be /courses/:course_id/grades/
:student_id
- verify the dropdown is accessible
- note: if a student is enrolled in multiple courses, the
dropdown for the sort order should be on the right-hand
side of the /courses/:course_id/grades page (and the
dropdown for the course selection should be on the
left-hand side). if a student is only enrolled in
one course, the dropdown for sort order should be on
the left-hand side of the page.
Change-Id: Idbcbea2d25051cb5d933bfb395daebeedc630855
Reviewed-on: https://gerrit.instructure.com/69419
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
- also encode URI components when generating context URI
Fixes CNVS-26130
Test plan:
1. Create a course with no outcomes defined
2. Create and save an assignment
3. Click on "Add Rubric"
4. Click on "Find Outcome"
5. Click on "Click here to go to the outcomes page"
6. Verify that you are taken to outcomes page instead of error
7. Go to Outcomes/Manage rubrics in course with no outcomes defined
8. Repeat steps 3-6
9. Go to Accounts/Rubrics in account with no outcomes defined
10. Repeat steps 3-6
Change-Id: I2ada04858d124ecbdb1e205baef34e0180063f6a
Reviewed-on: https://gerrit.instructure.com/70258
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: McCall Smith <mcsmith@instructure.com>
This commit removes technical debt introduced in
CNVS-25850.
fixes CNVS-25853
Test plan:
0. With the "Gradebook Performance" flag turned off on:
`/accounts/1/settings`
1. Go to Gradebook in a Course with Assignments.
2. Click on the name of the assignment.
3. Verify that the assignment show page loads.
4. Review links and text throughout gradebook to verify
that nothing else is mangled.
5. Create an assignment with the following text as its
title:
<script>alert('oh 💩')</script>
6. Reload the gradbook and verify that no popup is visible
Change-Id: I0cf4d191fa69f1ab2f8ceab763b2078d1be255fe
Reviewed-on: https://gerrit.instructure.com/68834
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
fixes CNVS-25686
Test plan:
0. With multiple grading periods enabled in a course with
many periods, a teacher, and a student…
1. As the teacher, create many assignments in several
different grading periods, ensuring the assignments are
not created in calendar order.
2. As the teacher select "Arrange columns by due date" in
gradebook settings.
3. Refresh the page and verify that the assignments are
sorted by due date.
4. As the teacher select "Arrange columns by assignment
group" in gradebook settings.
5. Refresh the page and verify that the assignments are
not sorted by due date.
Change-Id: Iaa590e29d9bf512c0b2ac12dad2b7c64a2b579ab
Reviewed-on: https://gerrit.instructure.com/69253
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins
Product-Review: Strand McCutchen <smccutchen@instructure.com>
fixes CNVS-14719
test plan:
- Create a quiz with a multiple-dropdowns-question.
- Navigate to take the quiz.
- Observe that the dropdowns work as expected.
- Complete the quiz with a student.
- Observe the completed quiz screen.
- Observe that there are no dropdowns in the question text.
- Observe that the selected answers are just treated as plaintext
when interacted with via VoiceOver, NVDA & JAWS.
Change-Id: I9506f064417eae85c084a15c416974d4f00568ee
Reviewed-on: https://gerrit.instructure.com/70156
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
fixes CNVS-26804
test plan:
* as a teacher, do a POST to /courses/:id/undelete/teacher_name_1
* it should 500
* the logged error should be about invalid type, not about no
method named find for nil class
Change-Id: I3dc6cc5fa0f64a21762bf37caec1b6167e3c08e6
Reviewed-on: https://gerrit.instructure.com/70970
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes #CNVS-26144
Change-Id: Iccf3c707cd3d1e09ef90d878d74b472f08ec9576
Reviewed-on: https://gerrit.instructure.com/70988
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
refs CNVS-25916
the subscription icon class gets added in an afterRender hook,
so it sometimes fires after we're already checking to see if the
data is there yet. This stabilizes the wait time to make sure the
transition is complete before we start checking it's state.
TEST PLAN:
1) discussions_index_page_any_user_spec fail rate should decline lots
Change-Id: I85d82f4d59314b33b44b4b5d4482db6b2a4e3566
Reviewed-on: https://gerrit.instructure.com/71032
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
refs CNVS-25916
this link has it's text changed in stages (to blank then to unpublished)
and if we start asserting things on it before it's been populated
we get intermittant breakages. This makes sure the transition is
complete before continuing into the specs.
TEST PLAN:
1) quizzes_publish_quiz_teacher_spec fail rate should fall significantly
Change-Id: I32385e36103e06c7b90c07c64f626cae39dafa21
Reviewed-on: https://gerrit.instructure.com/71022
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Fixes CNVS-26059
Test plan:
1. Go to outcomes page with outcomes defined
2. Select one of the outcomes to bring up detail
3. Tab to Back button and click
4. Verify that focus remains in outcomes content
5. Select an outcome group to bring up group members
6. Tab to back button and click
7. Verify that focus remains in outcomes content
Change-Id: Iafcc3d95c71d8c06ce5fe0ed056b7d8f5d964325
Reviewed-on: https://gerrit.instructure.com/70432
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
- Workaround of rails bug affecting account.all_users.find
Fixes CNVS-26170
Test plan:
As account admin:
1. ensure account has student users and outcomes
2. go to the user page for a student user
3. click "See Outcome Results for ..."
4. Verify that the page shows a table of outcome results
instead of a server error
Change-Id: I71cac5d9250dc6601213f81a970a7d6d1798e1de
Reviewed-on: https://gerrit.instructure.com/70364
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Tested-by: Jenkins
Product-Review: McCall Smith <mcsmith@instructure.com>
fixes CNVS-26207
- decaying average now provides a score for a single outcome result
- n_mastery now supports n==1
Test plan:
1. As a teacher, add an outcome with type decaying average
2. Associate a new rubric with the outcome
3. Attach the rubric to a new assignment
4. As a student, complete the assignment
5. As a teacher, grade the assignment, including a passing score
in the rubric
6. View the learning mastery gradebook
7. Verify that the student's single result is reflected in LMG
8. Repeat steps 3-6 with this rubric.
9. Verify that the mastery score average is updated appropriately
10. As a teacher, add an outcome with type n_mastery and n==1
11. Repeat steps 2-9 with this new outcome
Change-Id: I1d3d833997252cbdc273304a7cb971eaf37edfe5
Reviewed-on: https://gerrit.instructure.com/70212
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: McCall Smith <mcsmith@instructure.com>
Fixes CNVS-25911
Test plan:
Align an outcome to a question bank
Create a quiz
Import question bank into quiz
Have student take quiz
Go to outcome show page
Click on the quiz result within "Artifacts"
Should redirect to quiz submission, not show error
Change-Id: Ibb25d4fae21ccce29d49325bd593de3eafd866e3
Reviewed-on: https://gerrit.instructure.com/70093
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Tested-by: Jenkins
Product-Review: McCall Smith <mcsmith@instructure.com>
fixes CNVS-24774
fixes CNVS-25052
Reverts "gradebook quiz icon appears when quiz receives
default grade." This reverts commit
b3dc1c72f5.
Test plan:
- As a teacher, create a quiz with an essay question.
- As a student, take the quiz.
for CNVS-24774
==============
1. As the teacher, view the Gradebook as and click
the Q for the submission.
2. Click on another cell in gradebook.
3. Verify that the quiz icon remains.
for CNVS-25052
==============
1. In the Gradebook, hover over the grading cell for
the student and the quiz, and click the comments
icon.
2. In the dialog box that appears, click on "More
Details in the SpeedGrader"; this opens the
SpeedGrader in a new tab.
3. In SpeedGrader, manually change the score for the
question and click on "Update Scores".
4. Close the SpeedGrader, then close the dialog box
in the Gradebook.
5. Go back to the SpeedGrader and view the submission.
6. Verify that it has the score which you previously
gave it.
Change-Id: Ibd6ccef7daa427cbe847ef6b1d7b43580c9c2386
Reviewed-on: https://gerrit.instructure.com/70619
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Christi Wruck
closes CNVS-25748
test plan:
- verify clicking the 'i' icon brings
up the keyboard shortcuts menu
- verify the 'i' icon is accessible.
the screenreader should announce
'Keyboard Shorcuts' when focusing
on the 'i' icon.
Change-Id: Ie4a721db7623f2d0935b4b853ad7bfa359a97ee3
Reviewed-on: https://gerrit.instructure.com/70444
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Christi Wruck
fixes CNVS-26257
test plan:
on the question bank page tab to the bookmark icon
next to a QB and press enter
the kb focus should stay on the icon
Change-Id: I3ea57d8e25076fd62989c180e64fe02660618a2a
Reviewed-on: https://gerrit.instructure.com/70433
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
refs CNVS-25916
sometimes this click event fires just before the link is available.
This adds some timeouts to make sure we don't die on this spec
because the page wasn't ready.
TEST PLAN:
1) quizzes_one_question_at_a_time_spec should stop fragile failing
in the webpack selenium build
Change-Id: I3534ccb8e4905a114efa58aab32eb2967eb01a95
Reviewed-on: https://gerrit.instructure.com/71016
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-23878
test plan:
* go to password reset
* it does not allow blank
* it should allow you to attempt a username that's not an e-mail address
* if you have multiple users with the same e-mail address (or username),
you should receive an e-mail for each
Change-Id: I6ff81861dd6f5cc3aaf3317d4a53491ac31550bc
Reviewed-on: https://gerrit.instructure.com/70311
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
TEST PLAN:
1) start canvas with no consul config
2) no error messages should be logged
Change-Id: I55898e1630b63ca5a96d1d178dba6db66c844fb5
Reviewed-on: https://gerrit.instructure.com/71009
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
refs CNVS-25916
sometimes we try to type data into tinymce instances that aren't
initialized yet. This results in saving no changes, so specs fail
intermittantly because the input didn't take effect.
TEST PLAN:
1) groups_pages_student_spec should stop being a fragile problem
in the webpack selenium build
Change-Id: I3e93e8b3d30b2e18152c4562acb05f937cf5d0d1
Reviewed-on: https://gerrit.instructure.com/71011
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
refs CNVS-18526
test plan:
- navigate to <canvas>/accounts/self/plugins/ticketing_system
- select an account and ticketing system type
- apply the account configuration settings
- expect plugin settings to successfully update
Change-Id: Ie620e26dd991b54d9cdbb24c4680386c826b2572
Reviewed-on: https://gerrit.instructure.com/71001
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: August Thornton <august@instructure.com>
fixes CNVS-26792
there was a regression with the integration of notification service
where a line assumes presence of the user, this adds a guard clause
to allow those messages to deliver.
TEST PLAN:
1) file a ticket with the ticketing system with no user logged in
2) no NoMethodError should be thrown during dispatch
Change-Id: Ia3cb322dd533a414c9bba1cb51dc51d8f90cbf7b
Reviewed-on: https://gerrit.instructure.com/70976
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
The button was working fine in development but not in production.
The events was never triggered (confirmed that by adding a 'console.log').
I had to modify the click listener with a 'on' one to make it work.
It is quite logic I think, as the button is actually 'appended' using javascript.
In production it was failing both for firefox and chrome.
Test plan:
* Create a course, with a module and a page (and/or an assignment)
* Add a mark as done requirement for the newly created resource
* Invite a student and connect using his account
* Go to the page (of course you did not forget to publish it?)
* Try the mark as done button
Again, it was working fine in development but not in production. I do wonder why... if you have any ideas, let me know.
refs #CNVS-26056
Change-Id: I3f60457ffc2ea1e2676da583903418513cc00634
Reviewed-on: https://gerrit.instructure.com/70843
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
refs #CNVS-26056
Change-Id: I0cb3c3c46ccee9e26972853aa0f08db0f0fffcce
Reviewed-on: https://gerrit.instructure.com/70967
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-26796
test plan
- should not be typoed
Change-Id: I6b8629d3245b93a6abf0b8c9bfd6480107f0a0ee
Reviewed-on: https://gerrit.instructure.com/70969
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
refs #CNVS-25860
Change-Id: I7b82860481e56b1d27647dd5a3d63c950558e2c2
Reviewed-on: https://gerrit.instructure.com/70862
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Change-Id: I8db845360a3f38e2ff4cb9390ae75b240eb6f783
Reviewed-on: https://gerrit.instructure.com/70953
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Clay Diffrient