fixed some errors with really early dates
with assignments in canvas
fixes CNVS-19936
test plan:
- create an assignment with an old date (before the year 1000)
- go to the assignment index notice no crash
- go to assignment show notice correctly shown date
Change-Id: I1733729989b4cf5954dd66c83d9cbd779d189430
Reviewed-on: https://gerrit.instructure.com/53451
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
refs CNVS-16799
No behavior change, just proving that when you
explicitly pass in a nil object to a date or time
presenter as a zone override, it uses the default
Time.zone correctly. the actual behavioaral change
went out in a hotfix in /c/44148
TEST PLAN: specs should pass
Change-Id: I59da9cf68d5738b1006ae1579db2946731468539
Reviewed-on: https://gerrit.instructure.com/44159
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Stepping through the code, old and new, zone is set to nil when the call
to ::Time.zone happens in the default argument position, but not when it
happens as the first line of the function. I don't yet know why.
fixes CNVS-16799
test plan:
- create an assignment with a due date
- view the assignment as a student. the due date should match
(repeating test plan from commit that caused the regression)
- Create a new course shell and go to the courses settings page and set
the courses time zone as Eastern and save the change.
- Create a new assignment and put a due date of whatever day you want,
but have the time be 11pm and save it.
- When the page reloads, hover your mouse over the due date.
- The due date should be correct (on the day after).
Change-Id: I048d766f1552f2c244b5cdebbd7cc3445ed92969
Reviewed-on: https://gerrit.instructure.com/44148
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-13541
write specs to identify the issue
(and to confirm that it's not present
in the javascript layer that does similar
formatting work)
start breaking apart text helper
because we need some object that
can persist a zone override through
all the helpers
pull out a set of utils classes for dealing
with date and time presentation
fix the zone override when doing a date time
presentation across multiple zones
TEST PLAN:
- Create a new course shell and go to the
courses settings page and set the courses
time zone as Eastern and save the change.
- Create a new assignment and put a due date of
whatever day you want, but have the time be
11pm and save it.
- When the page reloads, hover your mouse over
the due date.
- The due date should be correct
(on the day after).
Change-Id: I3274a502545bdbbb482bc7e529446e2fa422740c
Reviewed-on: https://gerrit.instructure.com/42064
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Steven Burnett