Test Plan:
Create a user.csv file to import via SIS Imports with a row
containing an invalid login_id.
Note that the message is not "unique_id is invalid"
Note that the message contains contextual login_id and
sis_id / user_id information
Fixes: SIS-1732
Change-Id: I16f47d57f4dbe2550d979e6f6552d164a8709631
Reviewed-on: https://gerrit.instructure.com/71056
Product-Review: Linda Feng <lfeng@instructure.com>
Tested-by: Jenkins
Reviewed-by: Max Stahl <mstahl@instructure.com>
Reviewed-by: Nick Houle <nhoule@instructure.com>
QA-Review: Kausty Saxena <kausty@instructure.com>
In order to facillitate better debugging and customer support efforts,
the error messages given for enrollments that had a valid user but not a
valid course or section id were improved. The error message now includes
the relevant course ID, section ID, and user ID, in a convenient format,
in addition to the old message.
Example error message (old):
Neither course 1 or section 2 existed for user enrollment
Example error message (new):
Neither course nor section existed for user enrollment \
(course_id=1, section_id=2, user_id=3)
Test plan:
* Create CSVs for SIS import
* Create `enrollments.csv` with valid enrollments for actual users
* Delete some lines from `courses.csv` and `sections.csv` to create
conflicts
* In the "last import" view, the error log should contain the more
detailed error message.
Fixes: SIS-1734
Change-Id: I52b82a7a83f7cf7df4a5845f6d3fc82b9623e47e
Reviewed-on: https://gerrit.instructure.com/71267
Tested-by: Jenkins
Reviewed-by: Ken Romney <kromney@instructure.com>
Product-Review: Linda Feng <lfeng@instructure.com>
QA-Review: Kausty Saxena <kausty@instructure.com>
test plan:
* create a new user
* as the user, upload a new file to the user's folder
* refresh the page
* the quota should be updated
close #CNVS-27064
Change-Id: Ic16b807428802f24b2dd502de25bdbd4902f6d82
Reviewed-on: https://gerrit.instructure.com/71606
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
refs CNVS-27034
also refs gerrit c/71414/
this takes out the old "pass text" path that shouldn't be used
anymore for processing gradebook uploads. No active code paths
are being changed.
TEST PLAN:
1) gradebook imports still work
Change-Id: I3e0840c86ad7d0441164dcf6202932fc319d80e7
Reviewed-on: https://gerrit.instructure.com/71528
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-26537
test plan:
* use new UI
* add a user as an admin in a subaccount
* delete that subaccount
* as that user, the sub account should no longer show up
in the account tray
Change-Id: I8bffdf43a941b7e1348317691f16ac47301b918b
Reviewed-on: https://gerrit.instructure.com/71623
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
turns out zh_Hant is not a valid BCP 47 language tag
but "zh-Hant" is
this error was being swallowed up in the files and
groups pages by react
test plan:
* with locales enabled, the files and groups pages
should work with Traditional Chinese locale
closes #CNVS-26943 #CNVS-18596
Change-Id: I2f1aacae093a945bfedc95a2765657c1fb2d62b7
Reviewed-on: https://gerrit.instructure.com/71578
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
some assignments are only visible to overrides, not to an entire course,
these must be handled specially when applying assignment overrides
Added a basic spec for Api::V1::SisAssignment. Then added a failing
spec for 'sis assignments handle only visible to overrides', then added
the bit of code to get the spec to pass.
test plan:
* in a course with multiple sections
* create an assignment
* create another assignment that is only applicable to a single section
* query the sis assignments api:
- /api/sis/courses/:course_id/assignments
* the first assignment should return all sections in the course
* the second assignment should only return the section for which it is
applicable
Fixes: SIS-1623
Change-Id: Iaa34295b98ea9615df400287ffbea0d762cc48bc
Reviewed-on: https://gerrit.instructure.com/69702
Tested-by: Jenkins
Reviewed-by: Brad Humphrey <brad@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Ken Romney <kromney@instructure.com>
test plan:
* add a person to a course as a non-observer role
* should be able to use the cog menu through the people page
to edit their role to an observer role
* if you link the unassigned observer to a student, their
role should no longer be editable
closes #CNVS-27094
Change-Id: I9cf962bc71b60d0bb9053f5f91218e00f99e6a05
Reviewed-on: https://gerrit.instructure.com/71477
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
this spec fails all the time, and selenium is overkill for it... if it's
even worth testing, it should be done as a JS test
Change-Id: I2feea6484b4bf8576bd1c772a51d82ac1d670b75
Reviewed-on: https://gerrit.instructure.com/71593
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
test plan:
* create a wiki page and add it as a module item
* require the page to be viewed
* require the module to be progressed through
sequentially
* as a student, visit the wiki page
* it should work on first load
closes #CNVS-26868
Change-Id: I06c8eaf571547ef4222d33e52ce40f458471dced
Reviewed-on: https://gerrit.instructure.com/71241
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-26160
Note for reviewer: In addition to fixing the bug, I
also fixed some small issues with the print styles
and the new UI:
- Hamburger button and header no longer print
- Margins for the primary nav and the context
nav have been removed, so the printing can cover
the whole width of the page.
Test plan:
- Create a very long page in a course. Print it to
PDF/Preview in Chrome or another unaffected browser
to confirm it prints over more than one page.
- Open the same page in Firefox. Go to Print >
PDF > Open PDF in Preview (see bug report in
JIRA for a video)
- Confirm that the page prints to PDF/Preview
successfully. There should be no more cutoff,
as reported in the bug.
Change-Id: Ibed9f83af1fddaea20524fa552539ce337b5f204
Reviewed-on: https://gerrit.instructure.com/71378
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-13304
test plan:
- have at least two question banks
- create a new question in one bank
- without refreshing the page, move or copy
question to other bank
- the question should appear in the new bank
- check both question banks and general
quiz question creation/editing for regressions
Change-Id: Ib3162320487eee33d8f3aeabb12dc4091d8b1f6a
Reviewed-on: https://gerrit.instructure.com/71228
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Matt Berns <mberns@instructure.com>
fixes CNVS-26303
test plan
- go to a users ePortfolio
- add some pages and edit their content
(https://community.canvaslms.com/docs/DOC-2745)
- add a page, but do not alter default content
("No Content Added Yet" will be default content)
- attempt to download ePortfolio as a zip file
- it should be successful
note:
if this is a small course the download should take
no more than 1 minute or so. If you're waiting for
an abnormally long period of time, it's likely
something has gone wrong.
Change-Id: Ied8d53e224496ac8f092b5ef950a28aed980ea59
Reviewed-on: https://gerrit.instructure.com/70520
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Matt Berns <mberns@instructure.com>
I removed this in my change because consul outputted a warning
suggesting that I didn't really want it... but I think what it was
actually saying was use `-bootstrap` instead of `-bootstrap-expect 1`.
This fixes an intermittent error if the canvas dev container tries to
query consul before it is ready.
Change-Id: I48988592f9cbea4c32b372461f56ebbd8b34567c
Reviewed-on: https://gerrit.instructure.com/71583
QA-Review: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
Tested-by: Brian Palmer <brianp@instructure.com>
closes CNVS-27034
stops dumping the file to the delayed job parameter, which was never a
good idea. This sends it to S3 or file storage and streams it from
there on import. With the current setup, way more memory than necessary
is consumed while the job is running, and this is the way we process
large files in places like SIS anyway so this makes it more consistent.
TEST PLAN:
1) gradebook imports should still work
2) gradebook import jobs should not eat memory like popcorn
Change-Id: If5bc1aab2eba01c617d6c37480fe777000d80165
Reviewed-on: https://gerrit.instructure.com/71414
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-25944
Test Plan:
- Register an Arn with your local canvas through console
- enqueue a message to be delivered from canvas
- notice the push notification on your phone
Change-Id: I1ac80f9ca74953b27d58a95d3f382bf43ad242a1
Reviewed-on: https://gerrit.instructure.com/70425
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Tested-by: Jenkins
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Fixes: CNVS-26578
test plan:
- as a user with old or new ui
- navigate to > account > ePortfolios in new UI
- navigate to > settings > ePortfolios in old UI
- the 2px reference in this case was for a separator
see screenshot of usage http://www.screencast.com/t/vxF86S3qX1
ensure enlarging to our minimim 12px hasn't broken anything
Change-Id: I8977d5424d3ffcc7eaaf7240f98f97ceec1b91b9
Reviewed-on: https://gerrit.instructure.com/70870
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Refs: CNVS-26580
test plan:
setting the stage:
- as a teacher using old or new ui
- ensure that "turnitin" is configured under the account settings
example: http://screencast.com/t/BQfGlThV9 (in addition to checking
the box you will need to scroll down and configure the turnitin
settings - info inside gollum under "other services")
- next create an assignment that has turnitin enabled and file uploads
example: http://screencast.com/t/QzEHfjEKoO
setting the stage part two:
- as a student that is enrolled in the above course
- submit an assignment that is uploaded (this submission needs to
contain a significant amount of content that you have pulled
from let's say... wikipedia)
final steps:
- as the teacher navigate to speedgrader to view the above student
submission - it should look similar to this example:
http://screencast.com/t/2fT0zR4KU
- font size is now our minimum of 12px vs the 9px and lastly it is
set using the rem font translation so it can endlarge if the
user enlarges the browser font from medium to large or very large
Change-Id: If70cbc202b5ad6b5fdab1a975024230552f2f5c7
Reviewed-on: https://gerrit.instructure.com/71117
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Refs: CNVS-26580
test plan:
- setting the stage... will need to have an unread message in
your inbox
- as a user with the old ui navigate to your home page so you
can view the unread message bubble on the inbox nav
example: http://screencast.com/t/66rS62GWv
- if you increase the browser font from medium to very large
the notification bubble should increase as well
example: http://screencast.com/t/va77e0g7Rnjd
Change-Id: I0bacb421ed79f113228c8e6dc8289593589e637e
Reviewed-on: https://gerrit.instructure.com/71070
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
depending on spec run order, sometimes you'd get ::UserNote instead of
::Alerts::UserNote, and everything would asplode. make sure we only look
within ::Alerts and nowhere else
test plan:
* rspec ./spec/models/alerts/delayed_alert_sender_spec.rb:294:233 --seed 39656
should now pass
* ¯\_(ツ)_/¯ ... i hope we don't actually sometimes want stuff here from
other places in the module tree, cuz that would be bananas
Change-Id: I8091c3a48e094ac4994e2fb6e24d1d582915d928
Reviewed-on: https://gerrit.instructure.com/71530
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
This removes our custom-built consul docker container (only used in
development) and replaces it with a popular public image from the docker
registry.
Change-Id: I7d42117e704f60b99f8e7f2895e9fb1b029c15f2
Reviewed-on: https://gerrit.instructure.com/71511
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
Fixes: CNVS-25379
Code review note: I realized that adding dimensions
to this image via CSS would also affect any user-
uploaded images that live inside this container. The
least-harmful way in the end was to specify the width
and height within our default logo SVG file (this does
not prevent the SVG from scaling down).
I also changed the dimensions of the image container to
better match the dimensions of the area at the top of
the main nav where the image will be placed.
Test plan:
- Recompile assets and clear browser cache
- Open Theme Editor. If you have any custom
theming going, please reset Canvas to its
default branding :(
- Expand the Global Navigation section
- You should now be able to see the default Canvas
logomark in all supported browsers:*
http://screencast.com/t/lMAhb5l8q5Wg
* Note: MS Edge had a bug with scaling images via
max-width (which we do here to keep the image inside
our image container):
https://connect.microsoft.com/IE/feedback/details/
1494666/
scaling-an-svg-using-max-width-vs-width-in-microsoft-edge
It is fixed now, but if you have an older build of
Edge, you might find the default Canvas logo looks
a little small.
Change-Id: Ia4eeec799c8aa7a00d0e2c32c89bf53856e87fa3
Reviewed-on: https://gerrit.instructure.com/71306
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-26169
Test plan:
- Follow the instructions in the JIRA ticket to
reproduce bug
- The search input should now look like this:
http://screencast.com/t/vrM9HbLG
- Text inside the search input should no longer
be getting cut off in Firefox
- I also changed the type of the input to "search"
instead of "text"
- The search input should function exactly as it did
before this change: filtering student names
- Note: the search input has an aria-label attribute,
so it did not need an html label
Change-Id: I52d3ddc01ccb03bfa8c2fbbc0d73ae21d54593c8
Reviewed-on: https://gerrit.instructure.com/71289
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-26276
Test plan:
- Go to [your school]/sub_accounts
- The page should now look like this:
http://screencast.com/t/o6bU9Mqsf
- Icon buttons should now meet color contrast
requirements
- Also tidied the old CSS up a bit: added current
variables for text, some margin/padding and
background-color, and reduced the font-size of
each subaccount list item heading.
- Buttons on the page should work exactly as before.
Change-Id: Ia889181de85099770d552f82f73d482bacff7bcc
Reviewed-on: https://gerrit.instructure.com/71279
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Blake Simkins <bsimkins@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Add FAQ, where we can add things as people run into problems
Change-Id: I671bee6d53c845d66de7d65fd25baf46adb1d240
Reviewed-on: https://gerrit.instructure.com/71533
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Ethan Vizitei <evizitei@instructure.com>
This allows a vendor file to be ignored from the xss
check
Test Plan:
- Nothing to test here.
Change-Id: Ic312e412e7e1790c9c2ac99823d1a2905af81c9f
Reviewed-on: https://gerrit.instructure.com/71476
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Transifreq