ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
47,119 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

8 Commits

Author SHA1 Message Date
Cody Cutrer 548a2a1732 update all invocations of send_later and friends to new syntax 
Change-Id: I7f40ed058b50882121da69f0cb05966854b8e920
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/250924
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
 2020-10-30 19:13:54 +00:00
Cody Cutrer 06763dd519 add # frozen_string_literal: true for lib 
Change-Id: I59b751cac52367a89e03f572477f0cf1d607b405
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251155
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2020-10-27 20:49:50 +00:00
Cody Cutrer c5227d3f1b shackles was renamed to guardrail 
closes FOO-989, FOO-990

Change-Id: I49dfa130cb74c34dd0eb25952790176ae4951058
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249365
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2020-10-06 19:23:08 +00:00
Jeremy Stanley 7c2fcc3542 use squiggly heredocs for SQL 
to avoid sending unnecessary whitespace to the database

test plan: specs

closes LS-1422

Change-Id: Iaaa73059b46964d4c51e920fd469b876256ec632
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246811
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
 2020-09-04 19:11:47 +00:00
Spencer Olson d720b98df1 fix bigdecimal deprecation warning 
Fixes `warning: BigDecimal.new is deprecated; use BigDecimal() method
instead.`.

flag=none

Test Plan:
- specs pass

Change-Id: I11f41131a18f464703c40ee9b38fe8b2590a8768
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/242727
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
 2020-07-15 19:59:56 +00:00
Keith T. Garner f2e9c8c076 remove vestigial class name alias 
test plan:
 - specs pass

Change-Id: Ib11e1c658f7ccca6d4854c86238140156a4866fb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/242078
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Keith Garner <kgarner@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Syed Hussain <shussain@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
 2020-07-07 18:58:09 +00:00
Adrian Packel aa88124a0b Set root_account_id for assignment score stats 
closes TALLY-705
flag=none

Test plan:
- Create a course with some students and some assignments
- Assign some grades
- Check that the ScoreStatistic models for the affected assignments have
  their root account ID set to the course's root account ID

Change-Id: I12787d38f5016856f616084daef3086fe4ad8b26
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/239968
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Syed Hussain <shussain@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
 2020-06-12 17:04:05 +00:00
Keith T. Garner c62b2787f2 rewrite grades presenter course score statistic to be cached 
This caches the averages for the teacher's grade as part of the score
statistics generator. This rewrite removes the need for a course-level
cache busting as it was only used

closes TALLY-851
flag=none

test plan:
 - Have a few courses with a few assignments and a few students
 - As a teacher, grade the students
 - As a teacher, go to /grades
 - Ensure values for all the teacher's courses appear
 - Ensure the values are correct (i.e. the average of each courses
   current scores for all active and invited enrollments)

Change-Id: Ieeb5ddb734d8bc21f40196014d062b9ba5935ebd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/234109
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
 2020-04-23 19:37:50 +00:00