closes CORE-2620
Test Plan:
- Turn on RCE enhancements
- Click image icon in RCE
- Plugin menu should show
- Clicking upload images should show old image plugin
- Clicking course images should show temporary alert
Change-Id: I9c5345f1e78bccebe52d21fd3d351f93f7dcdb6b
Reviewed-on: https://gerrit.instructure.com/188680
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
this fixes the canvas-rce build and means our consumers don't have to
neccisarily be using webpack
test plan:
* cd packages/canvas-rce
* `yarn && yarn test` should work
Change-Id: I25b2262193b45e38c49fb9afea181e900f269fc7
Reviewed-on: https://gerrit.instructure.com/188628
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Closes: CORE-2599
Test plan:
* with the rce_enhancements feature flag turned off, nothing should
change
* turn on the rce_enhancements feature flag
* go to an editor
* it should load without throwing any errors
- note, you will see some “bomb” icons that we will need to update
And the formatting/styling of the toolbar will need some work.
But that is ok for this commit because it is all behind the feature
Flag and we will get address those in a future commit
Change-Id: If28167731b5b285005143861e19fdb2fc0c34def
Reviewed-on: https://gerrit.instructure.com/187179
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
We don’t need these and they just add dead weight to the js browser
bundles
Test plan:
* nothing should change since nothing used these
Change-Id: I2c5aefa1fbc6122cf96fdaf89fd3f6b3759121b7
Reviewed-on: https://gerrit.instructure.com/188122
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes CORE-2595
closes CORE-2596
closes CORE-2597
Test Plan:
- `yarn dev`
- Click on the configuration options
- Click on open content tray
- You should have a dropdown that enables links or files
- Selecting Files should give additional dropdowns for
sub-types and sorting methods
Change-Id: I90eb6d733e13a947ae5fc83c802079dc018b7b39
Reviewed-on: https://gerrit.instructure.com/187854
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes CORE-2594
Test Plan:
- Load up the RCE demo environment
- Open the "Configuration Options" area
- Click "Open Content Tray"
- Tray should open and have some fake content
- Tray should close
Change-Id: I0cff284f84279ea52c6ad6babb31ac19a3060e4d
Reviewed-on: https://gerrit.instructure.com/187472
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes CORE-2590
Test Plan:
- Enable/allow "RCE Enhancements" at the Account level
- Go to an RCE instance
- The JS console should log out a message saying
`Using enhanced RCE`.
- When the flag is off this message should not appear.
Change-Id: Iae44086ee36351201e3953ddeaa3dba24992c682
Reviewed-on: https://gerrit.instructure.com/187398
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
This makes it so we only throw if the error that
gets received is a connection type error
Test Plan:
- Automated tests pass
Change-Id: Ib91ca6f6453c1fc0e4108c3aba3b6a0ae710a77c
Reviewed-on: https://gerrit.instructure.com/187197
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Ryan Shaw <ryan@instructure.com>
closes CORE-2705
Test Plan:
- Go to an RCE instance without canvas-rce-api running
- It should give a better console.error message
Change-Id: I60af01c6ca108a5cfc8592a5e5011a862d4ef73e
Reviewed-on: https://gerrit.instructure.com/187068
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes CORE-2593
Test Plan:
- Documentation makes sense
Change-Id: I68ff4e16e00909951513d649b68a35b66f2913fc
Reviewed-on: https://gerrit.instructure.com/186891
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
This also fixes the build script
refs CORE-2587
Test Plan:
- Automated tests pass
Change-Id: I9fd4e64af0cfb0f67b3678f4e68b382f30c7d3a8
Reviewed-on: https://gerrit.instructure.com/186501
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
closes CORE-2329
There were some tests that were expecting a snapshot-like value
where it expected `new Date().toLocaleDateString()` to give something
Like “2016-7-11” but that was actually wrong. If you do
`new Date().toLocaleDateString()` in a browser it will give you
something like “7/11/2016”. And this new version of node matches what
a real browser would have done, so I just updated the specs so they
are looking for the correct format. This change does not actually
reflect a change in what a real user would see. Just what
jest/jsdom/node formats it as.
Test Plan:
- check to make sure that the assignments 2 availability dates
component produces markup exactly as it did before
- Automated tests pass
- Build canvas locally, everything passes.
- Build canvas with docker, everything passes.
Change-Id: I74285cd6d9b251ca60ab79396e332cc3a419bcee
Reviewed-on: https://gerrit.instructure.com/177198
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
there is a temporary situation where if you upgrade to node 10 and
run `yarn run babel` inside canvas-rce's directory it will
use canvas-lms/node_modules/.bin/babel even though
canvas-lms/packages/canvas-rce/node_modules/.bin/babel exists. there are
unique versions of it because canvas uses babel 6 and canvas-rce uses
babel 7.
like I said, it is temporary and once we are on node 10 and we also
upgrade canvas-lms to use babel 7 then there will only be one babel
(in canvas-lms/node_modules/.bin/babel) and so `yarn run babel` will
activate the right babel.
test plan:
* run `yarn`
* it should work and canvas-rce's `yarn build:canvas` task should
finish successfully
Change-Id: Ic23f780679df244913163e5a452585a94db6e666
Reviewed-on: https://gerrit.instructure.com/185847
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
This gets canvas planner and canvas-rce on babel 7, which is a
prerequisite to canvas doing the same. Also, by not depending on the
Kitchen sink of ui-presets, it cleans a ton of unused stuff from our
node_modules/yarn.lock. It was originally 2 different commits but
in order to get the yarn.lock right, we have to do them all as one.
This also made it so we needed to have less “resolutions” in our
package.json since the newer versions of those things work fine with
the newer version of babel
So there are 2 test plan areas:
1. Canvas-planner
Closes: CORE-2575
Test plan:
* smoke test to make sure everything in canvas-planner still works/looks
like it used to in the canvas ui
* make sure the translation task (yarn check-transifex) still works
canvas-rce: upgrade to babel 7 & @instructure/ui-babel-preset
2. canvas-rce
Closes: CORE-2576
Test plan:
* smoke test the RCE editor
* theming should still work/look exactly as before
* make sure all the various build tasks (eg yarn test, test:coverage,
debug, lint, extract, etc) all still work as before
Change-Id: Id896687e3905f4df4627b181cad3f67ffe4417a5
Reviewed-on: https://gerrit.instructure.com/183877
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Closes: CORE-2560 CORE-2569
Refs: ADMIN-2453
Test plan:
* general spot check to make sure things look the same
(Specifically check the publish/unpublish button on the modules page)
* verify that the total size of the vendor & common production webpack
bundles is smaller
Change-Id: I734e9723917c14778cdc5fc4e22dcd1011b5e77e
Reviewed-on: https://gerrit.instructure.com/184911
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
It looks like this is not actually being used yet, so I deleted it.
If it is, in fact, being used that’s fine. Just let me know and I will
abandon this.
Change-Id: I47100e03408c4ad83ef9eed6ea9d68d57fc9d7d0
Reviewed-on: https://gerrit.instructure.com/183785
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Jeremy Neander <jneander@instructure.com>
We really should only be writing eslint-ignore in files where we KNOW
We don’t want to do what it is suggesting.
If it is suggesting something that we probably should do, but it was
written before us so we want to be lazy and not do anything about it,
we should not just eslint-ignore it. We should fix it or leave it there
for someone else to fix.
Having an eslint-ignore in a file is a signal that someone who knew what
They are doing saw that error and said “no I want to do it anyway”
We really should not be having lots of cases where you need to even
write `eslint-ignore`. A rule should either be 99.9% always followed or
we should get rid of it (and as a side note, I think we are there now)
A lot of these were leftovers from before we did that ^
Change-Id: I1e515d486550ad3118d6d74e9c824d28ebf6e714
Reviewed-on: https://gerrit.instructure.com/183786
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
This removes outdated code for treating missing submissions as
not-yet-submitted, which is no longer how submissions are handled.
test plan:
* Smoke test front end grade calculation
* Emphasis on differentiated assignments
assigned only to some students
Change-Id: I57bca1c1b7e63fdfbc0900928af35ff5ba277b64
Reviewed-on: https://gerrit.instructure.com/181982
Tested-by: Jenkins
Reviewed-by: Keith Garner <kgarner@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
test plan:
- tests pass and everything still works
Change-Id: I73540f1b5e4647c19f3446ce558bce7e4dfde684
Reviewed-on: https://gerrit.instructure.com/180736
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes ADMIN-2233
test plan:
- click the delete button which will open a confirmation dialog that
roughly matches the design
- a11y for the dialog should make sense
- the close button should dismiss the dialog with no effect
- the cancel button should dismiss the dialog with no effect
- the delete button should start a delete operation
- when the delete operation completes, you should be redirected to the
assignment index screen with a message indicating the assignment has
been deleted
- if your user does not have permission to delete the assignment, or
some other error occurs, then the in-development error screen should
be shown
Change-Id: I0c3304360d3c389296bd0910d02d8215bdb0ac9e
Reviewed-on: https://gerrit.instructure.com/177754
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Tested-by: Jenkins
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
refs ADMIN-2339
test plan:
- opportunities button badge should appear correctly
- screenreaders should read the button and the badge properly
Change-Id: I7b7a76c4a563ce18ab18806c5d42debb8431a222
Reviewed-on: https://gerrit.instructure.com/177999
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
refs ADMIN-2339
test plan:
- focus the link in a planner item and see that the focus ring does not
overlap the text above it
Change-Id: Iaae8b50fef8ee82f9508caac9350073d919727e1
Reviewed-on: https://gerrit.instructure.com/178141
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
refs ADMIN-2277
test plan:
- Do some spot checking all around, esp. on newer stuff written with
InstUI
- Do some specific spot checking on:
- Assignments edit page. Esp. with moderated grading
- Gradebook late policies
- Check the original bug (ADMIN-2211)
Change-Id: Iaaaeb9d86dc2d59cb2c9ccca2a8764a5adb0896b
Reviewed-on: https://gerrit.instructure.com/176912
Tested-by: Jenkins
Reviewed-by: Anju Reddy <areddy@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Ubuntu