and remove most monkeypatches of PostgresqlAdapter#add_index -
the non-concurrent-while-creating-shards is handled by switchman now,
and all other features are supported by vanilla Rails. one difference
is that Rails raises on duplicate index, instead of warning. still
keep a cleaner, more targeted monkeypatch of allowing concurrent
index adds during migration specs
also, fix several migrations with bugs exposed by this:
* concurrent index adds that didn't have disable_ddl_transaction!
* duplicate indexes added shortly after their dup
Change-Id: I6a3a2b4d2b63f27349922e476127fb7c3034b45c
Reviewed-on: https://gerrit.instructure.com/106092
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
also pins all migrations to Rails 4.2 semantics
Change-Id: I386566f7a1f3e3e8aa31675f467c87c443457aee
Reviewed-on: https://gerrit.instructure.com/95571
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>