Reviewed-on: https://gerrit.instructure.com/97258/
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Change-Id: I7cce022b2c749257e4f8e009815066fb01cfe4aa
Fixes CNVS-33657
Refs CNVS-33562
Test Plan:
* In an account with multiple terms
spanning across past, present, and
future, go to account settings
Part 1:
* The "Show courses from the term:" dropdown
on the right should include groups for Default,
Active, Future, and Past (in that order)
* The terms in the dropdown are categorized
correctly based on their start and end dates
and alphabetized
Part 2:
* Click "+ New Course" on the right hand side
* The enrollment terms dropdown should match the criteria
from Part 1.
Part 3:
* Select the Reports tab
* Configure a report
* A modal should appear with a terms
dropdown that matches the criteria from Part 1 & 2.
Change-Id: Id46de9052ada9841cf7b2ad77246bb63258fc017
Reviewed-on: https://gerrit.instructure.com/96802
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes CNVS-33187, CNVS-33546
switch existing usage of number_(to|with)_(delimiter|precision|rounded|percentage)
to the new helper, and simplifying local arguments
test plan:
* have at least 1000 courses, and 1000 files
* make sure jobs have run to generate the statistics
* go to /accounts/x/statistics
* the numbers for course and files should have a thousands delimiter
(i.e. "1,000", not "1000")
Change-Id: Ica8ccccba478030f5b4712f739b3120192313386
Reviewed-on: https://gerrit.instructure.com/96127
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Fixes: CNVS-33866
test plan:
- as an admin ensure you have a course that is "unpublished" in
your account
- select the account (not siteadmin) choose the "courses" link
from the left-hand sub-nav
- you should now see the unpublished icon next to the course
that is not published (used to be an uggo hammer)
example of new view: http://www.screencast.com/t/oehy3aNd
- now select the "users" link from the left-hand sub-nav
- choose one of the students that is enrolled in the course
that is not published
- within the student "enrollments" section there should be
the appropriate "unpublished" icon alongside the course
name. example: http://www.screencast.com/t/JECmCtdv
Change-Id: I1cd539fd0a358fc69080f4add8d6bb919523d908
Reviewed-on: https://gerrit.instructure.com/97628
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki
Product-Review: Kyle Follett <kfollett@instructure.com>
test plan:
- go to the account course index
- enter a search term in the "Find a Course" box and click "Go"
(the term must match more than one course name)
- the "Sort" box (just above the search term on the sidebar)
should still function like it does when first entering
the page and no search term has been queried
fixes CNVS-33759
Change-Id: I3dc645afa43a2ca6fade1011cdfa20d12fd2c5de
Reviewed-on: https://gerrit.instructure.com/97549
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes CNVS-33887
Test Plan:
* Prerequisites: Log in as a user enrolled in at least 15 courses
* Click on 'Calendar' on the left nav
* Under the 'Calendars' on the right you will see the list of courses
* To the right of those should be the color picker
* The color picker should be clickable and not hidden under the scroll bar
Change-Id: I5ff44b59213fddda9ae379bdfd0d39e081f40f5c
Reviewed-on: https://gerrit.instructure.com/97675
Reviewed-by: Joel Hough <joel@instructure.com>
Tested-by: Jenkins
QA-Review: Dan Sasaki
Product-Review: Chris Ward <cward@instructure.com>
Ref: RD-3406
Test plan:
Create a cloud assignment with the Office365 LTI app
As a student submit the cloud assignment
As a teacher check that the submission shows up in speed grader
Change-Id: Ib6a059c2e16f882f1f254233de0f8e09b69e8814
Reviewed-on: https://gerrit.instructure.com/97435
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Josh Orr <jgorr@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
also includes a `n` handlebars helper, and propery formats the count
in pluralized strings.
closes CNVS-33190
test plan:
- NA (qa example implementation in future commit)
Change-Id: Ic199b334a263afe0463fa3efd0797e5c9eeb3d93
Reviewed-on: https://gerrit.instructure.com/96839
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
Closes CNVS-33355
Test Plan:
* Examine the color picker on both the dashboard cards and from
the calendar
- Attempting to enter any of the following previously valid hex
codes for white should result in an error icon displaying in
the color preview swatch
-fff
-Fff
-ffffff
-Ffffff
-#fff
-#ffffff
-#Fff
-#Ffffff
- Attempting to select 'Apply' with any of these colors in the
input should result in an error flash message at the top
of the screen
Change-Id: I9bb3498aa220b418ca128f232f55d563a9e023c9
Reviewed-on: https://gerrit.instructure.com/96914
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Dan Sasaki
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
closes: CNVS-33153
this changes the boundaries for how dates are bucketed
into grading periods.
Previously:
period_start_date <= date &&
date < period_end_date
Now behavior:
period_start_date < date &&
date <= period_end_date
Test Plan:
- Given a course with multiple grading periods enabled
- Given a grading period set with grading periods (note the time
and date of one of the grading period's end date)
- Given an assignment due at the same time and date as the grading
period's end date
- When navigating to the gradebook and selecting the grading period
- Then the assignment id visible for the grading period
Change-Id: Iaf4a278ec670eb8575336c57be0354be9aad2441
Reviewed-on: https://gerrit.instructure.com/97018
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Christi Wruck
A docker ignore entry was recently added for:
public/javascripts/translations/
This is a mirror of the .gitignore entry, however, there is one file
checked into the git repo that shouldn't be ignored, and is necessary
for docker image builds. This adds that file back.
Test Plan:
1. Docker image successfully builds from running:
docker-compose build web
Change-Id: Ia83fb6673197cb5cb8f98d9c230d65342b6be37c
Reviewed-on: https://gerrit.instructure.com/97721
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Tested-by: Jenkins
Product-Review: Bryan Petty <bpetty@instructure.com>
QA-Review: Bryan Petty <bpetty@instructure.com>
This is purely a refactor of the existing grade calculator. It does not
alter existing behavior, but bolsters its spec coverage to protect
against unexpected grade calculation changes.
Ensuring that calculated grades are unchanged before and after this
refactor will be sufficient for QA.
closes CNVS-33841
refs CNVS-33572
test plan:
A. select or create:
1. a course
2. a teacher for the course
3. a student for the course
4. an assignment group for the course
5. an assignment in the assignment group
6. a graded student submission
B. ensure scores are calculated and visible for:
1. Default (grid) Gradebook
2. Individual Gradebook (SRGB)
3. SpeedGrader
4. Student Grades Page
Change-Id: I1e87949dc690d4ebee4e3960f2adb141bc5a5e0d
Reviewed-on: https://gerrit.instructure.com/96780
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
test plan:
- in /accounts/X/authentication_providers, the "Remove All
Authentication" button should be at the bottom of the right
sidebar (and should be colored dangerously)
fixes CNVS-33690
Change-Id: I607b6013d0e335986676dfd600318f605a9fd3f6
Reviewed-on: https://gerrit.instructure.com/97343
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Chris Ward <cward@instructure.com>
Fixes: PLAT-1911
Test Plan:
- Create an OriginalityReport for a submission with
a file attachment. Give a value to the report's
originality_report_url field in addition to
required fields.
- Navigate to /courses/:course_id/assignments/
:assignment_id/submissions/:user_id/
originality_report/:asset_string
- Verify you are redirected to the OriginalityReport's
originality_report_url
- Navigate to the same URL as a user that does not have
the :view_turnitin_report permission and verify you get an error.
Change-Id: If4f18995ea0af9c441998d2cfc27b0a29b582d05
Reviewed-on: https://gerrit.instructure.com/96561
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
do this in the outermost around so that any kind of failure gives us a
screenshot page
test plan:
1. see various intentional failures captured on patchset 2
Change-Id: I5aa9f6035ecf327c9a585aafacaa820b10208753
Reviewed-on: https://gerrit.instructure.com/97672
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
test plan:
- webpack build should pass
Change-Id: I388b24cde55f87e1e25378b01e2670b4dcd12c8e
Reviewed-on: https://gerrit.instructure.com/97658
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Fixes CNVS-33314
Test Plan:
* Prereq: notification settings enabled for a user enrolled in a course
and an email communication channel confirmed
* Create a page
* Include long enough text to where it is truncated
* Save the page
* Notice the notification about the page is no longer truncated
Change-Id: I2819a2c23063f611a13920def7db4385e5327c34
Reviewed-on: https://gerrit.instructure.com/97388
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Chris Ward <cward@instructure.com>
if an assignment is locked by having any due date
in a closed grading period all fields are locked except
RCE, submission type fields, peer review fields.
closes: CNVS-30899
Test Plan
- lock an assignment edit page by having at least one
due date in a closed grading period
- create an assignment with at least one due date in
a closed grading period
- go to the edit the assignment page
(e.g. /courses/1/assignments/1/edit)
- all fields are locked except for
- description (RCE)
- submission type
- peer reviews
- if an assignment is not locked, all fields should
be editable as normal
- if the user is an admin, they can edit anything they want
Change-Id: I5cbee4e552331915280c949f467565069aee8743
Reviewed-on: https://gerrit.instructure.com/93380
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Christi Wruck
Tested-by: Jenkins
i.e. if it's already a child, or it has no children, and you don't
want to check those beforehand
Change-Id: Ie0568c980f888b1e39f64aa0108033222887b2b6
Reviewed-on: https://gerrit.instructure.com/97612
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
delay it until an error happens
fixes CNVS-33882
test plan
- make a new root_account on a new shard
- it should succeed
Change-Id: I51f9dbb52d69c82eb8bc1838144f1683f7d7e110
Reviewed-on: https://gerrit.instructure.com/97620
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
so that CodeClimate will stop choking on them
Change-Id: I139b57d6bd0636710825bf1dbf6c28f1c640e039
Reviewed-on: https://gerrit.instructure.com/97586
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Test Plan:
- Things like doing `const coreJsBuilder = require('core-js-builder')`
shouldn't throw the warning/error.
Change-Id: I0bf086af1c60d31e6f3570a24d3e6c1db598c6c7
Reviewed-on: https://gerrit.instructure.com/97622
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-33790
Test Plan:
- Go to syllabus page on a course
- Notice the assignment summary has changed to
course summary
Does not need specs for a text change
Change-Id: Ied24d951662d29f9db0cd2878bce5b5ce7059c84
Reviewed-on: https://gerrit.instructure.com/97572
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Ian Hoerner <ian@instructure.com>
closes OFFW-36
test plan:
- you should be able to start a web zip export through
the console
- this should cause module progression for all
viewable items
- ensure epub exports still export
Change-Id: I901d491325fba3955af4544d1c1a2b87270cffff
Reviewed-on: https://gerrit.instructure.com/96752
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
closes OFFW-37
test plan:
- it should export an empty zip file
(the other parts of this aren't wired up yet, so good luck getting to this)
Change-Id: Ied37e879a274c423c3393659e8557f69c7a0cc82
Reviewed-on: https://gerrit.instructure.com/96555
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
Adds more missing entries to .dockerignore for compiled assets.
Test Plan:
1. Verify successful docker image build from new checkout.
Change-Id: I88b1a1260fb3eb47c8f6961fe23d2667af588a07
Reviewed-on: https://gerrit.instructure.com/97463
Reviewed-by: Jeff Belser <jbelser@instructure.com>
Tested-by: Jenkins
Reviewed-by: Marc Alan Phillips <mphillips@instructure.com>
Product-Review: Bryan Petty <bpetty@instructure.com>
QA-Review: Bryan Petty <bpetty@instructure.com>
test plan:
* assign a rubric to an assignment and "use for grading" but leave
the assignment points possible as a different value from the
rubric
* copy the course - then re-copy it again
* the assignment should retain its original points possible
closes #CNVS-33311
Change-Id: Ieb52b6f3381d1d31e383feb5f39cf7bfbc11be40
Reviewed-on: https://gerrit.instructure.com/96736
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
- js tests should pass
Change-Id: I38411ca4c3f6c430282dc7fe5cdb4e1d63838793
Reviewed-on: https://gerrit.instructure.com/97599
Tested-by: Jenkins
Reviewed-by: Jim Simon <jsimon@instructure.com>
Product-Review: John Corrigan <jcorrigan@instructure.com>
QA-Review: John Corrigan <jcorrigan@instructure.com>
fixes SD-1850
otherwise it can wait infinitely if the condition is not met
test plan:
n/a, but this makes things like https://gerrit.instructure.com/#/c/96245/
unnecessary ... tested manually
Change-Id: I48f0e4bfa2992433e7b061ab34a8961edbb91213
Reviewed-on: https://gerrit.instructure.com/97529
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
fixes OUT-454
test plan:
- load NVDA in Firefox in a Windows environment
- go to the assignment create page
- click 'New Group Category'
- navigate through the elements in the dialog,
there should not be a series of 'clickable' elements
Change-Id: I42c46dec250d28e0339fa92097197365bd032d74
Reviewed-on: https://gerrit.instructure.com/97095
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Alex Ortiz-Rosado <aortiz@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
Tested-by: Jenkins
gb_mgp_page got renamed in another concurrent commit 😭
Change-Id: I0ec69db93ff7f5b68d92db38d53a8fc459859360
Reviewed-on: https://gerrit.instructure.com/97536
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Closes: CNVS-33746
Test Plan:
- Click around Canvas and ensure that icons are still
showing properly
Change-Id: Ie7664f6b393b692d7b62b88c0a20b0277890f301
Reviewed-on: https://gerrit.instructure.com/97414
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Tested-by: Jenkins
QA-Review: Dan Sasaki
also includes a helper to validate number strings for current locale
closes CNVS-33191
test plan:
- NA (a future commit demonstrating the use of the helper with be
qa-able)
Change-Id: I1722aad263e611d127317b2f1a3832537742c3fb
Reviewed-on: https://gerrit.instructure.com/96677
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
Transifreq