test plan:
* a course role with the ability to view all grades
but not manage grades should be able to see a link to
speedgrader in the sidebar on assignment pages
(they can already visit them directly)
closes #CNVS-12858
Change-Id: I97f86bcfc0cccc882bb6bca316cdfc5fd41ff4cd
Reviewed-on: https://gerrit.instructure.com/97855
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
treats questions as part of bank content
TODO: extend to quiz questions
closes #MC-19 #MC-22
Change-Id: Ib3e142832772958495c305e7151c191c2cba2d57
Reviewed-on: https://gerrit.instructure.com/97816
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-33656
test plan:
*peer review icons*
- the set-up for this one is as an admin have an assignment
that has the “Require Peer Reviews” checked within the edit
portion of the assignment (http://www.screencast.com/t/sL4jDThnj5A)
as well as students enrolled that can act as peer reviewers
once set-up…
- navigate to the “Assignments” link from the course sub-nav
select the assignment that has the peer review enabled
- from the right-hand side-bar select the “Peer Reviews” link
the screen should look something like this
http://www.screencast.com/t/GOB1TxSu0xz
*user settings/approved integrations*
- as an admin click the account > settings link from the sub-nav
- scroll down the page to the “Approved Integrations” area below
“Web Services” section… if you do not currently have any integrations
click the “+ New Access Token” button to create one for the sake of
testing (example: http://www.screencast.com/t/ga93V2vVkKf)
*account profile picture*
- the set-up for this one is to ensure your admin/account has
users that have avatars… then as one of said users you need to
flag another users avatar as inappropriate (so you can see that
on the admin side) once you have the set-up complete navigate to
your main account under the “Admin” sub-nav
- click the “users” link … then from there the “manage profile pictures”
from the right-hand side-bar
- there you will have options of viewing all | approved,
re-reported | reported | etc…
- example: http://www.screencast.com/t/jNnQA1LtQDp
*assignments in locked modules*
- the set-up for this one is to have modules created within a
course that have assignments within them - the key is to have
a module that requires a previous module to be completed before
it can be accessed
- once this set-up is complete… navigate to the first assignment
as a user (not the admin)
- example: http://www.screencast.com/t/n98QznZaC
*profiles user sidebar*
- the set-up for this one is as an admin ensure “Enable Profile Settings”
is checked within the account/settings
- navigate to a course that has users enrolled
- click the “People” link from the left-hand sub-nav
- select one of the users by clicking on their name
- the view should look similar to this
example: http://www.screencast.com/t/pep4xiH1BWzy
Change-Id: I5c897dd6d55b4050b3be78a8b6ff706af70674fc
Reviewed-on: https://gerrit.instructure.com/97269
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Dan Sasaki
also add filtering to only show blueprint courses
will need to follow up to adjust links and add the child course
count
closes #MC-51
Change-Id: Icb7ddc4e696f771c50f39bfece14e6e0908e108f
Reviewed-on: https://gerrit.instructure.com/98458
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes: CNVS-33929
Test Plan:
- Go to People in a Course
- The fontsize on the string of text for the + Group Set button
and + People button should now be the same
Change-Id: Ia29bd904dfe41d930b4ba38f1982ac6c3d476978
Reviewed-on: https://gerrit.instructure.com/98158
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Dan Sasaki
Product-Review: Stephen Jensen <sejensen@instructure.com>
Fixes: CNVS-33718
test plan:
- as a user navigate to the canvas login screen
- the insturcture logo should no longer have the word "by" in
front of it
example: http://www.screencast.com/t/eOjkx6w6I8w
- same goes for the footer on the dashboard
Change-Id: I24c1df11175089e794c27517b3163a2eb04fba84
Reviewed-on: https://gerrit.instructure.com/97776
Tested-by: Jenkins
QA-Review: Dan Sasaki
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
as of this commit, all canvas gems should be on rspec 3.5, and pass
without deprecation warnings.
closes CNVS-34040
test plan: specs should pass without deprecation warnings
Change-Id: I556b1a4a5aeb791c6ddd50ee35b51c513e025019
Reviewed-on: https://gerrit.instructure.com/98414
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins
if the batch does not exist it will have already
returned a 404
Change-Id: I60ef8817c79559baa46de242ba5b11f1099c05d8
Reviewed-on: https://gerrit.instructure.com/98391
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
closes QA-211
test plan:
* Ensure specs pass
Change-Id: Ib3373af0aaf89433ea10ffd14e5cbf4ab7473805
Reviewed-on: https://gerrit.instructure.com/98403
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Tested-by: Jenkins
Product-Review: Keith T. Garner <kgarner@instructure.com>
QA-Review: Keith T. Garner <kgarner@instructure.com>
Fixes CNVS-33974
Test plan:
* As an admin, setup a grading period that is closed
* Create 2 assignments:
1) a group assignment that is due in the closed period
2) a moderated assignment that is due in the closed period
* Masquerade as a teacher
* Try to edit each assignment:
1) For assignment (1), the "New Group Category" button should be
disabled.
2) For assignment (1), you should be able to enable peer reviews,
automatically assign them, and set reviews per user to any number
greater than 0. Save should work.
3) For assignment (2), clicking the moderated grading checkbox should
not enable the peer reviews checkbox in any browser.
Change-Id: I089e40be543531de711f816636f1fb8712b23ba8
Reviewed-on: https://gerrit.instructure.com/98348
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Neil Gupta <ngupta@instructure.com>
Refs CNVS-5498
Test plan:
* As a student, submit a large image file to an assignment
* As a teacher, view that submission in Speed Grader
The image should automatically resize to fit within your browser window
in both Chrome and Safari.
Change-Id: I1cff5b99ab0aad805457b7fea8420c19ad6b7542
Reviewed-on: https://gerrit.instructure.com/98384
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Neil Gupta <ngupta@instructure.com>
Fixes CNVS-33899
Test plan:
* Start creating an Assignment
* Check the 'This is a Group Assignment' checkbox
* Check the 'Require Peer reviews checkbox'
* Hover on the 'Allow moderator.... checkbox'. It should be disabled.
* Now go back and uncheck the 'Peer reviews' checkbox
* Also uncheck the 'Group Assignment..' checkbox
* Hover on the 'Allow moderator' checkbox again. It should be enabled.
Change-Id: I3325dade79451e85bae0595e60dd2df76b3eda02
Reviewed-on: https://gerrit.instructure.com/98349
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Neil Gupta <ngupta@instructure.com>
test plan:
- ensure external tool module items preserve published state
across course copy/export/import
fixes CNVS-33928
Change-Id: Ib44a77756055b34c99f24c4d31a64f2befc507eb
Reviewed-on: https://gerrit.instructure.com/98099
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes CNVS-5498
Test plan:
* As a student, submit a large image file to an assignment
* As a teacher, view that submission in Speed Grader
The image should automatically resize to fit within your browser window.
Change-Id: I81e90fba878d644092c2fed93752745590cedf75
Reviewed-on: https://gerrit.instructure.com/98241
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Tested-by: Jenkins
Product-Review: Keith T. Garner <kgarner@instructure.com>
closes CNVS-31561
test plan:
* Create an assignment and open it in speedgrader
* Submit a comment
* Create a draft comment
* Navigate through the comments with VO
* Each delete and submit button should include the comment text
Change-Id: I5d6af7a0f2cdb0fc5379d83246eca5046ceaecf4
Reviewed-on: https://gerrit.instructure.com/97859
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
test plan:
* the "Courses" link after searching for courses in an account
should link back to the index
closes #CNVS-33926
Change-Id: I2e0fc91d2c8f645a050fdaad3ca628334a43cc02
Reviewed-on: https://gerrit.instructure.com/98141
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
it seems to be the only thing using the :if logic but i think
we can strip it out and replace it with :account_allows
but it seems we should also not give the permission if
:account_allows is false so there's that
test plan:
* the "Manage faculty journal entries" permission should not be
listed in the permissions page unless the faculty journal
is enabled on the root account
closes #CNVS-33832
Change-Id: I67ff1f1f12af5fc4fb57414938554d3d3e46ad7d
Reviewed-on: https://gerrit.instructure.com/98132
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes SD-1938
test plan:
* see that gergich still successfully comments on
linter output on patchset 1
Change-Id: I3beecfab405e57ba0e8705821d6d297fe7423c3e
Reviewed-on: https://gerrit.instructure.com/98317
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
total time is unchanged, but slowest spec in this (sub)group is now 6 sec
instead of 47 sec
Change-Id: I93f2533c308023e8cbf8a495921588556724e7be
Reviewed-on: https://gerrit.instructure.com/98330
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
[ci rspec profile]
basically never use built-in implicit waiting, since it makes everything
wait (not just find_element, but attribute lookups, etc.). that means that
StaleElementProtection would automatically always take the full 15 seconds,
because that's how long we'd wait for the StaleElementReferenceError to
come back
instead roll our own, which allows those to recover almost immediately,
and prevents other unnecessary waiting. disable_implicit_wait is also
now much cheaper since it doesn't mean two ruby <-> firefox roundtrips
test plan:
1. specs should be faster, e.g.
./spec/selenium/quizzes/quizzes_unpublish_quiz_teacher_spec.rb:20
now takes 10 sec instead of 25, since it always has a
StaleElementReferenceError
Change-Id: Ice31e64a274930cdf8af4407b5632e961683cdf6
Reviewed-on: https://gerrit.instructure.com/98295
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
fixes CNVS-33952
test plan:
- review test plan for the following commit:
/canvas-lms/commit/00cef7fadd7fe91e8c8bb0b3eaf3f798babe6a89
- enable the frozen plugin (plugins/assignment_freezer)
- create an assignment in a master course
- enable lock the assignment after being copied
- import that content into another course
- masquerade as a teacher in the imported course
- move the assignment to a different
group from the assignment page
- confirm assignment can also be moved from
assignment edit page
- return the plugin setting page and enable option
to lock assignment_group_id
- import a 2nd assignment into the course and
masquerade as the teacher again
- the handle to move assignment to a new group
should be disabled
- confirm assignment can also not be moved
from assignment edit page
- disable plugin
- assignment should be moveable while logged
in as a teacher
Change-Id: Ic154a26d75bedf3d0ffbf4e3ece7ffe65db99f72
Reviewed-on: https://gerrit.instructure.com/98283
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Alex Ortiz-Rosado <aortiz@instructure.com>
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
James Williams