ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
56,752 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

14 Commits

Author SHA1 Message Date
Aaron Ogata 66d7155f61 emsure private defaults are used everywhere 
Change-Id: Ie43bdced918987670bd186cbb5eb9f63ff13c52b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/314067
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
 2023-03-23 13:52:36 +00:00
Aaron Ogata a6aae57a48 convert remaining boolean flags 
refs DE-1359

[canvas-builds-refspec=1f02879d6f1b3a3ca631b542539aa0b699e64146]

Change-Id: Id0b5e194f7e7d1ba55723fcbb5c0dcede028c5de
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/313490
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
 2023-03-16 18:30:43 +00:00
Aaron Ogata 9f1ca5f895 remove usage of configuration.getInteger 
refs DE-1359

Change-Id: I500acf9fefd0a5d4f247da80c08ed7093d7dd7f3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/313393
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
 2023-03-16 15:10:08 +00:00
Aaron Ogata d73e9a2cd6 fix skipped spec reporting 
refs DE-1221

Change-Id: I128924eee2a0d01c37a68bdbeaf1fd8fa4f50118
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293751
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
 2022-06-10 17:16:51 +00:00
Aaron Ogata 4410f1cb67 always upload junit results as artifact 
refs DE-1221

Change-Id: Ibb51fd81c0ba51a1715ffe5190092549193f879e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293641
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
 2022-06-10 15:07:32 +00:00
Aaron Ogata c78a877f1d remove mostly useless copy files script 
refs DE-1221

Change-Id: Ic1719c364ea2bf9561de2b5d8e0a091c77a880cb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293438
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
 2022-06-09 15:16:39 +00:00
Brian Watson 249ce6865d Only generate ruby skipped spec report for ruby-total 
this will prevent ruby-selenium and non-selenium from messing up
the map

flag=none

Change-Id: I751c02c39cfc73c795f16c66c961c8d7c514229d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288380
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
 2022-03-29 16:24:44 +00:00
Brian Watson f45ae395dc Dont update skipped specs when manually triggered by gerrit 
flag=none

Test-plan:
- run manually via gerrit commit, should skip skipped spec updater

Change-Id: I7fda48ee1e711ca48d53de2dfa212cc0e33ab052
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287858
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
 2022-03-24 15:02:38 +00:00
Jacob Burroughs 4253bed58b Use zeitwerk everywhere always 
Change-Id: Ide7490f4e8d2447b147328b6f7e2afc545941c14
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287599
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
 2022-03-22 18:54:50 +00:00
Brian Watson cae55d4611 Identify JS and Ruby skipped specs 
flag=none
Test-plan:
- manually run ruby coverage / js coverage / axe builds
- ensure artifacts are updated in s3

Change-Id: I2bd4e51eedecf5a10e5d96bdc8727abb17bac034
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286063
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
 2022-03-18 16:57:43 +00:00
Brian Watson 2f2a27d91b Upgrade to Selenium 4 
Switches from standalone containers to explicit node+hub config

Selenium 4 has some differences in handling stale elements that we
should be aware of moving forward

closes OUT-4988
flag=none
[skip-stages=Flakey Spec Catcher]

Test-plan:
- make sure screenshots can happen for failures
- retrigger a few times and make sure things pass
- verify build summaries are intact
- verify FSC can still run seleniums
- verify local selenium running still works
  - firefox / chrome / edge where applicable
- verify docker selenium running still works
  - firefox / chrome / edge where applicable

Change-Id: I8f2fe5a34d712b5ccd7191bae7a9aeeb6f1f473d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/284811
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
 2022-03-09 15:28:31 +00:00
Bobby Buten 92efe8e144 re-enable canvas ruby selenium coverage report 
refs DE-987
flag=none

TEST PLAN:
  confirm https://code-coverage.inseng.net/ is updated with new report

Change-Id: Iabd8c53be851ee6d7b3b7c57d6b3b5102bf7ab50
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283200
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
 2022-01-25 13:27:49 +00:00
James Butters 6b33307857 fix coverage build, add redisUrl 
Change-Id: I1d8305402c73e677a66bae6bcc7343302a98510b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283137
Reviewed-by: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
 2022-01-19 20:41:51 +00:00
Brian Watson 7e9d804dd2 Repair canvas coverage 
closes OUT-4926
flag=none

Test-plan:
- coverage should be complete
- coverage in latest jenkins build should match
  what's visible in code-coverage.inseng.net

Change-Id: Ia64778433a698e7f2eb8bbd2a5e9621662eedb03
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/281119
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
 2022-01-05 17:55:26 +00:00