couldn't actually get the run_on_deletion method working
but if you start guard and hit enter in that terminal window
it will delete the entire public/javascripts/jst directory
and re compile all
Change-Id: I25df0bc2cc0031c61e32c0141cef7d3f688a1056
Reviewed-on: https://gerrit.instructure.com/6171
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
This sidebar item is leftover from when we were going to implement assignment
grade publishing. Instead we're doing "assignment muting". The old code hasn't
been totally removed yet, so this sidebar was basically always showing all the
quizzes that were due > 1 week ago, and confused people.
Change-Id: I36cec88ee7d77dd310c267de3fba4c595967c07f
Reviewed-on: https://gerrit.instructure.com/6191
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
there were a few little bugs with the old one
we were using. this change also makes them accessible
and keyboard navigable.
removed input type="search" because the rounded corners
webkit adds makes it look bad with the autocomplete dropdown.
fixes#5548
Change-Id: Iff1c8516fdc6886bd6b5d190d1b878497b6a80be
Reviewed-on: https://gerrit.instructure.com/6249
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Stop loading questions in move question quiz bank dialog from
the DOM and instead load them from JSON. Load 50 questions at
a time, and display them as they load to speed up perceived
load time for user.
Change-Id: I03de30ced107bf12d5002bab44bf326dbbeb343e
Reviewed-on: https://gerrit.instructure.com/6244
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Added a column for Due Date so the availability
end date isn't confused with it.
Change-Id: I93e43e160c4256d3871b3d9a06ec9a97bf39bdd1
Reviewed-on: https://gerrit.instructure.com/6230
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Speed grader defaults to first user with a submitted but
ungraded assignment. Users are still sorted alphabetically.
Change-Id: I974bf3b19d01e9f34122081a04e2215cb94c12b3
Reviewed-on: https://gerrit.instructure.com/6222
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
does the work that group_category_data_migration pre-70c18ac missed,
no-op if group_category_data_migration post-70c18ac was run
Change-Id: I39cc35cf385857f11cdcbdab3c462dbff9c4ce12
Reviewed-on: https://gerrit.instructure.com/6235
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
We started hiding enrollments where the created_at
and updated_at fields were identical, assuming
it was SIS garbage data.
Turns out we were wrong. Reverting.
Change-Id: I9a479ea5f1ffde61365ab15aa36975e865be4e74
Reviewed-on: https://gerrit.instructure.com/6241
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Wasn't updating group_category_id on assignments; instead it was
updating groups again when it should have been doing the assignments.
This didn't mess up any groups, it just left the assignments unmigrated.
Change-Id: Id36cb9c90aecfe77c1af432a0149053239427520
Reviewed-on: https://gerrit.instructure.com/6234
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
tweak sidebar scroller so as not to set the body class if it's not
actually changing. this keeps chrome from repainting unnecessarily,
which was the reason why the <select> kept jumping back to the first
option every second.
Change-Id: I1c42cf89ec0f68dca2b49f8e1564c0b8d682d9dc
Reviewed-on: https://gerrit.instructure.com/6200
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Technically we probably shouldn't actually let people store questions like
this (since they're impossible to get right), but in the meantime, we
shouldn't raise exceptions if they exist.
Change-Id: I2d5d6dd0492055abd0f06eebfbf5fe65123bba68
Reviewed-on: https://gerrit.instructure.com/6216
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
also increase the per-page requested by the web UI
Change-Id: I70a9399474900a2cf62fce64f3c8f31c0b1e3766
Reviewed-on: https://gerrit.instructure.com/6213
Reviewed-by: Brian Palmer <brianp@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Also added a spec that tests the entire message processing stack (at least
with STDIN). An earlier refactor to do a more targeted test resulted in this
breakage.
Change-Id: Ic23eebaceccd2d4a615d9452675a66a1b925a387
Reviewed-on: https://gerrit.instructure.com/6212
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
state was being used at an effectively global level to manage the
pageless library. this didn't work well when trying to use pageless for
more than one UI feature on a page. wrap the whole thing up in a new
closure per instance. fixes#5425
Change-Id: I654460d297932f0f92f54136d44b68e697bea192
Reviewed-on: https://gerrit.instructure.com/6151
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Student entering a what-if grade no longer removes
any mute-related notifications (icon and tooltip).
Change-Id: I53bbe862564a973cb59a258e96bd4b8427389ecb
Reviewed-on: https://gerrit.instructure.com/6165
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
This doesn't play well with the selenium specs, which modify the test
env domain config when spawning a forked server.
This reverts the forced config, but keeps the domain_config refactoring.
Change-Id: I4ebf8983264adf99c37dd7097d28bdd1773bc2ec
Reviewed-on: https://gerrit.instructure.com/6169
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
The check in swfobject used to take 100-300ms,
with localStorage its 1-3.
Change-Id: I232374dd9c79033ce4ed53a9bbae995eea0a7899
Reviewed-on: https://gerrit.instructure.com/6167
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
The check in swfobject used to take 100-300ms,
with localStorage its 1-3.
Change-Id: I9f9ba81581da5bb1fa33138a4f9380e468782858
Reviewed-on: https://gerrit.instructure.com/6122
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
prior to this commit, submission was only saving the
most current version, so grade_history didn't have any
record of previous grades.
now saves a new version on grade update. only displays
the most recent grade change/version on the history page.
Change-Id: I96d70c1a0cbaebbf1bbebfbd8690cc53e7292c28
Reviewed-on: https://gerrit.instructure.com/5925
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
jammit was blowing up because it was getting js that
looked like:
})()(function() {
adding the semicolon will fix it so it looks like
})();
(function() {
which will actually work
Change-Id: I6a990259982d85f2c276c877d8fee362e4aad1df
Reviewed-on: https://gerrit.instructure.com/6133
Reviewed-by: Jon Jensen <jon@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Cody Cutrer