Commit Graph

9 Commits

Author SHA1 Message Date
Cody Cutrer a6420c966b proactively clear cache when changing plugin settings
test plan:
 * enable a cache store (redis, memcached)
 * change a plugin setting that's easily visible (like enabling
   twitter shows up in your profile, or enabled account reports
   shows up in account settings)
 * the change should take affect immediately, instead of five
   minutes later

Change-Id: I5968266c274defbd81f863f03acb6d5b5dc5a102
Reviewed-on: https://gerrit.instructure.com/14798
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
2012-10-29 12:11:31 -06:00
Cody Cutrer 80898608fa fix caching of nil PluginSettings
test plan:
 * enable caching
 * load a page a few times
 * verify that PluginSetting isn't queried each time (in the logs)

Change-Id: Id49f2001c4077f3351d96957c8681c7e91aec30c
Reviewed-on: https://gerrit.instructure.com/13595
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Brian Palmer <brianp@instructure.com>
2012-09-10 17:04:53 -06:00
Brian Palmer f70fe86fed cache plugin_settings for 5 minutes
Ideally these would expire if changed, but this is a quick
optimization because of other current limitations.

Change-Id: I8ef54a0161a754f407a5b939c576b6bbdfa485de
Reviewed-on: https://gerrit.instructure.com/13236
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
2012-08-28 16:50:34 -06:00
Cody Cutrer bdbebfaec8 check all models for protecting attributes refs #3847
Change-Id: I7cba6e26ad98e91723e2ccf0a28b8db79bb37b5c
Reviewed-on: https://gerrit.instructure.com/3631
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
2011-05-25 17:38:50 -06:00
Brian Whitmer cc81de2d43 better support for disabling plugins
There wasn't a good way in the interface to
disable a plugin other than the manually go through
and empty out all the text fields.

refs #4194

Change-Id: Ia095160323c907a43fb98f4f3fe85f1babf7eebc
Reviewed-on: https://gerrit.instructure.com/3544
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
2011-05-14 23:52:04 -06:00
Jon Jensen 8c0651a556 gracefully handle bad decrypt of plugin_settings
Change-Id: Ie2b1609592e5f70866b7416e2ee982eae98cf08d
Reviewed-on: https://gerrit.instructure.com/2974
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
2011-04-19 09:14:28 -06:00
Jon Jensen 86b062bf61 wimba integration, fixes #2989
added wimba web conferencing support, moved dimdim config into plugin
settings, fixed a few web conferencing ui issues

Change-Id: I6b36b0e594a9f296d14cd35bec02186478bcbd13
Reviewed-on: https://gerrit.instructure.com/2343
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
2011-02-25 14:35:14 -07:00
Brian Whitmer 2f3f70b339 better flow for updating plugin settings
also added option for plugins to provide validation on
their settings page.  I need this for some of the
more complex settings we'll have to put together
as we move stuff from yml files to settings.

Change-Id: I78e6e3cd423e7ef7e15eafae86db8337f605be3a
Reviewed-on: https://gerrit.instructure.com/2247
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
2011-02-16 12:30:18 -07:00
Brian Whitmer 8b8173dcc9 Initial commit.
closes #6988138
2011-01-31 18:57:29 -07:00