fixes LX-1939
flag = selective_release_edit_page
Test plan:
- Create an assignment and assign a single student to it
- Remove that student from the course
- Go to the assignment's edit page
- Expect to see no cards (since the student is removed)
- Click the add button, and expect that to work
Change-Id: Icc6572fbebd515a8690976ccbbbf3a3411ad2c90
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355246
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Closes QUIZ-14149
Test plan:
- Go to SiteAdmin settings -> Feature Options
- "Impact integration for New Quizzes" should exist as "Shadow"
flag = impact_integration
Change-Id: I4a8455948bc5d5dab81e8f2a3d1fb45077366581
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/353978
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Gergely Knipl <gergely.knipl@instructure.com>
Reviewed-by: Márton Gréczi <marton.greczi@instructure.com>
QA-Review: Márton Gréczi <marton.greczi@instructure.com>
Product-Review: Dmitry Buimistrov <dmitry.buimistrov@instructure.com>
fixes VICE-3676
flag=react_discussion
Test Plan:
1. In the url for discussion show page
and persist=true.
Then trigger highlight, ex 'go to topic'.
alternatively add this to the url to highlight an entry
?persist=true&entry_id=4
2. Have a graded discussion.
make it check-pointed
- Make sure a student has completed,
both topic replies and replies to another student.
-- this allows speedgrader to show discussion.
- next as a teacher, open in speedgrader for the entry.
- it will highlight the entry with persist.
Note:
There is a bug that should be handled by navigation.
- lets say the student has 3 entries,
it will only highlight 1 entry, no matter which you
open in speedgrader. This is unrelated to persist.
Change-Id: If56633cb95bf342bda603c08c0e9d844775625a0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354022
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Martin Yosifov <martin.yosifov@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Sam Garza <sam.garza@instructure.com>
This avoids two errors that we found when running the
data fixups in beta.
1. Site admin developer keys have a nil account.
When we have a dev key with a nil account_id, create
an Lti::Registration and set the account to
Account.site_admin. Previously, we would throw an error
if the account was nil.
2. DevelperKeyAccountBindings *can* be in non-root accounts.
That is to say, the backend allows it, validation-wise. This is
probably something that has been done a few times through
the API unintentionally. When we find a DeveloperKeyAccountBinding
for a non-root account, we should just skip trying to create
an Lti::RegistrationAccountBinding for it.
(Lti::RegistrationAccountBindings must be in a root account.)
Note: in lib/data_fixup/create_lti_registrations_from_developer_keys.rb,
the registration_values hash now has an account_id key instead of
just "account." This is because if the account_id is set to an ID
that doesn't match an account, developer_key.account will be nil,
even though developer_key.account_id is set to some integer. (If
it's a site admin key, developer_key.account_id is nil, and therefore
developer_key.account is also nil. But that's different from having
developer_key.account == nil because the account_id couldn't be found.)
If developer_key.account_id is set to a nonexistent account ID, then
developer_key.account is nil, but the developer key is *not* a
site admin key.
We still want to throw an error if developer_key.account is nil *if*
and only if developer_key.account_id is *not* nil. I.e., the account
is nil and it's not because it's a site admin key.
During the fixup on beta, we did run into a few where
developer_key.account_id was set to a nonexistent account.
test plan:
- specs pass
refs INTEROP-8501
refs INTEROP-8502
fixes INTEROP-8800
flag = lti_registrations_page
Change-Id: Ia3198b21e2b29b5cb9ac75b5f9cbabf492e620f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355019
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Tucker Mcknight <tmcknight@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
this commit changes the name of the enhanced_rubrics feature flag from
Rubric Enhancements to Enhanced Rubrics
closes EVAL-4485
flag=none
test plan:
- open up the feature flag page for an account or course
- verify the name of the feature flag is now Enhanced Rubrics
Change-Id: Ic312e78a05070cbacad4657765edb038aa140d8f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355243
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
closes EGG-5
flag=assignment_enhancements_teacher_view
Test Plan:
- Go to RootAccount -> Settings -> Feature Options
- Enable the "Assignment Enhancements Teacher View" feature flag.
- Select a course and go to its assignments.
- Select an individual assignment (not one that uses an external tool)
- Ensure that the assignment name is displayed at the top left
of the page.
- Nothing else will be displayed on the page. It is still in the
works.
Change-Id: I84fc911730d8fb5d925173b33e58594058d6a8a0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354662
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Angela Gomba <angela.gomba@instructure.com>
QA-Review: Angela Gomba <angela.gomba@instructure.com>
Product-Review: Sam Garza <sam.garza@instructure.com>
Test plan:
- Observe /courses/[id]/users
- Note that it makes a product manager happier
Change-Id: If3981114298e117b993a04bf55d08b2a4427388d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355242
Reviewed-by: Chris Soto <christopher.soto@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jeremy Perkins <jperkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
If there are errors on the assign to cards on save of
the page edit page, focus on those errors and don't save.
refs LX-1886
flag=selective_release_edit_page
test plan:
- create/edit a page and add some assign to cards
- make some errors on the cards, have invalid dates and
cards without assignees
- attempt to save the page, focus should go to the errors
and the save should not occur.
Change-Id: I5d63332ef6b25f38076bd3b0e9fca5160b9ecb9e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355213
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Sarah Gerard <sarah.gerard@instructure.com>
This commit takes the tray out of the page edit page.
You should be able to edit assign to cards and the cards
should save as expected. Validations on save are not yet
functional, and module overrides are not yet completely
functional.
refs LF-1886
flag=selective_release_edit_page
test plan:
- create a page and add overrides. Mess around with adding,
deleting cards, changing the dates, etc and ensure it
works as expected.
- save your changes and ensure that all changes are saved
correctly.
Change-Id: Ifff4dc71a80f1632400ebc4af3d939b272e523a5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355210
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Sarah Gerard <sarah.gerard@instructure.com>
Change-Id: If9441780317e9b79181529b7399396cee2bd8aba
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355233
Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
Migration-Review: Alex Slaughter <aslaughter@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
closes OUT-6551 OUT-6552 OUT-6553
flag=none
Users from trust accounts were incorrectly being filtered
out of LMGB when using the 'inactive', 'concluded', and
'unassessed' filters. This patchset addresses that issue
and provides tests that validate the solution
Test Plan:
Tests are sufficient and pass in Jenkins
Change-Id: I7a4f5d05f31be0cbd31818442b7616d760eaac7e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355209
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Angela Gomba <angela.gomba@instructure.com>
QA-Review: Angela Gomba <angela.gomba@instructure.com>
Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
test plan:
- ensure that /accounts still lists accounts
Change-Id: Ib8dee9d83afb1bbde7631b4da6240442759dc585
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354990
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Closes FOO-4633
flag=none
Test Plan:
* Start a large batch mode SIS import
* Abort it (via API or console) part-way through
* Observe that parallel importers are aborted rather
than continuing to run
Change-Id: I48fda5274d061b4f30661a5cb247bffd54e3a532
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355098
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Jason Perry <jason.perry@instructure.com>
QA-Review: Jason Perry <jason.perry@instructure.com>
Product-Review: Jason Perry <jason.perry@instructure.com>
fixes EVAL-4427
flag=assignments_2_student
Test Plan:
- acting as one of the students assigned to peer review, navigate to the
assignment as the reviewer
- reload de page adding embed=true parameter
- validate the canvas menu is not being rendered
Change-Id: I654f55ce7760087aa219004c39d7e93aa1c5fc05
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354624
QA-Review: Jackson Huang <jackson.huang@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes QUIZ-14061
flag = none
test plan:
- have the New Quizzes Common Cartridge flags turned on
- make sure quiz_lti is up-to-date, and/or
has the changes from g/352154
- create a course
- create a CQ and a NQ with points
- for the CQ to have points it must have questions
- the NQ points are set in the Assignment Edit page
- for the NQ, make sure the sum of the points from the
quiz entries is different than the assignment points
- go to the Export Course Content page and export the
course as an IMSCC package
- import the package into a different course
with the option "Import existing quizzes as New Quizzes"
turned on
- observe that the quizzes have the correct points
- import the package again into a different course with
the option "Import existing quizzes as New Quizzes" turned
off
- again, the quiz points should be imported correctly
Change-Id: I075945fe805df054a7f63012b54a765293739d3e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/352653
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Cason Snow
Reviewed-by: Iman Morshed <iman.morshed@instructure.com>
Reviewed-by: Adrian Diaz <adrian.diaz@instructure.com>
QA-Review: Adrian Diaz <adrian.diaz@instructure.com>
this commit updates the feature flag for enhanced rubrics to be at the
course level instead of the account level. This will allow a more
granular setting where the FF can be enabled at the account and course
levels.
closes EVAL-4476
flag=enhanced_rubrics
[fsc-max-nodes=15]
test plan:
- set an account to have the enhanced rubrics FF enabled
- verify that in the account rubrics page, the enhanced rubrics are
enabled
- set one course in the account to have the enhanced rubrics FF disabled
- verify that in the course rubrics page, the enhanced rubrics are
the old UI
- have an assignment with a rubric and visit speed grader. verify that
clicking on the rubric button opens up the old rubric UI. complete the
rubric assessment for the student.
- as the student, navigate to the assignment page and verify that you
can see the old rubric UI for the completed assessment.
- set one course in the account to have the enhanced rubrics FF enabled
- verify that in the course rubrics page, the enhanced rubrics UI is
enabled
- have an assignment with a rubric and visit speed grader. verify that
clicking on the rubric button opens the new rubric tray. complete the
rubric assessment for the student.
- as the student, navigate to the assignment page and verify that you
can see the new rubric UI for the completed assessment.
Change-Id: I54bfaba53517240382b151ae58c53c183e83fdba
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354965
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Sleyder Zuleta <sleyder.zuleta@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
this commit fixes the following:
- height of the rating cells in the traditional
rubric assessment view. The height of the rating cells are now dynamic
and should stretch to fit the height of the row instead of a set height.
- add criterion long description modal to the traditional rubric
assessment
- fix student view of the rubric assessment to show the long description
modal when the long description icon is clicked
- student view of the assessed traditional rubric should now have the
points input as text instead of input field
fixes EVAL-4412
fixes EVAL-4445
fixes EVAL-4404
flag=enhanced_rubrics
test setup:
- have a rubric with different types created and attached to assignments
- rubric with different sizes of ratings
- rubric with outcomes
- rubric with free form comments
- rubric with very long rating long descriptions
test plan:
- navigate to /rubrics
- view the different rubrics created by clicking on the rubric names
- verify that the rating cells in the traditional view stretch to fit
the height of the row and that everything looks normal
- navigate to speed grader for some of these different rubrics
- verify that they open in the sidebar and look normal.
- as a student, navigate to the assignment page and view the rubric
assessment
- verify that the long description modal opens when the long description
icon is clicked, the assessed point value is now a text instead of an
input field and that everything looks normal
Change-Id: I8075c76f705dc866f7b155afdd874cb71b19bda6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355093
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
fixes RCX-2111
flag=none
test plan:
- Run data fixup
- Verify uuids were changed in all non-deleted attachments
Change-Id: I13a5499e6c15c9cfb62046b1852e4a91afd86b7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354818
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
refs RCX-1900
flag=instfs_uuid_api
Test plan
- Have a couple of different types of file
urls (for rich content)
- Send a request to /api/v1/instfs_uuids_for_files
with a body like { user: <user_uuid>, file_urls:
["url", ...], location: "anything" }
- Ensure that this only works if the feature flag
is on (it is by default), otherwise 404
- Ensure that URLs are returned with the attachment's
instfs_uuid (if any) if the user you sent the uuid
for can manage the file
- Ensure that the URLs are not returned in the list
if the user cannot manage the file
Change-Id: I781b5165725a56e906c2e9c509c95961ca0d141e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348291
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
Reviewed-by: James Logan <james.logan@instructure.com>
QA-Review: James Logan <james.logan@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
Fixes FOO-4657
flag=none
The rspack upgrade changes how pathnames are mapped
for dynamic imports, which broke the language polyfill
code. I wasn't able to get all the way to the bottom
of what's going on; there is probably a better fix for
this (or maybe not!), but this makes the import more
explicit in a way that rspack clearly understands.
Will probably need to revisit this issue to clean up
the code and research exactly what is going. In the
mean time, this will do.
Test plan:
* Be in Google Chrome
* Set your user's language to Íslenska
* Reload the page with the browser console open
* You should see successful "polyfilled is for locale is"
and not any "Cannot find module" errors
Change-Id: I6c42d3f80da01576d939f5d3b39f042ca1ef594c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355131
Reviewed-by: Dustin Cowles <dustin.cowles@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes LX-1952
flag=selective_release_ui_api
flag=selective_release_edit_page
test plan:
- Enable required sync to SIS and make due
dates required in account settings.
- Navigate to a graded discussion create/edit page.
> Verify that if the Sync to SIS checkbox is enabled
the cards of the panel should require due dates
(showing errors). If not you can leave these fields
blank.
> Verify that you are not able to save if there
are empty due dates if Sync to SIS is enabled.
> Verify that if you try to Save, the focus will
go to the first issue you have on the cards.
Change-Id: Ic844d45aa477e41cd6d406cb3ed5f0c83817f551
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354840
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
fixes RCX-1838
flag=none
Test plan:
- Preview a media file
- Click the speed selection button
- Check that you can see all the options
down to the canvas-added 0.50x
Change-Id: I60ca8a383d116ba18c244fa1b9fac94c85ffd6d8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354998
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
why:
* the top_navigation_placement feature flag introduces
a wrapper div around all of Canvas, to make the Drawer
implementation work
* InfiniteScroll looks at the document for scroll events,
but with the wrapper div there aren't any
* use the wrapper div if present but fall back to the usual
document-style implementation
closes INTEROP-8799
flag=none
test plan
* create more than 50 tools in a Course or Account
* easiest way to do that is to take an existing tool and in a rails console
with the tool as `t`, run this:
`100.times.each { |i| t.dup.tap{ |t| t.name = "test #{i}"; t.save }`
* with the top_navigation_placement flag off, scrolling down to
the bottom of the list of apps should load more
* with the flag enabled, scrolling down won't load any more
* with this commit checked out, scrolling down should
always load more tools
Change-Id: Ic65166fa597c296d4c010e0a87faf2992bea2b33
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355123
Reviewed-by: Dustin Cowles <dustin.cowles@instructure.com>
Reviewed-by: Tucker Mcknight <tmcknight@instructure.com>
Reviewed-by: Ryan Hawkins <ryan.hawkins@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
fixes RCX-1990
flag=none
test plan:
- Open Icon Maker tray
- Click outside the tray and verify the tray does not close
- Upload an image via the icon maker tray
- Verify there is no prompt when clicking the image modal
- Make changes in the tray and click the close button
- Verify there is an alert asking to save the changes
Change-Id: I87784f8a4405dde8f557fa2c917a2c38f087fd43
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354823
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
closes EVAL-4144
flag=none
Test Plan:
PreReqs: Published course with a student enrollment that has media in
Studio. Have an assignment with file upload submissions and
file restrictions enabled. Assignment Enhancements DISABLED
- Edit assignment in a course and uncheck file upload submission types
without unchecking “Restrict Upload File Types.”
- Enable “media recordings” submission type.
- After saving the edits to the assignment, act as a student and select
the 'New Attempt' button at the top right of the assignment page, select
the Studio tab, and choose a video to submit.
- Click the embed button on the window that appears and notice the error
at the top of the page stating that the submission file type is invalid
and cannot submit.
Change-Id: I561a31c96aa38d65e05eacba2b4383abe32a624e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/351264
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
closes VICE-4492
flag=discussion_checkpoints
Test plan:
- Go to SiteAdmin -> Feature Options and enable
the Discussion Checkpoints feature flag
- Create a course and enroll yourself as teacher
or student; take a note of the course id
- Create a graded discussion with checkpoints
and add due dates
- Create a graded discussion with checkpoints
but do not add due dates
- Get undated assignments from the Calendar API
http://<canvas url>/api/v1/calendar_events?
type=assignment&context_codes[]=course_<course id>&undated=1
- Verify that response is an empty array
- Repeat the API call for type=sub_assignment
- Verify that the two undated checkpoints are returned
Change-Id: I1630561f5817fb39acd8f7534b873b6d6825c56a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354994
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
and prevent Tabs from nesting
and added I18n to SectionMenu
closes RCX-2179
flag=none
test plan:
- create an empty page
> you cannot delete the sole blank section
- add a new section
> expect the trash can in the toolbar
- delete all but 1 section
> you cnnot delete the last section
- add a Tabs block
- try to dnd Tabs into the Tabs
> expect it to be disallowed
- try to dnd another block into the Tabs
> expect it to work as expected
> expect the RCE Block to be present, even if the ai_text_tools
flag is off
- Add a columns section
- add a Text block to a column
- enter some text, including returns to introduce more
paragraphs
- add another text block above or below the first one
- add some text and <esc> to stop editing
> expect all the pragraphs to look evenly spaced
- in any of the text blocks select some text and
click on bold, italic, underline, and/or strikethru
in the toolbar
> expect the corresponding buttons to be highlighted
> expect the text to get the corresponding styling
- add a text block
- type some text with a ?
> expect the ? to work
Change-Id: I53ab48693873ec0a85979af6813292d8a100aa13
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354456
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
A graded discussion can have a todo date if it was converted
from an ungraded discussion to a graded discussion. In that
case we should not show to todo date on the modules page.
fixes LX-1964
flag=none
test plan:
- create an ungraded discussion and check the 'add to student
to do' box and add a date
- create a module and add the ungraded discussion to it
- expect to see the to do date on the module item
- go back to the discussion and change it from ungraded
to graded
- check the modules page, expect to see no date on the
discussion module item
- add a due date to the discussion and return to the module
page
- expect to see the due date on the discussion module item
Change-Id: If32c99af3aa5c49137a2e99593b090d30360dd8c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355009
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Sarah Gerard <sarah.gerard@instructure.com>
why:
- To allow admins to edit apps that were installed using Dynamic
Registrations. This reuses the same modal that is used during the
install process, rather than creating a whole new screen.
flag=lti_registrations_page
closes INTEROP-8525
test-plan:
- Enable the associated flag and navigate to the Apps page.
- Make sure you can still install an app using Dynamic Registration.
- Click the three dots button on the app that you just created in the
table.
- Click the Edit App button. A modal should open up to the review
screen.
- Modify some aspects of the configuration and click through all the
screens. Once you've finished, click the Update App button and make
sure it all saves properly.
Change-Id: Ib075c273f0091ae019cc4f67f4cd295c662b652f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354566
Reviewed-by: Paul Gray <paul.gray@instructure.com>
QA-Review: Paul Gray <paul.gray@instructure.com>
Product-Review: Alexis Nast <alexis.nast@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
flag=discussions_redesign
fixes EGG-17
test plan:
- create a graded group discussion for
a group set that has groups without any students
- as a student, visit the discussion
(you will end up in the root topic page, this is ok)
- reply to the discussion
- as a teacher, view discussion in speedgrader
- verify discussion loads without error
- create an anonymous discussion, as a student, reply
- delete your reply
- verify you can reload the page without the page breaking
- create a graded group discussion this time with
groups that have students
- as a student belonging to a group, reply to your
group's discussion
- as a teacher view speedgrader
- verify the the full discussion loads with the student's reply
Change-Id: Iadc6205a84c05c27cfbf03c7fbdc36087d72e81a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355056
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
Drake Harper